Commit Graph

246 Commits

Author SHA1 Message Date
Robbe Derks
efb5abec41 Make longitudinal planning triggered on model (#22641)
* Make long planning triggered on model

* fix process replay

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-10-28 12:27:09 +02:00
Vivek Aithal
2ea4feffb9 plannerd: add useLaneLines to lateralPlan (#22699)
* add laneless toggle in lateral plan message

* update cereal

* add refs
2021-10-26 14:32:41 -07:00
Adeeb Shihadeh
f2b48a1803 always show lane lines on HUD (#22693)
* always show lane lines on HUD

* update refs
2021-10-25 23:47:12 -07:00
qadmus
2e0bc9d365 GM: improved Volt lateral tuning (#22621)
* GM Volt lateral tuning and feedforward function

* improve comments, lower P 5% to 0.17, which matches all my notes over time, 0.18 was a last test change.

* don't justify actuator delay for now

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-10-21 14:10:41 -07:00
cydia2020
9a2ecec1a8 Toyota longitudinal: Illuminate PCS Warning Light If DSU is Unplugged (#22631)
* display amber "PCS Off" indicator when DSU is unplugged

* Update opendbc

* update ref

* Update opendbc

* update ref

* bump opendbc

* bump opendbc

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-10-20 15:41:31 -07:00
cydia2020
0b6b9b595d Toyota longitudinal: display PCS off when DSU is unplugged and no SDSU is found (#22626)
* display pcs off in car settings when DSU is unplugged

* Update opendbc

* fix checks

* bump opendbc

* use 0

* update refs

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-10-19 22:01:47 -07:00
ZwX1616
8574e79fec wider FOV DM on comma three (#22286)
* c3 is straightforward

* c2 transform

* c3 preview

* alpha model

* Revert "alpha model": wrong quantization data

This reverts commit b50e5739735b30d960aca22bcf3cbe23b0121e13.

* yuv looks good

* a55b

* const int

* block top deadzone

* new box alpha curve

* update k

* fix debug

* rhd use same offset

* box shift for rhd

* 7e3e

* set new thresh

* update ref

* explain

* remove e2e

* same metric thresh

* process isocc

* model

* cancel extra policy

* update numbers

* new model

* update cereal

* up cereal

Co-authored-by: Comma Device <device@comma.ai>
2021-10-13 17:00:46 -07:00
HaraldSchafer
c4510024da Remove accel cost in long MPC (#22527)
* ACCEL not useful

* new ref
2021-10-11 17:20:40 -07:00
HaraldSchafer
04cf12cb00 ACADOS fix non-convergence when long_plan changes (#22495)
* debug commit

* cleanup

* some indexing bugs

* need more its

* BALANCE is way better it seems

* fix test

* this converges in 2000segs

* new ref

* less cpu
2021-10-10 00:05:29 -07:00
Robbe Derks
91987f38d4 Make pandaState and safetyMode a list (#22454)
* wip: move to pandaStates

* bump cereal

* wip: SafetyMode struct

* move to safetyMode

* fix typo

* this can be None

* fix potential empty pandaStates list

* fix thermald

* fix controlsd

* rename safetyModes to safetyConfigs

* update process_replay

* fix test_models

* bump cereal
2021-10-08 17:54:34 +02:00
Vivek Aithal
83a53618b3 paramsd: Sort messages in each update iteration before processing (#22403)
* sort livelocationKalman and carState messages in each update iteration before processing

* update refs

* update refs

* update refs

* update again

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-10-07 18:21:11 -07:00
Willem Melching
6c29a4c7fb Honda Bosch longitudinal tuning (#22407)
* revert changes to standstill logic

* start with mostly open loop

* Revert "revert changes to standstill logic"

This reverts commit d737d858e7708aedaf09cfc068b85398161e9bbe.

* proper clipping

* less lag

* less gas command

* start gas from -0.2

* controls should take care of that

* use CarControllerParams

* switch to braking sooner

* Revert "switch to braking sooner"

This reverts commit cf11dae334ccb369f625d4b13b7cd4176156a446.

* 2.5x more P

* use active

* engage on rising edge

* Revert "engage on rising edge"

This reverts commit c972956cb460eedaff3d0169a40673a6ea933385.

* update ref
2021-10-07 16:37:02 +02:00
HaraldSchafer
a4bc1bbb74 Long MPC cleanup (#22462)
* cleaner extrapolation

* some comments

* new ref

* more comments

* new ref
2021-10-06 17:51:23 -07:00
Vivek Aithal
244fbde56e Add paramsd Stdev to message (#22443)
* add STD to message

* use modified names for car_kf state stdev atttributes

* update refs

* add modofied cereal

* update refs
2021-10-06 16:22:18 -07:00
HaraldSchafer
9ab09f5ae9 Retune long mpc (#22445)
* first try

* looks decent

* finalize retune

* back to 3 its

* may need 4 still

* misc cleanup

* new ref

* SPEEEED

* new ref
2021-10-06 09:37:53 -07:00
Willem Melching
e636f03c7a Set CarControl.active (#22442)
* Set CarControl.active

* update ref
2021-10-05 14:32:39 -07:00
martinl
4c45e90722 Subaru: update brake pressed signal (#21012)
* Change Global brakePressed to Brake_Status Brake signal

* Add Brake_Status Brake signal and check

* bump panda

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-09-28 22:00:35 -07:00
HaraldSchafer
85dc43d166 Small long MPC optimizations (#22360)
* Revert "temporarily relax camerad timings"

This reverts commit 174aa908ba.

* cleanup

* wrong weight size

* changes ever so slightly

* seems enough

* Revert "seems enough"

This reverts commit 24f64e9b18583462206bb77c37ba7727b9e47245.

* new ref
2021-09-28 17:37:31 -07:00
Adeeb Shihadeh
3b8fa4b7fd controls: only send cruise cancel while cruise is enabled (#22359)
* controls: only send cruise cancel while cruise is enabled

* cleanup

* might actually do something

* update refs

* update refs again

* update refs
2021-09-28 12:30:50 -07:00
HaraldSchafer
fe983a7b8c acados long merged (#22224)
* rebased

* cleaner, seems to drive better?

* more stable

* wrong import

* new way of thinking

* reports look nice

* start move back

* works at leas

* good timestamps

* step by step

* somewhat work

* tests pass

* ALL CARS STOPPED

* should work

* fake a cruise obstacle

* cleaner costs

* pretty good except cruise braking

* works pretty well now!

* cleanup

* add source

* add source

* that is needed for unit tests

* nan recovery

* little cleaner

* stop wasting arrays

* unreasonable without unfair init

* this isnt needed without the exponential

* that works too

* unused

* uses less

* new ref

* long enough

* e2e long api

* DONT PUT IN A VIEW INTO ACADOS

* new ref for outside weights

* remove debug prints
2021-09-27 19:48:28 -07:00
Willem Melching
2d7d8fba99 Improve Hyundai FW query stability (#22344)
* extend timeout on valid response

* extend total timeout in fw query

* redundant query

* cleanup

* add 2 new sonata fw

* add cloudlog

* total timeout always 10x

* update ref

* time.monotonic()

* more logging
2021-09-24 17:32:09 -07:00
Willem Melching
c68fc8ef9c set Honda Bosch long lag to 1s (#22335)
* set Honda Bosch long lag to 1s

* update ref
2021-09-24 10:28:00 -07:00
Adeeb Shihadeh
649af76fd4 remove community supported cars from community features (#22330)
* remove community supported cars from community features

* remove bosch and hkg long

* remove test case

* update refs
2021-09-23 17:34:52 -07:00
Greg Hogan
793ceb6b56 hyundai: resume from stop faster (#22274)
* hyundai: resume from stop faster

* update ref_commit
2021-09-23 13:20:25 -07:00
HaraldSchafer
fcda55fbf1 Fix cruise MPC convergence bug and add test (#22295)
* fix tests

* fix cruise convergence bug

* update refs

* Update selfdrive/controls/tests/test_cruise_speed.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>

* Update selfdrive/controls/tests/test_cruise_speed.py

* add msgh

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2021-09-21 12:19:05 -07:00
HaraldSchafer
7495100177 More extreme lead init for lead mpc (#22273)
* More harsh lead init for lead mpc

* update refs
2021-09-20 09:35:55 -07:00
Harald Schafer
32c57fee05 update ref for mpc lead accel clip 2021-09-18 22:35:11 -07:00
Vivek Aithal
3778592f50 locationd: modify factor for measurement STDEV in gps update (#22262)
* modify factor for measurement STDEV in gps update

* add new ref_commit
2021-09-17 22:33:46 -07:00
HaraldSchafer
66c275b711 Acados long fast (#22233)
* acados long

* new ref

* SPPEEEEEDDD

* less iterations

* this shouldn't be so high

* reset only essentials

* minimal reset for long mpc

* more cpu usage plannerd

* Use lead mpc even when going to crash

* reset to current state

* Use open loop speed for lead mpc

* 1 iteration is too little for cruise mpc

* add whitespace

* update refs
2021-09-15 19:00:12 -07:00
Willem Melching
417e229624 Add upper/lower bounds for longitudinal lag (#22235)
* Add upper/lower bounds for longitudinal lag

* add ref

* update ref

* bump cereal

* bump cereal
2021-09-14 18:57:16 -07:00
HaraldSchafer
96a8f8a831 Less QP iterations for lateral acados (#22231)
* Less QP iterations for lateral acados

* update ref
2021-09-14 13:55:30 -07:00
John Belmonte
f07e1ae99e Honda carstate: use common gas pedal signal (#22010)
* Honda carstate: refactor GAS_PEDAL handling

* collapse SCM signal cases

* stop using CAR_GAS signal (combined user pedal + computer)

* cleanup

* update refs

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-09-13 22:41:50 -07:00
Willem Melching
c4bac6bd68 Hyundai longitudinal prerequisites (#22121)
* panda

* bring over changes

* dont check car model

* remove comment

* fix typo

* more stuff gated behind long

* not

* not used

* gate that too

* try honda tuning

* clip accel values

* fix up merge

* fix stopping

* add retry logic around knockout

* increase timeout

* keep flipping lead bit

* true for now

* less tuning

* update comment

* 0.1 s is fine now

* merge honda and hyundai knockout

* more lead fields

* another obj bit

* increase timeout

* fix stopping flag

* only lag compensate for braking

* no lead

* less tuning

* only do knockout if not readonly

* try controlling using jerk

* tuning

* try higher stopping rate

* set stopping flag at higher speed

* clip upper jerk when stopping

* remove comments

* tester present 1hz

* use positive start accel

* 1.0 to maybe improve low speed stuff

* no point going over 0

* bump panda

* bump panda

* revert that change

* update ref
2021-09-13 22:03:08 -07:00
HaraldSchafer
0dc45eaf1c Fix 0 init bug for acados lateral (#22225)
* this is needed somehow

* new ref
2021-09-13 21:23:22 -07:00
HaraldSchafer
7081ab4fb7 Port lateral planning to ACADOS (#22080)
* lateral acados

* looks good!

* add another solve, needed for init somehow

* use copy

* init correctly

* cleanup sconstruct

* Update files_common

* update cpu usage

* reset when invalid

* fix cpu usage

* cost_set doesnt leak

* new ref

* non leaky reset

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Comma Device <device@comma.ai>
2021-09-13 19:06:54 -07:00
ZwX1616
dac8597a08 refactor dm pitch/yaw thresholding (#22191)
* use indiviual pitch/yaw instead of norm

* update process replay
2021-09-13 16:05:42 -07:00
Willem Melching
b7d1aac197 Parameterize longitudinal control using carParams (#22200)
* use CP.startAccel

* missing values

* order

* update ref

* cereal
2021-09-11 18:01:54 -07:00
Willem Melching
1e62b09e5d Use CP.vEgoStopping and clean up CP.startAccel (#22199)
* use CP.vEgoStopping and clean up

* update ref
2021-09-11 17:13:30 -07:00
HaraldSchafer
74b6c87254 cleanup old nidec accel override logic (#22181)
* cleanup old nidec accel override logic

* add ref without deprecated fields

* no more override
2021-09-10 10:34:18 -07:00
Adeeb Shihadeh
1c750975fc reduce startup alert duration to 10s (#22163)
* reduce startup alert duration to 10s

* update refs

* update refs

* update refs
2021-09-07 13:40:31 -07:00
Willem Melching
4f84e1b2ad actually set longControlState in actuators packet (#22155)
* actually set longControlState in actuators packet

* update ref
2021-09-06 20:14:01 -07:00
Willem Melching
b39f6efa3f parameterize longitudinal actuator delay (#22153)
* paremetrize longitudinal actuator delay

* update ref
2021-09-06 17:56:52 -07:00
Willem Melching
f941111dcd Clean up PID controller ACCEL_MIN/ACCEL_MAX (#22148)
* use ISO 15622:2018 limits in PID controller

* allow more for nidec

* limit PID inputs

* CP is not needed

* add GM

* not used

* update ref

* fix honda bosch
2021-09-06 17:29:32 -07:00
martinl
d3113fe01a Subaru: universal signal for ACC speed units (#21995)
* Change ACC Speed Units signals for Global and Pre-Global

* Use Dash_State UNITS signal for Preglobal

* Change Subaru Preglobal to use Dash_State2 UNITS signal

* bump opendbc

* cleanup

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-09-02 14:21:35 -07:00
Willem Melching
edae2218d7 Smarter longitudinal lag compensations (#22094)
* smarter lag compensations

* need to use speed from plan

* update ref

Co-authored-by: Harald Schafer <harald.the.engineer@gmail.com>
2021-09-01 15:28:16 -07:00
Willem Melching
c15a616ac4 Continuously update offset between TSS2 angle sensors (#21943)
* Continuously update offset between TSS2 angle sensors

* add comment

* less lines

* only when initialized

* init to None

* update ref
2021-09-01 15:00:52 -07:00
grekiki
21fad4d1ad Add angleError to pid_log (#21611)
* add angleError

* Log all the time

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-09-01 13:45:22 -07:00
Willem Melching
b8e4717f72 Populate angle offset in carState for Toyota accurate angle sensor (#22091)
* populate angle offset in carstate for TSS2

* update ref
2021-08-31 11:34:00 -07:00
Adeeb Shihadeh
86f68ff22e add TSS2 replay route (#21953)
* add TSS2 replay route

* skip on sim

* do not set on import time

* update ref

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2021-08-31 10:48:21 -07:00
HaraldSchafer
1ac89f14aa Change car controller interface from gas/brake to acceleration (#21911)
* retune civic

* seems smooth

* back to normal

* new ref

* fix conflict

* runs

* rm

* accel scale is 4

* toyota should be good

* more cleanup

* fixup

* better naming

* update ref

* deprecated

* sending brake when not enable causes a fault

* rm gas and brake

* unused

* update ref

* acura logic is no more

* wrong before

* revert tuning cleanup

* adress comments

* update ref

* already on master

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2021-08-30 09:32:52 -07:00