Commit Graph

269 Commits

Author SHA1 Message Date
Vivek Aithal
94d59314e2 Revert ecef std until real fix (#22982)
* too low

* update refs

Co-authored-by: Harald Schafer <harald.the.engineer@gmail.com>
2021-11-19 12:49:32 -08:00
HaraldSchafer
24aadaf1f3 Lateral planner: lower max cost (#22960)
* prevent ping pong when tuning is not so great

* update refs
2021-11-17 20:24:10 -08:00
HaraldSchafer
b3b45c8d29 Add cost to long plan change for smoother lag comp (#22923)
* add plan changing cost

* fix compile

* set weights

* try this cost

* horizon problem

* looks pretty good

* update refs

* update refs

* smoother plan changes
2021-11-16 17:57:55 -08:00
Adeeb Shihadeh
f262725705 update refs after alert disable 2021-11-15 21:45:18 -08:00
Adeeb Shihadeh
3302239013 put cruiseMismatch event in logging only mode 2021-11-15 21:16:54 -08:00
Vivek Aithal
534bf697ee locationd : Acceleration Bias in locationd (#22879)
* add accel bias to filter for offline calculation

* bugfix acc bias in live_kf

* add no_accel obsertvation

* increase initial certainty of acc-bias and reduce PN

* increase initial certainty of acc-bias and reduce PN

* increase accel bias PN

* increase obs noise for no_accel observation

* style fixes

* update refs
2021-11-12 15:55:16 -08:00
HaraldSchafer
a04114f68c Give car interface roll and pitch (#22891)
* Give car interface roll and pitch

* fixup

* whitespace
2021-11-12 12:21:22 -08:00
Vivek Aithal
c7be73b826 locationd: Set ECEF_POS valid flag to false if in no-gps mode (#22857)
* set ECEF_POS valid flag to false if in no-gps mode

* modify valid flag for all ecef states before gps

* add calibrated valid when no gps

* update refs

* remove extra whitespace

* add invalid flag to all NED values pre gps

* update refs

* update correct refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-11-11 21:34:17 -08:00
sshane
bdaea086f8 Longcontrol: do not clip vEgo to minSpeedCan (#22832)
* fix tss2 slow reacceleration in sng

(should) preserve stopping behavior

add comments since it's confusing

fix

* Revert "fix tss2 slow reacceleration in sng"

This reverts commit 42abde0eb945d8bc5ad9b502d1d89b3e3dc16f8a.

* don't max(vEgo)

* update ref

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2021-11-11 13:24:38 +01:00
Adeeb Shihadeh
327464fb84 increase engagement alerts duration 2021-11-10 22:11:14 -08:00
Adeeb Shihadeh
035bc0c20f controlsd: alert on cruise mismatch for >1s (#22841)
* controlsd: alert on cruise mismatch for >1s

* bump cereal

* update refs

* bump allowed soundd cpu

* bump cereal
2021-11-10 13:01:42 -08:00
Adeeb Shihadeh
c5d6b85c90 alerts: use a single duration for sound, text, and HUD (#22856)
* alerts: use a single duration for sound, text, and HUD

* little cleanup

* update refs
2021-11-10 11:54:12 -08:00
Adeeb Shihadeh
93ba52c76c controlsd: optimize alert management (#22846)
* controlsd: optimize alert management

* little cleanup

* dataclass is nice

* fix tests

* update refs

* sort by start frame

* update refs

Co-authored-by: Comma Device <device@comma.ai>
2021-11-10 10:54:18 -08:00
Jason Young
2006fff2b6 Fix momentary false blind spot alerts when changing lanes (#22819)
* reset LaneChangeDirection after finishing

* update ref

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2021-11-10 17:21:36 +01:00
HaraldSchafer
35d6ed1014 ACADOS: partial condensing (#22830)
* partial condense

* new refs

* new ref

* newerest refs
2021-11-09 19:29:55 -08:00
Jafar Al-Gharaibeh
2621e5301d Mazda: disable hud alerts until we find a way to silence audible alerts (#22808)
* Mazda: disable hud alerts for now until we find a way to silence audible warnings

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Mazda: add hud alert for steer lockout

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* show when above min steer speed

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-11-09 15:24:18 -08:00
Vivek Aithal
5c810a45b0 locationd: Make live_kf robust to no GPS (#22774)
* add no gps observations

* use correct ecef_location, orientation vals and stds for nogps states

* remove earth radius obs

* move initial loc to the ocean

* remove unnecessary changes

* update refs
2021-11-09 14:45:47 -08:00
Jafar Al-Gharaibeh
8c38e9c49e Mazda: fix occasional steer fault at initial lkas enable (#22806)
* Mazda: fix occasional steer fault at initial lkas enable

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-11-08 14:40:26 -08:00
sshane
a0e5eccb70 Toyota: handle brake hold (#22810)
* disallow engagement if brake hold active

* we can check once

* move to common events

revert

* fix

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-11-08 14:26:30 -08:00
cydia2020
d66f0fcc87 Toyota: Increment by 5 km/h (5 mph) on long press (#22678)
* Allow 5km/h speed increments on Toyota

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-11-04 14:53:32 -07:00
Adeeb Shihadeh
2252c6bba7 Mazda: move CX-9 out of dashcam mode (#22717)
* move cx9 out of dashcam

* no alc below 28

* process replay route
2021-10-31 22:02:36 -07:00
Robbe Derks
585c16cd2a Multipanda support (#22402)
* squash all PR commits for easy rebase

* merged all panda rx can into one message

* fix buffers in can_send

* more cleanup and minor fixes

* fix even more stuff

* fix non-allocated send buffer

* make connecting more robust

* fix bus offset

* fix controls_mismatch?

* simplify mismatch check

* C++ style struct

* fix connect loop

* update ref

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-10-29 13:04:26 +02:00
Jason Young
b49f518782 GM: EPS fault workaround (#22404)
* seems legit

* panda -> loopback

* fix comment

* add some "why" comments for the next guy

* re-test with stock 50Hz rate

* ugly test

* Update selfdrive/car/gm/carstate.py

Co-authored-by: qadmus <42746943+qadmus@users.noreply.github.com>

* update refs

* Update selfdrive/car/gm/carstate.py

Co-authored-by: qadmus <42746943+qadmus@users.noreply.github.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-10-28 16:54:12 -07:00
Robbe Derks
efb5abec41 Make longitudinal planning triggered on model (#22641)
* Make long planning triggered on model

* fix process replay

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-10-28 12:27:09 +02:00
Vivek Aithal
2ea4feffb9 plannerd: add useLaneLines to lateralPlan (#22699)
* add laneless toggle in lateral plan message

* update cereal

* add refs
2021-10-26 14:32:41 -07:00
Adeeb Shihadeh
f2b48a1803 always show lane lines on HUD (#22693)
* always show lane lines on HUD

* update refs
2021-10-25 23:47:12 -07:00
qadmus
2e0bc9d365 GM: improved Volt lateral tuning (#22621)
* GM Volt lateral tuning and feedforward function

* improve comments, lower P 5% to 0.17, which matches all my notes over time, 0.18 was a last test change.

* don't justify actuator delay for now

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-10-21 14:10:41 -07:00
cydia2020
9a2ecec1a8 Toyota longitudinal: Illuminate PCS Warning Light If DSU is Unplugged (#22631)
* display amber "PCS Off" indicator when DSU is unplugged

* Update opendbc

* update ref

* Update opendbc

* update ref

* bump opendbc

* bump opendbc

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-10-20 15:41:31 -07:00
cydia2020
0b6b9b595d Toyota longitudinal: display PCS off when DSU is unplugged and no SDSU is found (#22626)
* display pcs off in car settings when DSU is unplugged

* Update opendbc

* fix checks

* bump opendbc

* use 0

* update refs

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-10-19 22:01:47 -07:00
ZwX1616
8574e79fec wider FOV DM on comma three (#22286)
* c3 is straightforward

* c2 transform

* c3 preview

* alpha model

* Revert "alpha model": wrong quantization data

This reverts commit b50e5739735b30d960aca22bcf3cbe23b0121e13.

* yuv looks good

* a55b

* const int

* block top deadzone

* new box alpha curve

* update k

* fix debug

* rhd use same offset

* box shift for rhd

* 7e3e

* set new thresh

* update ref

* explain

* remove e2e

* same metric thresh

* process isocc

* model

* cancel extra policy

* update numbers

* new model

* update cereal

* up cereal

Co-authored-by: Comma Device <device@comma.ai>
2021-10-13 17:00:46 -07:00
HaraldSchafer
c4510024da Remove accel cost in long MPC (#22527)
* ACCEL not useful

* new ref
2021-10-11 17:20:40 -07:00
HaraldSchafer
04cf12cb00 ACADOS fix non-convergence when long_plan changes (#22495)
* debug commit

* cleanup

* some indexing bugs

* need more its

* BALANCE is way better it seems

* fix test

* this converges in 2000segs

* new ref

* less cpu
2021-10-10 00:05:29 -07:00
Robbe Derks
91987f38d4 Make pandaState and safetyMode a list (#22454)
* wip: move to pandaStates

* bump cereal

* wip: SafetyMode struct

* move to safetyMode

* fix typo

* this can be None

* fix potential empty pandaStates list

* fix thermald

* fix controlsd

* rename safetyModes to safetyConfigs

* update process_replay

* fix test_models

* bump cereal
2021-10-08 17:54:34 +02:00
Vivek Aithal
83a53618b3 paramsd: Sort messages in each update iteration before processing (#22403)
* sort livelocationKalman and carState messages in each update iteration before processing

* update refs

* update refs

* update refs

* update again

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-10-07 18:21:11 -07:00
Willem Melching
6c29a4c7fb Honda Bosch longitudinal tuning (#22407)
* revert changes to standstill logic

* start with mostly open loop

* Revert "revert changes to standstill logic"

This reverts commit d737d858e7708aedaf09cfc068b85398161e9bbe.

* proper clipping

* less lag

* less gas command

* start gas from -0.2

* controls should take care of that

* use CarControllerParams

* switch to braking sooner

* Revert "switch to braking sooner"

This reverts commit cf11dae334ccb369f625d4b13b7cd4176156a446.

* 2.5x more P

* use active

* engage on rising edge

* Revert "engage on rising edge"

This reverts commit c972956cb460eedaff3d0169a40673a6ea933385.

* update ref
2021-10-07 16:37:02 +02:00
HaraldSchafer
a4bc1bbb74 Long MPC cleanup (#22462)
* cleaner extrapolation

* some comments

* new ref

* more comments

* new ref
2021-10-06 17:51:23 -07:00
Vivek Aithal
244fbde56e Add paramsd Stdev to message (#22443)
* add STD to message

* use modified names for car_kf state stdev atttributes

* update refs

* add modofied cereal

* update refs
2021-10-06 16:22:18 -07:00
HaraldSchafer
9ab09f5ae9 Retune long mpc (#22445)
* first try

* looks decent

* finalize retune

* back to 3 its

* may need 4 still

* misc cleanup

* new ref

* SPEEEED

* new ref
2021-10-06 09:37:53 -07:00
Willem Melching
e636f03c7a Set CarControl.active (#22442)
* Set CarControl.active

* update ref
2021-10-05 14:32:39 -07:00
martinl
4c45e90722 Subaru: update brake pressed signal (#21012)
* Change Global brakePressed to Brake_Status Brake signal

* Add Brake_Status Brake signal and check

* bump panda

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-09-28 22:00:35 -07:00
HaraldSchafer
85dc43d166 Small long MPC optimizations (#22360)
* Revert "temporarily relax camerad timings"

This reverts commit 174aa908ba.

* cleanup

* wrong weight size

* changes ever so slightly

* seems enough

* Revert "seems enough"

This reverts commit 24f64e9b18583462206bb77c37ba7727b9e47245.

* new ref
2021-09-28 17:37:31 -07:00
Adeeb Shihadeh
3b8fa4b7fd controls: only send cruise cancel while cruise is enabled (#22359)
* controls: only send cruise cancel while cruise is enabled

* cleanup

* might actually do something

* update refs

* update refs again

* update refs
2021-09-28 12:30:50 -07:00
HaraldSchafer
fe983a7b8c acados long merged (#22224)
* rebased

* cleaner, seems to drive better?

* more stable

* wrong import

* new way of thinking

* reports look nice

* start move back

* works at leas

* good timestamps

* step by step

* somewhat work

* tests pass

* ALL CARS STOPPED

* should work

* fake a cruise obstacle

* cleaner costs

* pretty good except cruise braking

* works pretty well now!

* cleanup

* add source

* add source

* that is needed for unit tests

* nan recovery

* little cleaner

* stop wasting arrays

* unreasonable without unfair init

* this isnt needed without the exponential

* that works too

* unused

* uses less

* new ref

* long enough

* e2e long api

* DONT PUT IN A VIEW INTO ACADOS

* new ref for outside weights

* remove debug prints
2021-09-27 19:48:28 -07:00
Willem Melching
2d7d8fba99 Improve Hyundai FW query stability (#22344)
* extend timeout on valid response

* extend total timeout in fw query

* redundant query

* cleanup

* add 2 new sonata fw

* add cloudlog

* total timeout always 10x

* update ref

* time.monotonic()

* more logging
2021-09-24 17:32:09 -07:00
Willem Melching
c68fc8ef9c set Honda Bosch long lag to 1s (#22335)
* set Honda Bosch long lag to 1s

* update ref
2021-09-24 10:28:00 -07:00
Adeeb Shihadeh
649af76fd4 remove community supported cars from community features (#22330)
* remove community supported cars from community features

* remove bosch and hkg long

* remove test case

* update refs
2021-09-23 17:34:52 -07:00
Greg Hogan
793ceb6b56 hyundai: resume from stop faster (#22274)
* hyundai: resume from stop faster

* update ref_commit
2021-09-23 13:20:25 -07:00
HaraldSchafer
fcda55fbf1 Fix cruise MPC convergence bug and add test (#22295)
* fix tests

* fix cruise convergence bug

* update refs

* Update selfdrive/controls/tests/test_cruise_speed.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>

* Update selfdrive/controls/tests/test_cruise_speed.py

* add msgh

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2021-09-21 12:19:05 -07:00
HaraldSchafer
7495100177 More extreme lead init for lead mpc (#22273)
* More harsh lead init for lead mpc

* update refs
2021-09-20 09:35:55 -07:00
Harald Schafer
32c57fee05 update ref for mpc lead accel clip 2021-09-18 22:35:11 -07:00