Commit Graph

459 Commits

Author SHA1 Message Date
Vivek Aithal
3326487104 Torque Refactor (#25822)
* add torque gains refactor

* update refs

* avoid dict, use cereal struct

* bugfix

* no as_builder

* address final comments
old-commit-hash: 85ed5c4cb5
2022-09-17 00:07:54 -07:00
Willem Melching
cc473bf45b Hyundai: match ego speed on dash (#25235)
* hyundai: match speed on dash

* still needs conversion to m/s

* always use CF_Clu_VehicleSpeed2

* clean up, like honda

* experiment

* to the source

* works pretty well on optima (matches exactly on Sonata)

* could be 0.5

* clean up test

* revert test_moedls

revert test_moedls

* woops

* woops.

* .

* fix hyst

* only CF_Clu_VehicleSpeed

* omgomgomg

* add all this mess because it always takes a while

* set vEgoCluster

* fix all rounding errors

* stash

* clean up

* clean up

* fix metric conversion

* only calculate when updated

* try to filter (didn't look great from plots)

* Revert "try to filter (didn't look great from plots)"

This reverts commit 7e9876c237341d07163985b0718fd9c553372e72.

* clean up

* update refs

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: f73b041d43
2022-09-16 17:33:38 -07:00
Shane Smiskol
98b821fb1a GM minSteerSpeed: add some tolerance for Volt (#25809)
* add some tolerance for volts

* add comment

* update refs
old-commit-hash: b7dc1968cd
2022-09-15 21:21:10 -07:00
Vivek Aithal
5a097b3235 regenerate replay segments for torqued (#25805)
* update segments in test_processes

* bump cereal

* update refs
old-commit-hash: b133a4c9a8
2022-09-15 20:15:57 -07:00
Adeeb Shihadeh
ff42c549da update refs
old-commit-hash: a9f88503fe
2022-09-15 13:55:36 -07:00
Shane Smiskol
6f06e047d5 HKG: lower torque rate limits for CAN-FD cars (#25770)
* Change ramp limits to 2/2 for CANFD cars

* Only the high torque CANFD cars

* comment

* Update selfdrive/car/hyundai/values.py

* Better to do 2/3 and for all cars

* bump to master

* update refs
old-commit-hash: d57e07eec0
2022-09-15 11:28:49 -07:00
Willem Melching
56188f43a5 Honda: match current speed on dash (#25232)
* Honda Bosch: match speed on dash

* present on all cars

* all honda

* more explicit switching

* hyst

* hyst

* clean up

* Update ref_commit

* no bitwise

no bitwise

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: e699b0994c
2022-09-14 15:40:36 -07:00
Shane Smiskol
c1b9a202aa controls: enter overriding state for steering override (#25617)
* lateral overriding is overriding

* Update test

* remove

* also could do something like this and only have one OVERRIDE ET

* Revert "also could do something like this and only have one OVERRIDE ET"

This reverts commit 5c381641c08961676a56a9718fbdaa84989ac249.

* full names

* bump cereal

* test every event type

* update refs
old-commit-hash: 992707c172
2022-09-13 23:20:45 -07:00
Shane Smiskol
f8f22fabdf Car docs: CAN-FD cars do not yet have op long (#25707)
* CAN-FD cars do not yet have op long

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 973ea7440c
2022-09-08 11:41:29 -07:00
HaraldSchafer
4b6fbd26a5 Improve Hyundai long control, and conform to longcontrol API boundaries (#25696)
* Variety of experimental improvements

* fix start accel

* typo

* No jerk, no go

* Set jerk limit lower

* Update ref
old-commit-hash: da6c7311a3
2022-09-07 19:09:37 -07:00
Adeeb Shihadeh
e4f9781c17 single longitudinal toggle for e2e and disable radar (#25688)
* single longitudinal toggle for e2e and disable radar

* write disable radar param

* rename

* better param name

* clean that up

* update refs

* update translations

* not live for experimental

* write it out

* vanish
old-commit-hash: 655a64b603
2022-09-07 17:12:49 -07:00
HaraldSchafer
1c2c840a8a Let planner decide stopping state (#25643)
* Let planner decide stopping

* Refactor stop/start state machine

* Stay stoppe condition

* 1sec from target

* Add starting state

* Add starting state logic

* Undo some changes

* Update ref
old-commit-hash: 210a6163ac
2022-09-06 21:30:10 -07:00
Shane Smiskol
da41c19937 Toyota: match dash set speed (#25649)
* toyota: match set speed from dash

* Use unit bit

* Use RSA2

* flip this

* Universal unit signal, set vEgoCluster

* remove this and bump opendbc

* detect if car interface sets cluster fields

* revert

* needs to be cp

* UI_SPEED is actually always in kph?

* forgot to actually convert it

* same in onroad

* try conv factor only for imperial

* Seems like UI_SPEED is not the UI speed at all

* the dash might floor it

* same openpilot behavior

* bump

* ego speed factor is dynamic across speeds, handle Lexus exceptions with
diff msg

* remove test, bump opendbc

* secret formula

* secret formula v2

* 1.03 is sufficient

* try short press

* bump opendbc

* surely this can be cleaned up

surely this can be cleaned up

* use filter

* redo factors

* try UI_SPEED again with a factor

try UI_SPEED again with a factor

* dash applies hysteresis to speed. this matches pretty well, but not exactly

* match only set speed

* clean up

* clean up

clean up

* Update ref_commit

* update refs

Co-authored-by: Willem Melching <willem.melching@gmail.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 80533d6c03
2022-09-05 13:57:07 -07:00
HaraldSchafer
b8a6a961fe Remove lane planning code (#25651)
* Remove all lane planning logic

* Revert "Update ref"

This reverts commit 8dcb08ebccbb5641443459ac40601a95cf605682.

* bump cereal

* Update ref
old-commit-hash: 2eff6d0ebd
2022-09-04 13:07:51 -07:00
HaraldSchafer
754fb9306b Faster a_ego filter (#25646)
* Faster a_ego filter

* :x
Update ref

* typo

* update ref
old-commit-hash: 593dfd0aed
2022-09-02 16:19:06 -07:00
Shane Smiskol
846e366a55 GM: update minimum steer speed (#25618)
* EUV is 10 kph

* Update ref_commit

* temp

* Revert "temp"

This reverts commit 90ce28b06ba623e7bd1252798af3c285b465e0ec.
old-commit-hash: 3b602e2844
2022-09-02 13:41:58 -07:00
Shane Smiskol
1fcc31aac6 Car docs: add auto-resume column (#25572)
* Move auto resume in sng to car interface

* Update docs

* shorter name, star

* order

* resumes?

* add hidden detail sentence

* good to know this works, but revert

* VW auto resume

* bump cereal to master

* Update ref_commit

* match cereal

* try this

* ?

?

* like this
old-commit-hash: 452d5e42ec
2022-08-30 17:54:40 -07:00
Jason Wen
79dfc5293a Hyundai: Car Port for Tucson Hybrid 2022 (#25276)
* Hyundai: Car Port for Tucson Hybrid 2022

* Update RELEASES.md

* Init gear_msg at the top

* FW versions from script

* Button send attempt

* start with some cleanup

* Send button fixed bits

* Define all bytes and only send PAUSE/RESUME

* Use CRUISE_INFO to cancel cruise and resume

* 8-bit counter

* Cleanup ish

* 8 bit counter

* Send at 20ms

* Disengage bits

* Revert bump submodules

* Allow tx on 0x1a0

* Fix byte counts

* Send LFA and HDA icons based on engageability

* Send cruise buttons only on HDA2 cars for now

* Add comments

* Add FLAG_HYUNDAI_CANFD_HDA2 flag

* Update interface.py

* Update carstate.py

* Update carstate.py

* Update carstate.py

* Bump submodules

* Bump panda

* Bump opendbc

* Allow tx with CRUISE_INACTIVE

* GEAR has 24 bytes only

* Generate car docs

* Fix CRUISE_INFO copy

* Remove unused class

* Add CAN-FD busses to unit test

* Bump opendbc

* Revert "Add CAN-FD busses to unit test"

This reverts commit 2f751640408a7f73a9100947cbd95ea13fbb8a48.

* Remove duplicate

* New tune based on data

* Panda safety cleanup

* Include bus 0 in rx checks

* Missed one

* bus 6 check

* Remove redundant check

* Add comments

* Bump opendbc

* Sync with DBC

* Hide LFA icon when disengaged

* Little endian

* fix comment

* more conditions in carcontroller

* update pedal signal

* update tuning

* cleanup carcontroller

* bump panda

* fix mismatch

* alt buttons

* little more cleanup

* update refs for EV6 new safety param

* bump panda

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: bd5e28909f
2022-08-19 20:14:30 -07:00
Shane Smiskol
70682e04cf Toyota: remove STEERING_LKA frequency check (#25490)
* remove STEERING_LKA frequency check

* bump to master

* Update ref_commit
old-commit-hash: e5bb55ccd6
2022-08-18 22:23:39 -07:00
Shane Smiskol
2bd8ee0974 controls: block resume if cruise not previously engaged (#25402)
* see if this works at all

* can revert this

* think adding a no entry conditionally is nicer

* then we can revert this

* 0 makes more sense

* Revert "0 makes more sense"

This reverts commit efc89e8a2389ef58fbc0cec0a2872d24db524867.

* gm CC uses > 70

* bump cereal

* comment

* test on Honda

* whoops

* works

* add exception with todo

* moved button enable events to controlsd

* get rid of that

get rid of that

* different values for now

* car interfaces add enable event, controlsd can block it

* Regen and update refs

* delete if not set

* One place

one place

* regen routes are uninitialized first few frames

* Trim start of segment so it's like original segment

* stash

* regen

* not working

* clean up

* more cleanup

* revert

* bump ceral

* actually check resume button

* whoops

* pcmCruise cars don't use setSpeed, so we're good

* engage correctly in sim

* Update ref_commit

* Update refs
old-commit-hash: 5ed587ebef
2022-08-17 18:03:33 -07:00
Adeeb Shihadeh
15e9bc319b Chrysler: ensure control bit is high before torque cmd (#25465)
* Chrysler: ensure control bit is high before torque cmd

* move that & update refs

* check control bit too
old-commit-hash: e0e0aad144
2022-08-17 15:20:18 -07:00
Shane Smiskol
28a60fb42e process replay: initialize controlsState with original route (#25461)
* push

* do process replay

* commit

* update refs

* clean up

* clean up controlsd

* clean up controlsd

* Add assert

* debubuggier param name

* can be peristent

* Revert "can be peristent"

This reverts commit 6e6d3f6423c26a202623cef728e038259e9e46cd.

* Update selfdrive/test/process_replay/process_replay.py
old-commit-hash: 87ca42e993
2022-08-16 22:02:03 -07:00
Shane Smiskol
40189c8d3f GM: move set speed scaling to DBC (#25422)
* Move scaling into DBC for GM cruise setpoint

* bump opendbc

* no int

* Update refs

* Update ref_commit
old-commit-hash: f341df006a
2022-08-15 02:13:09 -07:00
Jason Young
7560dd6973 VW: Additional PQ / long control prep (#25427)
* VW: Longitudinal support prep

* minimize diffs

* make common button events function

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 1f0a435763
2022-08-13 11:45:23 -07:00
Robbe Derks
a353cc8627 Use steeringAngleDeg for angle control saturation warnings (#25404)
* use steeringAngleDeg for angle control cars

* update refs
old-commit-hash: 24645c92da
2022-08-12 11:30:19 +02:00
HaraldSchafer
48522500ea Falcon Punch Model: turn cutting improvements (#25413)
* simplified change to mpc dynamics

* add jerk pts

* increase jerk cost

* increase jerk pts multipler to master value

* Add final commit

* 1456d261-d232-4654-8885-4d9fde883894/440 ac1a6744-85b0-4ec6-8ba7-608d0717b8f1/750

* some copies are useful

* update model replay ref

* less frames in model replay onnx cpu

* 1456d261-d232-4654-8885-4d9fde883894/440 264b67f5-3f52-4b58-b11f-58dd8aaf08bf/950

* 1456d261-d232-4654-8885-4d9fde883894/440 236fc556-fba3-4255-8ccf-684b22637160/950

* c9d10c64-bea4-41ec-8ca3-d8c886fda172/440 26d73dd2-862a-44ae-bbdd-32cc4f397ad7/900

* Fix couple tests

* Update ref

* Unused for now

* Add lateral factor comment

* Unused variable

Co-authored-by: nuwandavek <vivekaithal44@gmail.com>
Co-authored-by: Bruce Wayne <yassine@comma.ai>
Co-authored-by: Yassine Yousfi <yyousfi1@binghamton.edu>
Co-authored-by: Bruce Wayne <batman@gpu06.internal>
old-commit-hash: 041458f632
2022-08-12 00:47:59 -07:00
cydia2020
63cd100780 Toyota: Send ACC_HUD immediately on fcw (#25348)
* Send ACC_HUD immediately on fcw

* update refs

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 88e034a2a3
2022-08-04 23:24:20 -07:00
Jason Shuler
57961d8364 GM: parse low and manumatic gears (#24764)
* Switch to ECMPRDNL2 for GM gear

* Removing manumatic gear #

* formatting

* update refs

* update refs

* line

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 4bfbd7ced8
2022-08-03 15:52:12 -07:00
HaraldSchafer
e5589e572f Cleanup calibration code (#25119)
* First attempt

* worksish

* tests pass

* cleanup

* get rid of garbahe

* fix name

* Still used in xx

* add debug functions

* used

* Revert "used"

This reverts commit 276e8ebab06d2d4f0e9927ba32b7d8aca2bf88c3.

* Update ref
old-commit-hash: 772b748689
2022-08-01 20:35:14 -07:00
Adeeb Shihadeh
3c275a5b26 Subaru: set cruiseState.standstill (#25320)
* Subaru: set cruiseState.standstill

* only global
old-commit-hash: 9eb27259c7
2022-08-01 09:48:03 -07:00
Adeeb Shihadeh
b34f0129e2 Subaru: 2020 Outback support (#25248)
* Subaru: 2020 Outback support

* bump panda

* bump panda

* update refs

* update refs
old-commit-hash: efa326e208
2022-07-31 12:43:27 -07:00
ZwX1616
6e5393367d Remove RHD toggle: determine by driver side instead (#24802)
* driverview

* auto choose

* useless

* remove

* modeld not use toggle

* remove from params

* should have commissue anyway

* delete icon file

* deal with init more elegantly and prohibit switching when engaged

* nonblock save when not unstable

* filter very low speeds

* a few more secs dont harm

* draw icon

* match

* radius

* use const

* ref commit

* new transs

* put_bool_nonblocking

* 5k route tune

* ref comm

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 22408781f7
2022-07-29 13:52:24 -07:00
Adeeb Shihadeh
9dc723b322 Subaru: log EPS torque (#25304)
* Subaru: log EPS torque

* update refs
old-commit-hash: 7fee45ad6c
2022-07-28 16:42:42 -07:00
Adeeb Shihadeh
8037edf789 Chrylser: some Ram 1500 can steer to 0 (#25279)
old-commit-hash: 5101a7cf88
2022-07-25 15:21:58 -07:00
Adeeb Shihadeh
1b33f98d81 Mazda: use torque controller (#25265)
* Mazda: use torque controller

* update refs

* update refs
old-commit-hash: 347455325e
2022-07-25 15:16:38 -07:00
Adeeb Shihadeh
35f6a6d632 Chrysler: increase steering angle resolution (#25278)
old-commit-hash: 49bd53549d
2022-07-25 14:46:21 -07:00
Jason Young
2c1184d7c8 VW MQB: Cleanup stock ACC button handling (#25168)
* VW MQB: Cleanup stock ACC button handling

* use controls resume output as trigger

* these can wait until taco bell

* pass through of previously fixed value

* retry CI

* checks already done in carcontroller

* don't need these anymore

* reduce diff for now

* remove parenthesis

* update refs

* fix packer exception

* update refs

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 0574b8504f
2022-07-25 14:15:14 -07:00
Adeeb Shihadeh
5263356958 remove CS.steeringRateLimited (#25251)
* remove CS.steeringRateLimited

* bump cereal

* update refs
old-commit-hash: d462a08056
2022-07-24 14:56:55 -07:00
Willem Melching
46b28bc680 Nissan: cleanup set speed (#25233)
* Nissan: cleanup set speed

* update ref
old-commit-hash: f0d494b752
2022-07-22 16:25:06 +02:00
Adeeb Shihadeh
04af978260 let can packer handle counter (#25240)
* let can packer handle counter

* diff is expected

* update refs

* clean that up

* bump opendbc

* fix sim
old-commit-hash: 0ca62bf7df
2022-07-21 20:54:53 -07:00
Willem Melching
95fb15aa5f prereq for matching speeds shown on cars dash (#25222)
* prereq for matching speeds shown on cars dash

* also handle fallback in the ui for replay

* update translations

* update ref
old-commit-hash: c3e95d5e19
2022-07-21 14:48:08 +02:00
Adeeb Shihadeh
b73f02bf45 controlsd: handle radar missing + cleanup system error handling (#25179)
* controlsd: handle radar missing + cleanup system erorr handling

* fix carla

* update refs
old-commit-hash: 505bbce29d
2022-07-14 19:55:18 -07:00
Adeeb Shihadeh
c7507bba29 Chrysler: never drop control bit on older models (#25159)
* Chrysler: never drop control bit on older models

* update refs
old-commit-hash: d5719913a9
2022-07-13 13:22:30 -07:00
Adeeb Shihadeh
9d1f2d9b8e Chrysler: send LKAS control bit while above minSteerSpeed (#25150)
* Chrysler: send LKAS control bit while above minSteerSpeed

* update refs

* rework that a bit

* little more

* update refs
old-commit-hash: 97d7ee369b
2022-07-12 23:11:55 -07:00
Adeeb Shihadeh
a68aa10b73 EV6: reject fake cruise engagements (#25143)
* EV6: reject fake cruise engagements

* bump panda

* raise to 8

* update refs

* bump panda

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 44c6ca7eb4
2022-07-12 18:23:48 -07:00
Adeeb Shihadeh
2e200db8fe Chrysler: limit buttons to 20Hz (#25125)
* Chrysler: limit buttons to 10Hz

* cleanup

* 20hz
old-commit-hash: 614b3a01f8
2022-07-11 22:10:06 -07:00
Adeeb Shihadeh
966713810b Chrysler: increase Ram torque rate limit
old-commit-hash: 29c8e5d227
2022-07-11 17:26:59 -07:00
Adeeb Shihadeh
f3ddb32649 process replay: ensure enabled for significant amount of time (#25121)
* process replay: ensure enabled for significant amount of time

* update refs

* 10s is reasonable
old-commit-hash: 2ae52e9b22
2022-07-11 17:20:56 -07:00
HaraldSchafer
be57ba1b0f Ram 1500 torque tune (#25117)
* torque control again

* 3mss per s

* no bad sensors

* tweaks

* Need more checks before we can do this

* update refs

* only ram for now

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: bdfaa1d1ee
2022-07-11 15:19:55 -07:00
Adeeb Shihadeh
2f7b2ce4d0 Ship EV6 (#25095)
* Ship EV6

* bump opendbc
old-commit-hash: d08a231774
2022-07-08 22:46:20 -07:00