Commit Graph

177 Commits

Author SHA1 Message Date
HaraldSchafer
be5ddd25cd Refactor long (#21433)
* refactor

* needs casting

* tests pass

* fix that test

* refactor in controls

* lets not go crazy

* change of names

* use constants

* better naming

* renamed

* soft constraints

* compile slack variables

* rm git conflict

* add slack variables

* unused

* new edition

* fcw

* fix tests

* dividing causes problems

* was way too slow

* take a step back

* byeeee

* for another time

* bad idxs

* little more cpu for cruise mpc

* update refs

* these limits seem fine

* rename

* test model timings fails sometimes

* add default

* save some cpu

* Revert "little more cpu for cruise mpc"

This reverts commit f0a8163ec90e8dc1eabb3c4a4268ad330d23374d.

* Revert "test model timings fails sometimes"

This reverts commit d259d845710ed2cbeb28b383e2600476527d4838.

* update refs

* less cpu

* Revert "Revert "test model timings fails sometimes""

This reverts commit e0263050d9929bfc7ee70c9788234541a4a8461c.

* Revert "less cpu"

This reverts commit 679007472bc2013e7fafb7b17de7a43d6f82359a.

* cleanup

* not too much until we clean up mpc

* more cost on jerk

* change ref

* add todo

* new ref

* indentation
2021-07-07 19:42:26 -07:00
Adeeb Shihadeh
c72d163e14 deprecate CP.enableCamera (#21509)
* deprecate CP.enableCamera

* more removal

* one more

* update refs
2021-07-07 14:59:18 -07:00
HaraldSchafer
6838e1c82c Refactor lateral lag compensation (#21334)
* add T_IDXS

* refactor

* fix test

* unused

* typo

* needs casting

* Update selfdrive/controls/lib/drive_helpers.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* deprecate field

* regen all

* new segs

* add todo

* split back

* clean

* bad names

* do in controls

* add arg

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-06-30 14:19:39 -07:00
Willem Melching
6729e963c9 Honda: emulate convenience blinker from stalk (#21387)
* Honda: emulate convenience blinker from stalk

* comment

* light->lamp

* reset on rising edge

* update ref
2021-06-29 12:10:35 +02:00
Willem Melching
a8fac002ae Honda Bosch longitudinal prerequisites (#21217)
* untested changes

* set compute_gb

* community feature for good measure

* add code for rolling backwards

* init needs CarParams

* stay in elm mode until carParams is written

* fix tester present bus number

* fix can errors

* fix enableCruise flag

* print when radar disable is done

* move retry logic to controlsd

* move lookup table into carcontroller params

* cleanup brake error values

* make init return

* that should be 1

* floats

* back to no failure handling

* try simplify knockout

* bump panda

* Move flags to panda

* add warnings

* Revert "try simplify knockout"

This reverts commit 4f496245791ea6bd041d4412b96035c6b434b91c.

* add note about LoC.long_control_state

* update ref
2021-06-22 16:28:11 +02:00
Greg Hogan
8071111f59 default carParams.stoppingControl to True (#21248)
* hyundai has full brake control

* set default stoppingControl to True

* update ref

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2021-06-15 14:00:57 +02:00
Jason Young
f86f344ba5 VW MQB: Switch to comfort blinker signal (#21253)
* Switch to comfort blinker signal

* bump opendbc

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-06-13 22:21:23 -07:00
Adeeb Shihadeh
7d8480cffe Update VW process replay route (#21142) 2021-06-04 15:29:13 -07:00
Willem Melching
de34d1a527 Determine lane chane direction in preLaneChange state (#21119)
* Determine lane chane direction in preLaneChange state

* cleanup

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-06-04 10:03:13 +02:00
Greg Hogan
6e300aaf57 hyundai: disable steering on all steer warnings (#20657)
* hyundai: set CF_Lkas_ToiFlt for wind down

* hyundai: disable steering on all steer warnings

* Revert "hyundai: set CF_Lkas_ToiFlt for wind down"

This reverts commit 065f0a996db9e52511013c7011ed95876966d134.

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-06-03 15:34:25 -07:00
ShaneSmiskol
ebc294296a Toyota: Only use gas interceptor under 19 mph (#21101)
* pedal improvements

* pedal tuning under 19 mph, stock tuning above

* Correctly set tuning, and a temporary reference script

* looking good

* use minEnableSpeed

* minEnableSpeed will always be -1 if pedal since it's used for lockout

* add hysteresis around 19 mph for enabling pedal use

* parameterize minAccSpeed (enable speed is -1 when stop and go to allow engage, acc is min limit for acc commands)

* fix Prius later, 5 mph gap around switch speed

* define min_acc_speed in interface and CC

* use pedal gains up to 22 mph, and correctly use hysteresis above the switch speed

* only check this if pedal

* consolidate comment

* Change BP to switch tuning at 19 mph, define global constant

* Start at interceptor status

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* update releases

* typo

* transition tuning from 19 to +3 mph

* change cmd names and update tuning comment

* Update RELEASES.md

* calculate new pedal gains

* little more clear

* even clearer

* same comment convention and hardcode new pedal tune

* bump cereal

* weird, got added in with the rebase

* three possible long tunings: pedal, improved non-pedal, and default non-pedal

* update refs

* future note: don't add submodules when rebasing!

* update refs

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-06-03 15:11:10 -07:00
ShaneSmiskol
e9e197eb3c Merge Accord trims (#21105)
* Merge unique Accord 1.5 fw versions

* remove all instances of ACCORD_15

* bump opendbc and update dbcs

* Switch between gearbox messages by detecting presence of gearbox msg

* both accord (2t) and accord hybrid use the same gearbox, 1.5t is the outlier

* default to GEARBOX

* add old name to migration

* bump opendbc

* update refs

* change msg name, bump cereal

* Update selfdrive/test/test_routes.py

* update ref

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Willem Melching <willem.melching@gmail.com>
2021-06-03 13:35:23 -07:00
Adeeb Shihadeh
a69e1715d4 Honda: cleanup enable logic (#20749) 2021-06-03 01:49:33 -07:00
HaraldSchafer
dc40631e97 Fix planner low speed behaviour (#20990)
* first point is 0

* first point is always now

* print replay diffs

* new ref

* changed wrong commit
2021-05-21 15:10:59 -07:00
ShaneSmiskol
551091bcfa Deprecate brakeLights field (#20954)
* remove all references to CS.brakeLights

* unused red

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-05-18 17:48:02 -07:00
HaraldSchafer
2f80775b50 Filter only initialized if up for 1sec (#20940)
* add time since reset check

* fix time since reset

* update ref

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2021-05-18 11:12:02 -07:00
Willem Melching
17c3220322 Rate limit paramsd angleOffset output (#20946)
* rate limit paramsd angle offset

* update ref
2021-05-18 12:59:42 +02:00
HaraldSchafer
e5f93ef142 Add ublox interference monitor (#20911)
* add interference monitor

* new thresholds

* correct labels

* always run for test

* new msg

* add flag

* Revert "always run for test"

This reverts commit b04b92ac2d73d996d1526509e26c4e1a4338cbbb.

* add hw status flags
2021-05-14 15:23:27 -07:00
Adeeb Shihadeh
0148c24147 cleanup Honda car strings - part 2 (#20848)
* cleanup honda car strins

* fix process replay

* update ref

* forgot to build

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2021-05-07 13:32:34 +02:00
Willem Melching
fc3da5eaf9 Use standstill flag in locationd (#20838) 2021-05-06 13:13:13 -07:00
Willem Melching
e9db5723ef Locationd 100 Hz (#20816)
* fix std transform

* 100Hz

* new ref

* no more decimation

* clean up confusing maths

* static typing

* Revert "static typing"

This reverts commit 23d87337de648e629fbd35dd8c04a740bbefca47.

* 100Hz costs more

* move normalization into core

* add quat idxs

* add big eps

* this is not safe in the filter

* more sensible

* updates to rednose

* not tested

* normalize in python too

* update rednose

* nan check

* check for infs too

* all should be finite

* update ref

* rednose pr now in master

Co-authored-by: Harald Schafer <harald.the.engineer@gmail.com>
2021-05-06 11:01:58 +02:00
xps-genesis
1e473d764a Chrysler BSM info signal (#20694)
* Chrysler BSM info signal

* change to ==1

* add checks to enable bsm

* add fingerprint can id for enableBsm

* gate behind enableBsm

* fix indenatation

* update refs

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-05-04 20:37:39 -07:00
Willem Melching
7a8f61f4bf Remove unnecessary trim levels from car name (#20815)
* remove unnecessary trim levels from car name

* remove hardcoded strings

* fix process replay

* more fixes

* fix migration

* update ref
2021-05-04 09:24:24 -07:00
HaraldSchafer
daecf4247b Revert "Locationd 100hz (#20759)" (#20797)
* Revert "Locationd 100hz (#20759)"

This reverts commit 333313cf0e.

* new ref
2021-05-02 15:06:34 -07:00
Adeeb Shihadeh
f9a961f6fb delay controls start (#20761)
* delay controls start

* shouldn't need this stuff anymore

* only delay board

* bail after 2s

* fix loopback test

* fix process replay

* update refs

* bump cereal

Co-authored-by: Comma Device <device@comma.ai>
2021-04-30 13:55:17 -07:00
HaraldSchafer
333313cf0e Locationd 100hz (#20759)
* fix std transform

* 100Hz

* new ref

* no more decimation

* clean up confusing maths

* static typing

* Revert "static typing"

This reverts commit 23d87337de648e629fbd35dd8c04a740bbefca47.

* 100Hz costs more
2021-04-28 15:29:14 -07:00
Adeeb Shihadeh
b0503e534a Hyundai: add BSM detection (#20747)
* Hyundai: add BSM detection

* update refs
2021-04-25 13:12:03 -07:00
Adeeb Shihadeh
6c7ed8f2e4 enforce message checks in can parser (#20742)
* enforce message checks in can parser

* nissan

* vw

* hkg

* subaru

* toyota

* honda bosch

* gm

* honda nidec

* bump opendbc

* not all tss2 have bsm

* toyota fixes

* honda fixes

* vw fix

* fix subaru

* fix long tests

* update refs

* crv bsm
2021-04-25 12:52:16 -07:00
Joost Wooning
d2a2ccfee4 compare carspeed float to epsilon instead of zero (#20714)
* compare carspeed float to epsilon instead of zero

* update ref

* add ref commit again

Co-authored-by: Harald Schafer <harald.the.engineer@gmail.com>
2021-04-22 17:55:41 -07:00
Adeeb Shihadeh
836668f105 less harsh steering unavailable alert when overriding (#20718)
* less harsh steering unavailable alert when overriding

* just steer

* 1s

* orange

* update refs
2021-04-20 21:01:28 -07:00
Willem Melching
aae849ea45 Use cached fw query in process replay (#20709)
* use fw query in process replay

* update ref

* only for supported cars
2021-04-20 14:01:59 +02:00
Joost Wooning
ff813b6b45 Add flag to process replay config to use real submaster (#20701) 2021-04-19 17:27:36 +02:00
Willem Melching
343fea2bf9 Fix typo in ephemeris parsing (#20677)
* fix typo in ephemeris parsing

* update ref
2021-04-14 11:25:43 +02:00
mahlzeit1948
f6d800a89e Fix Chrysler Pacifica weight (#20647)
* Update interface.py

2858 is the gross vehicle weight of the hybrid (maximum weight of vehicle + cargo).
Curb weight for the ICE is 1964 kg, for the hybrid it is 2242 kg

* hybrid & update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-04-11 17:18:31 -07:00
HaraldSchafer
0e10b74a61 MPC retune for laneless fix (#20616)
* was making wrong policy more aggresive

* allow to be set from simulator

* update refs

* put params together
2021-04-08 12:56:47 -07:00
Adeeb Shihadeh
2fa1b2572d Alerts update (#20567)
* steer temp unavailable should be a soft disable

* no mute

* these should be no entries

* sound

* better name

* deprecated

* make vehicleModelInvalid a soft disable

* update refs

* bump cereal

* bump cereal

* update refs
2021-04-07 12:18:58 -07:00
HaraldSchafer
d72d433ec7 no heading cost (#20594)
* no heading cost

* live mpc weight config

* need to add stds

* make work on empty data

* no divide by 0

* update refs

* update model replay

* update proc replat

* new model replay ref
2021-04-06 23:49:29 -07:00
Adeeb Shihadeh
2319d726fb lower min lane change speed to 30mph (#20586)
* lower min lane change speed to 30mph

* update refs
2021-04-05 15:38:53 -07:00
Jason Young
48fa8ffb33 VW MQB: Update to Audi A3 Mk3 (#20489)
* Add A3 and A3 e-tron FPv2

* Update README

* Catch up with model renaming

* Trim duplicate FW values

* Add 2014 A3 (bankster)

* Update model-year range

* Revert more model name changes

* Revert more model name changes

* More FW for 2017 A3 e-tron (fastzeek)

* Update A3 models and packages in README

* Update A3 packages again

* AUDI_A3 -> AUDI_A3_MK3

* Update test route reference

* CAN valid should pass for VW now

* Update process_replay route

* Expand tested A3 range (we have known 2014-15,17)

* Revert "CAN valid should pass for VW now"

This reverts commit 73a4b4886f572045ada05cd13e60790ca3e17a94.

* revert route changes and update refs

* update refs again

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-03-30 14:49:46 -07:00
Jason Young
e181fd7f0a VW MQB: Misc bugfixes and cleanup (#20540)
* Add LDW->SWA signal pass-through

* GC currently unused ACC_06 and LDW_02 signal data

* Split out Jetta GLI

* Pass in camera CAN parser now that we use it

* GC unused CarController param, camelCase->PEP8

* CAN valid should pass for VW now

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-03-30 13:59:17 -07:00
ZwX1616
0fb00e10b1 also use e2e model output for DM policy (#20526)
* neg mining

* clean up format

* eyes less noisy

* update ref
2021-03-29 19:41:27 -07:00
Adeeb Shihadeh
43ce7165c4 Remove lane change toggle and default LDW to off (#20442)
* remove lane change toggle and default LDW to off

* update refs
2021-03-22 20:55:57 -07:00
HaraldSchafer
8bddaa7607 Update locationd (#20410)
* this was too extreme

* unused import

* capnp wants bools

* update refs
2021-03-19 17:12:34 -07:00
Willem Melching
3c23226edc verify safetyParam read back from PandaState (#20384)
* verify safetyParam read back from PandaState

* update ref

* bump panda
2021-03-17 14:20:05 +01:00
HaraldSchafer
27035131cc Sane curvature rate limit in plannerd (#20366)
* safety limit

* should be in RADs

* add raw

* update refs
2021-03-16 15:00:03 -07:00
Jason Young
1af35c3398 VW MQB: Updated message and signal data, round 2 (#20298)
* ACC_02 signal naming update

* Add conversion factor now that DBC scaling has changed

* bump opendbc

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-03-15 15:09:09 -07:00
qadmus
ad123714ba Add GM steering rate and EPS torque to CarState (#20319)
* Add GM steering rate and EPS torque to CarState

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-03-12 14:51:20 -08:00
Willem Melching
c23ec9f753 LateralPlanner should only compute curvature (#20289)
* get curvature from planner

* no need to check active

* remove that

* remove self

* liveParams not needed

* cast

* fix test bug

* fixes

* fix ui.py

* fix radians

* update refs

* update refs

* bump cereal

* bump cereal

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-03-11 21:08:51 -08:00
Jason Young
1813c72a76 VW MQB: Use raw steering angle signal (#20247)
* Use raw instead of processed steering angle

* update ref commit

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-03-09 13:47:00 -08:00
Jason Young
6129a92f38 VW MQB: Add support for blind spot monitoring radar (#20242)
* Get steering rate-change sign from the right signal

* Temp remove network-switching reference prior to upstream

* Additional description of BSM signals

* Simplify expression

* Typo

* Update ref_commit

* update refs after merge

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-03-04 16:48:36 -08:00