Commit Graph

213 Commits

Author SHA1 Message Date
HaraldSchafer
0dc45eaf1c Fix 0 init bug for acados lateral (#22225)
* this is needed somehow

* new ref
2021-09-13 21:23:22 -07:00
HaraldSchafer
7081ab4fb7 Port lateral planning to ACADOS (#22080)
* lateral acados

* looks good!

* add another solve, needed for init somehow

* use copy

* init correctly

* cleanup sconstruct

* Update files_common

* update cpu usage

* reset when invalid

* fix cpu usage

* cost_set doesnt leak

* new ref

* non leaky reset

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Comma Device <device@comma.ai>
2021-09-13 19:06:54 -07:00
ZwX1616
dac8597a08 refactor dm pitch/yaw thresholding (#22191)
* use indiviual pitch/yaw instead of norm

* update process replay
2021-09-13 16:05:42 -07:00
Willem Melching
b7d1aac197 Parameterize longitudinal control using carParams (#22200)
* use CP.startAccel

* missing values

* order

* update ref

* cereal
2021-09-11 18:01:54 -07:00
Willem Melching
1e62b09e5d Use CP.vEgoStopping and clean up CP.startAccel (#22199)
* use CP.vEgoStopping and clean up

* update ref
2021-09-11 17:13:30 -07:00
HaraldSchafer
74b6c87254 cleanup old nidec accel override logic (#22181)
* cleanup old nidec accel override logic

* add ref without deprecated fields

* no more override
2021-09-10 10:34:18 -07:00
Adeeb Shihadeh
1c750975fc reduce startup alert duration to 10s (#22163)
* reduce startup alert duration to 10s

* update refs

* update refs

* update refs
2021-09-07 13:40:31 -07:00
Willem Melching
4f84e1b2ad actually set longControlState in actuators packet (#22155)
* actually set longControlState in actuators packet

* update ref
2021-09-06 20:14:01 -07:00
Willem Melching
b39f6efa3f parameterize longitudinal actuator delay (#22153)
* paremetrize longitudinal actuator delay

* update ref
2021-09-06 17:56:52 -07:00
Willem Melching
f941111dcd Clean up PID controller ACCEL_MIN/ACCEL_MAX (#22148)
* use ISO 15622:2018 limits in PID controller

* allow more for nidec

* limit PID inputs

* CP is not needed

* add GM

* not used

* update ref

* fix honda bosch
2021-09-06 17:29:32 -07:00
martinl
d3113fe01a Subaru: universal signal for ACC speed units (#21995)
* Change ACC Speed Units signals for Global and Pre-Global

* Use Dash_State UNITS signal for Preglobal

* Change Subaru Preglobal to use Dash_State2 UNITS signal

* bump opendbc

* cleanup

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-09-02 14:21:35 -07:00
Willem Melching
edae2218d7 Smarter longitudinal lag compensations (#22094)
* smarter lag compensations

* need to use speed from plan

* update ref

Co-authored-by: Harald Schafer <harald.the.engineer@gmail.com>
2021-09-01 15:28:16 -07:00
Willem Melching
c15a616ac4 Continuously update offset between TSS2 angle sensors (#21943)
* Continuously update offset between TSS2 angle sensors

* add comment

* less lines

* only when initialized

* init to None

* update ref
2021-09-01 15:00:52 -07:00
grekiki
21fad4d1ad Add angleError to pid_log (#21611)
* add angleError

* Log all the time

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-09-01 13:45:22 -07:00
Willem Melching
b8e4717f72 Populate angle offset in carState for Toyota accurate angle sensor (#22091)
* populate angle offset in carstate for TSS2

* update ref
2021-08-31 11:34:00 -07:00
Adeeb Shihadeh
86f68ff22e add TSS2 replay route (#21953)
* add TSS2 replay route

* skip on sim

* do not set on import time

* update ref

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2021-08-31 10:48:21 -07:00
HaraldSchafer
1ac89f14aa Change car controller interface from gas/brake to acceleration (#21911)
* retune civic

* seems smooth

* back to normal

* new ref

* fix conflict

* runs

* rm

* accel scale is 4

* toyota should be good

* more cleanup

* fixup

* better naming

* update ref

* deprecated

* sending brake when not enable causes a fault

* rm gas and brake

* unused

* update ref

* acura logic is no more

* wrong before

* revert tuning cleanup

* adress comments

* update ref

* already on master

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2021-08-30 09:32:52 -07:00
HaraldSchafer
da73249fc2 Retune nidec long (#21941)
* retune civic

* add a deadzone

* large diffs may not be ok

* typo

* seems smooth

* improve pedal

* back to normal

* new ref

* new ref
2021-08-16 17:06:19 -07:00
ZwX1616
00ea7c1c82 DM 0.8.8 (#21897)
* update threshs

* e392

* 40% less

* ref
2021-08-16 12:44:45 -07:00
Mitchell Goff
05b37552f3 Retuned desire model (#21919)
* New model: d8e7f76f-7bec-4a83-af00-c0fae792527f/950

* Updated process replay refs

* Updated model replay ref
2021-08-12 21:06:26 -07:00
HaraldSchafer
a8f3e2b3c2 Change long control honda pilot, ridgeline, honda fit, civic, ilx (#21886)
* not used

* just use gas

* allow gas

* try 0

* typo

* set to default

* set default

* makes more sense

* downtune and cleanup

* max accel always

* that is needed to smooth gas to brake

* try downtuning low speed

* try from default

* nidec is not bosch

* air resistance exists

* more smoothing

* wind brake sooner

* Civic experiments2 (#21862)

* control on throttle

* throttle modifier

* get acura in line

* try set speed control again (#21870)

* new acura function

* put back

* put back

* make linter happy

* define wind_brake once

* Civic experiments (#21908)

* remove civic

* start from scratch

* data drivenm

* the data does not lie

* data collection

* data driven

* limit

* final candidate

* fix windbrake

* Civic experiments (#21910)

* remove civic

* start from scratch

* data drivenm

* the data does not lie

* data collection

* data driven

* limit

* final candidate

* fix windbrake

* add acura control

* more cleanup

* cleanup

* update ref

* clip

* seems to fault

* always continuous

* new ref
2021-08-11 18:32:37 -07:00
HaraldSchafer
e0087fc313 Fix orientation in map (#21863)
* fix calibrated orientation

* update ref

* cleaner

* update ref

* master

* update again

* update ref again again

* actually compiled this tim,e
2021-08-05 21:06:46 -07:00
ZwX1616
0066523b88 DM model with better noise performance (#21733)
* smooth 3d4f

* update thresholds

* update ref commt

* update
2021-08-05 16:29:37 -07:00
HaraldSchafer
aa689176fc Cleaner lane change alerts (#21857)
* less is more

* small

* remove HUD warnings

* update ref

* safe

* update refs

* update again

Co-authored-by: Willem Melching <willem.melching@gmail.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-08-05 14:23:27 -07:00
Harald Schafer
e63d94d8d2 Revert "nav: use calibrated orientation (#21853)"
This reverts commit 4b209f31a1.
2021-08-04 10:41:49 -07:00
HaraldSchafer
4b209f31a1 nav: use calibrated orientation (#21853)
* calibrate map

* msg added
2021-08-04 09:58:04 -07:00
Mitchell Goff
15d6bbb47c Revert "New desire model (#21729)" (#21805)
* Revert "New desire model (#21729)"

This reverts commit e83973b9b3.

* Updated process replay ref and reverted release notes
2021-07-30 14:34:29 -07:00
Adeeb Shihadeh
f7dc898853 update prius test route (#21791) 2021-07-29 20:04:07 -07:00
HaraldSchafer
4bd4ed4999 safer low speed (#21705) 2021-07-25 15:15:50 -07:00
HaraldSchafer
ef0b120a9a add jerk to longitudinal plan (#21598)
* add jerk output, so its like lateral

* typo

* add to packet

* update cereal and ref
2021-07-14 11:51:48 -07:00
HaraldSchafer
5d07819084 Taper off high speed accel (#21599)
* max 0.2 diff from before to preserve bad tuned cars

* update ref
2021-07-14 10:53:14 -07:00
HaraldSchafer
6a93346729 fix low speed override bug and cut-in bug (#21593)
* fix low speed bug and cutin bug

* update ref
2021-07-13 23:36:25 -07:00
HaraldSchafer
fd41e9f01b Lower speed for lowest planned acceleration (#21578)
* 55mph sounds about right

* update refs
2021-07-13 14:22:06 -07:00
HaraldSchafer
a42d8f3a14 less accel (#21565)
* less accel

* new refs

* Update longitudinal_planner.py

* update refs
2021-07-12 18:30:56 -07:00
Adeeb Shihadeh
6d9dc9945a Honda: keep braking after PCM disables cruise (#21510)
* Honda: keep braking after PCM disables cruise

* update refs
2021-07-11 19:31:09 -07:00
Harald Schafer
8c4582c87a new refs 2021-07-09 16:38:23 -07:00
HaraldSchafer
be5ddd25cd Refactor long (#21433)
* refactor

* needs casting

* tests pass

* fix that test

* refactor in controls

* lets not go crazy

* change of names

* use constants

* better naming

* renamed

* soft constraints

* compile slack variables

* rm git conflict

* add slack variables

* unused

* new edition

* fcw

* fix tests

* dividing causes problems

* was way too slow

* take a step back

* byeeee

* for another time

* bad idxs

* little more cpu for cruise mpc

* update refs

* these limits seem fine

* rename

* test model timings fails sometimes

* add default

* save some cpu

* Revert "little more cpu for cruise mpc"

This reverts commit f0a8163ec90e8dc1eabb3c4a4268ad330d23374d.

* Revert "test model timings fails sometimes"

This reverts commit d259d845710ed2cbeb28b383e2600476527d4838.

* update refs

* less cpu

* Revert "Revert "test model timings fails sometimes""

This reverts commit e0263050d9929bfc7ee70c9788234541a4a8461c.

* Revert "less cpu"

This reverts commit 679007472bc2013e7fafb7b17de7a43d6f82359a.

* cleanup

* not too much until we clean up mpc

* more cost on jerk

* change ref

* add todo

* new ref

* indentation
2021-07-07 19:42:26 -07:00
Adeeb Shihadeh
c72d163e14 deprecate CP.enableCamera (#21509)
* deprecate CP.enableCamera

* more removal

* one more

* update refs
2021-07-07 14:59:18 -07:00
HaraldSchafer
6838e1c82c Refactor lateral lag compensation (#21334)
* add T_IDXS

* refactor

* fix test

* unused

* typo

* needs casting

* Update selfdrive/controls/lib/drive_helpers.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* deprecate field

* regen all

* new segs

* add todo

* split back

* clean

* bad names

* do in controls

* add arg

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-06-30 14:19:39 -07:00
Willem Melching
6729e963c9 Honda: emulate convenience blinker from stalk (#21387)
* Honda: emulate convenience blinker from stalk

* comment

* light->lamp

* reset on rising edge

* update ref
2021-06-29 12:10:35 +02:00
Willem Melching
a8fac002ae Honda Bosch longitudinal prerequisites (#21217)
* untested changes

* set compute_gb

* community feature for good measure

* add code for rolling backwards

* init needs CarParams

* stay in elm mode until carParams is written

* fix tester present bus number

* fix can errors

* fix enableCruise flag

* print when radar disable is done

* move retry logic to controlsd

* move lookup table into carcontroller params

* cleanup brake error values

* make init return

* that should be 1

* floats

* back to no failure handling

* try simplify knockout

* bump panda

* Move flags to panda

* add warnings

* Revert "try simplify knockout"

This reverts commit 4f496245791ea6bd041d4412b96035c6b434b91c.

* add note about LoC.long_control_state

* update ref
2021-06-22 16:28:11 +02:00
Greg Hogan
8071111f59 default carParams.stoppingControl to True (#21248)
* hyundai has full brake control

* set default stoppingControl to True

* update ref

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2021-06-15 14:00:57 +02:00
Jason Young
f86f344ba5 VW MQB: Switch to comfort blinker signal (#21253)
* Switch to comfort blinker signal

* bump opendbc

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-06-13 22:21:23 -07:00
Adeeb Shihadeh
7d8480cffe Update VW process replay route (#21142) 2021-06-04 15:29:13 -07:00
Willem Melching
de34d1a527 Determine lane chane direction in preLaneChange state (#21119)
* Determine lane chane direction in preLaneChange state

* cleanup

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-06-04 10:03:13 +02:00
Greg Hogan
6e300aaf57 hyundai: disable steering on all steer warnings (#20657)
* hyundai: set CF_Lkas_ToiFlt for wind down

* hyundai: disable steering on all steer warnings

* Revert "hyundai: set CF_Lkas_ToiFlt for wind down"

This reverts commit 065f0a996db9e52511013c7011ed95876966d134.

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-06-03 15:34:25 -07:00
ShaneSmiskol
ebc294296a Toyota: Only use gas interceptor under 19 mph (#21101)
* pedal improvements

* pedal tuning under 19 mph, stock tuning above

* Correctly set tuning, and a temporary reference script

* looking good

* use minEnableSpeed

* minEnableSpeed will always be -1 if pedal since it's used for lockout

* add hysteresis around 19 mph for enabling pedal use

* parameterize minAccSpeed (enable speed is -1 when stop and go to allow engage, acc is min limit for acc commands)

* fix Prius later, 5 mph gap around switch speed

* define min_acc_speed in interface and CC

* use pedal gains up to 22 mph, and correctly use hysteresis above the switch speed

* only check this if pedal

* consolidate comment

* Change BP to switch tuning at 19 mph, define global constant

* Start at interceptor status

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* update releases

* typo

* transition tuning from 19 to +3 mph

* change cmd names and update tuning comment

* Update RELEASES.md

* calculate new pedal gains

* little more clear

* even clearer

* same comment convention and hardcode new pedal tune

* bump cereal

* weird, got added in with the rebase

* three possible long tunings: pedal, improved non-pedal, and default non-pedal

* update refs

* future note: don't add submodules when rebasing!

* update refs

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-06-03 15:11:10 -07:00
ShaneSmiskol
e9e197eb3c Merge Accord trims (#21105)
* Merge unique Accord 1.5 fw versions

* remove all instances of ACCORD_15

* bump opendbc and update dbcs

* Switch between gearbox messages by detecting presence of gearbox msg

* both accord (2t) and accord hybrid use the same gearbox, 1.5t is the outlier

* default to GEARBOX

* add old name to migration

* bump opendbc

* update refs

* change msg name, bump cereal

* Update selfdrive/test/test_routes.py

* update ref

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Willem Melching <willem.melching@gmail.com>
2021-06-03 13:35:23 -07:00
Adeeb Shihadeh
a69e1715d4 Honda: cleanup enable logic (#20749) 2021-06-03 01:49:33 -07:00
HaraldSchafer
dc40631e97 Fix planner low speed behaviour (#20990)
* first point is 0

* first point is always now

* print replay diffs

* new ref

* changed wrong commit
2021-05-21 15:10:59 -07:00