Commit Graph

67 Commits

Author SHA1 Message Date
Justin Newberry
3b91610c0b Precommit: ensure executable bit is set (#29784)
* precommit ensure executable

* exclude tinygrad

* bump submodules

* exclude tinygrad globally
old-commit-hash: 4e69937d0d
2023-09-05 16:33:26 -07:00
Justin Newberry
c4f322ce2d Linter: remove pylint (#29611)
remove pylint
old-commit-hash: 1ee6ed4b16
2023-08-24 16:30:54 -07:00
Dean Lee
1a2f9c464b locationd: passing eigen objects by reference (#28719)
pass eigen objects by reference
old-commit-hash: 3930ec9fac
2023-08-24 12:55:47 -07:00
Dean Lee
0984736972 cpplint: add filter build/include_subdir (#29585)
old-commit-hash: 21da5a216f
2023-08-24 15:42:17 +01:00
Dean Lee
97e9d55588 cpplint: build/include_what_you_use (#29556)
* include_what_you_use

* remove comments

* include <memory>

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 2d99521e75
2023-08-23 13:25:17 -07:00
Adeeb Shihadeh
16ec56398c add openpilot prefix to imports (#29498)
* add openpilot prefix to imports

* more

* more

* fix docs

* fix linter

* bump submodules

* fix patched tests

* update dynamic imports

* debug

* Revert "debug"

This reverts commit db5e13b9911cc74438bee123bc3430da6c31b24b.

* fix pm test
old-commit-hash: a9626f95b6
2023-08-20 20:49:55 -07:00
Justin Newberry
f33b4de80b Ruff: b905 (strict zip) (#29336)
* added mutable default args

* most of the Bs

* add comment about lrucache

* b905
old-commit-hash: e4ead4f183
2023-08-11 16:13:51 -07:00
Justin Newberry
3ee0786de3 CI: Pylint to ruff (#29294)
* pylint to riff

* pylint to riff

* pylint to riff

* revert more

* undo exclude removal

* exclude tinygrad

* set line length

* pylint exclusions to ruff

* same excludes as old linter

* fix tools QA

* remove unrequired check

* revert linting third_party

* ignore e402
old-commit-hash: 7fdd9fc37c
2023-08-09 13:26:54 -07:00
Justin Newberry
7b677910df Linter: Fix >160 line length test (#29287)
* test

* fix line length

* fix line length

* fix file size

* revert poetry

* cleanup for PR
old-commit-hash: cf64b27168
2023-08-08 17:13:35 -07:00
Adeeb Shihadeh
e33973cdd4 pre-commit: autoupdate hooks (#29198)
* Update pre-commit hook versions

* fix

* bump submodules

* one more

---------

Co-authored-by: adeebshihadeh <adeebshihadeh@users.noreply.github.com>
old-commit-hash: 39ce23420c
2023-08-01 12:32:21 -07:00
Harald Schäfer
86b8e2eb8c Qcom localizer: erratic clocks have an erratic error rate too (#28654)
Erratic clocks drift erratically too
old-commit-hash: af9edb020d
2023-06-23 09:44:37 -07:00
Harald Schäfer
f1f5f15f12 Add lane ekf (#26986)
* change lane_kf pos

* add lane back here
old-commit-hash: af97a96080
2023-01-16 19:43:34 -08:00
HaraldSchafer
eac9ec1570 locationd: Fix GPS sensor times with fixed offsets (#25920)
* Rewind to qcom time

* Fix test

* Typo

* init unix_time fix

* add gps sensor_time_offsets

* remove all clocks code and add todo

* :emove clocks in unit test

* update refs

* update refs

Co-authored-by: nuwandavek <vivekaithal44@gmail.com>
old-commit-hash: b332441803
2022-10-12 17:47:30 -07:00
Adeeb Shihadeh
35ff65121e pre-commit: add codespell (#25571)
old-commit-hash: 6590fb2b93
2022-08-30 11:20:55 -07:00
HaraldSchafer
fa226dd852 Support quectel gps (#25299)
* qcom clock gets corrected randomly it seems

* Use quectel gps

* fix small laikad bugs

* Support both

* Support ublox and qcom clock model

* fix laikad test

* fix typo

* Back to original value

* More typos

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 11da2804f6
2022-07-28 10:56:59 -07:00
HaraldSchafer
fa85de9f8b Full localizer: Use standard naming conventions (#25007)
Use standard naming conventions
old-commit-hash: dd43ae2856
2022-06-30 14:49:17 -07:00
Gijs Koning
6a83611df2 Update rednose: use EKF_sym_pyx (#24978)
* Update rednose

* Update rednose

* cleanup
old-commit-hash: fdc22554b8
2022-06-28 11:32:51 +02:00
Gijs Koning
5494622601 Improve laikad cpu usage. Less pos fix. Less local imports (#24887)
* Improve laikad cpu usage. Less pos fix. Not local imports

* Add laika to files_common

* Add laika to dockerfile sim

* Fix

* Fix

* undo
old-commit-hash: 1c4b145aa4
2022-06-20 14:24:11 +02:00
Gijs Koning
226edb4918 laikad: fixes to run on device (#24879)
* Always run laikad on device!

* Update laika

* Update laika

* Fix gps week and time of week in msg

* Reset kalman filter if pos_fix or last_known_position

* put behind file

* move pr parsing into common file

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: dc98511b7a
2022-06-16 17:45:08 +02:00
Adeeb Shihadeh
3c48bc47b7 Move a bunch of stuff to system/ part 3 (#24829)
* move swaglog.py

* timezoned

* logmessaged

* version.py

* fix linter
old-commit-hash: 0fce5d9045
2022-06-11 23:19:27 -07:00
HaraldSchafer
6bd1706b52 Offline localizer: accept addition camera (#24266)
* Offline localizer: add option for additional camera

* add names

* fix some bugs

* Wide ORB features are less accurate

* add comment
old-commit-hash: a762567de9
2022-04-19 22:45:35 -07:00
Adeeb Shihadeh
bd71c594a2 pylint: enforce indentation (W0311) (#24039)
* pylint: enforce indentation (W0311)

* few more
old-commit-hash: 8af20af66d
2022-03-24 23:23:29 -07:00
Vivek Aithal
1eb13fdc65 paramsd: fix VehicleModelInvalid errors (#23726)
* bound steerratio, stiffness std

* remove start steer_ratio limits after looking at data

* reduce sf obs noise

* update refs

* update refs

* add comment explaining change
old-commit-hash: 8a2cbfe00b
2022-02-09 17:37:28 -08:00
Ewout ter Hoeven
f206ebd054 Pyupgrade 3.6: Update syntax with Python 3.6+ features (#23305)
Updated Python code with Python 3.6+ features:
- utf-8 encoding is now the default (PEP 3120)
- Replace list comprehensions by Generator Expressions (PEP 289)
- Replace yield loop by yield from (PEP 380)
- Remove the (object) subclass when defining a class
- Replace the IOError alias by OSError (PEP 3151)
- Define sets with curly braces {} instead of set()
- Remove "r" parameter from open function, which is default

Co-Authored-By: Adeeb Shihadeh <8762862+adeebshihadeh@users.noreply.github.com>
Co-Authored-By: GregorKikelj <96022003+GregorKikelj@users.noreply.github.com>

Co-authored-by: Adeeb Shihadeh <8762862+adeebshihadeh@users.noreply.github.com>
Co-authored-by: GregorKikelj <96022003+GregorKikelj@users.noreply.github.com>
old-commit-hash: 332f568a82
2021-12-24 11:18:39 -08:00
HaraldSchafer
f64c2974b4 Road Roll Compensation Rebased (#23251)
* first commit

* update refs
old-commit-hash: cf466222f6
2021-12-16 17:34:12 -08:00
Vivek Aithal
37ccdd8127 locationd: cleanup (#23088)
* remove dead code, avoid indexing by value in locationd

* remove dead states in live_kf
old-commit-hash: 64eb5b0da4
2021-12-01 00:09:00 -08:00
Vivek Aithal
b2ddfb3719 add a note in loc_kf (#23082)
old-commit-hash: b57f55088e
2021-11-30 10:51:32 -08:00
Vivek Aithal
87f37d73a3 Mesh3D: Add accelerometer bias to loc_kf (#22880)
* add accel-bias to mesh3d

* remove acc scale
old-commit-hash: 5040427cb7
2021-11-29 19:30:14 -08:00
Vivek Aithal
d537897e9a locationd: Fix Nav localization reliability (#22959)
* modify reset logic

* remove debug statements

* use ecef pos and vel covariances during reset

* reset orientations initialized to 0,0,GPSbearing

* refactor nav fix

* add fake gps observations to control ecef pos and ecef vel std

* replace fake_P with individual fake cov

* set gps mode flag

* add gps invalid flag names

* update refs

* more accurate gps accuracy check + update refs
old-commit-hash: 8b6a147583
2021-11-24 15:24:25 -08:00
Vivek Aithal
16d9fcbd80 Revert ecef std until real fix (#22982)
* too low

* update refs

Co-authored-by: Harald Schafer <harald.the.engineer@gmail.com>
old-commit-hash: 94d59314e2
2021-11-19 12:49:32 -08:00
Vivek Aithal
27a6dc0c08 locationd : Acceleration Bias in locationd (#22879)
* add accel bias to filter for offline calculation

* bugfix acc bias in live_kf

* add no_accel obsertvation

* increase initial certainty of acc-bias and reduce PN

* increase initial certainty of acc-bias and reduce PN

* increase accel bias PN

* increase obs noise for no_accel observation

* style fixes

* update refs
old-commit-hash: 534bf697ee
2021-11-12 15:55:16 -08:00
Vivek Aithal
6bc1c7b502 locationd: Make live_kf robust to no GPS (#22774)
* add no gps observations

* use correct ecef_location, orientation vals and stds for nogps states

* remove earth radius obs

* move initial loc to the ocean

* remove unnecessary changes

* update refs
old-commit-hash: 5c810a45b0
2021-11-09 14:45:47 -08:00
Vivek Aithal
b150ceffa4 locationd: Gyro bias initial covariance (#22622)
* reduce cam odo std multiplier

* increase gyro obs noise

* increase initial cov for gyro bias
old-commit-hash: 2006aa412e
2021-10-22 21:00:01 -07:00
Vivek Aithal
0bc7ccfbaa remove confusing logic in live_kf, move to locationd (#22558)
old-commit-hash: d22f57e36d
2021-10-14 11:57:50 -07:00
HaraldSchafer
eff53180ca Update car_kf.py
old-commit-hash: a3071bf15b
2021-06-18 17:57:42 -07:00
HaraldSchafer
420090ffea time checks in locationd (#20880)
* time checks

* no debug print

* correct timestamps in test

* non nan
old-commit-hash: 62e22e7eac
2021-05-11 15:57:13 -07:00
Willem Melching
b4263a43fc Locationd 100 Hz (#20816)
* fix std transform

* 100Hz

* new ref

* no more decimation

* clean up confusing maths

* static typing

* Revert "static typing"

This reverts commit 23d87337de648e629fbd35dd8c04a740bbefca47.

* 100Hz costs more

* move normalization into core

* add quat idxs

* add big eps

* this is not safe in the filter

* more sensible

* updates to rednose

* not tested

* normalize in python too

* update rednose

* nan check

* check for infs too

* all should be finite

* update ref

* rednose pr now in master

Co-authored-by: Harald Schafer <harald.the.engineer@gmail.com>
old-commit-hash: e9db5723ef
2021-05-06 11:01:58 +02:00
Willem Melching
41901d2204 Remove sympy import from paramsd at runtime (#20710)
old-commit-hash: b27bad8776
2021-04-20 14:29:37 +02:00
Joost Wooning
c0ac9bb63c convert locationd to c++ (#20622)
* live_kf to c++

* first locationd code

* Running in process_replay

* locationd handle cam_odo and live_calib

* log event handlers

* working message receiving

* compiling message sending

* correctly sending some messages

* correct receiving and sending

* update ref_commit with some all_alive_and_valid being false, minor fixes

* fix std abs

* linking on device fix

* fix cpu usage test

* generate kf constants and defines

* fix replay test

* replay without acks, cleanup

* operate on bytearray messages

* cleanup

* send msg fix

* small sleep, less flaky test

* remove python locationd

* review feedback

* bump rednose
old-commit-hash: 3420707ad5
2021-04-20 11:56:43 +02:00
Joost Wooning
ff9840c53f locationd and paramsd using cython version of ekfsym (#20610)
* Locationd live_kf using c++ kalman filter

* use both cpp and python live_kf to compare

* Locationd using ekfsym cpp

* Paramsd using c++ ekf_sym

* Other building method

* Cleanup

* cleanup

* Single sconscript for rednose and locationd/models

* CI

* CI

* CI fix

* renamed scons config

* Fix lib loading

* bump rednose

* update cpu usage test
old-commit-hash: e6a8157916
2021-04-08 13:09:11 +02:00
HaraldSchafer
cf6c7cb2b8 Update locationd (#20410)
* this was too extreme

* unused import

* capnp wants bools

* update refs
old-commit-hash: 8bddaa7607
2021-03-19 17:12:34 -07:00
Willem Melching
9616a0f245 pass cloudlog to EKF_sym
old-commit-hash: d9c1561d37
2021-03-15 13:27:12 +01:00
HaraldSchafer
a1d6e4f9f0 Locationd process noise typo (#20085)
old-commit-hash: 9e746c6dd8
2021-02-16 11:41:21 +01:00
Adeeb Shihadeh
c55926c7b8 lgtm fixes (#19610)
* pass matrices by reference

* suppress that

* destructor

* that's wrong, suppress it
old-commit-hash: 4096f86e21
2020-12-28 20:36:23 -08:00
Harald Schafer
f749a2e424 use name
old-commit-hash: 4fafdee9e4
2020-12-03 13:29:58 -08:00
HaraldSchafer
bc3b340694 Misc locationd improvements (#1714)
* I like this more

* rewind less

* bump rednose

* falling off windshield detectopr

* adjust thresholds

* this is a soft disable now

* move that

* process replay fixes

* update refs

Co-authored-by: Comma Device <device@comma.ai>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 8e2d344135
2020-07-30 15:33:22 -07:00
HaraldSchafer
6e6c165e7f Clean mesh3d 2 (#1618)
* seems overkill

* not too extreme

* make linter happy

* try adding accel scale

* some tweaks

* Revert "some tweaks"

This reverts commit 58cec365da650fa653dee91c7a5cbe37b8289908.

* Revert "Revert "some tweaks""

This reverts commit 517108b5b676b4ab31bba92a9eb59afa1b3d3faf.

* stability concerns

* this works

* still works

* ugh sympy is weird, still may be not correct

* comment clean

* comment

* clarify

* fix

* unused
old-commit-hash: 87bbbd4100
2020-06-10 17:25:48 -07:00
Adeeb
9027018368 Update Flake8 config (#1624)
* update flake8 checks

* add E502

* no whitespace warnings

* fix violations

* no W391

Co-authored-by: Jason Young <jason@comma.ai>
old-commit-hash: 367155168a
2020-06-03 16:13:34 -07:00
Willem Melching
a56e2b01f8 Make pylint more strict (#1626)
* make pylint more strict

* cleanup in progress

* done cleaning up

* no opendbc
old-commit-hash: 843a64c72f
2020-06-02 16:29:32 -07:00
Adeeb Shihadeh
9823f1164c enable flake8 E303: too many blank lines
old-commit-hash: f3dcf861c7
2020-05-31 17:21:11 -07:00