Commit Graph

129 Commits

Author SHA1 Message Date
Adeeb Shihadeh
660928eedf Only draw lead car indicators when controlling longitudinal (#1914)
old-commit-hash: 61548f5a48
2020-07-23 13:28:58 -07:00
Adeeb Shihadeh
cd317b0780 Fix most remaining LGTM alerts (#1893)
* fixups from LGTM

* short globals

* fix spinner and textwindow

* total ordering

* no spinner/text window when import from manager

* not android
old-commit-hash: 5db81f60ca
2020-07-19 16:12:22 -07:00
Adeeb Shihadeh
cdfb090c7a Wunused (#1841)
* enable Wunused, first pass

* unused stuff in snpe model

* these are used on phone

* handle sigint and sigterm in modeld

* fix phone build

* camera qcom

* QCOM build works

* delete unused camerad vars

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: eb1aa3d831
2020-07-09 09:25:32 -07:00
Dean Lee
9c33f51990 remove offroadLayout from sm (#1846)
old-commit-hash: 11fbe85c14
2020-07-08 21:24:55 -07:00
Dean Lee
0a9b8f2a32 paint.cc: Simplify drawing line (#1643)
* simplify drawing line

* remove space
old-commit-hash: ff4f432f0f
2020-07-03 19:42:26 -07:00
Dean Lee
fa06882a72 better update_offroad_layout_state (#1808)
apply review suggestion
old-commit-hash: 9de015f588
2020-07-03 12:52:43 -07:00
Adeeb Shihadeh
219b117c21 fix hardcoded frequencies in UI
old-commit-hash: 2f16349c4c
2020-07-03 12:30:47 -07:00
Adeeb Shihadeh
d10d3287a3 remove unused UI variables
old-commit-hash: e8259895f7
2020-06-29 14:12:28 -07:00
George Hotz
ada8359180 UI 10x speedup with hardware antialias (#1787)
* enable MSAA, disable nvg antialias

* less opaque and clean up

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: b62da571b4
2020-06-29 13:54:23 -07:00
Adeeb Shihadeh
3d56b4cc35 better alert when controls takes too long to start
old-commit-hash: f8ce6502a9
2020-06-23 16:07:10 -07:00
Willem Melching
31e0931cee ui, fix vision_seen when starting with camerad already running
old-commit-hash: 99949cc27d
2020-06-23 15:16:55 -07:00
Adeeb Shihadeh
ab66589a46 fix engage/disengage sounds
old-commit-hash: 51b7dc0e38
2020-06-23 10:50:24 -07:00
Adeeb Shihadeh
4c19a49586 Fix some alert sounds not repeating (#1763)
* fix sounds not repeating

* fix PC build

* 3 loop

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: af22b282ff
2020-06-22 19:22:02 -07:00
Adeeb Shihadeh
0891b1331d Add cppcheck as a pre-commit hook (#1646)
* add cppcheck as a pre-commit hook

* fix Dockerfile

* update precommit config

* exclude panda and opendbc
old-commit-hash: 3c461ca5cc
2020-06-19 20:39:34 -07:00
Adeeb Shihadeh
dd3247d128 Alert when controls fails to start (#1750)
* alert when controls fails to start

* more friendly

* fix sound

* remove that

* just else

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 968443c545
2020-06-19 19:28:56 -07:00
Adeeb Shihadeh
1f6af4ded2 fix alert sounds looping
old-commit-hash: 78b428e534
2020-06-19 14:53:55 -07:00
Dean Lee
dffb9800ad Sound refactor (#1589)
* Soud refactor

* remove files from  files_common

* add timeout to set_volumn

* add param volume to init

* done

* test.cc

* fix typo

* add repeat param instead of loop

* revert submodule

* add member function currentSound

* remove function create_player from class member

* fix build error

fix repeat

* rename CHECK_RESULT to ReturnOnError

* set currentSound_ before posible err

* use std::map to initialize sound table

cleanup

cleanup

cleanup

fix bug in stop

change paramater name

* done

* remove function CreatePlayer, create player in init()

* resolve conflict

* remove sound test

* rebase

* remove whitespace

* Apply great review suggestion

* use player's SLVolumeItf interface to set volume

* use float

* leave the volume control the way it is
old-commit-hash: 8cacc14b31
2020-06-15 15:26:38 -07:00
George Hotz
5d069eb8c3 Fixups for Mac, and a bunch for PC (#1654)
* fix mac nui

* fix cereal

* builds on mac without warnings

* ui swap shouldn't be instant on pc

* camerad builds on mac

* modeld, and now everything, builds on mac

* ui draws pictures on mac now

* fix camerad shutdown

* support ui looping on pc

* python3 on that

* SCNu64 should be cross platform

* bump cereal and new apk

* clean up

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 344a9a3699
2020-06-11 18:21:59 -07:00
ZwX1616
82c3b6c110 fix dtype (#1676)
old-commit-hash: 681ef81ed8
2020-06-10 15:15:51 -07:00
Dean Lee
0f9202c4b7 add set_brightness in framebuffer.h (#1659)
old-commit-hash: 8ad1135e80
2020-06-10 10:28:18 -07:00
Dean Lee
36ee93e0fe remove function is_leon (#1660)
old-commit-hash: 5fdb60d43e
2020-06-08 17:24:55 -07:00
George Hotz
4b6c80336b Getting PC openpilot working again (#1650)
* fixup keras_runner to work and be nicer

* truncate the lane lines based on the valid len
old-commit-hash: 7770041f92
2020-06-05 17:40:56 -07:00
Dean Lee
92b5c00d0e ui.cc: remove variables from UIScene, use event::Reader to get data (#1585)
* use struct to store lead status

* remove white space

* use RadarState::LeadData::Reader

* use reader to get thermal data

* use reader

* continue

* remove variables

reset submodules,fix some errors

reset submodules

revert

* remove s->scene.gps_planner_active

* modify

* cleanup

* done

* resolve conflict

* remove irrelevant comment

* remove white space
old-commit-hash: d720f28ecb
2020-06-05 15:33:45 -07:00
Adeeb
d035394ce7 Add pre-commit hooks (#1629)
old-commit-hash: ab83e48ec4
2020-06-03 12:54:49 -07:00
Willem Melching
f9036398e8 ui.cc: read_db_value is not null terminated
old-commit-hash: 884b327374
2020-06-01 16:41:04 -07:00
Dean Lee
32fa3e26be Template version of read_param (#1593)
old-commit-hash: c9dbaf821c
2020-06-01 14:30:53 -07:00
Dean Lee
b72fcb69e2 driving.cc: Pass ModelDataRaw by reference (#1600)
* pass ModelDataRaw by reference

* pass NVGpaint by refer
old-commit-hash: af36aa28ab
2020-05-30 10:08:44 -07:00
Dean Lee
7db5410f10 UI: better read_model (#1586)
* update model struct inplace

* refer params

* pass path by refer
old-commit-hash: 108a13ead8
2020-05-28 15:10:49 -07:00
Willem Melching
56bddd9105 Fix #1566, athena status flicker in sidebar
old-commit-hash: 4de2c57bd1
2020-05-26 13:41:02 -07:00
Willem Melching
91f1082394 -Werror (#1567)
* werror

* -Wno-inconsistent-missing-override

* Silence ffmpeg deprecation warnings

* add some more pragmas to ignore warnings

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 50f3f1d335
2020-05-26 13:27:01 -07:00
Dean Lee
38e7d99d2f change light_sensor to atomic variable (#1560)
old-commit-hash: b3ab7ae392
2020-05-26 09:59:49 -07:00
Willem Melching
7f0b3180a4 Use C++ version of SubMaster and PubMaster (#1548)
* add PubMaster & SubMaster

remove 'delete msg'

remove headers

* use constructor to initial all submster

* modify drain sockets

* fix typo in ssconscript.remove lines

no checkValid in loggerd

last modify

handle_message:event->&event

fix type

remove heads

event to auto

* new interface

* api changed

* Revert "use constructor to initial all submster"

This reverts commit 73be7ea46250a325ce41d3a0445e34395a2ae692.

* change to new api

* revert loggerd

* dd

* use new PubSub api

* update to new interface

don't modify loggerd

reset panda

reset opendbc

remove empty lines

* switch to new pubMaster

* update to the new inteface

change

remove error code

. to ->

merge paramsd.cc

update panda

fix typo

simplify

fix typo

* Fix build

* always conflate

Co-authored-by: deanlee <deanlee3@gmail.com>
old-commit-hash: ab5af232b2
2020-05-21 16:04:33 -07:00
Jason Young
30e1e9f91c Make timeout setting code reachable (#1509)
old-commit-hash: d8d490ef6d
2020-05-14 13:03:47 -07:00
Willem Melching
0214bfa5eb Fix steering wheel icon showing (#1497)
* this should fix steering wheel icon showing

* fix syntax
old-commit-hash: 2ae2c40b29
2020-05-12 18:17:04 -07:00
Willem Melching
83d02c8c4a Don't show "no gps" when ubloxd is not running (#1479)
* dont show no gps when ubloxd is not running

* Just s

* Dropped that

* Connected is too long
old-commit-hash: f7c8707bf8
2020-05-08 21:04:55 -07:00
robbederks
5a12fc32e7 Ambient light calibration parameters on persist partition (#1429)
* WIP: light sensor persistent params

* fix params writing

* Persistent params argument in C params lib. Fixed symlink flow

* Removed debug prints

* fix boardd

* fix ui

* remove debug print
old-commit-hash: 71bebc4fca
2020-05-08 19:39:18 -07:00
Dean Lee
90af65c41c UI: move c-capnp to c++ (#1455)
* ui:move c-capnp to c++

* move Subsockets into vector

* rename reader to msg

include cereal/gen/cpp/log.capnp

* fix some errors

restore some changes

restore previous

* cleanup codes

cleanup codes

* remove unused variable alert_size

* handle capnproto's enum in a robust way

add break to default

* switch -> std:map

* use static std::map instead of switch

do cleanup

* fix wrong variable name

* use FlatArrayMessageReader instead of custom MessageReader

remove messagehelp.h

Revert "use FlatArrayMessageReader instead of custom MessageReader"

This reverts commit 57d8b6b1e2b4bad908246f35eb068535b1627167.

use FlatArrayMessageReader instead of custom MessageReader

add header file

remove capnp_c lib,add kj lib

include serialize.h

fix

remove duplicate includes
old-commit-hash: ee725534bb
2020-05-06 08:38:26 -07:00
Dean Lee
c1641cc035 simplify drawing text and rect (#1446)
* add ui_draw_text

remove draw textbox

make draw_text static

add blank line

* add ui_draw_text

remove draw textbox

make draw_text static

add blank line

add ui_draw_rect

draw rounded rect

fx typo

* remove used variables

* reduce lines

fix typo

* resolve confilit
old-commit-hash: 846a58507f
2020-05-02 11:27:03 -07:00
Dean Lee
5da84ba511 simplify drawing circle images (#1445)
* simplify drawing circle images

add static

set default color to 0 0 0 0

remove lines

* fix img_weel_y

* use color macro
old-commit-hash: 4857f45d6a
2020-05-01 19:16:17 -07:00
Dean Lee
40dfc4874b better ui_draw() (#1432)
* better ui_draw()

* fix missed border

reduce code

remove white line
old-commit-hash: 3fe3afeede
2020-04-30 12:11:35 -07:00
Dean Lee
4622ab2944 replace duplicate codes with variable (#1431)
* eplace duplicate codes with variable

* remove space
old-commit-hash: b2be607974
2020-04-28 13:44:57 -07:00
ZwX1616
34eebc37b1 orange distracted alert is now continuous (#1412)
old-commit-hash: 922055f464
2020-04-23 14:15:05 -07:00
Comma Device
9521ac53e5 call it vehicle, not panda
old-commit-hash: d0e0746138
2020-04-22 20:30:53 +00:00
Comma Device
928b82c2db s/athena/connect on sidebar
old-commit-hash: 4e44ab313e
2020-04-20 20:49:28 +00:00
Dean Lee
e03aa33c6c Remove redundant code (#1361)
* changing the coordinate system only once

* remove white space

* remove white space

* s->scene. to  scene->

* whitespace
old-commit-hash: 3e2e241a38
2020-04-17 15:59:43 -07:00
Dean Lee
7f561f2d3d close sensors when it's done (#1367)
old-commit-hash: 24495a2278
2020-04-17 15:52:40 -07:00
ZwX1616
f90b956f47 RHD support for driver monitoring (#1299)
old-commit-hash: 133b1a20b4
2020-04-15 16:48:44 -07:00
Dean Lee
746600dfb3 assert after nvgCreateImage in ui_nvg_init() (#1360)
* assert after nvgCreateImage

* update apks
old-commit-hash: ea055d169f
2020-04-14 12:27:55 -07:00
Dean Lee
9c9b8b2aa8 add ui_draw_image to reduce code repetition
old-commit-hash: 1ecef2c6be
2020-04-13 15:38:45 -07:00
andyh2
f7e3d8349d offroad/ui: Fix layout bugs (offroad drawing on top, settings open after drive)
old-commit-hash: 76052865cd
2020-04-13 08:53:52 -07:00