Commit Graph

336 Commits

Author SHA1 Message Date
HaraldSchafer
0512c89d34 various cleanup (#22289)
old-commit-hash: cc6af379ce
2021-09-20 16:26:10 -07:00
Mitchell Goff
aa4b201b96 Added update_with_xva method to long_mpc so it can be used in sim (#22284)
old-commit-hash: 485afda79d
2021-09-20 14:20:01 -07:00
HaraldSchafer
bc1882e3fb More extreme lead init for lead mpc (#22273)
* More harsh lead init for lead mpc

* update refs
old-commit-hash: 7495100177
2021-09-20 09:35:55 -07:00
Harald Schafer
b1e2f219c9 Clip radar acceleration for mpc stability
old-commit-hash: a1fcedda21
2021-09-18 22:21:03 -07:00
HaraldSchafer
e190dfaf13 Dont run plannerd for long tests (#22260)
old-commit-hash: f0be9a57ac
2021-09-16 20:45:13 -07:00
HaraldSchafer
8f84b2421a sane lead clips to prevent reset (#22255)
old-commit-hash: 5e995e5aff
2021-09-16 17:31:32 -07:00
HaraldSchafer
3305024cfc remove ACADO (#22247)
* remove acado

* not relevant anymore
old-commit-hash: 42d93e94df
2021-09-15 21:14:11 -07:00
HaraldSchafer
2d4b64ed04 Acados long fast (#22233)
* acados long

* new ref

* SPPEEEEEDDD

* less iterations

* this shouldn't be so high

* reset only essentials

* minimal reset for long mpc

* more cpu usage plannerd

* Use lead mpc even when going to crash

* reset to current state

* Use open loop speed for lead mpc

* 1 iteration is too little for cruise mpc

* add whitespace

* update refs
old-commit-hash: 66c275b711
2021-09-15 19:00:12 -07:00
Willem Melching
d688b62c62 Add upper/lower bounds for longitudinal lag (#22235)
* Add upper/lower bounds for longitudinal lag

* add ref

* update ref

* bump cereal

* bump cereal
old-commit-hash: 417e229624
2021-09-14 18:57:16 -07:00
HaraldSchafer
8877772a95 Less QP iterations for lateral acados (#22231)
* Less QP iterations for lateral acados

* update ref
old-commit-hash: 96a8f8a831
2021-09-14 13:55:30 -07:00
HaraldSchafer
65a1b386dc Fix 0 init bug for acados lateral (#22225)
* this is needed somehow

* new ref
old-commit-hash: 0dc45eaf1c
2021-09-13 21:23:22 -07:00
HaraldSchafer
c422cce205 Port lateral planning to ACADOS (#22080)
* lateral acados

* looks good!

* add another solve, needed for init somehow

* use copy

* init correctly

* cleanup sconstruct

* Update files_common

* update cpu usage

* reset when invalid

* fix cpu usage

* cost_set doesnt leak

* new ref

* non leaky reset

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 7081ab4fb7
2021-09-13 19:06:54 -07:00
Willem Melching
523219c678 Parameterize longitudinal control using carParams (#22200)
* use CP.startAccel

* missing values

* order

* update ref

* cereal
old-commit-hash: b7d1aac197
2021-09-11 18:01:54 -07:00
Willem Melching
b079219b93 Use CP.vEgoStopping and clean up CP.startAccel (#22199)
* use CP.vEgoStopping and clean up

* update ref
old-commit-hash: 1e62b09e5d
2021-09-11 17:13:30 -07:00
HaraldSchafer
cb1cd01bdf cleanup old nidec accel override logic (#22181)
* cleanup old nidec accel override logic

* add ref without deprecated fields

* no more override
old-commit-hash: 74b6c87254
2021-09-10 10:34:18 -07:00
Adeeb Shihadeh
7fc6a76f04 reduce startup alert duration to 10s (#22163)
* reduce startup alert duration to 10s

* update refs

* update refs

* update refs
old-commit-hash: 1c750975fc
2021-09-07 13:40:31 -07:00
Willem Melching
ab7d2f1d08 put LongControlState in CarControl.Actuators (#22154)
old-commit-hash: 21ae64868e
2021-09-06 18:45:59 -07:00
Willem Melching
977cf8ca02 parameterize longitudinal actuator delay (#22153)
* paremetrize longitudinal actuator delay

* update ref
old-commit-hash: b39f6efa3f
2021-09-06 17:56:52 -07:00
Willem Melching
6f5c9d5ad1 Clean up PID controller ACCEL_MIN/ACCEL_MAX (#22148)
* use ISO 15622:2018 limits in PID controller

* allow more for nidec

* limit PID inputs

* CP is not needed

* add GM

* not used

* update ref

* fix honda bosch
old-commit-hash: f941111dcd
2021-09-06 17:29:32 -07:00
HaraldSchafer
1b98341932 Prevent PID windup on Honda NIDEC (#22112)
* add higher set speed

* freeze when close to cruise

* dont bias this

* higher set speed

* start high

* 2mph might be needed

* better condition

* limit accel windup like this

* wrong name
old-commit-hash: ebf2a2279d
2021-09-02 14:16:44 -07:00
Harald Schafer
4e7cca187c unused
old-commit-hash: a4ae99a489
2021-09-01 16:46:17 -07:00
Willem Melching
a06ffc48c1 Smarter longitudinal lag compensations (#22094)
* smarter lag compensations

* need to use speed from plan

* update ref

Co-authored-by: Harald Schafer <harald.the.engineer@gmail.com>
old-commit-hash: edae2218d7
2021-09-01 15:28:16 -07:00
grekiki
afe4df11dd Add angleError to pid_log (#21611)
* add angleError

* Log all the time

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 21fad4d1ad
2021-09-01 13:45:22 -07:00
robbederks
f8085a47ef Smarter thermal controls for tici (#21923)
* dumb controller 'tuned' on a desk

* reduce Ki

* fix prev_time bug

* reset integral on going onroad

* cleanup thermal detection logic

* more minor tuning

* use controls' PI controller

* get rid of bat_temp

* change if once more

* cleanup

* cleanup import order

* add back bat temp in this PR

* move to constructor

* consistency

* add bp

Co-authored-by: Comma Device <device@comma.ai>
Co-authored-by: Willem Melching <willem.melching@gmail.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: f539cd45c9
2021-08-31 12:29:53 -07:00
HaraldSchafer
a73a820338 Change car controller interface from gas/brake to acceleration (#21911)
* retune civic

* seems smooth

* back to normal

* new ref

* fix conflict

* runs

* rm

* accel scale is 4

* toyota should be good

* more cleanup

* fixup

* better naming

* update ref

* deprecated

* sending brake when not enable causes a fault

* rm gas and brake

* unused

* update ref

* acura logic is no more

* wrong before

* revert tuning cleanup

* adress comments

* update ref

* already on master

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 1ac89f14aa
2021-08-30 09:32:52 -07:00
Adeeb Shihadeh
9de66112fb remove deprecated mpc logging code
old-commit-hash: 9be7cf2cda
2021-08-26 13:33:43 -07:00
Adeeb Shihadeh
ac8b08fa0c alert for per-core cpu usage (#21983)
* thermald: per-core cpu usage

* add alert

* better alert text

* list

* fix process replay
old-commit-hash: fc8b571a84
2021-08-19 19:14:51 -07:00
HaraldSchafer
e13349366e Remove HUD alert from green DM alert (#21942)
old-commit-hash: c0cacc7d2f
2021-08-16 22:30:51 -07:00
Mitchell Goff
b7b87efed9 Retuned desire model (#21919)
* New model: d8e7f76f-7bec-4a83-af00-c0fae792527f/950

* Updated process replay refs

* Updated model replay ref
old-commit-hash: 05b37552f3
2021-08-12 21:06:26 -07:00
sshane
41b7cbdadf longitudinal comments (#21898)
* cmt

* Update longcontrol.py
old-commit-hash: 737a79e556
2021-08-11 01:33:59 -07:00
Mitchell Goff
7fffcd9baa Update long_mpc api for use with sim (#21890)
old-commit-hash: 3022f68fa7
2021-08-10 10:51:38 -07:00
HaraldSchafer
b615987244 Cleaner lane change alerts (#21857)
* less is more

* small

* remove HUD warnings

* update ref

* safe

* update refs

* update again

Co-authored-by: Willem Melching <willem.melching@gmail.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: aa689176fc
2021-08-05 14:23:27 -07:00
sshane
51698f04bc Use first order filter (#21411)
* Use first order filter in INDI

* use first order filter in LP as well

* Update selfdrive/controls/lib/lane_planner.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>

* RC->rc

* division safe

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: c900bce1b0
2021-08-03 13:47:46 +02:00
Adeeb Shihadeh
eb8a334bfc remove alert for stock fcw (#21834)
old-commit-hash: fb028041cd
2021-08-02 21:59:03 -07:00
Mitchell Goff
2d0512b8a1 Revert "New desire model (#21729)" (#21805)
* Revert "New desire model (#21729)"

This reverts commit 709932b3bfb4c3b4f33711b8d07615469e762832.

* Updated process replay ref and reverted release notes
old-commit-hash: 15d6bbb47c
2021-07-30 14:34:29 -07:00
Mitchell Goff
3fb1a1c746 New desire model (#21729)
* New model: b822ee32-917c-4639-99f8-25be3e6aabad/900

* Enable keeps

* use new packet

* Send keep pulses once per second

* Updated model_replay_ref_commit

* New model: 0f160bf9-1bce-43e6-9785-564b2453eeac

* Bump model_replay_ref_commit

* Bump submodules

* New model: fd904bf9-5dd8-4619-8997-c5668400e078/550

* New model: fd904bf9-5dd8-4619-8997-c5668400e078/950

* No keeps

* Bumped model replay ref

Co-authored-by: Harald Schafer <harald.the.engineer@gmail.com>
old-commit-hash: e83973b9b3
2021-07-26 21:11:09 -07:00
HaraldSchafer
dee5a3e9a0 safer low speed (#21705)
old-commit-hash: 4bd4ed4999
2021-07-25 15:15:50 -07:00
HaraldSchafer
d1c5e054d0 Better localizer unstable alert (#21660)
* use canonical language

* filter out when gps signal is flaky

* Update selfdrive/locationd/locationd.cc

Co-authored-by: Willem Melching <willem.melching@gmail.com>

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 049a1bca34
2021-07-20 19:20:00 -07:00
HaraldSchafer
4455ae1b86 add jerk to longitudinal plan (#21598)
* add jerk output, so its like lateral

* typo

* add to packet

* update cereal and ref
old-commit-hash: ef0b120a9a
2021-07-14 11:51:48 -07:00
HaraldSchafer
bbd7181df2 Taper off high speed accel (#21599)
* max 0.2 diff from before to preserve bad tuned cars

* update ref
old-commit-hash: 5d07819084
2021-07-14 10:53:14 -07:00
HaraldSchafer
8fdfa3b97d fix low speed override bug and cut-in bug (#21593)
* fix low speed bug and cutin bug

* update ref
old-commit-hash: 6a93346729
2021-07-13 23:36:25 -07:00
HaraldSchafer
cdb2c42ca2 Lower speed for lowest planned acceleration (#21578)
* 55mph sounds about right

* update refs
old-commit-hash: fd41e9f01b
2021-07-13 14:22:06 -07:00
Adeeb Shihadeh
477e2e22d3 Revert model (#21571)
* Revert "New desire model (#21458)"

This reverts commit 9db03d2a3fefff50b738d288beadc2c2e7c3165e.

* revert rel notes
old-commit-hash: 88424ede2c
2021-07-12 19:26:50 -07:00
HaraldSchafer
91d5b10426 less accel (#21565)
* less accel

* new refs

* Update longitudinal_planner.py

* update refs
old-commit-hash: a42d8f3a14
2021-07-12 18:30:56 -07:00
Adeeb Shihadeh
4b79c86b5f fix unnecessary harsh steering unavailable alerts (#21541)
old-commit-hash: 092c728e76
2021-07-10 01:53:14 -07:00
HaraldSchafer
56b457207f less np (#21536)
old-commit-hash: 148c202bc4
2021-07-09 11:34:00 -07:00
HaraldSchafer
7fcdd04541 New desire model (#21458)
* New model: b822ee32-917c-4639-99f8-25be3e6aabad/900

* Enable keeps

* use new packet

* Send keep pulses once per second

* Updated model_replay_ref_commit

* New model: 0f160bf9-1bce-43e6-9785-564b2453eeac

* Bump model_replay_ref_commit

Co-authored-by: mitchell <mitchellgoffpc@gmail.com>
old-commit-hash: 4230d5d212
2021-07-07 19:44:17 -07:00
HaraldSchafer
96d4bfbff3 Refactor long (#21433)
* refactor

* needs casting

* tests pass

* fix that test

* refactor in controls

* lets not go crazy

* change of names

* use constants

* better naming

* renamed

* soft constraints

* compile slack variables

* rm git conflict

* add slack variables

* unused

* new edition

* fcw

* fix tests

* dividing causes problems

* was way too slow

* take a step back

* byeeee

* for another time

* bad idxs

* little more cpu for cruise mpc

* update refs

* these limits seem fine

* rename

* test model timings fails sometimes

* add default

* save some cpu

* Revert "little more cpu for cruise mpc"

This reverts commit f0a8163ec90e8dc1eabb3c4a4268ad330d23374d.

* Revert "test model timings fails sometimes"

This reverts commit d259d845710ed2cbeb28b383e2600476527d4838.

* update refs

* less cpu

* Revert "Revert "test model timings fails sometimes""

This reverts commit e0263050d9929bfc7ee70c9788234541a4a8461c.

* Revert "less cpu"

This reverts commit 679007472bc2013e7fafb7b17de7a43d6f82359a.

* cleanup

* not too much until we clean up mpc

* more cost on jerk

* change ref

* add todo

* new ref

* indentation
old-commit-hash: be5ddd25cd
2021-07-07 19:42:26 -07:00
HaraldSchafer
098d939428 Remove DM high std alert (#21501)
* cleaner

* no face and high stds is the same

* change test

* final clean

* need to deprecate
old-commit-hash: 2aadf8beb2
2021-07-07 17:08:55 -07:00
Adeeb Shihadeh
2293b4bcae update speedTooHigh alert sound (#21484)
old-commit-hash: 8dce135279
2021-07-04 19:23:09 -07:00