Commit Graph

1165 Commits

Author SHA1 Message Date
Adeeb Shihadeh
cc29c6640d pytest: strict config (#29676)
* pytest: strict config

* collection works

* fixes
old-commit-hash: 72e2e2c9ec4e3a42cf35c23dfc0d66ea0565ace6
2023-08-28 10:26:19 -07:00
Justin Newberry
ffddeace6e CI: fix sim/docs scons cache invalidation (#29639)
* fix sim and docs images

* fix that

* that's a weird issue

* exists should work fine

* as little diff as possible
old-commit-hash: 5716dfc9b54f9f24e412ae020ac572ccec6ae1c9
2023-08-27 19:52:38 -07:00
Dean Lee
c99c0b51e3 cabana/MessageListModel: replace match |= with match = match || (#29667)
old-commit-hash: 4f915f4f1a2ed4c62069e03b176d2a4906479c51
2023-08-27 17:56:49 +01:00
Dean Lee
3d04606233 cabana: use a monotonic buffer to allocate CanEvent (#29652)
* use a monotonic buffer to allocate CanEvent

* set the next buffer size to 6MB

* static

* cleanup

* use const iter

* rename to insert_pos
old-commit-hash: 57ad4f02f8e693639262aa3a982be8ed6c433ee0
2023-08-26 08:42:50 -07:00
Justin Newberry
643a13f27e CI: use local scons cache instead of building a separate image (#29634)
* use local

* added ci_sim

* revert scons

* dont need these anymore

* same for sim

* fix dockerfiles
old-commit-hash: c46965fc27ecfe76e02affca2aacbe410a55196a
2023-08-25 16:06:17 -07:00
Dean Lee
7a1b7d4206 cabana: improve frequency accuracy (#29631)
* improve frequency accuracy

* apply review

* 2 less lines!

* another!

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 2484548fddd1de51a75c52736b1709081ea61eb9
2023-08-25 15:15:16 -07:00
Dean Lee
dbf03eb2c2 scons: fix always generating car_fingerprint_to_dbc.json (#29625)
old-commit-hash: 86386fd87f3d4bda7303957d543c772f4dda5e1a
2023-08-25 10:39:55 -07:00
Justin Newberry
c4f322ce2d Linter: remove pylint (#29611)
remove pylint
old-commit-hash: 1ee6ed4b16e2ade0dd887c0687243aee769043e5
2023-08-24 16:30:54 -07:00
Adeeb Shihadeh
61cf541322 Minimal build (#29600)
* add build flag for minimum build

* add minimal build

* update

* fix pj

* bump opendbc

* update subaru
old-commit-hash: 4917e22615adbfcc9b3c3ec89b00d240e0b48883
2023-08-24 14:58:30 -07:00
Dean Lee
de809632bf cpplint: add filter whitespace/comma (#29595)
old-commit-hash: 7bfd3dac811ae95bfd09495e88377dfbaacda393
2023-08-24 10:42:06 -07:00
Dean Lee
0984736972 cpplint: add filter build/include_subdir (#29585)
old-commit-hash: 21da5a216fc8f5269d2deedc538c2f543a1c270a
2023-08-24 15:42:17 +01:00
Dean Lee
0702e273cb replay: fix visionbuf alignment on device (#26913)
* align visionbuf

* update test case

* cleanup

* fix cpplint warning
old-commit-hash: 3c94d953ab9fcaf8ee2371af3f269ae46d3563c6
2023-08-24 00:03:16 -07:00
Dean Lee
5f4b422305 cpplint: add filter whitespace/semicolon (#29568)
old-commit-hash: f203648de0a9d78121d3a775ae454a43e1211e62
2023-08-23 15:00:30 -07:00
Dean Lee
db211ce617 cpplint: add filter whitespace/parens (#29565)
old-commit-hash: 5480d32bb5d98d57100fd709b9ffe7bfcc6e020a
2023-08-23 14:25:05 -07:00
Adeeb Shihadeh
6b2ffe9490 bump cereal (#29561)
old-commit-hash: e726505918bfbaa4ee75714bd6ea391d7fff7fb8
2023-08-23 13:42:37 -07:00
Dean Lee
97e9d55588 cpplint: build/include_what_you_use (#29556)
* include_what_you_use

* remove comments

* include <memory>

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 2d99521e7500902070d0aacce69528bcfd8b9964
2023-08-23 13:25:17 -07:00
Willem Melching
6b98b83ad4 cabana: socketcan support (#27952)
* empty socketcan class

* works on linux with vcan

* add open stream widget

* fix MacOS build

* update readme

* unused

* no socketcan on C3

* fix in cabana sconstruct

* serial -> device
old-commit-hash: 2b0e4d46bbbb0ccbf028c975c3345d05765a7213
2023-08-23 10:50:11 -07:00
Dean Lee
004a097c95 cpplint: add readability/braces filter (#29554)
old-commit-hash: 363740a497620249066522c87ddb03e1362749d4
2023-08-23 10:13:46 -07:00
Robbe Derks
a04cbced36 Devcontainer (#29259)
* mvp devcontainer. builds, runs and UI works

* fix indentation

* enable color and fix openpilot_env path

* separate dockerfile for devcontainer

* use prebuilt image

* Fix openpilot_env setup

* Add dev container section in readme

* Fix typo

* Fix typo again

* Move dev dockerfile to .devcontainer dir

* Update README

* Add note about x11 forwarding on macos

* Update dev container json

* Fix typo

* Override DISPLAY on macOS

* Mention XAUTHORITY for macOS setup in README

* fix typo

* Add devcontainer CI test

* Rename to devcontainer

* Fix git issues

* ripgrep

* Link instead of vscode manual

* Replace raw path with containerWorkspaceFolder

* Fix typo

* Remove dev tools workflow

* Link away X11 forwarding setup isntructions for mac

* Remove fork consrtaint, add test run of scons

* Add submodules as safe.directories in postStartCommand

* Remove openpilot_env references

* Add scons cache volume

---------

Co-authored-by: Robbe Derks <robbe@localhost.localdomain>
Co-authored-by: Kacper Rączy <gfw.kra@gmail.com>
old-commit-hash: d71a7190f1210f5ac97ce16892552ecf495e2437
2023-08-22 11:47:09 -07:00
Adeeb Shihadeh
b38403f2ca Revert Qt MOC hacks (#29528)
* Revert "CI: prevent moc from running in cache population step (#29401)"

This reverts commit 34634b95aa15dc608315016c40857f3e16ca4ff9.

* Revert "SCons: respect cache read only (#29437)"

This reverts commit 77cb4da6381fdf94ea98c55d6fcc30db4d24dcf6.

* don't change moc path
old-commit-hash: 91dc8457ae8e9b188c8fe613be5b3aa2e86be276
2023-08-22 11:16:58 -07:00
Greg Hogan
69570ef251 script to install only ubuntu dependencies (#29510)
* script to install only ubuntu dependencies

* update Dockerfile

* add shebang
old-commit-hash: b24bbe4607c4b13010b2bbcd340b133b91c146e1
2023-08-21 16:32:35 -07:00
Justin Newberry
7205b92bb6 CI: use scons cache mount for building simulator and docs (#29436)
* build docker image with scons cache

* use setup

* scons cache

* added the dockerfile

* add the shell

* docs use cache

* dont pull lfs for docs

* simulator too

* dont pull the cache image

* fix inputs

* inputs

* booleans aren't supported

* bool not supported

* bool isnt supported

* fix

* readonly cache

* fix sim cache too

* respect readonly

* gitignore and move to correct folder

* also copy old

* move to tools/ci

* move to selfdrive/test

* just make the cache writable, it's discarded anyway

* minimize diff in this pr
old-commit-hash: 197460e06136f66f60e10ccefece646cb472b872
2023-08-21 15:11:31 -07:00
Kacper Rączy
1d47429f8e Setup cleanup vol. 2 (#29456)
* code from setup cleanup #29419

update ci

update ci

export variables for mac os

check env

what is in the profile script?

install pyenv the same everywhere

temporarily disable brew cache

temporarily disable brew cache

try fixing pyenv virtualenv-init

try this

inject shims path earlier

try alternate install method

switch back to brew install

try         eval "$(pyenv init --path)"

add eval "\$(pyenv init --path)"

* Add local .env file to the cache list

* Change .env paths

* debug line

* order?

* remove .env

* Add .venv to caches

---------

Co-authored-by: Greg Hogan <gregjhogan@gmail.com>
old-commit-hash: 0f7be5b1e6efa04c59ce2a45afacd650b2e4d417
2023-08-21 13:30:48 -07:00
Adeeb Shihadeh
16ec56398c add openpilot prefix to imports (#29498)
* add openpilot prefix to imports

* more

* more

* fix docs

* fix linter

* bump submodules

* fix patched tests

* update dynamic imports

* debug

* Revert "debug"

This reverts commit db5e13b9911cc74438bee123bc3430da6c31b24b.

* fix pm test
old-commit-hash: a9626f95b69af19306143fc4def02fb5769405d2
2023-08-20 20:49:55 -07:00
Adeeb Shihadeh
1c3ca3e810 update clone instructions (#29490)
* both

* Update README.md

* Update README.md
old-commit-hash: 5690386d8d731c9bebda536a5c71c890f6dfe98c
2023-08-20 15:13:24 -07:00
Greg Hogan
f136a35ce1 fast clone instructions (#29455)
* fast clone instructions

* Support default ubuntu 20.04 git

---------

Co-authored-by: Harald Schäfer <harald.the.engineer@gmail.com>
old-commit-hash: 012060ba328da69e7fd62531bd65e8d064b3f6c0
2023-08-19 01:49:16 -07:00
Greg Hogan
349359d488 venv in code directory (#29452)
put venv in code directory
old-commit-hash: 282fd778aa303542d5752b0edc3e40db8de10696
2023-08-17 15:43:02 -07:00
Justin Newberry
1988b4805e Revert "setup cleanup (#29419)" (#29451)
This reverts commit bc9c60a3f955bb5b96dc41e6072cab47191f8896.
old-commit-hash: 1944945d9dfee6f42a875b119a5cf60daf8ade09
2023-08-17 13:23:06 -07:00
Dean Lee
e1f4ce2fb1 replay/logreader: use unique_ptr for mbr_ (#29440)
old-commit-hash: 61a00d267380f8ea75e5d7b6aeb7d0dc5e17d763
2023-08-17 11:42:35 -07:00
Greg Hogan
cce2c732c6 setup cleanup (#29419)
* setup cleanup

* update ci

* update ci

* export variables for mac os

* check env

* what is in the profile script?

* install pyenv the same everywhere

* temporarily disable brew cache

* temporarily disable brew cache

* try fixing pyenv virtualenv-init

* try this

* inject shims path earlier

* try alternate install method

* switch back to brew install

* try         eval "$(pyenv init --path)"

* add eval "\$(pyenv init --path)"
old-commit-hash: ad32816fd6bdd744e7f596209822707494d3ba5e
2023-08-17 08:51:16 -07:00
Dean Lee
accd5f471b replay: fix seekTo issue (#29422)
* fix seekTo issue

* remove extra space
old-commit-hash: e8e03197ca73e98c152b94f64060ee57f88d2911
2023-08-16 11:01:14 -07:00
Dean Lee
3648506b7c cabana: set border color for scatter series (#29408)
old-commit-hash: 9dac6b66f982dc5356821048627d70b18595b39e
2023-08-15 10:28:48 -07:00
Kacper Rączy
7f02996102 replay: increase file descriptor limit macOS (#29346)
* Increase file descriptor limit for replay on macos

* Reword comment

* Move set_file_descriptor_limit to common/util.cc

* Include resource.h header
old-commit-hash: d8bda6feb491f571acf476314ce7de81a431453f
2023-08-15 00:05:27 +02:00
Dean Lee
c622a4cac5 common/util: move function random_int to util (#29388)
old-commit-hash: 22bc06fdaab24b8aa3aba2513a32ae828f6d589e
2023-08-14 09:37:16 -07:00
Justin Newberry
8e91f98da5 Replay UI: Fix zip issue (#29384)
Update ui_helpers.py

resolves https://github.com/commaai/openpilot/issues/29383
old-commit-hash: 783bb1f878a4b8f2d2902c053a9b7cc9e1ea1b8e
2023-08-13 22:55:59 -07:00
Adeeb Shihadeh
f50fedb647 Fixes for PYTHONWARNINGS=error (#29381)
old-commit-hash: db287496d82be87971a619b2659c47737142a385
2023-08-13 17:22:56 -07:00
Dean Lee
42dd6af842 ui/networking: remove call to clearLayout (#29037)
* build list inplace

* move clearLayout to cabana

* cleanup include

* polish style

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: fd8a9c852016ccfd13ae5146648a65f01cc2468c
2023-08-13 11:57:40 -07:00
Adeeb Shihadeh
e76af64065 CI: enable PYTHONWARNINGS=error (#29364)
* CI: enable PYTHONWARNINGS=error

* fixes

* more ignore

* more modeld ignore
old-commit-hash: b11b14aff86a4c993bf5342ee37af169788c9026
2023-08-12 17:15:16 -07:00
Adeeb Shihadeh
b3f734283d remove xx dependencies (#29263)
* rm xx deps

* mv that

* fix

* fix a path

* relock

* relock

* update

* update sentry

* update

* revert sentry

* Update lock

* Dummy pip package

* Not needed with poetry

* dont need dummy

---------

Co-authored-by: Bruce Wayne <harald.the.engineer@gmail.com>
old-commit-hash: 0ced56b2ea7e0800f309c4e77d9a78bb90d89fb6
2023-08-11 20:05:44 -07:00
Justin Newberry
f33b4de80b Ruff: b905 (strict zip) (#29336)
* added mutable default args

* most of the Bs

* add comment about lrucache

* b905
old-commit-hash: e4ead4f1830618f5f61978491930cb0b8d36ab26
2023-08-11 16:13:51 -07:00
Justin Newberry
d487c0501f Ruff: enable most of bugbear (#29320)
* added mutable default args

* most of the Bs

* add comment about lrucache
old-commit-hash: 62c1e6592439119f360dd64b854e7047f35222ba
2023-08-11 15:33:49 -07:00
Shane Smiskol
a9611d13be simulator: fix CANParser input args (#29343)
* we weren't testing?

* fix
old-commit-hash: 84fbf1c2e92d2799f193213f71987f1d6e8b6431
2023-08-11 14:12:33 -07:00
Dean Lee
0171e5ee26 scons: rename QT_MOCHPREFIX to QT3_MOCHPREFIX (#29334)
rename QT_MOCHPREFIX to QT3_MOCHPREFIX
old-commit-hash: 233e053842d8e9fc9211f778b00e73df3225220c
2023-08-11 10:38:34 -07:00
Justin Newberry
715f028a0e Ruff: enable flake8-builtins (#29315)
* enable flake8-builtins

* replace any with contains

* fix typo in pack

* fix type

* format is from the parent module, has to be enabled

* item_id

* fix item_id

* disable for id since that's what the remote server returns
old-commit-hash: 8793cbff40662a92bff16d75b51479c80517305a
2023-08-10 18:58:22 -07:00
Justin Newberry
7d6d3dc9ea Ruff: flake8 pie (misc lints) (#29318)
flake8 pie
old-commit-hash: af3ed37c5cd8823f793aec60e1c74760cf795bd9
2023-08-10 15:28:51 -07:00
Justin Newberry
3ee0786de3 CI: Pylint to ruff (#29294)
* pylint to riff

* pylint to riff

* pylint to riff

* revert more

* undo exclude removal

* exclude tinygrad

* set line length

* pylint exclusions to ruff

* same excludes as old linter

* fix tools QA

* remove unrequired check

* revert linting third_party

* ignore e402
old-commit-hash: 7fdd9fc37c1c5febf1cd3dc86441ebf0dec7f370
2023-08-09 13:26:54 -07:00
Justin Newberry
7b677910df Linter: Fix >160 line length test (#29287)
* test

* fix line length

* fix line length

* fix file size

* revert poetry

* cleanup for PR
old-commit-hash: cf64b27168614f851087adab2d7f766425922f64
2023-08-08 17:13:35 -07:00
Vivek Aithal
c1bcb53d4e [commabody] Add new body teleop ui (#29282)
* Revert "Revert "[commabody] Add new body teleop ui (#29119)" (#29249)"

This reverts commit 5dcfddbbfbddf00d16cb1f28c51f3dffc75d7cf6.

* add to release files

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: e7d307ca1b064c3789902bc077e93453dd96794b
2023-08-08 14:12:51 -07:00
Adeeb Shihadeh
ae549dcd30 macOS: remove old dependencies (#29275)
old-commit-hash: ee7a763ba337266873c607ac767f68c50332a8a7
2023-08-07 21:13:09 -07:00
Harald Schäfer
c0fbbd4b36 Revert "[commabody] Add new body teleop ui (#29119)" (#29249)
This reverts commit 0df6353569b77869ce4ddc8ce43bab621bccd107.
old-commit-hash: 623351e4edb01b7c66612e43e5e8ebefd237276d
2023-08-05 07:15:35 -07:00