Commit Graph

158 Commits

Author SHA1 Message Date
Willem Melching
c0866d9edb pre-commit pylint (#1580)
* "The commit-hook project sounds interesting though. I would definitely merge something that runs flake8 and pylint on the modified files!"
-  pd0wm, https://github.com/commaai/openpilot/pull/1575#issuecomment-634974344

* add pylint to pre-commit and make everything pass

* Remove uncommented stuff

Co-authored-by: J <user@4800.lan>
old-commit-hash: bd0643424357864287ae0485da03f66df85e1fb1
2020-05-27 20:00:14 -07:00
HaraldSchafer
3488486258 Minor fixes (#1571)
* was 5 seconds not .2!

* threshold for moving car highers, this can give FPw
old-commit-hash: 67017d69fe02d9ed6a9cfba54565a403e59afcc4
2020-05-27 14:35:01 -07:00
Adeeb Shihadeh
6f0c5834e7 Fix blank mdMonoTime and controlsStateMonoTime in radard
old-commit-hash: 2ecc7d9f6f85818765da23cfac614d186111abb7
2020-05-26 17:53:55 -07:00
Willem Melching
91f1082394 -Werror (#1567)
* werror

* -Wno-inconsistent-missing-override

* Silence ffmpeg deprecation warnings

* add some more pragmas to ignore warnings

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 50f3f1d3357b356c5b1144c518f35375f5bb9924
2020-05-26 13:27:01 -07:00
Willem Melching
4061f1d530 Add permanent CAN error alert (#1549)
* Add permanent CAN error alert

* canValid needs some time to initialize

* update ref
old-commit-hash: fcf879d783c345ccbf80252de23f649427c35fbd
2020-05-21 16:08:05 -07:00
Willem Melching
ce310f3f65 Revert "Add permanent CAN error alert"
This reverts commit 41dfb2a149788a19eb1ee40a3497f2ab35386b74.

old-commit-hash: e6f24f239041da4dc0d889492f8fbcfda111cd7b
2020-05-21 15:30:16 -07:00
Willem Melching
5e4ada7249 Add permanent CAN error alert
old-commit-hash: 0abf99dbe01cfe87617bb293c8eb047d93f709dd
2020-05-21 14:53:40 -07:00
Willem Melching
e57247be9d Sounds available isdir -> isfile
old-commit-hash: 41da10ff38abfb29c42e66250344176da14e2f65
2020-05-21 14:46:18 -07:00
Willem Melching
12d3366c55 Add percent sign to calibration screen
old-commit-hash: 517826c1e1263f0445c125a002223906b73538a8
2020-05-21 14:43:07 -07:00
Adeeb Shihadeh
982aacb28d fix possible FileNotFoundError
old-commit-hash: 260e6aff53f5f579298f81e1d3a01a0e1d6dc7fb
2020-05-21 09:59:39 -07:00
Willem Melching
b2fb4632cd Fix #1545, sensor alert on startup
old-commit-hash: 9f0eac90895d9fc4cc4ab782d61f31d3b5ab9685
2020-05-20 11:25:55 -07:00
Willem Melching
6e41973c3c Handle posenet and sensor alerts in locationd (#1541)
* handle posenet and senor alerts in locationd

* defaults now set in capnp file

* Cleanup c++ version of params learner

* update ref commit
old-commit-hash: d099e09fb77544eb00d13ba9aea34a0a3374a52e
2020-05-19 16:45:20 -07:00
eFini
7ec2abcf08 use buttonEvent.type instead of string (#1533)
old-commit-hash: e14dfa3beca9897dafa776fdd68c5076d7a31d4e
2020-05-18 10:15:30 -07:00
Andre Volmensky
f6c2c72851 Bugfix: Reset saturated_count if angle no longer saturated (#1522)
old-commit-hash: 135385c5fb47ca1b9efaf3ae9e388b44cd6e538d
2020-05-16 01:14:10 -07:00
Willem Melching
8189186d8e Alert callback functions were returning tuples
old-commit-hash: c18891b936a964493393242020783482e5467ac5
2020-05-15 18:29:22 -07:00
Willem Melching
a6676b8a62 White panda is deprecated (#1516)
* Start white panda deprecation

* Unify alert text

* Add noentry

* Change to no longer supported

* panda is lowercase

* Capitalize

* rerun ci
old-commit-hash: c85b174584b1281ce1f1d168b0b0610d5d540896
2020-05-15 13:00:00 -07:00
Willem Melching
380d1e4f3d Fix two event names
old-commit-hash: 631d0d94d3beb1bd5ac9000b70104847c8c71dac
2020-05-15 12:24:12 -07:00
Adeeb
48340cc8cb Alerts + Events refactor (#1466)
old-commit-hash: d976233f696040cd5f9a5081c7b21742b7aaef66
2020-05-14 15:21:21 -07:00
Willem Melching
39e5985776 Clip v_cruise to V_CRUISE_MAX
old-commit-hash: ef330078130f71f93b3e81e9839c3386fe55946f
2020-05-13 18:05:24 -07:00
Willem Melching
43b696893d speed too high louder alert
old-commit-hash: e7ec02e2011721a819d0bafe0245bc017ef89f4a
2020-05-13 18:02:09 -07:00
Willem Melching
ef6640c7c4 Fix controlsd typo in refactor
old-commit-hash: 516fa29738738b73b863597c4fae49cf688b7154
2020-05-12 18:58:18 -07:00
Adeeb
fe106e25a3 Controlsd refactor (#1487)
* it's a class

* more refactor

* remove that

* car interface should create that

* that too

* not a dict

* don't create permanent events every iteration

* break up long lines

* fix honda

* small optimization

* less long lines

* dict is faster

* latcontrol less args

* longcontrol less args

* update profiling script

* few optimizations

* create events together

* clean up

* more clean up

* remove comment

* clean up

* simplify state transition

* more clean up

* update comments
old-commit-hash: 08832ff29d20348ebffd0ac3bcce29ad3a479cee
2020-05-12 15:06:48 -07:00
Adeeb Shihadeh
bd980f6048 delete unused lines
old-commit-hash: 10ae22a19247042b825f1bcac740f70f58b4e197
2020-05-10 11:25:42 -07:00
Adeeb Shihadeh
0a5273bf46 fix circular import reported by LGTM
old-commit-hash: 48dec51f0e93dd1a46b24414afc8ebac27269188
2020-05-09 16:47:36 -07:00
HaraldSchafer
f3747d2fe5 Better poly (#1437)
- better polyfitting
- no mpc cost change during lane change
- model trained with better ll gt, sim noise and guaranteed memories
old-commit-hash: 65fcc7c45ff1d4d747dc52ff5791afb84a18744a
2020-05-08 17:14:43 -07:00
Willem Melching
21d7ad1e51 remove yet another reverse geocoder
old-commit-hash: 70ae01e3cdcba25b199e7831d24b70fa699db06d
2020-04-24 14:07:36 -07:00
Willem Melching
9da970c342 no more geofence
old-commit-hash: 267ee4d73b993cccee7098ed791b201fe07a3f1c
2020-04-24 14:06:17 -07:00
Willem Melching
cd4c04e290 No more line following robots
old-commit-hash: 42f741d6ffe342b629cdcdf083c4edc77d7f0233
2020-04-24 14:05:19 -07:00
ZwX1616
34eebc37b1 orange distracted alert is now continuous (#1412)
old-commit-hash: 922055f464fbb98ef8366f802897035aa5342333
2020-04-23 14:15:05 -07:00
George Hotz
06407161e6 add safety note
old-commit-hash: 58e71de9fb1d88f08098b00dd333c8a8a2585850
2020-04-20 13:56:02 -07:00
HaraldSchafer
5d72509104 Faster lane change (#1381)
* final B2 for 0.75

* more aggression in lane changes
old-commit-hash: d39595cf10a7813e55139320daa252278dd7567d
2020-04-16 18:13:37 -07:00
Willem Melching
e07d6c35b1 Show relay malfunction alert (#1373)
* show relay malfunction alert

* Remove empty line

* Also immediate disengage

* Forgot noEntry

* Fix name
old-commit-hash: 2b2751c6bdb3a4bf537b14467182c4b5186b30db
2020-04-16 11:38:31 -07:00
ZwX1616
f90b956f47 RHD support for driver monitoring (#1299)
old-commit-hash: 133b1a20b42e56dc67a013dc2ee856360e4d1d1c
2020-04-15 16:48:44 -07:00
Willem Melching
adaede6b37 Force decel on soft disable (#1334)
old-commit-hash: 7643b0a51100ab4318dc687545fbc120677ba9b8
2020-04-08 14:59:17 -07:00
Adeeb
d4cec82895 Unit test for alert width (#1307)
* unit test for alert width

* fix scale

* comment

* fix offending alert text

* rename

* update process replay refs

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 0f6c22ce8b3fbbbbb8fff59e44f49b8ec1578e90
2020-04-07 21:37:17 -07:00
Andre Volmensky
613e84efe0 Add angle based steer saturation timer (#1311)
* Add angle based steer saturation timeout

* Fixed saturated check
old-commit-hash: 522dc29b53c29bc800af84ab5a196d226bf924a6
2020-04-05 10:59:54 -07:00
eFini
7d25d238a3 use put_nonblocking when possible (#1288)
* use put_nonblocking when possible

* revert uneeded changes
old-commit-hash: 106be23c4e20f30dbedd3a2cddaec78584d726c5
2020-03-31 12:09:38 -07:00
Willem Melching
aa8ca1819d High speed alert (#1295)
* add speed to high alerts

* Add permanent alert

* Two lines

* No permanent alerts

* Less bad alert

* Typo
old-commit-hash: 3cb1568a546426eb36c0e206db9dea23aa7a886a
2020-03-30 18:41:56 -07:00
BRose98
173c3ca37d Removed self-assignments (#1283)
* Removed self-assignments

* pulled master version of changed cubmodules

* Corrected the submodules

Co-authored-by: BRose98 <b.roseboom@students.uu.nl>
old-commit-hash: daba092038c6759698565face52a32b3f341fd3b
2020-03-29 12:31:27 -07:00
Willem Melching
0d03fad5b6 Nissan leaf (#1275)
* split out leaf and xtrail

* Add brake pedal

* This should work

* Fix test car models + bump panda

* Combined cruise enabled detection in single message

* Proper frequency checks

* Add doors

* Blinkers and doors

* Seatbelt

* Gear

* Add cancel message

* Unify steering pressed

* Remove angle limit

* Add steer saturation alert for angle based control

* Add set speed

* Change wheel speed factor

* Fix offset in set speed

* Timeout on engage for steer saturated

* Put counter back

* try cancel using seatbelt

* Try different cancel message

* Rename cancel signal

* Add LKAS alert

* Add missing fingerprint values

* Update test car models

* Add some comments
old-commit-hash: 1df6b67511e0872c134edef0eb8535d71e0b2cfd
2020-03-27 21:44:59 -07:00
Harald Schafer
40ded9fb5e reformat for sim
old-commit-hash: 6766776e73060d9f37ace218efa6d8090c3c0661
2020-03-27 17:02:40 -07:00
ZwX1616
a004735b19 add webcam to cameras (#1201)
old-commit-hash: a95e61edf4176c034c0537293a3cf0753c45daa1
2020-03-26 19:19:47 -07:00
Harald Schafer
18a05e304c longitudinal e2e mpc
old-commit-hash: 34f2c0da75d9a50e2c85771e769586af6c6cf1c3
2020-03-26 17:43:11 -07:00
HaraldSchafer
ec2b82f11c New lane planner (#1276)
* better lane planner

* works well on test

* needs speed now

* update ref
old-commit-hash: 5f8e3b4d93109f1a1754f468e9241567e1d35c8d
2020-03-25 16:57:58 -07:00
Willem Melching
c3d7d8d6af Go to dashcam mode if locked out, fixes #1109
old-commit-hash: d08b56317fe31eadc1cffca8f1076acdd2144943
2020-03-18 11:38:00 -07:00
HaraldSchafer
054faf5f2e fade ll out and in (#1246)
* fade ll out and in

* bug fixes

* pretty important fixes

* safer in case model misses desire input

* Safer float compares

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: af5f99d7cfcc37574d893a86a1949f4b5bbbbe8f
2020-03-16 16:19:01 -07:00
Shane Smiskol
682c866a55 initialize all messages in 1 line (#1206)
old-commit-hash: 6ff881f7894d0117099787e56ec0966bfc63fa7c
2020-03-05 17:32:52 -08:00
HaraldSchafer
544d198bed Pulse desire (#1172)
* initial

* compilation fixes

* add desire

* pulse desire

* 0d5728f6-a918-40a6-bce3-a9d0f1238180/20

* cleaner

* inject model

* inject model

* test runs

* ah already done I see

* remove useless

* update

* updates, doesnt work

* fix generating new references

Co-authored-by: Willem Melching <willem.melching@gmail.com>

old-commit-hash: 63d3bb517fdac3d953e67ca4a16f2c742388cdc5
2020-03-04 18:51:45 -08:00
Adeeb
65a2c62114 Abstract common events + event cleanup (#1129)
* too many if

* unused

* whitespace

* key

* sefldrive/car/*

* no more gctx

* lower

* start abstracting common events

* all cars

* start small

* all cars

* reverse gear

* wrongCarMode

* wrongGear

* espDisabled

* steerUnvailable

* make linter happy

* c isn't used

* fix esp_disabled in VW

* update ref

* more red

* more cleanup

* fix subaru

* update ref

old-commit-hash: e8cb6ea06a2470dd89a6ad8fd17bd1d1b62034cc
2020-02-20 16:22:25 -08:00
Andrew Valish
e46e9ada22 Add LaneChangeEnabled param and settings toggle (#1093)
* add LaneChangeEnabled param and settings toggle

* Read lane change toggle in pathplanner.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>

old-commit-hash: 45718d929468a1f6cd1b362bf169988e545241e1
2020-02-14 15:24:59 -08:00