FPv2: add comment about nuance of fuzzy fingerprinting (#28465)

add comment describing this nuance of fuzzy fingerprint function
old-commit-hash: 3234243c97c7c6bf6fb4bb1298a7fd262e697c04
This commit is contained in:
Shane Smiskol
2023-06-08 20:47:55 -07:00
committed by GitHub
parent c73ef08d08
commit 1a3b5137b6

View File

@@ -91,6 +91,8 @@ def match_fw_to_car_fuzzy(fw_versions_dict, log=True, exclude=None):
elif candidate != candidates[0]:
return set()
# Note that it is possible to match to a candidate without all its ECUs being present
# if there are enough matches. FIXME: parameterize this or require all ECUs to exist like exact matching
if len(matched_ecus) >= 2:
if log:
cloudlog.error(f"Fingerprinted {candidate} using fuzzy match. {len(matched_ecus)} matching ECUs")