Commit Graph

52 Commits

Author SHA1 Message Date
Shane Smiskol
13381ed446 services: capitalize constant service list (#30005)
* rename

* bump

* Apply suggestions from code review
old-commit-hash: 7f073483bb
2023-09-21 18:25:15 -07:00
Adeeb Shihadeh
1f8459d285 use pytest for cpp tests (#29833)
* add pytest-cpp package (#29828)

* add pytest-cpp package

* disable for now

* use in ci

* use pytest cpp

* use my branch

* add missing tests

* that doesn't make sense

* it was merged upstream

* replace TEST_RLOG_URL with a publicly accessible url

* PR Cleanup

* assert instead

* update poetry lock

* add comment about  pytest-cpp

---------

Co-authored-by: Justin Newberry <jnewberry0502@gmail.com>
Co-authored-by: Justin Newberry <justin@comma.ai>
Co-authored-by: deanlee <deanlee3@gmail.com>
old-commit-hash: 2c1dfc2f34
2023-09-11 14:01:50 -07:00
Justin Newberry
dc6078a6c3 System: use paths for download folders too (#29818)
* use paths for download folders too

* trailing slash

* reset that
old-commit-hash: 73eda51a11
2023-09-07 12:49:03 -07:00
Justin Newberry
c7029ea15a System: cleanup paths to use a common class (#29816)
* use OP prefix for logmessage

* cleanup paths too

* cleanup the paths too

* add hw.py to release

* fix those issues

* fix unittests

* fix unittests

* fix unittests

* do swaglog_ipc properly across all the files

* fix that

* fix swaglog in c++

* review suggestions
old-commit-hash: bfe990b112
2023-09-07 11:32:47 -07:00
Justin Newberry
3b91610c0b Precommit: ensure executable bit is set (#29784)
* precommit ensure executable

* exclude tinygrad

* bump submodules

* exclude tinygrad globally
old-commit-hash: 4e69937d0d
2023-09-05 16:33:26 -07:00
Kacper Rączy
4040d85159 encoderd: fix crash when filename is null (#29748)
Use publish_name for thread name and debugging messages
old-commit-hash: 0bda43d71c
2023-09-01 11:51:59 -07:00
Justin Newberry
e3053e6659 Tests: loggerd reduce iterations (#29713)
* reduce those iterations

* sleep time could be decreased too

* in case it's negative
old-commit-hash: a5ef9febb9
2023-08-30 13:36:55 -07:00
Adeeb Shihadeh
cc29c6640d pytest: strict config (#29676)
* pytest: strict config

* collection works

* fixes
old-commit-hash: 72e2e2c9ec
2023-08-28 10:26:19 -07:00
Dean Lee
d5631664d3 v4l_encoder: convert macro checked_ioctl to funtion (#29609)
* break to multiple lines

* convert to function

* format errno

* use safe_ioctl

* cleanup
old-commit-hash: 1e62999e75
2023-08-25 11:05:22 -07:00
Adeeb Shihadeh
61cf541322 Minimal build (#29600)
* add build flag for minimum build

* add minimal build

* update

* fix pj

* bump opendbc

* update subaru
old-commit-hash: 4917e22615
2023-08-24 14:58:30 -07:00
Dean Lee
86692bf177 v4l_encoder: fix error handling for poll (#29166)
* fix error handling for poll

* revert

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: d54fa5c7f1
2023-08-24 12:56:06 -07:00
Dean Lee
de809632bf cpplint: add filter whitespace/comma (#29595)
old-commit-hash: 7bfd3dac81
2023-08-24 10:42:06 -07:00
Dean Lee
0984736972 cpplint: add filter build/include_subdir (#29585)
old-commit-hash: 21da5a216f
2023-08-24 15:42:17 +01:00
Dean Lee
56b582a059 cpplint: add filter whitespace/forcolon (#29582)
whitespace/forcolon
old-commit-hash: ac93902983
2023-08-23 22:46:02 -07:00
Dean Lee
9bb3316925 encoder/VideoWriter: remove unnecessary call to avcodec_close (#29039)
old-commit-hash: 95e9232963
2023-08-23 20:08:19 -07:00
Dean Lee
8c6cb78f38 encoderd: remove unnecessary calls to encoder_close() on exit. (#28970)
old-commit-hash: ddd849a882
2023-08-23 17:56:22 -07:00
Adeeb Shihadeh
6b2ffe9490 bump cereal (#29561)
old-commit-hash: e726505918
2023-08-23 13:42:37 -07:00
Dean Lee
97e9d55588 cpplint: build/include_what_you_use (#29556)
* include_what_you_use

* remove comments

* include <memory>

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 2d99521e75
2023-08-23 13:25:17 -07:00
Dean Lee
004a097c95 cpplint: add readability/braces filter (#29554)
old-commit-hash: 363740a497
2023-08-23 10:13:46 -07:00
Adeeb Shihadeh
16ec56398c add openpilot prefix to imports (#29498)
* add openpilot prefix to imports

* more

* more

* fix docs

* fix linter

* bump submodules

* fix patched tests

* update dynamic imports

* debug

* Revert "debug"

This reverts commit db5e13b9911cc74438bee123bc3430da6c31b24b.

* fix pm test
old-commit-hash: a9626f95b6
2023-08-20 20:49:55 -07:00
Adeeb Shihadeh
f50fedb647 Fixes for PYTHONWARNINGS=error (#29381)
old-commit-hash: db287496d8
2023-08-13 17:22:56 -07:00
Dean Lee
cfef62bbd6 encoderd: fix indentation (#29356)
fix indentation
old-commit-hash: 51cdf155d9
2023-08-12 13:30:54 -07:00
Vivek Aithal
8d11558056 [commabody] setup and run live stream encoders (#29087)
* op changes needed for body

* remove logmessaged callback

* add newlines

* add stream arg

* add stream_encoder to config

* supersets, avoid two encoderd

* fix recursive exit error

* fix loggerd crash

* add stream_encoderd cpu usage to test

* Update system/loggerd/loggerd.h

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* resolve comments

* stream_encoderd onroad to false

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 81322a4805
2023-08-11 15:34:25 -07:00
Justin Newberry
a14f162bc7 Ruff: comprehensions conventions (#29317)
ignore c408
old-commit-hash: 4a9afd7554
2023-08-10 16:40:30 -07:00
Justin Newberry
7b677910df Linter: Fix >160 line length test (#29287)
* test

* fix line length

* fix line length

* fix file size

* revert poetry

* cleanup for PR
old-commit-hash: cf64b27168
2023-08-08 17:13:35 -07:00
Dean Lee
b80325aa04 swaglog: enable type-checked against format string (#29096)
* check&fix fmt

* bump rednose

* correct format string

* bump rednose

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 940954c13e
2023-07-31 17:49:50 -07:00
Dean Lee
c4aeaba7c6 loggerd: check userFlag outside the while loop (#29095)
* improve check userFlag

* rename to ServiceState

* setxattr once
old-commit-hash: c0c00e1997
2023-07-23 12:33:06 -07:00
Cameron Clough
b120aec2f5 deleter: preserve flagged segments (#28814)
old-commit-hash: 98a30f10f4
2023-07-20 21:30:26 +01:00
Dean Lee
bd93cd7db3 encoder: remove function publisher_init, init PubMaster in constructor (#28980)
old-commit-hash: 65fe3c8c34
2023-07-17 19:25:41 -07:00
Cameron Clough
c22ad5e0cf loggerd: fix whitespace and indentation
old-commit-hash: f14447ad66
2023-07-17 22:55:20 +01:00
Dean Lee
ad461bedb2 encoder: remove public function encoder_init (#28971)
old-commit-hash: 06aef9edd3
2023-07-15 23:57:44 -07:00
Dean Lee
d4cd751101 encoderd: get avaiable streams from vipc server (#28935)
* get avaiable streams

* use std::thread

* assert buf size

* Update system/loggerd/encoderd.cc

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: cbed057789
2023-07-15 12:41:49 -07:00
Dean Lee
b59b27e01e loggerd/encoder: refactor constructors to take EncoderInfo as parameter (#28921)
* refactor constructors to take EncoderInfo as parameter

* remove last arg codec

* use macro to init function pointers
old-commit-hash: 713d2ec586
2023-07-15 10:39:40 -07:00
Cameron Clough
182ef3fe52 loggerd: add types to tests and use pathlib (#28943)
old-commit-hash: 5d45d1fadc
2023-07-14 15:12:11 +01:00
Dean Lee
434a7c3505 logger: use reference in range based loop (#28894)
old-commit-hash: f1a1456f27
2023-07-11 19:28:50 -07:00
ntegan1
1c5075bfcd v4l_encoder: enable hevc vui header timing info flag (#27156)
v4l_encoder: enable hevc vui timing info flag

Co-authored-by: Cameron Clough <cameronjclough@gmail.com>
old-commit-hash: 0ddecd36cf
2023-07-09 20:38:30 +01:00
Dean Lee
0ac70b51fa loggerd: pass encoder_info by reference (#28694)
old-commit-hash: 36fe84ccdd
2023-06-25 14:51:28 -07:00
Harald Schäfer
e841a5ef81 Encoderd: refactor msg getters and setters (#28509)
* Encoderd: refactor msg getters and setters

* whitespace

* whitespace

* whitespace
old-commit-hash: 2453d3a04b
2023-06-12 00:08:00 -07:00
Harald Schäfer
f4bf6a3ddd Encoderd: Give encoder threads good names (#28508)
old-commit-hash: 5df4ac61d3
2023-06-11 23:25:16 -07:00
Harald Schäfer
1581ba80f8 Encoderd: give every camera stream list of encoder streams (#28480)
* Compiles

* fixed something

* CLEANUP

* todo

* More cleanup

* Add TODO

* Update loggerd.cc

* remove write here too
old-commit-hash: ac45b77d3b
2023-06-11 22:23:40 -07:00
Harald Schäfer
0705a97292 Encoderd: encoders don't write, they only encode (#28499)
* Encoders dont write, they encode

* Delete words

* unused

---------

Co-authored-by: Harald Schaefer <torq_boi@Haralds-MacBook-Air.local>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: d8f677c5eb
2023-06-11 15:02:42 -07:00
Adeeb Shihadeh
22882d740c Revert "Encoderd: encoders just encode, no writing (#28482)"
This reverts commit eed43696f113feeac757b147a782b8c063638a63.

old-commit-hash: 5161c23645
2023-06-11 08:27:09 -07:00
Harald Schäfer
c4bc3964a6 Encoderd: encoders just encode, no writing (#28482)
Encoders dont write, they encode
old-commit-hash: 1fd7542eae
2023-06-10 23:44:01 -07:00
Shane Smiskol
8a7283d315 uploader: check upload key value (#28206)
* fix check

* tests

* fix test

* fix

* xattr truthy and falsy tests

---------

Co-authored-by: Cameron Clough <cameronjclough@gmail.com>
old-commit-hash: 7f7637f3e5
2023-05-16 21:55:24 -07:00
Adeeb Shihadeh
2f8939dd0e bootlog: log agnos partition hashes (#28141)
* bootlog: log agnos partition hashes

* full path

* trimming

* slot

* boot is big

* give some time to start

---------

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 1a3125bb8f
2023-05-10 13:56:44 -07:00
Adeeb Shihadeh
3689bd2e77 loggerd: log HW-specific extras (#28084)
* loggerd: log HW-specific extras

* fix value

---------

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: e24d28fd45
2023-05-08 19:21:22 -07:00
Cameron Clough
c0fa2f3ea2 uploader: log actual uploaded file size (#28000)
* uploader: log actual uploaded file size

The size will be less if compressed before uploading.

* cleanup

* fix return type

* add request to FakeResponse

* cleanup

* fix
old-commit-hash: 7126363093
2023-04-26 20:45:58 -07:00
Cameron Clough
3bb5167aa8 uploader: add missing types
old-commit-hash: e03efa723b
2023-04-21 23:06:47 -07:00
Cameron Clough
6626f3036f uploader: add typing (#28001)
* uploader: add typing

* fix types
old-commit-hash: a27ce83b28
2023-04-21 22:03:26 -07:00
Adeeb Shihadeh
3913d4197f log current bootlog (#27645)
* log current bootlog

* rm path

* mv that

---------

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: be659c976c
2023-03-21 17:28:38 -07:00