* ban cereal and msgq
* common too
* do toyota/values.py
* do all fingerprints
* example without builder
* this still works, but no type checking anymore
* stash
* wtf, how does this work
* okay actually not bad
* safe
* epic!
* stash data_structures.py
* some clean up
* hell yeah
* clean up old file
* add to delete
* delete
This reverts commit 90239b7797ace31ee647a2fdbd67e0c3faa98dcf.
* switch more CarParams stuff over
remove unused
* fix car tests by removing cereal! mypy forgets about dataclass if we wrap it :(
* fix this too
* fix this too
* remove more cereal and add some good hyundai tests
* bunch more typing
* override default with 20hz radar
* temp capnp converter helper
* more lateralTuning
* small union replicator is better than what i was trying, and fixes mypy dynamic typing issues
* can keep all this the same now!
* type ret: CarParams, add more missing structs, revert lateralTuning changes (smaller diff!)
* revert more
* get first enum automatically, but ofc mypy doesn't pick up the new metaclass so can't use :(
would have been `CarParams.NetworkLocation()`
* Revert "get first enum automatically, but ofc mypy doesn't pick up the new metaclass so can't use :("
This reverts commit bb28b228becba932052d2fc5a4389784027435b1.
* remove cereal from car_helpers (TODO: caching)
* remove a bunch of temp lines
* use dataclass_transform!
* remove some car.CarParams from the interfaces
* remove rest of car.CarParams from the interfaces
* same which() API
* sort
* from cereal/cache from fingerprinting!
* more typing
* dataclass to capnp helper for CarParams, cached it since it's kinda slow
* (partial) fix process replay fingerprintig for new API
* latcontrollers take capnp
* forgot this
* fix test_models
* fix unit tests
* not here
* VehicleModel and controller still takes capnp CP since they get it from Params()
* fix modeld test
* more fix
* need to namespace to structs, since CarState is both class and struct
* this was never in the base class?!
* clean that up again
* fix import error
fix import error
* cmts and more structs
* remove some more cereal from toyota + convert CarState to capnp
* bruh this was wrong
* replace more cereal
* EventName is one of the last things...
* replace a bunch more cereal.car
* missing imports
* more
* can fix this typing now
* proper toyota+others CS typing!
* mypy can detect return type of CS.update() now
* fix redeclaration of cruise_buttons type
* mypy is only complaining about events now
* temp fix
* add carControl struct
* replace CarControl
i hope there's no circular imports in hyundai's CC
* fine now
* lol this was wrong too
* fix crash
* include my failed attempts at recursively converting to dataclass (doesn't implicitly convert types/recursively :( )
but attrs does, maybe will switch in the future
* clean up
* try out attr.s for its converter (doesn't work recursively yet, but interesting!)
* Revert "try out attr.s for its converter (doesn't work recursively yet, but interesting!)"
This reverts commit ff2434f7bbd45a4d4bfb21f7d6712d1f1c3bcde9.
* test processes doesn't fail anymore (on toyota)!
* fix honda crash
* stash
* Revert "stash"
This reverts commit c1762af4e776790e4ad1322ad4ce0610157346e0.
* remove a bunch more cereal!
* LET'S GOOO
* fix these tests
* and these
* and that
* stash, something is wrong with hyundai enable
* Revert "stash, something is wrong with hyundai enable"
This reverts commit 39cf327def258e2959fe23cd7a550a858f6d8f03.
* forgot these
* remove cereal from fw_versions
* Revert "remove cereal from fw_versions"
This reverts commit 232b37cd409b55d04b1afc90d4a80c49e710eb56.
* remove rest of the cereal exceptions!
* fix that
* add typing to radard since I didn't realize RI.update() switched from cereal to structs
* and here too!
* add TODO for slots
* needed CS to be capnp, fix comparisons, and type hint car_specific so it's easier to catch type issues (capnp isn't detected by mypy :( )
* remove the struct converter
* save ~4-5% CPU at 100hz, we don't modify after so no need to deepcopy
btw pickle.loads(pickle.dumps()) is faster by ~1% CPU
* deepcopy -> copy: we can technically make a reference, but copy is almost free and less error-prone
saves ~1% CPU
* add non-copying asdict function
* should save ~3% CPU (still 4% above baseline)
* fix that, no dict support
* ~27% decrease in time for 20k iterations on 3X (3.37857 -> 2.4821s)
* give a better name
* fix
* dont support none, capitalize
* sheesh, this called type() on every field
* remove CS.events, clean up
* bump card %
* this was a bug on master!
* add a which enum
* default to pid
* revert
* update refs
* not needed, but consistent
* just Ecu
* don't need to do this in this pr
* clean up
* no cast
* consistent typing
* rm
* fix
* can do this if we're desperate for the last few %
* Revert "can do this if we're desperate for the last few %"
This reverts commit 18e11ac7883a0a56583750b1cc5a2b13011e7299.
* type this
* don't need to convert carControl
* i guess don't support set either
* fix CP type hint
* simplify that
* Use livePose instead of llk
* Update process replay sockets
* Fix import
* Fix calib
* Fix field name
* Dont store device_from_calib
* Update ref commit
* Simplify long control
* Seperate
* Rename
* Try new api for toyota
* rm v_pid everywhere
* No speed in reset
* 0 is better default
* unassigned variable
* Update other cars
* Update gm
* SIMPLIFY
* simplify more
* fix API boundry
* Fix stopping bug
* Small fixes
* Update ref
* format card
* standalone process
* no class member CS, there's no point
also can be confusing; what else could be using this?
* rename CoS
* Update selfdrive/controls/controlsd.py
* never works first time :D
* canRcvTimeout is bool
* hack
* add cpu
* see what testing closet comes up with
* first
* some clean up
* support passable CI, fix test models
* fix startup alert
* process replay changes
* test_fuzzy
* gate carOutput valid on carControl valid
* we should publish after we update carOutput
* controlsd was using actuatorsOutput from 2 frames ago for torque, not the most up to date
* check all checks for carControl in case controlsd dies
* log more timestamps
* more generic latency logger; needs some clean up
latency_logger.py was difficult to understand and modify
* card polls on can and carControl to get latest carControl possible
* temp try to send earlier
* add log
* remove latencylogger
* no mpld3!
* old loop
* detect first event
* normal send
* revert "card polls on can and carControl to get latest carControl possible"
how it was is best
* sheesh! update should be first
* first timestamp
* temp comment ( timestamp is slow :( )
* more final ordering, and make polling on/off test repeatable
* Received can
* new plot timestamps
* clean up
* no poll
* add controllers (draft)
* Revert "add controllers (draft)"
This reverts commit e2c3f01b2fadcff74347bac90c8a5cc1ef4e27b3.
* fix that
* conventions
* just use CS
* consider controlsd state machine in card: not fully done
* hmm it's just becoming controlsd
* rm debugging
* Revert "hmm it's just becoming controlsd"
This reverts commit 534a357ee95bec4ed070667186af55d59421bbc7.
* Revert "just use CS"
This reverts commit 9fa7406f30c86200f20457f7b9ff95e731201bf9.
* add vCruise
* migrate car state
* Revert "migrate car state"
This reverts commit 4ae86ca163c6920070f410f608f7644ab632850b.
* Revert "add vCruise"
This reverts commit af247a8da41c3626ada4231b98042da1a1ae4633.
* simple state machine in card (doesn't work as is)
* Revert "simple state machine in card (doesn't work as is)"
This reverts commit b4af8a9b0a2e17fdfc89d344c64678ef51305c24.
* poll carState without conflate
* bump
* remove state transition
* fix
* update refs
* ignore cumLagMs and don't ignore valid
* fix controls mismatch; controlsd used to set alt exp
* controlsd_config_callback not needed for card
* revert ref temp
* update refs
* no poll
* not builder!
* test fix
* need to migrate initialized
* CC will be a reader
* more as_reader!
* fix None
* init after publish like before - no real difference
* controlsd clean up
* remove redundant check and check passive for init
* stash
* flip
* migrate missing carOutput for controlsd
* Update ref_commit
* bump cereal
* comment
* no class params
* no class
* Revert "no class"
This reverts commit 5499b83c2dcb5462070626f8523e3aec6f4c209d.
* add todo
* regen and update refs
* fix
* update refs
* and fix that
* should be controlsstate
* remove controlsState migration
CoS.initialized isn't needed yet
* fix
* flip!
* bump
* fix that
* update refs
* fix
* if canValid goes false, controlsd would still send
* bump
* rm diff
* need to be very careful with initializing
* update refs
* regen
* regen
* update
* undo
* update refs
* fix
* real fix
* test
* test2
* test3
* stash
* Revert "stash"
This reverts commit bf6765f526b48426f49a4b29c4042097f57fc4b0.
* rk.lagging can not be trusted. BODY segment has radarFault while modelV2 is not valid, causing radarState to not be valid
* order
* update refs again
* we never logged carOutput!
* bump
* add back checks
* card: create pedal pressed event (#32393)
* move pedalPressed to card
* rm
* needs to be a builder
* move these
* clean up
* reader later
* Update ref_commit
* moved to card
* move stateless, common car events to car interface
* try to reduce process replay diff a bit
* Revert "try to reduce process replay diff a bit"
This reverts commit b12798deabea67c5a636d6e70e80a3c21c7225ff.
* update refs
* VW: Steer to zero, for large values of zero
* ah, the joy of floating point
* comment, style
* actually fix floating point issue
* follow PlatformConfig refactor
* this check is not useful after PlatformConfig
* don't really need that
* work around docs assert
* little better
* one comment
* update refs
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com>
* Ford: handle metric cruise speed (v2)
**Description**
I found a signal which appears to match the IPC "Show km/h" setting.
Requires https://github.com/commaai/opendbc/pull/1010.
**Verification**
- [ ] Test in car and confirm that toggling the "Show km/h" setting does
not result in the cruise speed shown in openpilot being incorrect.
- [ ] Test in a non-English (metric) car.
* not present on Q4
* fix freq
* test
* Revert "test"
This reverts commit 5e3a9f6df126d51685157de1e52bd6695db40fac.
* Update ref_commit
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com>
* with brand name
* migrate
* Fix
* fixes
* more
* passes
* fix
* fix the doc
* collects
* these too
* more stuff
* body exception :/
* more
* hardcode i guess
* update ref
* toyota
* more toyota
* and here
* final!
* fix notebooks and ccs
* move this here
* get platform_str from the enum name
* fix tests
* add migration table
* remove impossible todo
* Add link to PR in MIGRATION table
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* Remove useless brand name comments and rename RAM_1500 to RAM_1500_5TH_GEN
* rename RAM_HD to RAM_HD_5TH_GEN
* rename references to RAM_HD and RAM_1500
* change "mock" to "MOCK" and rename torque data of Nissan Leaf 2018 IC
* remove MOCK from fingerprints.py
* change hard-coded car model in test_can_fingerprint.py/test_timing
* migration
* update ref
* space
* prius
---------
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: justin newberry <justin@comma.ai>
Co-authored-by: Justin Newberry <jnewberry0502@gmail.com>
* start at param
* start by sending personality
* change to personality
* POC: button changes personality
* what's wrong with this?
* fix
* not really possible but fuzzy test catches this
* there's always a typo
* dang, we're dropping messages
* clean up
* no comment
* bump
* rename
* not all cars yet
* works but at what cost
* clean up
* inside settings
* write param so we save the distance button changes
* setChecked activates buttonToggled and already writes param!
* don't need this, we update from longitudinalPlan on changes
* some clean up
* more
* ui
* allow some time for ui to receive and write param
* plannerd: only track changes in case no ui
* Revert "plannerd: only track changes in case no ui"
This reverts commit 2b081aa6ceb92c67a621b74592b2292756d29871.
* write in plannerd as well, I assume this is atomic?
* don't write when setting checked (only user clicks)
* better nane
* more
* Update selfdrive/controls/lib/longitudinal_planner.py
Co-authored-by: Cameron Clough <cameronjclough@gmail.com>
* doesn't write param now
* ParamWatcher is nice
* no debug
* Update translations
* fix
* odd drain sock proc replay behavior
* vanish
* Revert "odd drain sock proc replay behavior"
This reverts commit 29b70b39413e1852bb512155af6b6a94a5bd9454.
* add GM
* only if OP long
* move personality to controlsState, since eventually it won't be exclusive to long planner
more
bump
* diff without translations
* fix
* put nonblocking
* CS should start at up to date personality always (no ui flicker)
* update toggle on cereal message change
* fix
* fix that
* ubmp
* mypy doesn't know this is an int :(
* update translations
* fix the tests
* revert ui
* not here
* migrate controlsState
* Revert "migrate controlsState" - i see no reason we need to test with
any specific personality
This reverts commit 6063508f2df1a5623f113cda34dcd59a1f4b2ac9.
* Update ref_commit
---------
Co-authored-by: Cameron Clough <cameronjclough@gmail.com>
* start at param
* start by sending personality
* change to personality
* POC: button changes personality
* what's wrong with this?
* fix
* not really possible but fuzzy test catches this
* there's always a typo
* dang, we're dropping messages
* clean up
* no comment
* bump
* rename
* revert longplan
* revert this
* Fix check
* more appropriate up here
* consistenet
* Update selfdrive/car/toyota/carstate.py
* Update ref_commit
* subclass bosch and nidec
* end with comma
* one line
* remove unused flags
* as a test see what happens if we exceeed CP.flags
* Revert "as a test see what happens if we exceeed CP.flags"
This reverts commit f57a346df5e6f3c6ab19875b843633c0571d16e3.
* Update ref_commit
* part 1. Toyota platform config
* more
* everything works now
* no more DBC
* janky but that saves a lot of car lines
* need to init inside values or else it won't be reliable
* no return
* fixes
* minor update
* common flags, no dbc grouping
* some clean up
* some clean up
* rename
* copied wrong :(
* another
* copied specs for easiest ones first
* second easiest
* fix erroneous commas
* more clean up
* do the rest
* bug
* the refactor is so error prone
* huh?!
* static
* fix stiffness factor
* detect unsupported DSU
* Revert "detect unsupported DSU"
This reverts commit 9b72de6c8ef282ce20f6472970874a960761884b.
* fix DBC diff
* test carparams
* test sets
* scratch
* catches this
* Revert "scratch"
This reverts commit de08daa9fb8cc0368c5847b669e87b1b2e577616.
* Revert "test sets"
This reverts commit 62402f9b021cdf16a27fd9fb0883d81169711cbd.
* Revert "test carparams"
This reverts commit b02971659c2a8268d0ac8fdff02231dc36b5a197.
* Update ref_commit
* fuck me!
* that kinda makes things pretty nice
* move it down
* and move this comment
* Wip
* more flags :/
* add the debug shit
* add
* lets not break this yet
* MORE flags git add .git add .git add .git add .!
* B
* add mando
* update ref
* possibly better?
* we can use flags here
* formatting
* formatting
* move up
* canfd subclass
* this is more clear
* spacing
* static!
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com>
* flags
* update ref
* use the flags directly
* use post_init (don't freeze)
* we can maintain frozen with custom class
* not preglobal
* move to common
* cleanup
* Do Accord
* add comment
* good test
* this catches the accord/accordh issue!
* as expected, only if both radar&camera have in common FW does the test fail
* cmt
* clean up
* better
* Use HondaFlags
* detect alt brake
* for test
* hypothesis isn't installed
* test failure
* works
* Revert " works"
This reverts commit bfc0d808abe548630e6507431f13b01e8a1316cb.
* Revert "test failure"
This reverts commit 10ab6eb63ccd411740751b742f31fd610397fe8e.
* Revert "hypothesis isn't installed"
This reverts commit d474cc3f0ed7e84fe8bd24f452b3315fd2b8d47c.
* Revert "for test"
This reverts commit 98e039f4fc0189ccb57c1dae6b344209ef15eb1c.
* this is important too
* clean up
* merge accord fingerprints, test
* remove duplicates
* accordh doesn't have these
* rm
* no unknown
* start over, merge platforms
* add cmt
* note non-essential ecus
* add non essential obd ecus
* combine FW
* format fingerprints (remove dups)
* migrate test models segs
* cmt
* Update ref_commit
* clean up
* log params when calculable
* better
* Update ref_commit
* this is redundant
* this is only used in one place, confusing which to use so remove
* better
