Commit Graph

189 Commits

Author SHA1 Message Date
Shane Smiskol
c5a673b998 car interfaces: handle buttons changing state without going unpressed (#26463)
* rename function first and foremost

* the function

* comment

* move usages over

* probably fine

* comments

* btn

* single line

* not comments

* fix keyword

* is it not clear?

* noEntry while holding cancel

* bumpo

* remove

* better?

* better?

* try this

* try this

* loop

* better

* more clear

* Revert "more clear"

This reverts commit 37e0277e4bfe6f1c553dbbcece6f532a280be62e.

* no optional

* fine

* add comment

* clean up honda

* one line

* can also do this

* but unclear

This reverts commit 1984a72cc8680b23c202695b8aeeb1aa28f7160c.

* bumppanda
old-commit-hash: 24f5a6170d
2023-08-25 16:47:10 -07:00
Adeeb Shihadeh
16ec56398c add openpilot prefix to imports (#29498)
* add openpilot prefix to imports

* more

* more

* fix docs

* fix linter

* bump submodules

* fix patched tests

* update dynamic imports

* debug

* Revert "debug"

This reverts commit db5e13b9911cc74438bee123bc3430da6c31b24b.

* fix pm test
old-commit-hash: a9626f95b6
2023-08-20 20:49:55 -07:00
Jason Young
ac83f87b36 interfaces: add common STD_CARGO_KG to mass (#29416)
* cleanup std_cargo_kg

* fix Sonata mass

* remove snowflake construct

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: f76ffbdbbc
2023-08-17 21:06:07 -07:00
Shane Smiskol
183515c04b Rename CivicParams (#29459)
* CivicParams -> ReferenceCarParams

* remove usage in interface

* better name

* revert
old-commit-hash: 8dcd108972
2023-08-17 21:02:09 -07:00
Jason Young
b4614b3c28 car interfaces: cleanup tire stiffness calculation (#28263)
* cleanup tire stiffness calculation

* bump cereal

* think these todos still apply

* gm: same default

* revert comments

* bump

* update refs

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 90c4bbe8e4
2023-08-15 14:17:08 -07:00
Justin Newberry
7b677910df Linter: Fix >160 line length test (#29287)
* test

* fix line length

* fix line length

* fix file size

* revert poetry

* cleanup for PR
old-commit-hash: cf64b27168
2023-08-08 17:13:35 -07:00
Shane Smiskol
1b5e039afd Honda: set autoResumeSng for docs (#28458)
set autoResumeSng for Honda
old-commit-hash: 7a64385fcd
2023-06-09 11:20:42 -07:00
Shane Smiskol
b5aff78ee0 Honda: use CS accFaulted field (#28339)
* log accFaulted

* bool

* also bool
old-commit-hash: 80e84a2158
2023-05-30 15:05:57 -07:00
Shane Smiskol
d916e0ed2d Car docs: pass docs flag to car interfaces (#27311)
* docs

* docs

* docs

* docs

* use docs in gm
old-commit-hash: 5aebdb0ad0
2023-04-18 12:22:22 -07:00
AlexandreSato
4a7535fd17 Honda: HR-V 2023 port (#27731)
* initial commit

* HR-V is diff enought to split from Civic22

* Add US HR-V 2023

* update CARS.md

* Update RELEASES.md

* Use a alternative brake signal

* US HR-V have a weird noise in the BrakeSwitch

* Shane tunning

* this is added automatically

* sorry jyoung

* civic22_stop_faster

limit stopAccel to current safety model

* relax calib temporarily (12 deg)

relax calib temporarily (10 deg)

* compute accel (car overshoots requests at low speed)

* revert brake pressed caused controls mismatches

* fix crash

* cause a cruise fault

* Revert "cause a cruise fault"

This reverts commit 09a6469ac6fc38ebd38dd1c5d464712a15d0fde1.

* no brake error

* use alt brake

* Update selfdrive/car/honda/carcontroller.py

* change HONDA_BOSCH_ALT_BRAKE_SIGNAL to CP.flags

* Revert "change HONDA_BOSCH_ALT_BRAKE_SIGNAL to CP.flags"

This reverts commit e0f8123b33db3218f27c4b64a7b2a0b1f740860f.

* remove FPv2 from brazilian HR-V

* bump panda

* fix a bug

* revert calib threshold

* new test route

* separate pr

* update

* update that

* thought i removed this

* revert steer ratio

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 93c1810522
2023-04-14 03:12:10 -07:00
Shane Smiskol
730450d71e Honda Bosch Radarless: use CarControllerParams variable
old-commit-hash: 51c3f43205
2023-03-30 12:19:48 -07:00
royjr
77ce14cf0b Honda Bosch Radarless: update stopAccel to match actuation limits (#27740)
* civic22_stop_faster

* limit stopAccel to current safety model

* Update selfdrive/car/honda/interface.py

* Update selfdrive/car/honda/interface.py

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: fe49fbf8ec
2023-03-30 12:18:32 -07:00
royjr
f4d0b68a21 Honda Bosch Radarless: experimental longitudinal support (#25364)
* civic22_long

* Stock requests -4

* add standstill bit

* bump

* fix standstill

* bump

* bump

* bump panda

* Update hondacan.py

* bump panda

* add docs

* bump panda

* bump panda

* fix control_on value

* set control_off

* fix cars.md

* Update panda

* Update opendbc

* Update panda

* Update panda

* allow more braking

* Revert "allow more braking"

This reverts commit ecd2493a436a095b621d815e8b0c7591fa6b93a9.

* Update panda

* fix speed mismatch

* Revert "fix speed mismatch"

This reverts commit ca795dc5bd9d6e841225e1ac1ff93a1f78618513.

* Update panda

* fix speed mismatch and standstill

* delay stopped message to match stock behavior

* green cruise only when enabled

* Update panda

* Revert "green cruise only when enabled"

This reverts commit d21aa5b541a42fa6d1c87e3b065f720af28ff38b.

* lesser nester

* simplify

* simplify control_on

* simplify common signals

* simplify CONTROL_ON

* lessest nester

* hide speed on gas_override to match stock behavior

* tiny simplification, lesser nester

* flip common acc control values around

* move magic number to global variable

* Revert "move magic number to global variable"

This reverts commit 160be0e0872dc08a8786d97fc2125b2eb131362d.

* remove stopped logic

* remove unused variable

* looks ok

* looks better

* simplify override

* clarify CONTROL_OFF signal comment

* civic22_long_bettercontroloff

shorten delay

init

selfless

whoops

move to carcontroller

selfmore

lower time, currently take 5s to kick in

just right

deline

* Rename CONTROL_OFF -> IDLESTOP_ALLOW

This tells the car its ready to turn off the engine, which does so when the car is standstill.

* Update panda

* Update opendbc

* Update panda

* fix docs

* Update panda

* Update panda

* Update opendbc

* Update panda

* Update panda

* Update panda

* Update panda

* bump panda

* idlestop in another PR

* radarless doesn't need tester present

* simplify that

* helper

* one line is fine

* test bump

* bumpback

* disallow

* reduce diff

---------

Co-authored-by: sshane <shane@smiskol.com>
old-commit-hash: 1853d6f40e
2023-03-28 01:53:48 -07:00
Rob Chouinard
42626606dd Allow Honda Nidec vehicles with comma pedal to drive at max speed. (#26902)
Without this Honda Nidec vehicles with the comma pedal will drive around 2 mph under the max speed.
old-commit-hash: d4c5b8d6f4
2023-02-14 22:24:13 -08:00
Shane Smiskol
acc8e38111 GM: enforce steering command message timing (#27250)
* draft

* bump opendbc

* still draft

* that's not right

* superset of the changes, 33hz

* cleanup

* this should work

* remove line

* pass it in again

* actually no need to check updated now

* now_nanos

* consistent name

* fix replay

* one line isn't that bad

switch

switch

* fix CarController tests

* Update ref_commit
old-commit-hash: 8f5057ff2d
2023-02-09 15:37:39 -08:00
Adeeb Shihadeh
20fbb0a8fd rename carState.radarOffCan to radarUnavailable (#27187)
* rename carState.radarOffCan to radarUnavailable

* bump cereal
old-commit-hash: 6fa9b555a4
2023-02-02 11:38:09 -08:00
Shane Smiskol
bf31067e92 Honda: merge Passport platform into Pilot (#27061)
* Move Passport FW versions to Pilot

* lol, all duplicates already in pilot

* No Passport

* Better params for both
old-commit-hash: b2c6d5d34a
2023-01-23 20:16:50 -08:00
Shane Smiskol
8aadc8dda6 Car interface: set common params after port (#26613)
* remove pylint exception, _get_params takes no defaults

* clean up

* mock uses it too

* unused

* unused

* fix that

* bump

* Update selfdrive/car/interfaces.py
old-commit-hash: 860f441e2f
2022-11-29 11:49:13 -08:00
FAN HANGYU
f7d49be556 Honda: add Chinese Odyssey FW versions (#25943)
* Update values.py

add a carFW of odyssey_chn

* move after odyssey

* common carparams

* just ignore

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 131263a75b
2022-10-31 13:13:57 -07:00
Adeeb Shihadeh
e4f9781c17 single longitudinal toggle for e2e and disable radar (#25688)
* single longitudinal toggle for e2e and disable radar

* write disable radar param

* rename

* better param name

* clean that up

* update refs

* update translations

* not live for experimental

* write it out

* vanish
old-commit-hash: 655a64b603
2022-09-07 17:12:49 -07:00
Shane Smiskol
c3342795f2 Common button enable/cancel event creation (#25445)
* handle button presses in create_common_events

* remove from imports

* Handle

* Fix Honda (it hardcodes pcmCruise)

* Update selfdrive/car/volkswagen/interface.py

* Update selfdrive/car/volkswagen/interface.py
old-commit-hash: e3d3fd0230
2022-08-18 23:40:24 -07:00
Chris Souers
bcbca2afc9 Honda: cleanup minEnableSpeed (#25447)
* Honda interface.py: cleanup `stop_and_go` variable

* Update selfdrive/car/honda/interface.py

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 3fc001c945
2022-08-16 00:40:47 -07:00
Shane Smiskol
43bb8dd087 Car Port: 2022 Honda Civic (#24535)
* master 2022 Civic

* bump panda

* bump

* bump cereal

* fix

* needed

* try for now

* maybe

* revert for now

* move to Cam parser

* fix

* move to cam

* need AEB_STATUS too

* bump for debug prints

* bump opendbc and add cruise_params

* bump opendbc and update cruise_params

* bump

* test route

* update ref

* Revert "update ref"

This reverts commit 28345dab63d1919865ccb510265222a4cd4252f4.

* cleanup

* just to test

* bump

* revert

* need to send val 12 too?

* change bus

* not needed

* update bus

* syntax

* move this to other bus too

* Revert "move this to other bus too"

This reverts commit 770bf4745ee244c8426ac108f44b67777198d0a7.

* test new lane line signal

* needed too

* maybe need both?

* Test new LKAS hud message

* bump

* missing comma

* missing

* maybe

* add frame and idx

* add in hud_lanes

* switch this too

* bump panda

* add this

* I guess need this too

* to match

* also

* wasnt correct

* bump opendbc

* bump panda

* move to cam parser

* missing

* add here too

* bump

* remove from cam parser

* bump

* back to cam parser

* its 5hz

* bump for new checksum function

* bump for correct frequency

* update frame and idx

* bump

* bump and update

* send set me bit

* bump

* pass these values through

* silly atom

* ret

* fix this

* use copy instead

* add these too

* to check keyerror

* switch

* bump submodules

* send too

* proper

* Replace HUD with BOH

* add dashed lanes

* small fix

* clean up

* not needed anymore

* remove and change

* this too

* dont always set

* remove additional LKAS message

* bump

* add

* to test

* add frame

* bump

* rebase

* remove default values

* rename

* clean up some carstate logic

* regenerate docs

* spacing

* simplify more logic

* bump opendbc

* bump opendbc

* only if radarless

* panda at least builds now

* add comment

* bump

* fixes

* bump opendbc

* bump opendbc

fix for new DBC

* bump opendbc

* bump opendbc

* carstate: fix bus, parser signals

* Set safety param

* pt bus is 0, not 1

* Fix SCM_BUTTONS and bump panda and opendbc

* fixes for ACC_CONTROL

* bump opendbc

* bump opendbc

* convert from MPH on HONDA_BOSCH_RADARLESS

move is_metric

* make sure we don't disable if radarless

* don't show incorrect harness on website

don't show incorrect harness on website

* bump panda

* remove/update comments

* bump panda

* Fix harnesses

* one line check

* bump opendbc

* remove this

* Some carstate cleanup

We removed STANDSTILL->WHEELS_MOVING

we don't use CRUISE_PARAMS

add back

add back

* more cleanup

* update docs

* marketing says it has TJA and ACC with low speed follow

* send buttons on bus 0

bump panda

* comment

* camera needs to see buttons on bus 2

comment

* bump panda

* add to releases

* remove comments

* comment

* we don't use stock hud yet

Co-authored-by: vanillagorillaa <ntmccoy@yahoo.com>
Co-authored-by: vanillagorillaa <31773928+vanillagorillaa@users.noreply.github.com>
Co-authored-by: kevinharbin <76784413+kevinharbin@users.noreply.github.com>
old-commit-hash: abcc7338d4
2022-06-19 00:06:23 -07:00
HaraldSchafer
b0b1aff5cc Rocket league model (#24869)
* dd9a502d-c8e2-4831-b365-804b0ae0739d/600 80041070-d276-4fed-bdb9-0075e5442908/420

* no elementwise op

* 9dabf0fe-2e60-44bf-8d3a-d20a74aca072/600 ae746590-0bb5-4a16-80db-15f02d314f03/300 c4663a12-b499-4c9b-90dd-b169e3948cb1/60

* explicit slice

* some copies are useful

* 1456d261-d232-4654-8885-4d9fde883894/440 c06eba55-1931-4e00-9d63-acad00161be0/700 af2eb6ba-1935-4318-aaf8-868db81a4932/425

* 154f663e-d3e9-4020-ad49-0e640588ebbe/399 badb5e69-504f-4544-a99e-ba75ed204b74/800 08330327-7663-4874-af7a-dcbd2c994ba7/800

* set steer rate cost to 1.0

* smaller temporal size

* Update model reg

* update model ref again

* This did upload somehow

* Update steer rate cost

Co-authored-by: Yassine Yousfi <yyousfi1@binghamton.edu>
old-commit-hash: 9283040d84
2022-06-15 15:29:42 -07:00
HaraldSchafer
f7edd5f3d3 Car interface: set max lateral torque from table (#24789)
* json

* better naem

* Read from table

* formatting and default to nan

* Generate docs

* Read from table

* this should be the same

* Prius v is full

* test we always set the tunes correctly

add to release files

* Set for all cars

Set for all cars

* Revert tuning changes

Revert tuning changes

* remove that

* fixes

* update ref commit for new maxLateralAccels

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 3066ad81a8
2022-06-10 17:57:23 -07:00
Shane Smiskol
68e8173474 docs: adjust steering torque thresholds (#24798)
* Prius has good steering control now

* 1.5 is the threshold for good torque

* get back down there, hondas

* half stars for 1.0-1.5

* show number of cars

* try bigger

* emphasize tiers

balanced

* Add half star

* Update ref_commit
old-commit-hash: 1b402687e4
2022-06-09 18:51:34 -07:00
Shane Smiskol
1a2bf8412c Car documentation: set steering torque star using car interface (#24709)
* Set good torque using torque controller tuning

* should be equal to

* save lateral accel to car params

* use maxLateralAccel

* always

* same convention

* nan will always evaluate to false

* The great good torque purge

* adjust default friction

* Add data for more cars

* adjust name

* Welcome back, guys. Only adjust good torque if maxLatAccel is set

* Update refs (1.7 is 1.7000001...)
old-commit-hash: c6bc03311c
2022-06-03 17:41:20 -07:00
Shane Smiskol
3ba40da00a Honda: fix enabling before PCM (#24715)
* Don't enable for pcmCruise Honda

* make it a no entry as well

* do in another PR
old-commit-hash: 40deea7d7b
2022-06-02 22:06:01 -07:00
Shane Smiskol
ddf2d5b63c Button-enable cars: common functions for button events (#24678)
* function for creating button events

* fix

* one line

* alphabetical

alphabetical

* only needed once

* common function for enable events

* add to list

* extend

* fixes

* add type hints

* flip around
old-commit-hash: eed6803ccc
2022-06-01 12:03:34 -07:00
Adeeb Shihadeh
3789587df1 add alert for CAN bus timeout (#24162)
* add alert for CAN bus timeout

* add alert

* set in interface

* cleanup

* cleanup

* add event

* fix mock

* bump

* bump opendbc

* update refs

* return reader
old-commit-hash: 49c2164814
2022-04-12 22:58:34 -07:00
Adeeb Shihadeh
bd71c594a2 pylint: enforce indentation (W0311) (#24039)
* pylint: enforce indentation (W0311)

* few more
old-commit-hash: 8af20af66d
2022-03-24 23:23:29 -07:00
Shane Smiskol
4d624b6f81 Honda: clean up CarInterface.apply and CarController (#23876)
* clean up honda/carcontroller

* indentation

* fixes

* clean up apply function

clean up apply function
old-commit-hash: 70286766da
2022-03-18 19:10:59 -07:00
Adeeb Shihadeh
3327348aeb don't read params in car interfaces (#23978)
old-commit-hash: bae78dd46b
2022-03-16 15:17:47 -07:00
Adeeb Shihadeh
d0b419796f Fix controls mismatch on button enable cars + test against panda safety (#23975)
* test models: check button enable cars against panda safety

* gm too

* cleanup
old-commit-hash: 20db4525a2
2022-03-16 14:54:22 -07:00
Adeeb Shihadeh
94e02bcb3f add parkingBrake to carState (#23968)
* add parkingBrake to carState

* fix gm
old-commit-hash: ae19308e83
2022-03-14 16:32:20 -07:00
Adeeb Shihadeh
ec47e0fef0 break up selfdrive.config (#23959)
* break up selfdrive.config

* add to release files

* fix import order
old-commit-hash: 5c3f3e44bc
2022-03-13 21:42:39 -07:00
Shane Smiskol
3e61c7e6ae carControl: add long and lat active fields (#23859)
* proof of concept

* actuators packet describes which actuators are active

* bump cereal

* fixes

* not needed for this PR

* Do Toyota

* add back controlsState.active

* bump cereal

* rest of cars

* in actuators

* add active back

* which

* use controlsState.active for now

* will make an issue

* Update selfdrive/controls/controlsd.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* move local lat_active checks into CC.latActive

* remove redundant checks

* move comment

move comment

* fix joystick mode

* get enabled from carcontrol

* do standstill check in controlsd

* make sure we consider the gas press case for GM

* use CC.actuators

* fix

* capitalization

* Bump cereal

Bump cereal

* make intermediate actuators

* similar convention to before

* clean that up

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 629399a449
2022-03-13 20:58:44 -07:00
vanillagorillaa
f8f1ffd0d6 Honda: Merge Passport interface (#23651)
old-commit-hash: 06541abddc
2022-01-27 20:16:13 -08:00
vanillagorillaa
455fd17008 Honda: Merge Pilot_2019 into Pilot (#23590)
* merge pilot

* these weren't on the 2019 pilot

* add non essential ECUs
old-commit-hash: 4f827e2e9e
2022-01-24 21:19:40 -08:00
Adeeb Shihadeh
70f1418256 remove community features toggle (#23214)
* remove community features toggle

* bump cereal

* little more

* update refs
old-commit-hash: 3e9cb7fa12
2022-01-24 14:49:47 -08:00
Dean Lee
98de810849 check in tuple instead of list (#23477)
* check in tuple instead of list

* Update selfdrive/car/toyota/carcontroller.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>

* Update selfdrive/car/mazda/interface.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: a653461dec
2022-01-10 16:36:51 +01:00
Dean Lee
0a762c27ce interfaces/apply: follow capnp best practices (#23371)
old-commit-hash: 05b905d140
2022-01-04 11:34:49 +01:00
Anthony Foerster
8d2f0de871 Fix steering oscillations in 2019 RDX (#22677)
Steering wheel would oscillate quickly when going straight, oscillation
is gone after this modification.
old-commit-hash: 1ca5e1c82b
2022-01-03 23:07:49 -08:00
HaraldSchafer
f64c2974b4 Road Roll Compensation Rebased (#23251)
* first commit

* update refs
old-commit-hash: cf466222f6
2021-12-16 17:34:12 -08:00
Ewout ter Hoeven
a962365292 Convert format strings strings to f-strings (#23241)
* Convert all text strings to f-strings

Reformats all the text from the old "%-formatted" and .format(...) format to the newer f-string format, as defined in PEP 498. This requires Python 3.6+.

Flynt 0.69 was used to reformat the strings. 120 f-strings were created in 51 files.

F-strings are in general more readable, concise and performant. See also: https://www.python.org/dev/peps/pep-0498/#rationale

* revert pyextra changes

* revert ublox.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 55390d273f
2021-12-16 14:58:17 +01:00
Willem Melching
7b3e330def Log actuators after applying rate limits in CarController (#23230)
* return actuators from carcontroller

* log it

* pass to latcontrol

* chrysler

* gm

* honda

* more brands

* rest of the brands

* gm cleanup

* hyundai cleanup

* update ref

* rename field

* fix subaru

* add types

* more subaru fixes #23240

* consistent whitespace

* bump cereal
old-commit-hash: 4f1eb4278a
2021-12-16 13:08:20 +01:00
Adeeb Shihadeh
189c41a614 Merge 2021 Accords into 2018 Accords (#23174)
* Merge 2021 Accords into 2018 Accords

* last of them
old-commit-hash: 1638975627
2021-12-08 14:40:14 -08:00
Adeeb Shihadeh
87f707ec87 Honda: use new Bosch LKAS_HUD messages (#23000)
* Honda: use new Bosch LKAS_HUD messages

* enum value

* better name

* flip that
old-commit-hash: 0283942a95
2021-12-05 13:51:33 -08:00
Willem Melching
b8ab21bd64 add CarParams.wheelSpeedFactor (#23079)
* add CarParams.wheelSpeedFactor

* Fudge speed for Lexus RX

* should have been the TSS2 model

* bump cereal

* refactor into function

* update refs
old-commit-hash: e6180738fd
2021-12-03 14:57:53 +01:00
Adeeb Shihadeh
89eb02fee4 Bring back Accord 2021 + 2021 Hybrid (#23021)
Co-authored-by: Chris Souers <csouers@gmail.com>
old-commit-hash: 239c7c1d4e
2021-11-23 23:19:11 -08:00