Commit Graph

783 Commits

Author SHA1 Message Date
Shane Smiskol
634a6c9802 Deprecate noTarget event (#26638)
deprecate notarget
old-commit-hash: 5409895ab2
2022-11-30 02:32:47 -08:00
Shane Smiskol
3d161c4d42 controls: remove noTarget event (#26632)
remove noTarget alert
old-commit-hash: 41610fe8ae
2022-11-29 23:12:58 -08:00
Shane Smiskol
d1dee4625a controlsd: preEnable on brake at a standstill (#26273)
* pre-enable on brake at standstill

* test by getting rid of noTarget

* Update events.py

* rename

* stash what we got so far

* cmt

* not sure if best way to fix, but enabled with current states defs is fine

* no noEntry in preEnabled

* bumpcereal

* uncomment

* Update ref_commit

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: dbe512d167
2022-11-29 17:34:10 -08:00
Shane Smiskol
76e7a45284 controls: preEnabled doesn't consider noEntry (#26627)
preEnabled doesn't consider noEntry
old-commit-hash: 8ad8d4e1c2
2022-11-29 13:11:03 -08:00
Vivek Aithal
238e63bc2a [controlsd] Refactor apply_deadzone in Lateral Torque Control (#26626)
rename apply_slack to apply_center_deadzone, remove unused prius offline values
old-commit-hash: 3a4f19f0ee
2022-11-29 12:46:08 -08:00
Vivek Aithal
5bc529bf20 [controlsd] Toyota Prius 2017 (#26455)
* increase lag on prius

* better offline values computation

* split prius ecu more, set deadzone to 0

* add deadzone back

* replace deadzone with slack

* reduce deadzone to 0.2

* update refs
old-commit-hash: 0706b03e8c
2022-11-29 10:47:13 -08:00
Shane Smiskol
bcdbd8edb9 Toyota: alert when in standstill (#26585)
* add resume required alert

* possibly need this (pressing resume with brake held does nothing)

* better text (has both meanings)

* try this

* Revert "try this"

This reverts commit 5b2991929b62f5bcd9bfa0767d709b5fe83b094b.

* no alert with interceptor

* check long
old-commit-hash: 3253b85900
2022-11-25 16:00:58 -08:00
Shane Smiskol
db8028fa63 longcontrol: ignore cruise standstill if interceptor (#26597)
* ignore standstill

* cmt

* standstill

* rm cmt

* flip
old-commit-hash: a19b5b91d2
2022-11-24 18:17:36 -08:00
Adeeb Shihadeh
4f7bfc430a process replay: support old routes with no peripheralState
old-commit-hash: 7361d1a11b
2022-11-22 11:46:28 -08:00
Adeeb Shihadeh
7c96e7876a cleanup panda types everywhere (#26574)
* cleanup panda types everywhere

* one more
old-commit-hash: 65fa87a969
2022-11-21 23:43:24 -08:00
Shane Smiskol
b94dfd81c6 controlsd: add test around cruise speed gas pressed behavior (#26486)
* test

* test

* debug

* test

* test

* test

* clean up

* clean up

* add test

* stash

* clean up

* clean up

* clean up

* assert equal
old-commit-hash: 23a7a987f6
2022-11-21 17:05:13 -08:00
Adeeb Shihadeh
4cb61240b3 enable experimental longitudinal control on devel (#26544)
old-commit-hash: 94aa39bdd4
2022-11-21 16:18:51 -08:00
YassineYousfi
7d5a2309a7 long_mpc: fix e2e source condition (#26546)
* fix long_mpc source param

* rm print

* add back space for formatting
old-commit-hash: ded66e6307
2022-11-21 15:25:23 -08:00
Adeeb Shihadeh
aec5f32f3c publish experimental mode state (#26512)
* publish experimental mode state

* remove that
old-commit-hash: 9c96b21367
2022-11-15 17:18:13 -08:00
Shane Smiskol
270fe5aac3 controlsd cruise speed: fix missing initial value
old-commit-hash: f15d169289
2022-11-14 11:01:01 -08:00
Shane Smiskol
a0539910bf controlsd: no speed increment if enabled on button rising edge (#26490)
* don't increment speed if we enabled on rising edge

* more realistic test
old-commit-hash: e46063086f
2022-11-13 16:34:26 -08:00
Shane Smiskol
210e281cd4 cruise speed tests: match controlsd initialization of cruise speed (#26491)
* helper functions and fix resetting/enabling

* comment (resume not yet tested)

* make it clear how this resets

* this is fine to enable once

* same here
old-commit-hash: 3524cc7f0b
2022-11-13 16:15:17 -08:00
Shane Smiskol
0f3aeb531c controlsd: clean up v_cruise updating (#26479)
* clean up

* clean up

* clean up
old-commit-hash: 870b798185
2022-11-11 23:56:35 -08:00
Shane Smiskol
415152ade9 controlsd: add tests around cruise speed (#26478)
* start to add some tests

* test !pcmCruise

* test !pcmCruise

* better test

* fix pylint

* new test for making sure we adjust on falling edge of buttons
old-commit-hash: a638afb98e
2022-11-11 23:11:49 -08:00
Shane Smiskol
dd6f16fcfd controlsd v_cruise: fix unknown buttons (#26474)
Fix button being None
old-commit-hash: d3f971b365
2022-11-11 20:10:12 -08:00
Shane Smiskol
0371e47fac controlsd: resume does not increment speed while cruise standstill (#25470)
* fix runaway set speed for GM

* fix runaway set speed for GM

* Handle resuming to exit standstill generically

* clean that up

* ugh i want to fix all the formatting

* class that manages v_cruise

* better name

* move around

* add depressed_state

* fine to update on pressed change, better name

* cmt

* we need to check CS. button_change_state only works if we exit standstill on rising edge not falling edge

* no defaultdict
old-commit-hash: 76ac3d4c99
2022-11-11 19:43:30 -08:00
Shane Smiskol
a7828e1ae3 controlsd: add cruise speed helper class (#26472)
* fix runaway set speed for GM

* fix runaway set speed for GM

* Handle resuming to exit standstill generically

* clean that up

* ugh i want to fix all the formatting

* class that manages v_cruise

* better name

* move around

* add depressed_state

* fine to update on pressed change, better name

* revert gm stuff

* revert standstill stuff

* remove

* revert that

* we can put this in here now!

* below update

* actually only used here

* one line
old-commit-hash: 811c096e64
2022-11-11 18:53:48 -08:00
Shane Smiskol
054cb1f8c1 Hyundai: fix button enable controls mismatch (#26471)
* bump panda

* buttonCancel needs to be a noEntry

* bompo

* Update ref_commit
old-commit-hash: 89b88fc7a2
2022-11-11 14:49:38 -08:00
Shane Smiskol
400b36a57f longitudinal tests: add disabled maneuver (#26470)
* undeclared variable

* run first second disabled

* only test

* test disabled as a new maneuver

* bottom
old-commit-hash: 9f80a97eee
2022-11-11 14:02:09 -08:00
Shane Smiskol
3fb09283a6 planner: fix undeclared variable (#26468)
* undeclared variable

* run first second disabled

* revert test

* rev
old-commit-hash: 98206fb92e
2022-11-11 13:22:56 -08:00
Harald Schäfer
dfd47a5f4d Add force decel to e2e long (#26448)
* add force decel to e2e

* Update longitudinal_planner.py
old-commit-hash: f23296bc87
2022-11-11 10:46:03 -05:00
Shane Smiskol
1ea7e49e8d controls: disengage on regen paddle independently (#26453)
* add regen braking field that's just used to add a pedalPressed

* bump

* bump

* Update ref_commit

* we want the standstill check

we want the standstill check

* see what diff is now

* Update ref_commit
old-commit-hash: 74b6e22a7d
2022-11-10 19:06:31 -08:00
YassineYousfi
b7b827bdd2 min lane change speed 20mph (#26434)
old-commit-hash: 7374080668
2022-11-09 22:04:57 -08:00
Adeeb Shihadeh
74979a7c76 experimental mode (#26416)
* experimental mode

* rename param

* red lights
old-commit-hash: 9a3f468051
2022-11-08 14:45:01 -08:00
Harald Schäfer
f86b44d516 E2e long model: calibrate model speed to wheel speed (#26395)
* calibrate!

* Fix test

* Fix proc replay

* check len

* get v_ego from model 8501d20-bb59-4193-aa82-82b2737dedd6/449 609d90f3-65e6-4617-a60c-d6d99eead408/700

* bump cereal

* initialize v_model_error

* typo

* better names

* cleanup

* bump cereal

* update model replay ref commit

* bump to cereal master

Co-authored-by: Yassine Yousfi <yyousfi1@binghamton.edu>
old-commit-hash: f63f0de80a
2022-11-07 17:49:36 -08:00
Vivek Aithal
3029919422 [torqued] Fix high speed oscillations (#26338)
* modify low speed factor during high speeds and rescale friction

* update refs
old-commit-hash: e9eb5d99ff
2022-11-07 17:01:24 -08:00
Harald Schäfer
f10cccb318 FCW: less false positives (#26366)
* Less FP for FCW

* enable fcw for e2e long
old-commit-hash: 253e5d7f9d
2022-11-06 12:17:07 -08:00
Harald Schäfer
e20020053d Longcontrol: faster transition from starting to stopping (#26361)
* Never command accel when stopping

* Update ref_commit
old-commit-hash: a7ced7c54b
2022-11-04 13:21:34 -07:00
Adeeb Shihadeh
8ec2fa1307 controlsd: steer in old preEnable state (#26269)
* controlsd: steer in old preEnable state

* bump panda

* bump panda

* Update ref_commit

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 6698cd4829
2022-10-27 20:53:15 -07:00
HaraldSchafer
dd03dbc344 Eliminate toyota close radar glitches causing no resume (#26272)
Eliminate toyota close radar glitches
old-commit-hash: f76a390daf
2022-10-27 17:31:15 -07:00
HaraldSchafer
48f4c8b701 No fcw when standstill (#26252)
old-commit-hash: b80f2efdf2
2022-10-26 14:53:01 -07:00
HaraldSchafer
742310271b Long control: add a_change cost in e2e mode (#26237)
Add e2e cost
old-commit-hash: dcde942d9f
2022-10-25 16:53:24 -07:00
Greg Hogan
92014b7dbe controlsd: update is_metric live (#26228)
* fix speed increment if units changed while driving

* don't recreate params

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 9091e737c8
2022-10-25 15:51:39 -07:00
HaraldSchafer
3b62f66008 Use same minimum speed for lateral planning and controls (#26177)
* Use same speed for lag adjustmenet

* One is a nicer number

* Update ref
old-commit-hash: 4f84b29985
2022-10-20 14:34:36 -07:00
Shane Smiskol
70249fae14 Rename gmAccFaultedTemp -> accFaultedTemp
old-commit-hash: b1efdab788
2022-10-19 01:31:12 -07:00
HaraldSchafer
9c26b70a43 Partial revert, lax torque control (#26146)
* Closer to original

* Update ref
old-commit-hash: 1548db8962
2022-10-18 21:25:06 -07:00
Shane Smiskol
6695cbf258 CAN-FD HKG: query FW versions from camera (#26063)
* add adas essential ecus

* add adas ecu and query

* add queries

* add name

* after

* presence of adas ecu

* Revert "presence of adas ecu" (POC)

This reverts commit ab88a7e7df32e1c02a175b81848bd4112b2e5c69.

* no whitelist for debugging

* Apply suggestions from code review

* add adas response

* remove adas version

* temp

* read pandaStates

* works in debug script

* only fwdCamera on tucson

* fix pandaStates reading

* fix test_startup

* fix

* simpler

* use existing socket

* pass in number of pandas

* need to create sm using outcome of fingerprinting, which uses sm

fix

* move default argument

* use sock

* always ignore

always ignore

* add canfd fingerprint test

* Update selfdrive/car/hyundai/tests/test_hyundai.py

* set
old-commit-hash: 7bf70bf7d8
2022-10-17 23:04:06 -07:00
Shane Smiskol
961c613005 GM camera ACC: prevent fault when engaging at a stop (#26079)
* prevent bolt fault

* comment

* only for camera ACC

* fixup alert

* bump cereal to master

* use new name

* Update selfdrive/car/gm/interface.py

* Update selfdrive/car/gm/interface.py

* Update selfdrive/car/gm/interface.py

* only care about prevent engagement when we look at PCM
old-commit-hash: 4e82f68de2
2022-10-14 22:21:53 -07:00
Shane Smiskol
4df9e825ae Use longActive for car-specific override signals (#26030)
* add override field to cruiseControl

* need to check if long *can* be active

* bump cereal to master

* revert

* better

* fix

* update refs

* rename variable
old-commit-hash: 7418678132
2022-10-11 16:27:46 -07:00
HaraldSchafer
f9b65f9189 Low speed lateral like before (#26022)
* Add explicit cost on steering wheel movement

* Laxer low speed control

* Laxer low speed control

* Lower min speed now there is a cost

* 3m/s

* Similar to old master

* Add cost

* Crazy high

* Update ref

* comment
old-commit-hash: 2c9b150761
2022-10-11 14:53:43 -07:00
HaraldSchafer
a13f2deeeb Increase low speed jerk cost (#26008)
* Increase low speed jerk cost

* Update planner weight

* Update ref_commit

* Update lateral_planner.py

* cleanup and refactor

* Update ref_commit
old-commit-hash: fb07437819
2022-10-07 19:15:04 -07:00
HaraldSchafer
3488569ac3 Divide by 0 bug fix lateral planner (#25995)
* Divide by speed correctly

* Update

* Update lateral_planner.py

* Update ref_commit
old-commit-hash: 1ecf6f351c
2022-10-07 00:16:18 -07:00
HaraldSchafer
a8ec6f4cfd Rocket Launcher Model (#25963)
* 1456d261-d232-4654-8885-4d9fde883894/440 6b7d7cec-ead8-40f3-86cc-86d52c9b03fe/300

* compute only 9 tokens: 1456d261-d232-4654-8885-4d9fde883894/440 6b7d7cec-ead8-40f3-86cc-86d52c9b03fe/300

* tinygrad: cleanup gather

* 1456d261-d232-4654-8885-4d9fde883894/440 6b7d7cec-ead8-40f3-86cc-86d52c9b03fe/700

* empty commit for tests

* bump tinygrad

* dont use tinygrad matmul for now

* bump tinygrad

* 1456d261-d232-4654-8885-4d9fde883894/440 e63ab895-2222-4abd-a9a5-af86bb70e260/700

* float16 1456d261-d232-4654-8885-4d9fde883894/440 e63ab895-2222-4abd-a9a5-af86bb70e260/700

* increase steer rate cost

* Revert "increase steer rate cost"

This reverts commit 74ce9ab9be7ef17ecfec931f96851b12f37f2336.

* fork tinygrad

* empty commit for tests

* basics

* Kinda works

* new lat

* new tuning

* Move LATMPCN so scons compiles

* Update long weights

* Add tinygrad optim

* Update model ref

* update weights

* Update ref

* Try

* Error message for field ignore

* update model regf

* ref commit

* Fix onnx test

Co-authored-by: Yassine Yousfi <yyousfi1@binghamton.edu>
old-commit-hash: cb0b7375b7
2022-10-05 21:43:38 -07:00
Adeeb Shihadeh
2a25b0ab83 fixup toggle cleanup
old-commit-hash: 300577f38f
2022-10-05 13:00:22 -07:00
HaraldSchafer
f25d434a01 Planner cleanup (#25969)
old-commit-hash: e5d2c3ce7a
2022-10-04 21:19:04 -07:00