Commit Graph

523 Commits

Author SHA1 Message Date
Shane Smiskol
6b6ac2bc67 Toyota: lower stopping speed (#26274)
* lower toyota stopping speed

* order

* Update selfdrive/car/toyota/interface.py

* Update ref_commit
old-commit-hash: ba7a474765
2022-12-10 02:25:16 -08:00
Shane Smiskol
ec9060c7ba CarController: log steer sent to the car (#26743)
* log value sent to the car

* rename

* bump

* Update ref_commit
old-commit-hash: f36a3664b0
2022-12-10 02:03:40 -08:00
Shane Smiskol
d1dee4625a controlsd: preEnable on brake at a standstill (#26273)
* pre-enable on brake at standstill

* test by getting rid of noTarget

* Update events.py

* rename

* stash what we got so far

* cmt

* not sure if best way to fix, but enabled with current states defs is fine

* no noEntry in preEnabled

* bumpcereal

* uncomment

* Update ref_commit

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: dbe512d167
2022-11-29 17:34:10 -08:00
Vivek Aithal
5bc529bf20 [controlsd] Toyota Prius 2017 (#26455)
* increase lag on prius

* better offline values computation

* split prius ecu more, set deadzone to 0

* add deadzone back

* replace deadzone with slack

* reduce deadzone to 0.2

* update refs
old-commit-hash: 0706b03e8c
2022-11-29 10:47:13 -08:00
Jason Young
0d2373312e VW MQB: Redundant brake pressed signals (#26401)
* VW MQB: Redundant brake pressed signals

* retry CI

* update refs

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 636ff5979f
2022-11-22 16:18:42 -08:00
Shane Smiskol
cf287d796b GM Cam: log when cruise not adaptive (#26581)
* bump opendbc

* log when nonAdaptive

* Update ref_commit
old-commit-hash: 9fdbe9f397
2022-11-22 15:18:10 -08:00
Harald Schäfer
beccaa2e76 More Honda rate limit (#26509)
* More Honda rate limit

* Update ref_commit
old-commit-hash: fbf3ef0895
2022-11-15 14:21:00 -08:00
Harald Schäfer
88135d52cb Rate limit honda steer (#26500)
* Rate limit honda steer

* Update ref_commit
old-commit-hash: e58f6fbc11
2022-11-15 00:46:47 -08:00
Shane Smiskol
74d58ab0d6 GM: match stock enabling behavior (#26442)
* add first draft enable button timeout

* use allow_enable

* it doesn't count if brakePressed

* enable on rising edge of resume (matches stock)

* not today

* add comment describing the fault this avoids

* cleaner

* handle incrementing speed

* rename

* add test for not changing speed if enabled changes mid-press

* spacey

* ugh

* bumpo

* need this to fix a fault (draft)

* already have

* this should be cancel

* fine to do for all

* fine to do for all

* bump

* bumpo

* bump to master

* Update selfdrive/car/gm/interface.py

* Update selfdrive/car/gm/interface.py

* Update ref_commit
old-commit-hash: 15383d3016
2022-11-13 21:13:46 -08:00
Shane Smiskol
a570984aa3 interfaces: disable on falling edge of cancel button (#26493)
* both

* Update ref_commit
old-commit-hash: ca37d0c8cc
2022-11-13 20:50:28 -08:00
Shane Smiskol
054cb1f8c1 Hyundai: fix button enable controls mismatch (#26471)
* bump panda

* buttonCancel needs to be a noEntry

* bompo

* Update ref_commit
old-commit-hash: 89b88fc7a2
2022-11-11 14:49:38 -08:00
Shane Smiskol
1ea7e49e8d controls: disengage on regen paddle independently (#26453)
* add regen braking field that's just used to add a pedalPressed

* bump

* bump

* Update ref_commit

* we want the standstill check

we want the standstill check

* see what diff is now

* Update ref_commit
old-commit-hash: 74b6e22a7d
2022-11-10 19:06:31 -08:00
Shane Smiskol
ab5e2b66e8 Toyota: factor on cluster speed to match dash (#26408)
* add a minimum factort

* Update ref_commit
old-commit-hash: e1001a3036
2022-11-09 18:27:30 -08:00
Shane Smiskol
54b089a56d GM Camera: use ECM brake pressed bit (#26400)
* GM camera: use ECM brake pressed bit

* bump panda and use more reliable bit

* bump panda

* back to ECMEngineStatus

* bump

* Update selfdrive/car/gm/carstate.py

* bump panda

* Update ref_commit
old-commit-hash: 191b8081b2
2022-11-08 20:52:35 -08:00
Shane Smiskol
f9c9b96e27 Toyota: add hysteresis to cluster speed (#26386)
* add hysteresis to cluster speed

* add minimum cluster scaling

* fix

* Update ref_commit
old-commit-hash: 52a644e656
2022-11-08 00:03:23 -08:00
Shane Smiskol
f36d799198 Hyundai: bump safety params (#26407)
* bump panda

* bump panda

* bump panda

* update refs

* bump panda

* bump panda
old-commit-hash: e971bb11c2
2022-11-07 22:14:47 -08:00
Vivek Aithal
3029919422 [torqued] Fix high speed oscillations (#26338)
* modify low speed factor during high speeds and rescale friction

* update refs
old-commit-hash: e9eb5d99ff
2022-11-07 17:01:24 -08:00
ZwX1616
cfa80ee10c DM: compensate for non-calibrated pitch spread (#26348)
old-commit-hash: 2837e73a70
2022-11-04 14:18:51 -07:00
Harald Schäfer
e20020053d Longcontrol: faster transition from starting to stopping (#26361)
* Never command accel when stopping

* Update ref_commit
old-commit-hash: a7ced7c54b
2022-11-04 13:21:34 -07:00
Vivek Aithal
8f6f406237 [paramsd] Prevent low speed drifting (#26360)
* lower active speed for paramsd observations

* update refs
old-commit-hash: 81f6ebebaa
2022-11-04 01:32:29 -07:00
Kurt Nistelberger
890f7ffd80 locationd: add gps sanity check for quectel gps (#26352)
* update check

* .

* .

* remove gps kf time check for gps ok

* upsi

* dont use gps_mode

* update refs

* Update selfdrive/locationd/locationd.cc

Co-authored-by: Shane Smiskol <shane@smiskol.com>

Co-authored-by: Kurt Nistelberger <kurt.nistelberger@gmail.com>
Co-authored-by: Cameron Clough <cameronjclough@gmail.com>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: aebb08e105
2022-11-03 23:43:30 -07:00
Shane Smiskol
da68ac1b66 car docs: auto-generate footnote for DSU cars (#26321)
* note for dsu cars

* don't hardcode dsu footnote (1/2)

* test

* revert the experimental long toggle

* another day:(

* DSU doesn't have to be toyota specific, it's a generic carParam!

* this is safe, just make sure it's unknown

* these cars do not have OP long for some reason

* UNSUPPORTED_DSU_CAR

* forgot this

* fix autoResume

* fix autoResume 2
old-commit-hash: 3e69973819
2022-11-03 01:00:33 -07:00
Shane Smiskol
6a7ce3a4d6 GM camera ACC: vision-only ACC behind toggle (#25631)
* put gm camera voacc behind disable radar toggle

* bump panda

* bump panda

* bump panda

* experimental long

* fixes

* car control notes and fixes for Bolt EUV

* might enable stop and go

* consistent name

* min enable speed seems to be around 5 kph

* camera acc can engage under 5 kph if stopped

* comment

* comment

* remove this for now

* only real brake

* comments

* update max brake

* bump

* clean up/fix

* same if

* simplify

* fix

* old comment

* no brake_pressed

* temporary fault fix

* tune longitudinal

* update docs

* bump panda

* GM camera ACC cars have no regen in ACC

* cleaner

* cleaner

* fix

* set max gas

* fixes

* fix LKAS unavailable warning from camera

* only camera

* bump panda

* bump panda

* bump panda

* bump panda

* clean up gmcan

* clean up CC

* flip

* rm

* rm comment

* clean up

* custom starting/stopping probably not needed

* Update selfdrive/car/gm/carcontroller.py

* fix crash

* long tuning

* we need long control state to resume

* CAMERA_ACC_CAR not needed

* no interp on accel

* tuning

* formatting

* formatting

* formatting

* formatting

* formatting

* no need to init ccp

* makes more sense now
old-commit-hash: 2fb7b4ffad
2022-11-02 02:46:29 -07:00
Shane Smiskol
a230015754 Toyota: unify deadzone params (#26325)
* i'm sure this makes no difference

* update refs
old-commit-hash: 423d16693a
2022-11-02 02:09:54 -07:00
Shane Smiskol
59090b598f GM: add longitudinal deadzone (#26323)
* add deadzone

* Update ref_commit
old-commit-hash: 0f6f305f2d
2022-11-02 01:58:15 -07:00
Jason Young
eb3d572add VW MQB: Fahrzeuglängsbeschleunigungssteuerungseinrichtung (#22963)
* can I kick it?

* bumpity bump bump

* bump panda

* everybody's gotta be special

* attempt at improving stopping/starting

* reduce lateral feedforward

* tweak gradient and comfort bands

* oops

* accel from the dept of redundancy dept

* bump opendbc

* jerk limiter not needed and causing problems

* don't leave stop/start flags hung when not enabled

* reduce comfort band with lead car

* borrow decel comp from HKG

* align stopping state thresholds

* (re)try letting PI clean up some of this

* bump panda

* tweaks and comments

* elide superfluous import

* VW MQB: Longitudinal prereqs

* gate this too

* bump CI

* cleanup

* more cleanup; require gateway integration

* don't run long state/actuators unless sending message

* setpoint visibility in instrument cluster

* show fixed lead car if lead visible

* hold my beer?

* tuning

* the code is darkest before the refactor

* a little more

* set freewheel and stop distance correctly

* rounding issue maybe?

* ACC_04 Charisma profiles and HUD alerts

* fix ACC_04 counter, fix gradient and accel bugs

* revert tuning change in upstream focused branch

* need 0.5m/s to leave

* reduced braking when not absolutely needed

* oops

* bump panda

* match opendbc to master

* filter ACC_13, disable secondary accel

* bump panda

* bump panda

* bump opendbc and panda

* startAccel is deprecated

* testing manual trans min engage speeds

* pass stock ACC type to TSK

* bump panda

* bump opendbc

* bump opendbc

* test hax for Brake alert

* remove ACC_13 with matching panda bump

* fix submodule refs

* update long control safety param name

* bump panda

* actuator delay corrected by Mk1 eyeball

* a little more

* tweak stop/start thresholds

* Revert "tweak stop/start thresholds"

This reverts commit 60abd57d2025c3218f069dbec4600c8d14033c05.

* more lag reduction

* bump opendbc

* support both analog and digital clusters

* tuning adjustments

* bump opendbc and panda

* accept two button types for resume

* support separate set and resume

* bump panda

* #24706

* partial revert 6b93ac27

* fixes

* one more

* refactor all the things

* follow experimental long refactor

* fill in ACC hud status

* temp force E2E availability

* start cleaning up

* comment touchup

* gimme some comfort baby

* experiment

* SnG me maybe?

* a little more rollout

* is this why I'm not leaving?

* turns out you need startAccel to leave

* try without ACC_04

* cleanup unused variables

* temp hack to standstill handling

* temp hack to button handling

* trim rollout distance with slower vEgoStopping

* ultra fat comfort band due to noisy E2E actuator

* I like big changes and I cannot lie

* remove lead car display for now

* cleanup, drives somewhat better

* partial FtS/basic support

* diff reduction

* not needed

* more cleanup

* oops

* more cleanup

* restore lead car visible for PQ

* bump panda

* better enable button solution

* redundant

* OP long on *all* the things

* OP long on all the things *sometimes*

* docs generator a little TOO clever

* solve starting-state a different way

* try that again

* bump panda

* oops

* follow DBC refactor

* retry CI

* signal name changed

* sync with custom enable button branch

* oops

* more follow refactor

* bump panda

* sync opendbc to master

* bump panda

* updated comments

* light P, no I

* bump panda

* bump panda again

* add openpilot long test_models route

* bump panda with replay route

* temporarily disable experimental long for merge

* bump panda to master

* resolve conflict?

* now can we go to head?

* explicit length check

* update refs

Co-authored-by: Comma Device <device@comma.ai>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: b31b031044
2022-11-01 10:00:26 -07:00
Adeeb Shihadeh
8f4338cef4 EV6 long tuning (#26166)
* some matching and jerk limit

* update that

* one jerk limit

* little more

* more jerk

* bump opendbc

* update refs
old-commit-hash: b727f6cff4
2022-10-31 08:37:05 -07:00
Adeeb Shihadeh
8ec2fa1307 controlsd: steer in old preEnable state (#26269)
* controlsd: steer in old preEnable state

* bump panda

* bump panda

* Update ref_commit

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 6698cd4829
2022-10-27 20:53:15 -07:00
Vivek Aithal
d843347126 [torqued] Update offline values (#26261)
* add qlog mode to torqued

* update offline valujes from qlogs

* resollve comments

* update refs

* resolve comments
old-commit-hash: b158c016cb
2022-10-27 16:34:11 -07:00
Shane Smiskol
e135d07018 process replay: test Bolt EUV (camera-ACC platform) (#26270)
ADD BOLT TO PROCESS REPLAY
old-commit-hash: 995c74a994
2022-10-27 14:36:47 -07:00
Vivek Aithal
5cfe86afa5 [torqued] Update offline values (#26243)
* update offline vals

* update refs
old-commit-hash: 03ebc3bff5
2022-10-26 11:45:21 -07:00
Adeeb Shihadeh
53c9b3c5cd Hyundai: CAN-FD blindspot signals (#26229)
* Hyundai: CAN-FD blindspot signals

* fix that

* update refs
old-commit-hash: 339253bc05
2022-10-25 13:51:23 -07:00
Shane Smiskol
ed9c040be9 GM: reduce LKAS faults while inactive (#26196)
* send at 10hz when inactive

* try to make it fine to switch rates

* fix rate

* todododo

* fine if we skip, we usually send too early

* clean up

* this may be required, 50Hz is not really needed to sync/initialize

* preserves previous behavior (not sure if this makes sense)

* Revert "preserves previous behavior (not sure if this makes sense)"

This reverts commit 3b297bca72307b5cba09bec4e2cd8e0f2761af42.

* Revert "this may be required, 50Hz is not really needed to sync/initialize"

This reverts commit a6b4693814214d3f508db922f3b371c402a13995.

* rm com

* Update ref_commit

* gate behind GM Cam

* common logic

* bet

* update refs
old-commit-hash: 27e315e58f
2022-10-25 00:12:49 -07:00
HaraldSchafer
89e6b69f05 Calibrationd: Calibrate wide from device (#26204)
* Use calibrator to stabilize wide transform

* Need array

* Needs init

* Needs to be arr

* publish mshg

* Check size

* Update ref

* fix calibration param read when no wide calib

* need self!
old-commit-hash: 15595fc859
2022-10-24 20:17:05 -07:00
Bruce Wayne
21bcfad5a7 Revert "Use calibrator to stabilize wide transform (#26201)"
This reverts commit 1827b3c9e2942240f65d03ec0f790c91aa9c00ee.

old-commit-hash: 75b7fd0a7d
2022-10-21 21:44:47 -07:00
HaraldSchafer
dfbb291ef2 Use calibrator to stabilize wide transform (#26201)
* Use calibrator to stabilize wide transform

* Need array

* Needs init

* Bump to master

* Needs to be arr

* publish mshg

* Check size

* Update ref
old-commit-hash: 42ef62e391
2022-10-21 20:30:48 -07:00
HaraldSchafer
3b62f66008 Use same minimum speed for lateral planning and controls (#26177)
* Use same speed for lag adjustmenet

* One is a nicer number

* Update ref
old-commit-hash: 4f84b29985
2022-10-20 14:34:36 -07:00
Adeeb Shihadeh
449fd1db18 Hyundai CAN-FD: use cruise signals from SCC ECU (#26171)
* Hyundai CAN-FD: use cruise signals from SCC ECU

* bump panda

* bumppanda

* update refs
old-commit-hash: eaedfb9a66
2022-10-19 23:31:24 -07:00
Shane Smiskol
b0f435e710 Hyundai HDA2 detection: use ADAS ECU (#26130)
* use adas ecu

* new route

* update refs

* new route

* update refs

* new test routes

* bump
old-commit-hash: f6416e7769
2022-10-19 14:21:03 -07:00
HaraldSchafer
9c26b70a43 Partial revert, lax torque control (#26146)
* Closer to original

* Update ref
old-commit-hash: 1548db8962
2022-10-18 21:25:06 -07:00
ZwX1616
426286f24f DM: add use of e2e preds (#26078)
* try ml

* de56

* j914ef75a

* jd1124586

* jd1124586

* d112

* oops

* set

* update ref

* use offset

* bump DM power usage

* new ref
old-commit-hash: d522492ba0
2022-10-17 19:40:06 -07:00
Shane Smiskol
82b6fe1c4c Fix refs
old-commit-hash: c0840e0c33
2022-10-14 16:50:07 -07:00
Shane Smiskol
87b9f41022 GM: remove brake scaling (#26080)
* Don't add a weird factor to ret.brake

* update refs
old-commit-hash: 5d00e5cc71
2022-10-14 15:53:24 -07:00
Adeeb Shihadeh
f6803bc8df Hyundai: share panda flags with CAN-FD platform (#26058)
* Hyundai: share panda flags with CAN-FD platform

* move that

* only set bit

* bump panda

* panda master

* regen + update refs for new param
old-commit-hash: c782380fc1
2022-10-12 21:54:08 -07:00
HaraldSchafer
eac9ec1570 locationd: Fix GPS sensor times with fixed offsets (#25920)
* Rewind to qcom time

* Fix test

* Typo

* init unix_time fix

* add gps sensor_time_offsets

* remove all clocks code and add todo

* :emove clocks in unit test

* update refs

* update refs

Co-authored-by: nuwandavek <vivekaithal44@gmail.com>
old-commit-hash: b332441803
2022-10-12 17:47:30 -07:00
Adeeb Shihadeh
026668b5f8 EV6 longitudinal (#26023)
* ev6 long

* update refs
old-commit-hash: 3c0904a18f
2022-10-12 14:22:40 -07:00
Shane Smiskol
6a92eb5a7a GM camera ACC: reduce LKAS faults on startup (#26039)
* GM camera ACC: no faults on start up 2.0

And by 2.0 I mean we don't need to wait for blocked msg support to be merged first to merge this without regressing accidental single blocked msg count handling.

* Send the camera counter + 1

* Keep updating the first counter until we get a message on the bus

* Only update right before sending so sent_lka_steering_cmd is updated first

* Update ref_commit
old-commit-hash: 0f94d81b7a
2022-10-11 22:33:37 -07:00
Shane Smiskol
4df9e825ae Use longActive for car-specific override signals (#26030)
* add override field to cruiseControl

* need to check if long *can* be active

* bump cereal to master

* revert

* better

* fix

* update refs

* rename variable
old-commit-hash: 7418678132
2022-10-11 16:27:46 -07:00
HaraldSchafer
f9b65f9189 Low speed lateral like before (#26022)
* Add explicit cost on steering wheel movement

* Laxer low speed control

* Laxer low speed control

* Lower min speed now there is a cost

* 3m/s

* Similar to old master

* Add cost

* Crazy high

* Update ref

* comment
old-commit-hash: 2c9b150761
2022-10-11 14:53:43 -07:00
HaraldSchafer
a13f2deeeb Increase low speed jerk cost (#26008)
* Increase low speed jerk cost

* Update planner weight

* Update ref_commit

* Update lateral_planner.py

* cleanup and refactor

* Update ref_commit
old-commit-hash: fb07437819
2022-10-07 19:15:04 -07:00