Commit Graph

13133 Commits

Author SHA1 Message Date
Dean Lee
55446438ab scons: remove Wno-error=unused-but-set-variable (#33355)
remove Wno-error=unused-but-set-variable
2024-08-22 10:53:17 -07:00
Dean Lee
13e58d33db drive_helpers.py: iterate button_timers with items() (#33351)
iterate button_timers with items()
2024-08-21 11:03:55 -07:00
Shane Smiskol
7af3c6dfee move some car interface tests into opendbc (#33352)
* bump

* this is in opendbc

* so is radar interface

* clean up

* bump

* can import from opendbc

* bump
2024-08-21 00:30:06 -07:00
Shane Smiskol
d8c9822421 ui: fix wrong path color indexing (#33350)
* fix

* clean up

* clean up

* clean up
2024-08-20 20:49:30 -07:00
Shane Smiskol
fe51a2fc62 move test_lateral_limits.py to opendbc 2024-08-20 15:42:25 -07:00
commaci-public
c013d8aa94 [bot] Update Python packages (#33347)
Update Python packages

Co-authored-by: Vehicle Researcher <user@comma.ai>
2024-08-20 15:28:41 -07:00
Shane Smiskol
be8485ca89 update car docs in weekly repo maintenance (#33345)
* does this work?

* fix

* fix

* what
2024-08-20 15:28:28 -07:00
Dean Lee
b644555a1d SubMaster: add self.services attribute for consistent service management (#33268)
simplify service handing
2024-08-19 16:56:57 -07:00
Dean Lee
b14fca78e0 cereal/SubMaster: encapsulate frequency management in FrequencyTracker (#33252)
* encapsulate frequency management

* apply reviews

* early return, avoiding unnecessary calculations

* simplify avg freq calc
2024-08-19 16:53:13 -07:00
Adeeb Shihadeh
7b5f76ecf9 research -> autonomy 2024-08-19 16:11:20 -07:00
commaci-public
9b2cafe597 [bot] Update Python packages (#33327)
* Update Python packages

* fix opendbc

---------

Co-authored-by: Vehicle Researcher <user@comma.ai>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2024-08-19 15:25:05 -07:00
Shane Smiskol
2a7c6bc8bd fix labeler syntax 2024-08-19 14:45:55 -07:00
Shane Smiskol
799539320d Remove car labeler (#33329)
* can?

* car still makes sense

* bump

* opendbc

* ?

* bump

* revert
2024-08-19 14:45:02 -07:00
Alexandre Nobuharu Sato
7a40c97068 Update what-is-a-car-port.md (#33323) 2024-08-19 14:28:13 -07:00
Shane Smiskol
ee9977df2f card: fix memory leak from nested function scoping (#33328)
* stash

* no other leaks! pm.send grows memory usage by ~20mb but that's it

* undo

* clean up
2024-08-19 14:27:50 -07:00
Adeeb Shihadeh
08f64ae30a update test 2024-08-19 14:19:12 -07:00
Andrei Radulescu
ba098f509b agnos updater: set decompress max_length (#33320)
* agnos: decompress max_length

* flash last chunk after eof

* don't decompress more than length

* cleanup

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2024-08-17 16:31:22 -07:00
Sameh Mohamed
542f3d1b44 Cleaning up README for tools directory (#33322)
cleaning up readme

Co-authored-by: Sameh <Sameh Mohamed>
2024-08-17 15:37:06 -07:00
Shane Smiskol
e735a7f379 move selfdrive/car to opendbc (#32630)
* move most of /car

* move some car tests

move some car tests

* fix selfdrive/car/tests

* fix selfdrive/controls tests

* fix the rest of the selfdrive tests

* bump opendbc

* fix all tests

* few more non-test references

* remove opcar and move docs to car

fix these debugging scripts

fix docs

* bump opendbc and panda

forgot panda
2024-08-17 00:54:51 -07:00
Shane Smiskol
bf68eeb596 remove import linter (#33319)
* rm import linter, we're done!

* revert

* uv lock

* Revert "uv lock"

This reverts commit 5e46f48e8a5738ea5121da6f2d1c7210dcefe053.
2024-08-16 23:57:42 -07:00
Shane Smiskol
1eda5f4736 car: move conversions.py into common/ 2024-08-16 15:53:37 -07:00
Shane Smiskol
6a15c42143 selfdrive/car: ban cereal and capnp (#33208)
* ban cereal and msgq

* common too

* do toyota/values.py

* do all fingerprints

* example without builder

* this still works, but no type checking anymore

* stash

* wtf, how does this work

* okay actually not bad

* safe

* epic!

* stash data_structures.py

* some clean up

* hell yeah

* clean up old file

* add to delete

* delete

This reverts commit 90239b7797ace31ee647a2fdbd67e0c3faa98dcf.

* switch more CarParams stuff over

remove unused

* fix car tests by removing cereal! mypy forgets about dataclass if we wrap it :(

* fix this too

* fix this too

* remove more cereal and add some good hyundai tests

* bunch more typing

* override default with 20hz radar

* temp capnp converter helper

* more lateralTuning

* small union replicator is better than what i was trying, and fixes mypy dynamic typing issues

* can keep all this the same now!

* type ret: CarParams, add more missing structs, revert lateralTuning changes (smaller diff!)

* revert more

* get first enum automatically, but ofc mypy doesn't pick up the new metaclass so can't use :(

would have been `CarParams.NetworkLocation()`

* Revert "get first enum automatically, but ofc mypy doesn't pick up the new metaclass so can't use :("

This reverts commit bb28b228becba932052d2fc5a4389784027435b1.

* remove cereal from car_helpers (TODO: caching)

* remove a bunch of temp lines

* use dataclass_transform!

* remove some car.CarParams from the interfaces

* remove rest of car.CarParams from the interfaces

* same which() API

* sort

* from cereal/cache from fingerprinting!

* more typing

* dataclass to capnp helper for CarParams, cached it since it's kinda slow

* (partial) fix process replay fingerprintig for new API

* latcontrollers take capnp

* forgot this

* fix test_models

* fix unit tests

* not here

* VehicleModel and controller still takes capnp CP since they get it from Params()

* fix modeld test

* more fix

* need to namespace to structs, since CarState is both class and struct

* this was never in the base class?!

* clean that up again

* fix import error

fix import error

* cmts and more structs

* remove some more cereal from toyota + convert CarState to capnp

* bruh this was wrong

* replace more cereal

* EventName is one of the last things...

* replace a bunch more cereal.car

* missing imports

* more

* can fix this typing now

* proper toyota+others CS typing!

* mypy can detect return type of CS.update() now

* fix redeclaration of cruise_buttons type

* mypy is only complaining about events now

* temp fix

* add carControl struct

* replace CarControl

i hope there's no circular imports in hyundai's CC

* fine now

* lol this was wrong too

* fix crash

* include my failed attempts at recursively converting to dataclass (doesn't implicitly convert types/recursively :( )

but attrs does, maybe will switch in the future

* clean up

* try out attr.s for its converter (doesn't work recursively yet, but interesting!)

* Revert "try out attr.s for its converter (doesn't work recursively yet, but interesting!)"

This reverts commit ff2434f7bbd45a4d4bfb21f7d6712d1f1c3bcde9.

* test processes doesn't fail anymore (on toyota)!

* fix honda crash

* stash

* Revert "stash"

This reverts commit c1762af4e776790e4ad1322ad4ce0610157346e0.

* remove a bunch more cereal!

* LET'S GOOO

* fix these tests

* and these

* and that

* stash, something is wrong with hyundai enable

* Revert "stash, something is wrong with hyundai enable"

This reverts commit 39cf327def258e2959fe23cd7a550a858f6d8f03.

* forgot these

* remove cereal from fw_versions

* Revert "remove cereal from fw_versions"

This reverts commit 232b37cd409b55d04b1afc90d4a80c49e710eb56.

* remove rest of the cereal exceptions!

* fix that

* add typing to radard since I didn't realize RI.update() switched from cereal to structs

* and here too!

* add TODO for slots

* needed CS to be capnp, fix comparisons, and type hint car_specific so it's easier to catch type issues (capnp isn't detected by mypy :( )

* remove the struct converter

* save ~4-5% CPU at 100hz, we don't modify after so no need to deepcopy

btw pickle.loads(pickle.dumps()) is faster by ~1% CPU

* deepcopy -> copy: we can technically make a reference, but copy is almost free and less error-prone

saves ~1% CPU

* add non-copying asdict function

* should save ~3% CPU (still 4% above baseline)

* fix that, no dict support

* ~27% decrease in time for 20k iterations on 3X (3.37857 -> 2.4821s)

* give a better name

* fix

* dont support none, capitalize

* sheesh, this called type() on every field

* remove CS.events, clean up

* bump card %

* this was a bug on master!

* add a which enum

* default to pid

* revert

* update refs

* not needed, but consistent

* just Ecu

* don't need to do this in this pr

* clean up

* no cast

* consistent typing

* rm

* fix

* can do this if we're desperate for the last few %

* Revert "can do this if we're desperate for the last few %"

This reverts commit 18e11ac7883a0a56583750b1cc5a2b13011e7299.

* type this

* don't need to convert carControl

* i guess don't support set either

* fix CP type hint

* simplify that
2024-08-16 15:13:00 -07:00
Kacper Rączy
51fae363e4 paramsd: remove usages of llk nested structures (#33317)
* Remove usages of llk nested structures

* Rename to debugFitlerState

* Semicolon

* Initial parameters debugFilterState
2024-08-16 14:25:42 -07:00
Adeeb Shihadeh
4baf6c1be9 rerun: update to 0.18 (#33316) 2024-08-16 10:46:26 -07:00
Shane Smiskol
e6b2996478 test_fw_fingerprint.py: fix RAM HD test 2024-08-16 01:00:26 -07:00
Shane Smiskol
a255b8043a ecu_addrs.py: fix function argument typing 2024-08-16 00:58:53 -07:00
Shane Smiskol
c9f9eba614 card: fix return signature for update_events 2024-08-16 00:56:31 -07:00
Shane Smiskol
6a5bbb261e fw_versions.py: mark raw in f-string 2024-08-16 00:38:28 -07:00
Shane Smiskol
c2ab62c2b2 radard: remove redundant NoneType check 2024-08-16 00:37:31 -07:00
Shane Smiskol
207c77ea93 hyundai: test some feature detection (#33315)
test some feature detection
2024-08-16 00:30:11 -07:00
Shane Smiskol
bce11e393f hyundai: declare type override of cruise_buttons 2024-08-16 00:26:40 -07:00
Shane Smiskol
f6780fca2f toyota: pycapnp enum which should be called 2024-08-16 00:18:37 -07:00
Shane Smiskol
b41f9f2dfe run_process_on_route.py: use zstd 2024-08-16 00:08:17 -07:00
Adeeb Shihadeh
72b5c6f61a jenkins: remove unused pcStage 2024-08-15 22:23:37 -07:00
Shane Smiskol
d43bf89978 GM: remove basedir import (#33312)
* remove these exceptions

* whoop

* ahhh
2024-08-14 22:55:17 -07:00
Maxime Desroches
3e9b91a2ac setup.sh: fix macOS path specification (#33311)
realpath and mac
2024-08-14 21:49:32 -07:00
Shane Smiskol
424b657376 docs: remove common import (#33310)
* add opcar

* fix references

* actually better to split this so opendbc will test docs conventions, and openpilot will test diffing

* not exe

* clean up
2024-08-14 20:29:14 -07:00
Shane Smiskol
9d0180ca97 body: remove controls import (#33309)
* body uses car's PIDController

* use a simple version
2024-08-14 20:27:53 -07:00
Shane Smiskol
2ed567b0f5 move live fingerprint debugging code to debug/car (#33308)
* remove cereal from fw_versions

* fix it

* do ecu_addrs and vin

* do last one

* move executable-ness

* notexe

* nice test
2024-08-14 19:24:24 -07:00
Shane Smiskol
bcfb50d98c Copy kalman filter to selfdrive/car (#33307)
move to car/common/ and give proper names
2024-08-14 18:10:11 -07:00
Maxime Desroches
f118d17659 op.sh: categorize commands (#33305)
names
2024-08-14 16:51:14 -07:00
Kacper Rączy
c61d504516 ui: remove GPS status from the sidebar (#33304)
* Remove usage of llk in ui

* Remove GPS from sidebar

* Remove it from test
2024-08-14 15:52:47 -07:00
Maxime Desroches
406939b9c0 replace python with python3 (#33303)
3
2024-08-14 15:14:31 -07:00
Shane Smiskol
b9dec5e3b5 rm tesla (#33300)
* rm tesla

* more rm

* ugh we should remove dynamic imports soon
2024-08-14 15:06:00 -07:00
Maxime Desroches
2bc5d2b635 retry uv with cache (#33297)
try uv with cache
2024-08-14 12:11:39 -07:00
Maxime Desroches
585f362738 lint.sh: better shebang lint (#33296)
-e
2024-08-14 11:34:52 -07:00
Shane Smiskol
7248b00086 Common CI._update function (#33289)
* use CP

* no car control, consistent _update function signatures

* eh it's fine to name it whatever

* clean up

* oops

* !!

* now we can delete this!

* nobody does anymore
2024-08-13 22:59:25 -07:00
Shane Smiskol
cb61d0045c card: set mock carState fields (#33294)
* mock carstate inside card

* not used
2024-08-13 22:48:55 -07:00
Shane Smiskol
9f14c447db Move buttonEvents to CarState (#33292)
* move mazda button events to carstate

* do  more

* remove

* some more

* clean up
2024-08-13 22:30:46 -07:00
Shane Smiskol
29882b4519 Consistent spacing in car interfaces (#33293)
* formatting

* fix these

* not these
2024-08-13 22:08:48 -07:00