Commit Graph

1004 Commits

Author SHA1 Message Date
Shane Smiskol
cffc14e4d8 map: fix exit lane direction when active (#29159)
* fix

* clean up

* comment
2023-08-05 04:02:18 -07:00
Dean Lee
da91555056 ui/OnroadWindow: do not update state when offroad (#29134)
do not updateState when offroad
2023-07-31 20:25:15 -07:00
Shane Smiskol
6fe480b232 Experimental mode toggle description: missing spaces (#29167)
* Update settings.cc

* more missing spaces

* scons

* vanish

* fix that
2023-07-27 14:00:41 -07:00
Adeeb Shihadeh
0922a1040f ui: less confusing wifi training (#29137)
* ui: less confusing wifi training

* update

* cleanup

---------

Co-authored-by: Comma Device <device@comma.ai>
2023-07-25 13:32:00 -07:00
Harald Schäfer
9c3c7f0dda Experimental mode description: update nav (#29130)
* Update description

* Update releases

* Update RELEASES.md

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update selfdrive/ui/qt/offroad/settings.cc

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* small tweaks

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2023-07-25 10:31:25 -07:00
Shane Smiskol
412ed6a017 navd: don't use empty last step banner instructions (#29034)
* fix empty banner instructions when arriving at destination

* bug fixes

* hide distance on arrival

* stash

* simpler

* can also do this, but i don't like modifying the response

* clean up

* rm

* revert

* rm

* flip this order

* move up

* need to flip order

* Revert "need to flip order"

This reverts commit ba961b8e6aa5d9490ab0dc661866cff9c72db91d.

* Revert "move up"

This reverts commit f1a4d8ae883080d52547fdaf9472457050e40669.

* Update selfdrive/navd/navd.py
2023-07-25 01:28:17 -07:00
Shane Smiskol
0dd1dcc7d0 ui: new nav settings button (#29068)
* add image

* remove extra spacing

* add images

* use nav-settings-square-smaller.png

* draft

* clean up

* kinda works!

* nop need to update state

* can just use clicked

* MORE

* remove old button

* slightly smaller (todo change image))

* this works but is ugly

* remove old settings button

* draft

* no it's not

* draft 2.0

* clean up

* clean up

* let's make map_settings_btn public

* since we don't have map, use enabled

* fix image size

* can do clean up in another PR

show

* add line

* rename

* useless spacing

* use old nav icon

* handle DM icon (and test)

* clean up

* no reason

* remove old image

* don't use setCurrentIndex

* Revert "don't use setCurrentIndex"

This reverts commit 6fde765a3cd3a9ee39205614587a23fbfbc60950.

* also can use a ternary

* seems cleanest

This reverts commit f9287230704b94f46b6bb5376d9a17075a20caf7.
2023-07-24 22:27:01 -07:00
Shane Smiskol
13dc0325b2 ui/map: hide settings with showing map (#29127)
consistent map showing behavior
2023-07-24 18:25:46 -07:00
Dean Lee
bcfb9d6940 ui/settings: use existing params instance (#29109)
use exsting params
2023-07-23 17:45:19 -07:00
Dean Lee
980ba1312f ui/map: remove unused variables (#29098) 2023-07-22 12:24:16 -07:00
Dean Lee
cc551fe24b ui/MapSettings: remove function shorten (#29078) 2023-07-21 19:51:25 +01:00
Shane Smiskol
d70c4916db nav: improve no route alert text (#29076)
* kind of

* Revert "kind of"

This reverts commit 25abbbf1764b0f7e8fbcb83e37159ba6f8cdf641.

* more generic alert text, whenever we're waiting for navd.

* actual better comment

* update translations
2023-07-20 22:40:31 -07:00
Dean Lee
0b8d35b132 ui/map: fix ETA widget text spacing (#29065)
* fix eta spacing

* fix unit color

---------

Co-authored-by: Justin Newberry <jnewberry0502@gmail.com>
2023-07-20 21:10:17 -07:00
Shane Smiskol
e4dc86f44d ui: set global map transition duration (#29061)
* this works!

* revert properties

* more clean up

* more

* more

* add comment

* final
2023-07-20 16:11:23 -07:00
Dean Lee
942a2f9760 ui/map: move MapInstructions & MapETA to separate files (#28976) 2023-07-20 21:58:46 +01:00
Shane Smiskol
5b368a67ea nav: show warning for routing problems (#29055)
* all my debugging stuff

* this works

* add comment

* bb navd

* navInstruction is valid when we get a non-empty route response

* now don't need this

* stash

* big cleanup

* clean up

* clean up

* debug

* final clean up

* one line

* flip order

* update translations

* is this simpler?
2023-07-20 04:01:55 -07:00
Shane Smiskol
d0ea8be95f nav: set icon anchor for destination pin (#29054)
* anchor!

* whoops

* fix anchor
2023-07-20 01:28:21 -07:00
Mitchell Goff
ba03e94290 nav: draw destination pin on top of navigation path (#29050)
* Draw destination pin on top of navigation path

* fix draw ordering

fix draw ordering

* add todo

* rename to feature

* draft

* clean up

* testing

* testing 2

* Revert "testing 2"

This reverts commit fc236aafbc14bbdc5ddb52fb56265302247ddf4b.

* Revert "testing"

This reverts commit 982a508ad701268ebdae910980fd5464454f44a8.

* clean up

* add todo

* show!

* Update selfdrive/ui/qt/maps/map.cc

* lgtm

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-07-20 00:54:42 -07:00
Dean Lee
4584e883dc ui/networking: call isTetheringEnabled out of the loop (#29028) 2023-07-19 12:28:44 +01:00
Shane Smiskol
7a673c87ff nav: show green path when enabled (#29020)
* draft

* draft

* clean up

* clean up

* cleaner

* needs to be here to work

* or this works

* works too

* stash

* clean up qdebugs

* revert to master

* reapply changes

add bool

* consistent cmts

* clean up

* can be simpler combined

* clean up/fix
2023-07-18 15:52:59 -07:00
Shane Smiskol
0bea1419e3 ui: change last reference to experimental longitudinal (#29009)
* change experimental longitudinal language to alpha

* vanish

* Update selfdrive/ui/qt/offroad/settings.cc

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* update translations

* vanish

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2023-07-17 21:33:06 -07:00
Shane Smiskol
358a86b636 nav: show when using navigate on openpilot (#28958)
* draft

* clean up

* helper

* comment

* debug

* Revert "debug"

This reverts commit d30ff3e996e73818e14f28b51afed206337bf6da.

* nav path

* transition

* revert width transition

revert width transition

* 400 is better, hard to see flicker at 500

* add width back

* tune

* tune

* 12 might be good

* 400ms is good

* lower case company lcc

* up here

* up here

* clean up

* multiple lines

* self explanetory
2023-07-17 21:28:10 -07:00
Shane Smiskol
6bc28fc769 experimental mode: gate nav (#29007)
* first draft copy, needs updates

* gate behind exp mode

* can be one line

* this is no longer true

* toggle isn't just e2e long now, rename

* don't enable/disable

* kinda works!

* remove old giant qstring

* comment clean up

* similar breakpoint

* more clean up

* fixup onroad

* preserve planner behavior, and we don't need to look at confirmed param if we're onroad

* update translations

* vanish translations

* use scene for op long

* lowercase!

* updated copy

* need to check longitudinal here now too

* clean up!

* here is better

* used

* no nav emoji

* don't check param if not valid

* revert this

revert this

* ed

* revert experimental mode longitudinal checks (still need to revert toggle change)

* revert

* logic works

* revert test

* fix

* update translation

* fix (reset and update)
2023-07-17 21:18:18 -07:00
Shane Smiskol
6e50706baa ui: rename experimental mode toggle variable 2023-07-17 20:38:38 -07:00
Shane Smiskol
b5b431c12d Revert "experimental mode: gate navigate on openpilot (#28883)" (#29005)
This reverts commit f973d605b2.
2023-07-17 19:56:38 -07:00
Dean Lee
1afdca2ef1 ui/MapSettings: remove call to clearLayout (#28961) 2023-07-17 15:32:28 +01:00
Dean Lee
d47d8808d1 ui/map: update destination on param change (#28957)
* update destination on param change

* use ParamWatcher

* remove include
2023-07-16 13:48:33 -07:00
Dean Lee
b4f7e76531 ui/util: add a helper class ParamWatcher (#28978)
* new class ParamWatcher

* Update selfdrive/ui/qt/util.cc

* Update selfdrive/ui/qt/util.h

* Update selfdrive/ui/qt/util.cc

* Update selfdrive/ui/qt/util.cc

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2023-07-16 13:17:16 -07:00
Dean Lee
53934c7fee ui/map: fix wrong remaining time (#28960) 2023-07-15 13:28:21 +01:00
Dean Lee
187696977e ui/MapSettings: store destinations to load on widget init (#28950)
Co-authored-by: Cameron Clough <cameronjclough@gmail.com>
2023-07-15 11:37:41 +01:00
Dean Lee
e958ce1c31 ui: set max brightness when showing the QR code (#28907)
* set max brightness when showing the QR code

* set brightness in ui

* set in device
2023-07-14 12:22:35 -07:00
Dean Lee
ccfca97dfc ui/map: cache navigation images at startup (#28783)
Co-authored-by: Cameron Clough <cameronjclough@gmail.com>
2023-07-14 20:18:49 +01:00
Shane Smiskol
f973d605b2 experimental mode: gate navigate on openpilot (#28883)
* first draft copy, needs updates

* gate behind exp mode

* can be one line

* this is no longer true

* toggle isn't just e2e long now, rename

* don't enable/disable

* kinda works!

* remove old giant qstring

* comment clean up

* similar breakpoint

* more clean up

* fixup onroad

* preserve planner behavior, and we don't need to look at confirmed param if we're onroad

* update translations

* vanish translations

* use scene for op long

* lowercase!

* updated copy

* need to check longitudinal here now too

* clean up!

* here is better

* used

* no nav emoji

* don't check param if not valid

* revert this

revert this

* ed
2023-07-14 05:26:59 -07:00
Shane Smiskol
936bfcd7ba ui: use stencil buffer to draw polygons (#28902)
* Update ui.cc

* add a bunch of debugging stuff i don't want to lose

* Revert "add a bunch of debugging stuff i don't want to lose"

This reverts commit 2de6ab5b68bc528e913db68f7fe576b6ebe89a9b.

* enable stencil buffer

* lower ui CPU usage

* Revert "lower ui CPU usage"

This reverts commit 650241c0d89c1476de3995f1dc3f87f671dd1dd7.
2023-07-13 20:38:49 -07:00
Dean Lee
c3fe3c8162 ui/MapSettings: sort location JsonArray inplace (#28886) 2023-07-13 10:59:46 +01:00
Shane Smiskol
daf80eaef5 map panel: show map on interactive timeout (#28904)
Co-authored-by: Cameron Clough <cameronjclough@gmail.com>
2023-07-13 10:35:57 +01:00
Dean Lee
ae4a375dd6 ui/map: handle & display error in MapWindow (#28854) 2023-07-13 10:26:58 +01:00
Shane Smiskol
b8dd4dcc28 ui: singleton Device instance (#28908)
* singleton

* remove awake
2023-07-12 18:36:44 -07:00
Shane Smiskol
d68bd905fc ui: fix timeout typo (#28905)
tim is out -> timeout
2023-07-12 13:09:42 -07:00
Shane Smiskol
c158537df6 ui: reset nav status on offroad transition (#28897)
* need to do this

* actually better to clear it on offroad transition, then onroad transition will be fine
2023-07-11 19:04:41 -07:00
Shane Smiskol
34a5e626d6 ui: show map with nav (#28867)
* accept touch events in map settings

* draft

* draft 2.0

* revert this stuff

* need this

* fix

* clean up debug prints

* fraft

* only show map on closeSettings if nav

* works!

* can't do it here

* I was going to connect signals from UIState to HomeWindow, then to OnroadWidget, but that seems like too much

* just need to keep track of it in onroad, seems like the cleanest option

* ideally we show the map where we set the scene variable, and that's in map.cc

* old variable

* comments

* less confusing

* app comment

* add back

* fix

* move to top

* remove this comment
2023-07-11 14:49:19 -07:00
Cameron Clough
6643616c47 nav: hide settings on map request visible (#28884) 2023-07-11 21:40:33 +01:00
Cameron Clough
4d61d680b2 UI: preserve recent destinations sort order (#28881) 2023-07-11 12:39:06 +01:00
Dean Lee
8149c07fac ui/map: singleton navigation requests (#28862) 2023-07-11 11:42:10 +01:00
Dean Lee
d34138e275 ui: capnp best practices (#28877) 2023-07-11 10:26:57 +01:00
Dean Lee
4544b40b70 ui/map: don't clear eta when map is hidden (#28878) 2023-07-11 10:23:45 +01:00
Shane Smiskol
305ab3cb3e ui: don't hide sidebar twice (#28868)
* draft

* draft 2

* comment and clean up

* delete

* better name

* even better?
2023-07-11 00:58:28 -07:00
Shane Smiskol
28df811f42 ui: remove unused MapPanel function (#28874)
forgot about this
2023-07-11 00:46:59 -07:00
Shane Smiskol
71e001ee57 map settings: accept touch events (#28865)
* accept touch events in map settings

* use override

* revert this

* remove debug stuff

* add comments

* not the main purpose
2023-07-11 00:21:25 -07:00
mitchellgoffpc
1690cf4af6 Revert "UI: Indicate when Nav on OP is enabled (#28665)"
This reverts commit a66135665c.
2023-07-10 13:52:55 -07:00