build test files by default (#25515)

* build test files by default

* only on master based

.github/workflows/selfdrive_tests.yaml

@@ -74,11 +74,11 @@ jobs:
       with:
         save-cache: true
     - name: Build openpilot with all flags
-      run: ${{ env.RUN }} "scons -j$(nproc) --extras --test && release/check-dirty.sh"
+      run: ${{ env.RUN }} "scons -j$(nproc) --extras && release/check-dirty.sh"
     - name: Cleanup scons cache
       run: |
           ${{ env.RUN }} "rm -rf /tmp/scons_cache/* && \
-                          scons -j$(nproc) --extras --test --cache-populate"
+                          scons -j$(nproc) --extras --cache-populate"
 
   #build_mac:
   #  name: build macos
@@ -225,7 +225,7 @@ jobs:
     - name: Run unit tests
       run: |
         ${{ env.RUN }} "export SKIP_LONG_TESTS=1 && \
-                        scons -j$(nproc) --test && \
+                        scons -j$(nproc) && \
                         $UNIT_TEST common && \
                         $UNIT_TEST opendbc/can && \
                         $UNIT_TEST selfdrive/boardd && \
@@ -356,7 +356,7 @@ jobs:
         key: car_models-${{ hashFiles('selfdrive/car/tests/test_models.py', 'selfdrive/car/tests/routes.py') }}-${{ matrix.job }}
     - name: Test car models
       run: |
-        ${{ env.RUN }} "scons -j$(nproc) --test && \
+        ${{ env.RUN }} "scons -j$(nproc) && \
                         coverage run -m pytest selfdrive/car/tests/test_models.py && \
                         coverage xml && \
                         chmod -R 777 /tmp/comma_download_cache"

SConstruct

@@ -10,10 +10,6 @@ AGNOS = TICI
 
 Decider('MD5-timestamp')
 
-AddOption('--test',
-          action='store_true',
-          help='build test files')
-
 AddOption('--extras',
           action='store_true',
           help='build misc extras, like setup and installer files')
@@ -53,6 +49,12 @@ AddOption('--no-thneed',
           dest='no_thneed',
           help='avoid using thneed')
 
+AddOption('--no-test',
+          action='store_false',
+          dest='test',
+          default=os.path.isfile(Dir('#laika_repo').abspath),
+          help='skip building test files')
+
 real_arch = arch = subprocess.check_output(["uname", "-m"], encoding='utf8').rstrip()
 if platform.system() == "Darwin":
   arch = "Darwin"