Commit Graph

351 Commits

Author SHA1 Message Date
Maxime Desroches
ed831773ea misra21.15 (#2030)
* cast

* remove suppression

* make it more explicit
2024-09-19 10:35:11 -07:00
Shane Smiskol
8587ae3fc0 drivers: log can core reset when switching multiplexing (#1972)
fdcan: log lost tx messages when resetting can core for multiplexing
2024-08-26 17:56:46 -07:00
Robbe Derks
080e53f04d Cuatro fan (#1999)
* cuatro fan debugging

* fix

* faster fan, faster interrupts

* fix comment

---------

Co-authored-by: Comma Device <device@comma.ai>
2024-08-18 17:43:27 -07:00
dzid26
588d4e0950 remove void return (#1963) 2024-05-30 14:21:42 -07:00
dzid26
6ff6733ba3 Cppcheck 2.14 (#1951)
* enable cppcheck 2.14

* cppcheck: Uninitialized variable

* cppcheck: variableScope

* cppcheck: misra-c2012-21.16
both arguments to memcmp() should be of compatible (matching) essential types

* cppcheck: misra-c2012-11.6
Avoid casting between pointer to void and an arithmetic type.
Refactor bootloader address casting for easier understanding.

* cppecheck 2.14.1
- force cppecheck tag fetch
2024-05-27 21:21:13 -07:00
Adeeb Shihadeh
cade0d5e75 SPI: add test endpoint for arbitrary lengths (#1949)
Co-authored-by: Comma Device <device@comma.ai>
2024-05-16 19:36:40 -07:00
Adeeb Shihadeh
2b70e283c1 tres: lower SOM reset timeout (#1945)
* tres: lower SOM reset timeout

* update test
2024-05-03 14:03:54 -07:00
Adeeb Shihadeh
714642ec9a Remove WebUSB popup (#1932) 2024-04-17 10:15:40 -07:00
Adeeb Shihadeh
01c54d1199 enable misra-c2012-11.8 (#1916)
* fix up harness_config definition

* enable misra-c2012-11.8
2024-03-24 12:38:25 -07:00
Adeeb Shihadeh
418fca3583 enable misra-config checks (#1879)
* mostly done

* fix rest of misra-config

* do other two in next pr
2024-03-24 12:10:37 -07:00
Adeeb Shihadeh
dcc7b84001 UID_BASE is always defined now 2024-03-24 10:59:51 -07:00
Adeeb Shihadeh
dd82382d5f instant boot (#1910)
no more boot time :P
2024-03-22 14:01:44 -07:00
Adeeb Shihadeh
091773f448 Adjust CAN bus orientation live with harness orientation (#1913)
* set orientation in one place

* no flip

* cleanup

* more explict on startup

---------

Co-authored-by: Comma Device <device@comma.ai>
2024-03-22 14:00:13 -07:00
Adeeb Shihadeh
de061e4f73 remove rest of gmlan (#1908)
* remove rest of gmlan

* fix

* update struct

* update
2024-03-21 13:56:36 -07:00
Adeeb Shihadeh
6dfd4db4ab remove rtc (#1897)
* remove rtc

* fix build

* rm taht

* revert that
2024-03-11 16:08:43 -07:00
Aryan
4303ae1387 enable misra-c2012-10.6 (#1811)
* misra-c2012-10.6

* fixed uninitialized data error

* revert false positive

* enable 10.6

* update install.sh

* cleanup

* bug fix

* better fix ?
2024-02-27 10:32:28 -08:00
Jason Young
96a3099398 fix forwarded bus logging for CAN-FD hardware (#1884) 2024-02-24 10:03:45 -08:00
Aryan
b4442a7c93 enable misra-c2012-10.3 (#1852)
* enable misra-c2012-10.3

* fix that

* cleanup

* little more

* one more

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2024-02-18 11:56:44 -08:00
Adeeb Shihadeh
6eed036473 (almost) enable cppcheck unusedFunction (#1875)
* remove some unused

* more

* kinda works

* rest are false positives

* disable for now

* add back exhaustive
2024-02-17 14:16:15 -08:00
Adeeb Shihadeh
c076a9f2f6 remove pedal fw (#1872)
* remove pedal fw

* little more

* one more

* and tests

* rest of it

* little more

* fix linter

* more fix
2024-02-16 22:58:01 -08:00
Aryan
54459e694e update cppcheck (#1859)
* update cppcheck

* Update tests/misra/install.sh

* delete cppcheck cache

* remove misra 5.8 erroors

* fixed uninitialized data error

* suppress misra-c2012-2.3 and misra-c2012-2.4

* reinstate cache to fix mutation test

* rerun for mutation test

* increase timeout for mutation test

* styling

* comments + variable name changes

* Update tests/misra/install.sh

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update install.sh

* more variable name changes

* condition on defining CANPacket_t

* just cherry pick

* fix build

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2024-02-10 14:50:36 -08:00
dzid26
32301a855a USB-C cable orientation clarification (#1860) 2024-02-08 22:33:26 -08:00
Adeeb Shihadeh
93a06f1257 remove HW GMLAN support (#1848) 2024-02-03 23:18:33 -08:00
Ruben Medina
40671436ee enable misra-constParameterPointer (#1826) 2024-01-20 21:50:42 -08:00
Adeeb Shihadeh
424882e0e7 enable knownConditionTrueFalse in cppcheck 2024-01-20 16:34:40 -08:00
Ruben Medina
229e8bb3a5 enable misra-c2012-12.2 (#1824)
* enable misra-c2012-12.2

* refactor: use 1UL in all FAULT defs
2024-01-20 16:19:34 -08:00
Aryan
a902a19ead enable misra-c2012-21.2 (#1819)
* enable misra-c2012-21.2

* Add suppressions on memset and memcpy

* revert that

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2024-01-18 14:29:01 -08:00
Ruben Medina
5ddc0cf04f enable misra-c2012-21.14 (#1810) 2024-01-18 14:10:17 -08:00
Ruben Medina
7ab3fcf5d2 enable misra-c2012-10.7 (#1804)
* enable misra-c2012-10.7

* cleanup

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2024-01-16 16:52:36 -08:00
Aryan
369fd8c6d5 enable misra-c2012-7.2 (#1807)
* misra-c2012-7.2

* removed misra-c2012-7.2 from suppressions.txt
2024-01-16 15:49:13 -08:00
Ruben Medina
8c2b50fa2f enable misra-c2012-10.1 (#1803) 2024-01-15 21:14:52 -08:00
Aryan
6ae65db44a enable misra-c2012-5.8 (#1800) 2024-01-15 10:38:46 -08:00
Hoang Bui
817d68f6a6 enable misra-c2012-10.4 (#1796)
* enable misrac-10.4

* changes

* cleaner
2024-01-13 15:49:56 -08:00
Adeeb Shihadeh
f64ba24685 enable misra-c2012-2.2 2024-01-09 22:03:28 -08:00
Adeeb Shihadeh
dc1fd96118 Revert "H7: fix GMLAN bitbang timer (#1542)" (#1745)
This reverts commit 5778c0ae5d.
2023-11-24 16:00:18 -08:00
Adeeb Shihadeh
666a462450 remove low level LIN support (#1744) 2023-11-23 17:18:25 -08:00
Adeeb Shihadeh
4c0d2505b7 remove k-line driver (#1743) 2023-11-23 17:09:10 -08:00
Adeeb Shihadeh
a1d699b87d SOM boot recovery (#1712)
* reset

* simpler

* only once per panda boot

* cleanup

* also check serial
2023-11-09 18:01:46 -08:00
Adeeb Shihadeh
d2ea9ad293 refactor bootkick (#1690)
* bootkick refactor + reset

* simplify

* revert reset stuff

* cleanup

---------

Co-authored-by: Bruce Wayne <batman@comma.ai>
2023-11-08 22:54:55 -08:00
Igor Biletskyy
5778c0ae5d H7: fix GMLAN bitbang timer (#1542)
* init

* move Adeeb's test

* bitbang expected to fail can_health
2023-10-03 13:14:14 -07:00
Adeeb Shihadeh
b6e37f25b6 Remove flash logging (#1674)
* Revert "Disable flash logging (#1667)"

This reverts commit 62db60595b.

* Revert "Faster log retrieval (#1484)"

This reverts commit 694aae9c26.

* Revert "Flash bounds checking outside of bootstub (#1459)"

This reverts commit 054344de6b.

* Revert "Logging (#1445)"

This reverts commit 0cc91a7f7b.

* cleanup

* cleanup
2023-09-30 12:49:46 -07:00
Adeeb Shihadeh
62db60595b Disable flash logging (#1667)
* disable logging to flash

* update tests

* fix hitl
2023-09-21 15:28:19 -07:00
Shane Smiskol
546087125f GM: change ignition signal (#1662)
* GM: change ignition signal

* Update board/drivers/can_common.h
2023-09-15 02:04:51 -07:00
Igor Biletskyy
394b61cd16 H7: reset CAN core on bus off state (#1615)
* init

* misra

* merge
2023-09-06 09:50:13 -07:00
Igor Biletskyy
3efa31a804 F4: fix GMLAN clocks (#1624)
* init

* misra
2023-08-31 09:55:12 -07:00
Igor Biletksyy
d41a0abef6 H7: comments for RAM organization reasoning 2023-08-29 16:10:50 -07:00
Igor Biletskyy
91d457cbb1 H7: reorganize RAM (#1619)
init
2023-08-29 13:04:27 -07:00
Igor Biletskyy
0a32b17513 H7: few more Kb of RAM found (#1605)
* init

* remove discard
2023-08-24 16:56:31 -07:00
Igor Biletskyy
b47b8259ef unify CAN/FDCAN odjects naming (#1596)
* init

* happy MISRA
2023-08-21 16:09:31 -07:00
Adeeb Shihadeh
33a95d6bea pedal: fix warning on invalid serial (#1563)
* pedal: fix warning on invalid serial

* fix

* fix:

* shouldn't need that

* fix

---------

Co-authored-by: Bruce Wayne <batman@comma.ai>
2023-08-06 13:47:37 -07:00