Riccardo
c597dcc897
VERSION update after health packet changes and minor misra test change
2019-07-12 12:04:21 -07:00
rbiasini
01072bec0b
Misra 11.x: pointer usage. ( #250 )
...
* RDLR, RDHR gone from safety
* back at not failing misra safety
* fix safety tests
* did not mean this
* Use get-bytes in pedal too
* Ignore Misra 11.5 and Fix 11.8 violaitons
* Fix 11.3 violations
* Neglect Misra 11.4, fix pointer issue in bootstub and rutn on Werror for pedal builds
* Fix Misra 11.6: can't assign number to void pointer
* Fix test after changing honda_moving name
* for loop is better
* Fix bugs from fbck
2019-07-10 20:56:03 -07:00
rbiasini
fd68c26aba
Propagate can_push errors ( #249 )
...
* Misra 17.7: counting can_push errors
2019-07-10 17:27:26 -07:00
Riccardo
ce1daf2062
Misra check only done for EON config
2019-07-10 12:02:50 -07:00
Testing closet
70d4fd7f64
cleanup docker container on failure
2019-07-10 10:19:44 -07:00
Riccardo
04756a037f
Turning back Misra check: unvoluntarily change
2019-07-09 16:18:44 -07:00
George Hotz
fcb1208e15
fix weird code in USB_ReadPacket
2019-07-09 15:08:25 -07:00
Riccardo
b983cc8fe6
Re-wrote test_misra.sh
2019-07-09 14:37:26 -07:00
Riccardo
0b19206360
Misra 17.7: The value returned by a function having non-void return type shall be used. We should hang on initial failed safety_set_mode
2019-07-08 20:08:53 -07:00
Riccardo
06ee8bd2d2
Ignore Misra 5.4 until cppcheck bug (?) is fixed
2019-07-08 19:30:58 -07:00
Riccardo
4be858224f
Update cppcheck commit and pass predefined params to avoid impossible combinations of configs
2019-07-08 18:20:00 -07:00
Riccardo
f45dd04c67
cppcheck: ignore redundantAssignment and selfAssignment for registers in llcan.h
2019-07-08 17:16:15 -07:00
Riccardo
9ce6311558
Misra 12.1 (operator order) and 10.4 (incompatible essential types) fixes, arised after properly checking UID_BASE config
2019-07-08 15:51:20 -07:00
Riccardo
1cd34e5645
Explicitly set the define and undefine for unknown configs in misra checks
2019-07-08 15:32:55 -07:00
Adeeb Shihadeh
5a024999dc
remove esp flash from run_automated_tests.sh
2019-07-08 15:17:45 -07:00
rbiasini
23e3684d70
Cppcheck unused functions ( #247 )
...
* Skip cppcheck on unused functions that are consumed in large headers we can't pass to cppcheck
2019-07-08 15:13:52 -07:00
Riccardo
c97d60be64
Removed bad language
2019-07-08 12:05:08 -07:00
Riccardo
b031480a7f
Missed adding Dockerfile
2019-07-08 12:03:13 -07:00
Riccardo
91ff6bb214
Run language checker in CI
2019-07-08 12:01:00 -07:00
Riccardo
205ec342ad
Improved language checker
2019-07-08 01:00:14 -07:00
Riccardo
f7bbab0723
Language checker test
2019-07-08 00:50:32 -07:00
Riccardo
d9d0a62f2b
Misra 5.5: missed this change from previous PR
2019-07-07 22:22:05 -07:00
rbiasini
85fa3c02ae
Misra 5.5: Identifiers shall be distinct from macro names ( #246 )
...
* Misra 5.5: Identifiers shall be distinct from macro names
2019-07-07 22:19:02 -07:00
Riccardo
190d604a0b
Pedal: 2 minor fixes to Misra 15.7 (else needed) and 17.7 (non-void output must be used)
2019-07-07 22:07:14 -07:00
Riccardo
8ea01ff127
Pedal: no built-in functions to avoid puts and putc re-definitions
2019-07-07 21:38:40 -07:00
rbiasini
1f40d1e6a6
Misra pedal ( #245 )
...
* Fix misra on pedal
2019-07-07 16:59:31 -07:00
Riccardo
a4554e3e69
Ignore advisory Misra 19.2: the union keyword should not be used
2019-07-07 16:31:06 -07:00
Riccardo
e6dc4172b1
Minor indent error
2019-07-07 15:57:14 -07:00
Riccardo
247e128b45
Fix strict compiler on bootstub build
2019-07-07 15:05:47 -07:00
Riccardo
ba68569216
Removed build strict test and enabled -Werror flag
2019-07-07 14:46:03 -07:00
Adeeb Shihadeh
da11f0fa0c
safety replay: update openpilot-tools after logreader fix
2019-07-05 16:31:21 -07:00
Riccardo
fc8b9e49bd
Cppcheck: also check pedal
2019-07-04 02:58:17 -07:00
rbiasini
f7bd2c2f38
Misra 10.4: fix last 2 violations ( #242 )
2019-07-04 02:27:21 -07:00
rbiasini
9be5fdead9
finished misra 17.8 ( #241 )
2019-07-04 01:37:26 -07:00
rbiasini
3c3aba3dbc
Misra 10.4: Both operands of an operator in which the usual arithmetic conversions are performed shall have the same essential type category ( #240 )
...
* Almost done with 10.4, a couple of non-obvious violations remaining
2019-07-04 01:04:58 -07:00
Riccardo
f2a3a177b3
Misra 15_7: fix what seems to be a false positive of cppcheck
2019-07-03 20:53:00 -07:00
rbiasini
812ace5386
Misra 15_7: if … else if constructs should be terminated with an else clause ( #230 )
...
* Fixed all Misra 15_7 violations
2019-07-03 20:48:02 -07:00
Adeeb Shihadeh
79e9735ae1
rename 5_wifi_udp.py
2019-07-03 20:02:53 -07:00
quillford
3c3ff0c03b
Update Jenkinsfile ( #239 )
2019-07-03 19:47:41 -07:00
rbiasini
1bd9284372
Misra 17.7: the value returned by a function having non-void return shall be used ( #237 )
...
* Fixed Misra 17.7 violations except for can_push
2019-07-03 16:01:01 -07:00
George Hotz
18c9e88bc0
Merge pull request #238 from commaai/misra_17_8
...
Misra 17.8: a function parameter should not be modified
2019-07-03 13:36:49 -07:00
George Hotz
7ac321de4e
Merge pull request #235 from commaai/memxxx
...
memxxx function changes to be Misra compliant
2019-07-03 13:35:49 -07:00
Adeeb Shihadeh
004e543cc2
Jenkins: run EON test first
2019-07-03 11:09:49 -07:00
Adeeb Shihadeh
4bff286205
Merge branch 'memxxx' of github.com:commaai/panda into memxxx
2019-07-03 11:03:11 -07:00
Riccardo
7cd80de23a
typo
2019-07-03 02:07:02 -07:00
Riccardo
385e33b32c
12.1 regression
2019-07-03 02:04:25 -07:00
Riccardo
955842bae6
WIP
2019-07-03 01:59:27 -07:00
rbiasini
ea908cbb75
10_1 violations: Operands shall not be of an inappropriate essential type ( #233 )
...
* 10_1 violations
2019-07-02 23:43:06 -07:00
rbiasini
fa33038055
Fix Misra 5.3: An identifier declared in an inner scope shall not hide an identifier declared in an outer scope ( #236 )
...
* Fix Misra 5.3
2019-07-02 22:39:00 -07:00
Riccardo
ebfe1c512f
Merge branch 'master' of github.com:commaai/panda into memxxx
2019-07-02 21:45:23 -07:00
