Files
opendbc-meb/opendbc/safety/tests/test_volkswagen_mlb.py
Jason Young dd629a7e9c VW MLB: Porsche Macan (dashcam mode) (#2846)
* add DBC

* add platform definition data

* carstate checkpoint

* checkpoint carcontroller/mlbcan/interface

* checkpoint safety and safety test

* PEBCAK

* checkpoint various fixes

* fixes

* more fixes

* Blinkmodi_01 is genuinely on-demand only, add a fixme

* get turn signal state from a less annoying source

* add @Bentley's route for dev/test only

* gearshift position

* cleanup

* auto_fingerprint e8dac44d3a3458a5/00000000--9b83a227ce

* smooth move, ex-lax

* Kombi_01 COUNTER isn't real, at least not universal

* use lat accel torque controller

* checkpoint refactor

* Revert "always CANFD"

This reverts commit ac6122e272.

* auto_fingerprint 3a4f7c559c2f1215/00000001--5dc72af277

* add the VIN just to be sure

* auto_fingerprint a3bd1cb95d7c2f97/00000082--dbb4d37c0d

* she's a quick one

* more torque

* use different turn state signal

* slight reduction in ramp-up rate for jerk limit safety

* fix HCA status handling

* FINE

* add seatbelt signal

* enable door states

* Revert "use different turn state signal"

This reverts commit fb334567544d1adbeb71289310356e3ddcba17c6.

* use turn stalk helper to handle one-touch lane changes

* derp

* more friction

* a little more SR

* cleanup test routes

* reduce whitespace diff

* unnecessary for now

* dashcam

* cleanup

* Reapply "always CANFD"

This reverts commit 38e304f898107f16d963c976b3ef79978eb49e1d.

* VW: Safety code cleanup

* not yet

* consolidate ESP_05 for MQB

* retry CI after pinning pycapnp

* DRY not worth it here

* a little more DRY

* convert another single-bit read to GET_BIT

* separate MLB checksum handling, add XOR support

* XOR checksum support for LS_01

* shared message handling for LH_EPS_03 and LWI_01

* selective signal pass-through for LS_01

* add note for later consolidation

* consolidate create_lka_hud_control, unpretty but works

* XOR checksum support for TSK_05

* add TODO

* try it out

* good enough for who it's for
2025-11-10 00:24:36 -05:00

142 lines
5.7 KiB
Python
Executable File

#!/usr/bin/env python3
import unittest
from opendbc.car.structs import CarParams
from opendbc.safety.tests.libsafety import libsafety_py
import opendbc.safety.tests.common as common
from opendbc.safety.tests.common import CANPackerSafety
MSG_LH_EPS_03 = 0x9F # RX from EPS, for driver steering torque
MSG_ESP_03 = 0x103 # RX from ABS, for wheel speeds
MSG_MOTOR_03 = 0x105 # RX from ECU, for driver throttle input and driver brake input
MSG_ESP_05 = 0x106 # RX from ABS, for brake light state
MSG_LS_01 = 0x10B # TX by OP, ACC control buttons for cancel/resume
MSG_TSK_02 = 0x10C # RX from ECU, for ACC status from drivetrain coordinator
MSG_HCA_01 = 0x126 # TX by OP, Heading Control Assist steering torque
MSG_LDW_02 = 0x397 # TX by OP, Lane line recognition and text alerts
class TestVolkswagenMlbSafetyBase(common.CarSafetyTest, common.DriverTorqueSteeringSafetyTest):
RELAY_MALFUNCTION_ADDRS = {0: (MSG_HCA_01, MSG_LDW_02)}
MAX_RATE_UP = 9
MAX_RATE_DOWN = 10
MAX_TORQUE_LOOKUP = [0], [300]
MAX_RT_DELTA = 169
DRIVER_TORQUE_ALLOWANCE = 60
DRIVER_TORQUE_FACTOR = 3
# Wheel speeds _esp_03_msg
def _speed_msg(self, speed):
values = {"ESP_%s_Radgeschw" % s: speed for s in ["HL", "HR", "VL", "VR"]}
return self.packer.make_can_msg_safety("ESP_03", 0, values)
# Driver brake pressure over threshold
def _esp_05_msg(self, brake):
values = {"ESP_Fahrer_bremst": brake}
return self.packer.make_can_msg_safety("ESP_05", 0, values)
# Brake pedal switch
def _motor_03_msg(self, brake_signal=False, gas_signal=0):
values = {
"MO_Fahrer_bremst": brake_signal,
"MO_Fahrpedalrohwert_01": gas_signal,
}
return self.packer.make_can_msg_safety("Motor_03", 0, values)
def _user_brake_msg(self, brake):
return self._motor_03_msg(brake_signal=brake)
def _user_gas_msg(self, gas):
return self._motor_03_msg(gas_signal=gas)
# ACC engagement status
def _tsk_status_msg(self, enable, main_switch=True):
values = {"ACC_Status_ACC": 1 if not main_switch else 3 if enable else 2}
return self.packer.make_can_msg_safety("ACC_05", 2, values)
def _pcm_status_msg(self, enable):
return self._tsk_status_msg(enable)
# Driver steering input torque
def _torque_driver_msg(self, torque):
values = {"EPS_Lenkmoment": abs(torque), "EPS_VZ_Lenkmoment": torque < 0}
return self.packer.make_can_msg_safety("LH_EPS_03", 0, values)
# openpilot steering output torque
def _torque_cmd_msg(self, torque, steer_req=1):
values = {"HCA_01_LM_Offset": abs(torque),
"HCA_01_LM_OffSign": torque < 0,
"HCA_01_Sendestatus": steer_req,
"HCA_01_Status_HCA": 7 if steer_req else 3}
return self.packer.make_can_msg_safety("HCA_01", 0, values)
# Cruise control buttons
def _ls_01_msg(self, cancel=0, resume=0, _set=0, bus=2):
values = {"LS_Abbrechen": cancel, "LS_Tip_Setzen": _set, "LS_Tip_Wiederaufnahme": resume}
return self.packer.make_can_msg_safety("LS_01", bus, values)
# Verify brake_pressed is true if either the switch or pressure threshold signals are true
def test_redundant_brake_signals(self):
test_combinations = [(True, True, True), (True, True, False), (True, False, True), (False, False, False)]
for brake_pressed, motor_03_signal, esp_05_signal in test_combinations:
self._rx(self._motor_03_msg(brake_signal=False))
self._rx(self._esp_05_msg(False))
self.assertFalse(self.safety.get_brake_pressed_prev())
self._rx(self._motor_03_msg(brake_signal=motor_03_signal))
self._rx(self._esp_05_msg(esp_05_signal))
self.assertEqual(brake_pressed, self.safety.get_brake_pressed_prev(),
f"expected {brake_pressed=} with {motor_03_signal=} and {esp_05_signal=}")
def test_torque_measurements(self):
# TODO: make this test work with all cars
self._rx(self._torque_driver_msg(50))
self._rx(self._torque_driver_msg(-50))
self._rx(self._torque_driver_msg(0))
self._rx(self._torque_driver_msg(0))
self._rx(self._torque_driver_msg(0))
self._rx(self._torque_driver_msg(0))
self.assertEqual(-50, self.safety.get_torque_driver_min())
self.assertEqual(50, self.safety.get_torque_driver_max())
self._rx(self._torque_driver_msg(0))
self.assertEqual(0, self.safety.get_torque_driver_max())
self.assertEqual(-50, self.safety.get_torque_driver_min())
self._rx(self._torque_driver_msg(0))
self.assertEqual(0, self.safety.get_torque_driver_max())
self.assertEqual(0, self.safety.get_torque_driver_min())
class TestVolkswagenMlbStockSafety(TestVolkswagenMlbSafetyBase):
TX_MSGS = [[MSG_HCA_01, 0], [MSG_LDW_02, 0], [MSG_LS_01, 0], [MSG_LS_01, 2]]
FWD_BLACKLISTED_ADDRS = {2: [MSG_HCA_01, MSG_LDW_02]}
FWD_BUS_LOOKUP = {0: 2, 2: 0}
def setUp(self):
self.packer = CANPackerSafety("vw_mlb")
self.safety = libsafety_py.libsafety
self.safety.set_safety_hooks(CarParams.SafetyModel.volkswagenMlb, 0)
self.safety.init_tests()
def test_spam_cancel_safety_check(self):
self.safety.set_controls_allowed(0)
self.assertTrue(self._tx(self._ls_01_msg(cancel=1)))
self.assertFalse(self._tx(self._ls_01_msg(resume=1)))
self.assertFalse(self._tx(self._ls_01_msg(_set=1)))
# do not block resume if we are engaged already
self.safety.set_controls_allowed(1)
self.assertTrue(self._tx(self._ls_01_msg(resume=1)))
def test_cancel_button(self):
# Disable on rising edge of cancel button
self._rx(self._tsk_status_msg(False, main_switch=True))
self.safety.set_controls_allowed(1)
self._rx(self._ls_01_msg(cancel=True, bus=0))
self.assertFalse(self.safety.get_controls_allowed(), "controls allowed after cancel")
if __name__ == "__main__":
unittest.main()