* fix
* clearer
* cleanup
* more fix
* hkg dbc
* typo!
* Add Custom MIT License (#26)
* missed
* better
* more fixes
* try this out
* inherit in carcontroller properly
* hyundai: main button handling
* always disable
* add main check for pcm cruise
* revert
* sunnyParams
* Move car-specific changes to opendbc
* no need
* more fixes
* more!
* final?
* static analysis
* use new cereal
* rename to lkas_button
* rename
* mads base for cars
* add lkas for ford
* enabled <-> active
* MUST REMOVE test process replay
* Revert "MUST REMOVE test process replay"
This reverts commit 6dde2c8435b0e09158ab455aa215a573f5212c11.
* subaru
* ruff
* more subaru
* toyota
* add them
* mypy
* fix
* update name
* FCA
* assign directly
* init directly
* missing
* not yet
* missed
* no longer needed
* missed hd
* fix
* move to generator
* more nissan
* Apply suggestions from code review
* no need
* Revert "no need"
This reverts commit 6156c62113d9abb626014947a9066b5580f6460a.
* hyundai: move main logic out of main carstate
* move around
* move lkas and lfa icon logic to mads base
* Parse more flags from alt exp, more tests, hyundai main cruise allowed
* license
* add code spell ignore
* fix icon
* remove toyota lta status for lkas, causes weird behaviors
* parse signals inside mads methods
* more codes in mads childs
* Update opendbc/sunnypilot/car/hyundai/escc.py
* revert
* type hint
* test type hint
* more type hint
* no
* needs to be in carstate
* in another PR
---------
Co-authored-by: Jason Wen <haibin.wen3@gmail.com>
* local changes
* keep ki the same, clean up
* same line
* clean up
* error correct on future aEgo
* Revert "error correct on future aEgo"
This reverts commit 2332106c829161fedf3a6e8a61244c6fd3ad9069.
* flip
---------
Co-authored-by: Comma Device <device@comma.ai>
* Refactor ACC commands for better modularity
Split `create_acc_commands` into smaller helper functions to improve readability and maintainability. Each helper function now handles the creation of specific message values and checksum calculations, making the code more modular and easier to manage.
* Bringing ESCC
* Remove SP_DEBUG dependency from escc as its not currently used
* Add unit tests for Hyundai ESCC and ESCC Base classes
Introduced comprehensive test cases for ESCC and ESCC Base classes within the Hyundai car implementation. These tests include validating message IDs, enabled flag handling, and refreshing car state functionalities. The goal is to ensure robust and accurate behavior of the ESCC-related features.
* Refactor ESCC interfaces for improved modularity.
Moved and integrated ESCC base classes into a new `escc_interfaces` module. Updated existing code to reflect these changes and removed redundant ESCC state base class.
* Don't try to disable radar ECU if it's ESCC
* Reorder HyundaiFlagsSP bit flags to avoid conflicts.
Updated the bit flags in HyundaiFlagsSP to be in reverse order to prevent conflicts with existing CarParams from OP. This ensures no overlap and maintains code clarity and functionality.
* Update Hyundai carcontroller for ESCC and adjust SP flags
Added ESCC parameter to `create_acc_opt` call for enhanced support in Hyundai. Also realigned Sunnypilot flags to prevent conflicts with existing definitions and arranged for proper bit allocation.
* Refactor flag handling in ESCC and introduce sunnyParams
Refactored ESCC flag handling to use sunnyParams for clarity and better structure. Updated related tests and configurations to align with the new sunnyParams structure. Also, added the sunnyParams definition to car.capnp.
* Refactor Hyundai flags for consistency
Reorganized Hyundai flag values to avoid conflicts and improve readability. Reduced power values for each flag to simplify the flag structure and ensure unique identifiers for each feature.
* Refactor Hyundai flag definitions
Updated HyundaiFlagsSP class to include documentation for special flags used within sunnypilot. The flag definitions were moved to bitwise shift notation for clarity and consistency, ensuring ease of extension up to 32 flags.
* Update opendbc/car/hyundai/interface.py
* Apply suggestions from code review
* Remove ESCC base and interfaces classes
Consolidated ESCC functionalities directly into the Hyundai ESCC module, removing redundant base and interface classes. This simplified the class structure and improved code maintainability.
* Removing hints because they were causing a circular dependency
* sunnyParams -> sunnypilotCarParams
* slight cleanup
* CarStateSP (shared in other PRs)
* Revert "CarStateSP (shared in other PRs)"
This reverts commit b4298d3472470adfd5cbd3b163a6b5030dbc06cc.
* rename
* EsccCarController
* fix
* more cleanup
* hyundaican cleanup
* rename
* Fixing inconsistencies thanks to the tests!
* fixing imports after rename
* And more fixes
* Adding __init__.py thanks to one of the tests
* Updating to the new flags ordinal on cereal
* Reverting some of the misc changes, clarifying naming and passing the scc12 and fca11 values to the methods as they are defined out of order
* undoing more naming changes to simplify diff
* More naming and tiny adjustments
* use constant for msg id
* house keeping
* how you like that
* more
* unused
* final
* how did we forget xD
* already added
* keep stock barely touched
* circular
* Apply suggestions from code review
* split escc from radar interface
* fix
* add TODO-SP
* unused
* fix init
* revert
* rename
* always use true radar tracks if available
* update comment
---------
Co-authored-by: Jason Wen <haibin.wen3@gmail.com>
* Hyundai CAN: Longitudinal support for Camera SCC cars
* fix OP long checking fcw/aeb
* can error
* cleanup
---------
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>