Commit Graph

1535 Commits

Author SHA1 Message Date
DevTekVE
5d399457c8 Modular Assistive Driving System (MADS) (#29)
* fix

* clearer

* cleanup

* more fix

* hkg dbc

* typo!

* Add Custom MIT License (#26)

* missed

* better

* more fixes

* try this out

* inherit in carcontroller properly

* hyundai: main button handling

* always disable

* add main check for pcm cruise

* revert

* sunnyParams

* Move car-specific changes to opendbc

* no need

* more fixes

* more!

* final?

* static analysis

* use new cereal

* rename to lkas_button

* rename

* mads base for cars

* add lkas for ford

* enabled <-> active

* MUST REMOVE test process replay

* Revert "MUST REMOVE test process replay"

This reverts commit 6dde2c8435b0e09158ab455aa215a573f5212c11.

* subaru

* ruff

* more subaru

* toyota

* add them

* mypy

* fix

* update name

* FCA

* assign directly

* init directly

* missing

* not yet

* missed

* no longer needed

* missed hd

* fix

* move to generator

* more nissan

* Apply suggestions from code review

* no need

* Revert "no need"

This reverts commit 6156c62113d9abb626014947a9066b5580f6460a.

* hyundai: move main logic out of main carstate

* move around

* move lkas and lfa icon logic to mads base

* Parse more flags from alt exp, more tests, hyundai main cruise allowed

* license

* add code spell ignore

* fix icon

* remove toyota lta status for lkas, causes weird behaviors

* parse signals inside mads methods

* more codes in mads childs

* Update opendbc/sunnypilot/car/hyundai/escc.py

* revert

* type hint

* test type hint

* more type hint

* no

* needs to be in carstate

* in another PR

---------

Co-authored-by: Jason Wen <haibin.wen3@gmail.com>
2024-12-16 09:33:18 +01:00
Jason Wen
378967043d Chrysler: Add LKAS and Traction Buttons to DBC (#41) 2024-12-11 12:29:20 -05:00
Jason Wen
8cc9020578 Sync: commaai/opendbc:master into sunnypilot/opendbc:master-new 2024-12-08 19:39:07 -05:00
Jason Wen
668e3b488c Merge branch 'upstream/master' into sync-20241208 2024-12-08 19:33:30 -05:00
Shane Smiskol
cc30feb6fb Toyota: fix future aEgo calculation (#1562)
Update carcontroller.py
2024-12-07 04:53:46 -06:00
Shane Smiskol
a0b0b06ed7 Toyota: remove PCM compensation (#1560)
* remove toyota PCM compensation

* clean up

* rename

* move
2024-12-06 18:34:32 -08:00
Shane Smiskol
43dcf5c26f Toyota: error correct on future acceleration (#1559)
* future aego

* tune i

* consistent names
2024-12-06 18:18:59 -08:00
Jason Wen
c67bfd6a97 Sync: commaai/opendbc:master into sunnypilot/opendbc:master-new 2024-12-05 14:12:59 -05:00
Jason Wen
3d1780752e Merge branch 'upstream/master' into sync-20241205 2024-12-05 13:56:45 -05:00
Adeeb Shihadeh
b9daff809a make stale bot less annoying 2024-12-04 14:39:58 -08:00
Shane Smiskol
651be58ac8 Toyota: lower hybrid longitudinal actuator delay (#1553)
* lower hybrid delay

* better
2024-12-02 21:34:37 -08:00
Shane Smiskol
6afe699c0f Toyota: new longitudinal tune improvements (#1554)
lower up accel rl and raise permit braking threshold
2024-12-02 14:39:04 -08:00
Shane Smiskol
6626f62aca [bot] Fingerprints: add missing FW versions from CAN fingerprinting cars (#1550)
Export fingerprints
2024-12-02 14:33:27 -08:00
Shane Smiskol
78df311372 fix spacing 2024-12-02 12:49:04 -08:00
Shane Smiskol
6d1c7e3699 [bot] Fingerprints: add missing FW versions from new users (#1551)
Export fingerprints
2024-12-02 09:58:11 -08:00
Shane Smiskol
43e0fc14b2 [bot] Car docs: update model years from new users (#1549)
Update car docs
2024-12-02 09:56:54 -08:00
Isaac Barham
f40857e424 chore: Fixed typo in README.md (#1552) 2024-12-02 08:45:13 -08:00
Adeeb Shihadeh
1241f2d4f9 car support timeline faq 2024-11-30 09:49:09 -08:00
Adeeb Shihadeh
4d1d7f1898 fix error on scons clean 2024-11-29 14:52:19 -08:00
Adeeb Shihadeh
36c42132b3 README is the docs (#1545)
* wip

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* revert that

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* spelling
2024-11-29 14:29:48 -08:00
Adeeb Shihadeh
d458bdf827 remove cppcheck (#1542)
* remove cppcheck

* rm that
2024-11-28 12:03:40 -08:00
Adeeb Shihadeh
cb43b6cdf8 let's try sync labels 2024-11-28 11:55:31 -08:00
Shane Smiskol
e11fb76e05 Toyota TSS2: add longitudinal derivative (#1535)
* local changes

* keep ki the same, clean up

* same line

* clean up

* error correct on future aEgo

* Revert "error correct on future aEgo"

This reverts commit 2332106c829161fedf3a6e8a61244c6fd3ad9069.

* flip

---------

Co-authored-by: Comma Device <device@comma.ai>
2024-11-26 20:09:48 -08:00
Jason Wen
f9d7203779 Sync: commaai/opendbc:master into sunnypilot/opendbc:master-new 2024-11-26 22:51:30 -05:00
Jason Wen
d17cec0330 Merge branch 'upstream/master' into sync-20241126 2024-11-26 22:48:23 -05:00
Shane Smiskol
d5351b76fb Toyota: improve ego acceleration near stop (#1533)
* remove corolla from new long tune and fix start from stop overshoot on normal tune

* not here

* forgot

* Update carcontroller.py
2024-11-26 17:44:58 -08:00
Shane Smiskol
85d1113b90 Toyota: add missing k_f gain 2024-11-26 17:35:58 -08:00
Shane Smiskol
c2512eaeea Toyota: move longitudinal PID into carcontroller (#1532)
* commit

* clean up
2024-11-26 16:43:53 -08:00
Shane Smiskol
12f07ed7d8 [bot] Fingerprints: add missing FW versions from new users (#1526)
Export fingerprints
2024-11-25 13:48:18 -08:00
Maxime Desroches
21910a81bb ci: don't timeout if the runner is slow to pick up the job (#1521)
* try

* test

* fix

* try

* ;

* ;;

* fix

* try

* try

* fix this

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* try

* try failure

* works

* better

* comma

* test

* cleanup
2024-11-23 19:19:58 -08:00
Jason Wen
7185479f94 Sync: commaai/opendbc:master into sunnypilot/opendbc:master-new 2024-11-23 10:24:58 -05:00
Jason Wen
e6d000fa41 Merge branch 'upstream/master' into sync-20241122
# Conflicts:
#	.github/workflows/stale.yml
#	opendbc/car/hyundai/carcontroller.py
#	opendbc/car/hyundai/carstate.py
2024-11-23 10:14:05 -05:00
Jason Wen
a5a48406f1 tests: Point to sunnypilot's panda repository (#33) 2024-11-23 10:10:09 -05:00
Shane Smiskol
8e349c3955 Fix DBC scons build (#1523)
* fix

* clean up
2024-11-22 22:04:12 -08:00
Shane Smiskol
3c6e530d2e SConscript (#1520)
* try this

* better

* and that

* fix that
2024-11-22 13:29:05 -08:00
Louis Velez
551081b32f Build Dbcs with scons (#1519)
* clean-up generated dbcs and adds them to gitignore

* Adds SConscript for dbcs and adds reference to SConstruct
2024-11-22 10:46:24 -08:00
DevTekVE
b45036325a Hyundai: Enhanced Smart Cruise Control (ESCC) (#28)
* Refactor ACC commands for better modularity

Split `create_acc_commands` into smaller helper functions to improve readability and maintainability. Each helper function now handles the creation of specific message values and checksum calculations, making the code more modular and easier to manage.

* Bringing ESCC

* Remove SP_DEBUG dependency from escc as its not currently used

* Add unit tests for Hyundai ESCC and ESCC Base classes

Introduced comprehensive test cases for ESCC and ESCC Base classes within the Hyundai car implementation. These tests include validating message IDs, enabled flag handling, and refreshing car state functionalities. The goal is to ensure robust and accurate behavior of the ESCC-related features.

* Refactor ESCC interfaces for improved modularity.

Moved and integrated ESCC base classes into a new `escc_interfaces` module. Updated existing code to reflect these changes and removed redundant ESCC state base class.

* Don't try to disable radar ECU if it's ESCC

* Reorder HyundaiFlagsSP bit flags to avoid conflicts.

Updated the bit flags in HyundaiFlagsSP to be in reverse order to prevent conflicts with existing CarParams from OP. This ensures no overlap and maintains code clarity and functionality.

* Update Hyundai carcontroller for ESCC and adjust SP flags

Added ESCC parameter to `create_acc_opt` call for enhanced support in Hyundai. Also realigned Sunnypilot flags to prevent conflicts with existing definitions and arranged for proper bit allocation.

* Refactor flag handling in ESCC and introduce sunnyParams

Refactored ESCC flag handling to use sunnyParams for clarity and better structure. Updated related tests and configurations to align with the new sunnyParams structure. Also, added the sunnyParams definition to car.capnp.

* Refactor Hyundai flags for consistency

Reorganized Hyundai flag values to avoid conflicts and improve readability. Reduced power values for each flag to simplify the flag structure and ensure unique identifiers for each feature.

* Refactor Hyundai flag definitions

Updated HyundaiFlagsSP class to include documentation for special flags used within sunnypilot. The flag definitions were moved to bitwise shift notation for clarity and consistency, ensuring ease of extension up to 32 flags.

* Update opendbc/car/hyundai/interface.py

* Apply suggestions from code review

* Remove ESCC base and interfaces classes

Consolidated ESCC functionalities directly into the Hyundai ESCC module, removing redundant base and interface classes. This simplified the class structure and improved code maintainability.

* Removing hints because they were causing a circular dependency

* sunnyParams -> sunnypilotCarParams

* slight cleanup

* CarStateSP (shared in other PRs)

* Revert "CarStateSP (shared in other PRs)"

This reverts commit b4298d3472470adfd5cbd3b163a6b5030dbc06cc.

* rename

* EsccCarController

* fix

* more cleanup

* hyundaican cleanup

* rename

* Fixing inconsistencies thanks to the tests!

* fixing imports after rename

* And more fixes

* Adding __init__.py thanks to one of the tests

* Updating to the new flags ordinal on cereal

* Reverting some of the misc changes, clarifying naming and passing the scc12 and fca11 values to the methods as they are defined out of order

* undoing more naming changes to simplify diff

* More naming and tiny adjustments

* use constant for msg id

* house keeping

* how you like that

* more

* unused

* final

* how did we forget xD

* already added

* keep stock barely touched

* circular

* Apply suggestions from code review

* split escc from radar interface

* fix

* add TODO-SP

* unused

* fix init

* revert

* rename

* always use true radar tracks if available

* update comment

---------

Co-authored-by: Jason Wen <haibin.wen3@gmail.com>
2024-11-22 09:02:49 -05:00
Shane Smiskol
fb6ad760cc Revert "Hyundai CAN Longitudinal: Enable for Camera SCC cars" (#1518)
Revert "Hyundai CAN Longitudinal: Enable for Camera SCC cars (#1282)"

This reverts commit 6c68673cfd.
2024-11-21 20:16:03 -08:00
Shane Smiskol
c04557c8ef Corolla TSS2: support new Toyota tune (#1513)
* local changes

* we do need a pid after all

https://connect.comma.ai/a2bddce0b6747e10/00000477--adee1464ae/532/570

* back

* local changes

* hmmm

* add line

* 0.5

* probably can always be 0.35

* no debug

---------

Co-authored-by: Comma Device <device@comma.ai>
2024-11-21 20:10:11 -08:00
Shane Smiskol
b4e8a4970f Toyota: use a PID for PCM compensation (#1517)
* pid

* add pid
2024-11-21 19:01:38 -08:00
garrettpall
70009fed0c GM: Add Stock FCW to CarState (#1228)
* GM: Add Stock FCW to CarState

* Add Comment
2024-11-21 14:25:42 -08:00
Jason Wen
6c68673cfd Hyundai CAN Longitudinal: Enable for Camera SCC cars (#1282)
* Hyundai CAN: Longitudinal support for Camera SCC cars

* fix OP long checking fcw/aeb

* can error

* cleanup

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2024-11-21 14:25:07 -08:00
Louis Velez
e57375f1e2 CI: fix macOS test running (#1516)
* CI: fixes MacOS test running

* CI: adds coreutils for nproc

* CI: fixes based on PR

* cleanup

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2024-11-21 14:16:17 -08:00
Shane Smiskol
b17502d658 Match pid.py file from openpilot (#1514)
* match pid

* fix
2024-11-20 19:26:21 -08:00
Shane Smiskol
0bfd38f4c9 Toyota: prevent overshoot w/ new tune (#1515)
* use filter

* fix

* try pid

* Revert "try pid"

This reverts commit f47acb0b2ce3968be2aaefb8e9f2ecb884319c4a.

* improve start from stop

* comment
2024-11-20 19:24:20 -08:00
Shane Smiskol
eaeb7a96d7 Toyota: don't release brakes coming to a stop w/ new tune (#1508)
better creeping force
2024-11-19 18:52:05 -08:00
Adeeb Shihadeh
9a353c4d25 no stale for drafts 2024-11-18 16:02:41 -08:00
Shane Smiskol
e74e496cdc [bot] Fingerprints: add missing FW versions from new users (#1504)
Export fingerprints
2024-11-18 14:35:51 -08:00
Shane Smiskol
34af3abb10 Toyota: filter pitch for new tune (#1507)
* Update carcontroller.py

* pitch filter

* 1.5

* clean up

* whoops
2024-11-18 14:23:03 -08:00
Shane Smiskol
c59aa4a1d5 Reapply "Hyundai: always publish cruise and main buttons" (#1486) (#1505)
This reverts commit 68d93be959.
2024-11-18 11:43:06 -08:00