Commit Graph

78 Commits

Author SHA1 Message Date
HaraldSchafer
cf466222f6 Road Roll Compensation Rebased (#23251)
* first commit

* update refs
2021-12-16 17:34:12 -08:00
Ewout ter Hoeven
55390d273f Convert format strings strings to f-strings (#23241)
* Convert all text strings to f-strings

Reformats all the text from the old "%-formatted" and .format(...) format to the newer f-string format, as defined in PEP 498. This requires Python 3.6+.

Flynt 0.69 was used to reformat the strings. 120 f-strings were created in 51 files.

F-strings are in general more readable, concise and performant. See also: https://www.python.org/dev/peps/pep-0498/#rationale

* revert pyextra changes

* revert ublox.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2021-12-16 14:58:17 +01:00
Willem Melching
4f1eb4278a Log actuators after applying rate limits in CarController (#23230)
* return actuators from carcontroller

* log it

* pass to latcontrol

* chrysler

* gm

* honda

* more brands

* rest of the brands

* gm cleanup

* hyundai cleanup

* update ref

* rename field

* fix subaru

* add types

* more subaru fixes #23240

* consistent whitespace

* bump cereal
2021-12-16 13:08:20 +01:00
Adeeb Shihadeh
1638975627 Merge 2021 Accords into 2018 Accords (#23174)
* Merge 2021 Accords into 2018 Accords

* last of them
2021-12-08 14:40:14 -08:00
Adeeb Shihadeh
0283942a95 Honda: use new Bosch LKAS_HUD messages (#23000)
* Honda: use new Bosch LKAS_HUD messages

* enum value

* better name

* flip that
2021-12-05 13:51:33 -08:00
Willem Melching
e6180738fd add CarParams.wheelSpeedFactor (#23079)
* add CarParams.wheelSpeedFactor

* Fudge speed for Lexus RX

* should have been the TSS2 model

* bump cereal

* refactor into function

* update refs
2021-12-03 14:57:53 +01:00
Adeeb Shihadeh
239c7c1d4e Bring back Accord 2021 + 2021 Hybrid (#23021)
Co-authored-by: Chris Souers <csouers@gmail.com>
2021-11-23 23:19:11 -08:00
Adeeb Shihadeh
7746130a1e Honda Bosch cleanup (#22999) 2021-11-21 14:52:35 -08:00
Brett Sanderson
8b25551c7f Honda: rename HONDA_NIDEC_ALT_MAIN to HONDA_PARAM_NIDEC_ALT_SCM_MESSAGES (#22970)
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-11-18 14:52:37 -08:00
Adeeb Shihadeh
14651866c2 Honda: handle ACC state consistent with ISO 15622:2018 (#22958) 2021-11-17 17:30:50 -08:00
sshane
a0e5eccb70 Toyota: handle brake hold (#22810)
* disallow engagement if brake hold active

* we can check once

* move to common events

revert

* fix

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-11-08 14:26:30 -08:00
justinmccaffrey
28e16c7b84 Add 2021 Honda Passport (#22781)
* update values.py

* add passport to carstate, interface, values

* add a test route with mostly green

* switch to newer route

* update readme

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2021-11-04 15:28:04 +01:00
Robbe Derks
91987f38d4 Make pandaState and safetyMode a list (#22454)
* wip: move to pandaStates

* bump cereal

* wip: SafetyMode struct

* move to safetyMode

* fix typo

* this can be None

* fix potential empty pandaStates list

* fix thermald

* fix controlsd

* rename safetyModes to safetyConfigs

* update process_replay

* fix test_models

* bump cereal
2021-10-08 17:54:34 +02:00
Willem Melching
6c29a4c7fb Honda Bosch longitudinal tuning (#22407)
* revert changes to standstill logic

* start with mostly open loop

* Revert "revert changes to standstill logic"

This reverts commit d737d858e7708aedaf09cfc068b85398161e9bbe.

* proper clipping

* less lag

* less gas command

* start gas from -0.2

* controls should take care of that

* use CarControllerParams

* switch to braking sooner

* Revert "switch to braking sooner"

This reverts commit cf11dae334ccb369f625d4b13b7cd4176156a446.

* 2.5x more P

* use active

* engage on rising edge

* Revert "engage on rising edge"

This reverts commit c972956cb460eedaff3d0169a40673a6ea933385.

* update ref
2021-10-07 16:37:02 +02:00
John Belmonte
edabca193d Car Port: Honda Freed 2020 (#22003)
* car port: Honda Freed

Popular 3-row compact minivan in Japan based on Fit platform.

test route: 2c4292a5cd10536c|2021-08-19--21-32-15

* missing DRIVERS_DOOR_OPEN signal on FREED

* remove redundant long parameters

* additional FW; confirm lack of stop-and-go

* restore gateway ECU to fingerprint

* corrected mass and wheelbase

* add another forwardRadar id
2021-09-24 17:11:47 -07:00
Willem Melching
c68fc8ef9c set Honda Bosch long lag to 1s (#22335)
* set Honda Bosch long lag to 1s

* update ref
2021-09-24 10:28:00 -07:00
Adeeb Shihadeh
649af76fd4 remove community supported cars from community features (#22330)
* remove community supported cars from community features

* remove bosch and hkg long

* remove test case

* update refs
2021-09-23 17:34:52 -07:00
Willem Melching
c4bac6bd68 Hyundai longitudinal prerequisites (#22121)
* panda

* bring over changes

* dont check car model

* remove comment

* fix typo

* more stuff gated behind long

* not

* not used

* gate that too

* try honda tuning

* clip accel values

* fix up merge

* fix stopping

* add retry logic around knockout

* increase timeout

* keep flipping lead bit

* true for now

* less tuning

* update comment

* 0.1 s is fine now

* merge honda and hyundai knockout

* more lead fields

* another obj bit

* increase timeout

* fix stopping flag

* only lag compensate for braking

* no lead

* less tuning

* only do knockout if not readonly

* try controlling using jerk

* tuning

* try higher stopping rate

* set stopping flag at higher speed

* clip upper jerk when stopping

* remove comments

* tester present 1hz

* use positive start accel

* 1.0 to maybe improve low speed stuff

* no point going over 0

* bump panda

* bump panda

* revert that change

* update ref
2021-09-13 22:03:08 -07:00
Willem Melching
1e62b09e5d Use CP.vEgoStopping and clean up CP.startAccel (#22199)
* use CP.vEgoStopping and clean up

* update ref
2021-09-11 17:13:30 -07:00
HaraldSchafer
74b6c87254 cleanup old nidec accel override logic (#22181)
* cleanup old nidec accel override logic

* add ref without deprecated fields

* no more override
2021-09-10 10:34:18 -07:00
vanillagorillaa
bcb8a11d7f Honda e Port (#22108)
* Honda e Port

* Test route for Honda e

* remove

* Update README.md

* update values based on logs

* no need for Honda e specific DBC

* fix tests

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-09-07 16:46:44 -07:00
Willem Melching
f941111dcd Clean up PID controller ACCEL_MIN/ACCEL_MAX (#22148)
* use ISO 15622:2018 limits in PID controller

* allow more for nidec

* limit PID inputs

* CP is not needed

* add GM

* not used

* update ref

* fix honda bosch
2021-09-06 17:29:32 -07:00
HaraldSchafer
ebf2a2279d Prevent PID windup on Honda NIDEC (#22112)
* add higher set speed

* freeze when close to cruise

* dont bias this

* higher set speed

* start high

* 2mph might be needed

* better condition

* limit accel windup like this

* wrong name
2021-09-02 14:16:44 -07:00
HaraldSchafer
1ac89f14aa Change car controller interface from gas/brake to acceleration (#21911)
* retune civic

* seems smooth

* back to normal

* new ref

* fix conflict

* runs

* rm

* accel scale is 4

* toyota should be good

* more cleanup

* fixup

* better naming

* update ref

* deprecated

* sending brake when not enable causes a fault

* rm gas and brake

* unused

* update ref

* acura logic is no more

* wrong before

* revert tuning cleanup

* adress comments

* update ref

* already on master

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2021-08-30 09:32:52 -07:00
Adeeb Shihadeh
4be956f886 Revert 2021 Accord (#22063)
* bump panda

* Revert "Car Port: 2021 Accord 2.0 Touring & Hybrid Touring (#22007)"

This reverts commit 7e53a42984.

* revert release notes

* bump panda
2021-08-28 21:28:14 -07:00
Adeeb Shihadeh
7e53a42984 Car Port: 2021 Accord 2.0 Touring & Hybrid Touring (#22007)
* Add 2021 Accord 2.0 Touring & Hybrid Touring

- Create the HONDA_BOSCH_EXT set for HONDA_BOSCH cars that utilize the new extended IDs for LKAS_HUD

* Remove ids added to the wrong car

* add comment

* fix undefined signal

* fix tests

Co-authored-by: Chris Souers <csouers@gmail.com>
2021-08-22 12:50:58 -07:00
Adeeb Shihadeh
9e03aa0b92 Honda cleanup (#22008)
* cleanup magic numbers

* long tuning

* indentation

* remove noqa

* little more
2021-08-22 00:27:48 -07:00
HaraldSchafer
1c6c56a9df Remove acura (#21946)
* treat acura like nidec

* treat acura like nidec
2021-08-17 11:44:22 -07:00
HaraldSchafer
a8f3e2b3c2 Change long control honda pilot, ridgeline, honda fit, civic, ilx (#21886)
* not used

* just use gas

* allow gas

* try 0

* typo

* set to default

* set default

* makes more sense

* downtune and cleanup

* max accel always

* that is needed to smooth gas to brake

* try downtuning low speed

* try from default

* nidec is not bosch

* air resistance exists

* more smoothing

* wind brake sooner

* Civic experiments2 (#21862)

* control on throttle

* throttle modifier

* get acura in line

* try set speed control again (#21870)

* new acura function

* put back

* put back

* make linter happy

* define wind_brake once

* Civic experiments (#21908)

* remove civic

* start from scratch

* data drivenm

* the data does not lie

* data collection

* data driven

* limit

* final candidate

* fix windbrake

* Civic experiments (#21910)

* remove civic

* start from scratch

* data drivenm

* the data does not lie

* data collection

* data driven

* limit

* final candidate

* fix windbrake

* add acura control

* more cleanup

* cleanup

* update ref

* clip

* seems to fault

* always continuous

* new ref
2021-08-11 18:32:37 -07:00
HaraldSchafer
b8a4adfb2f hard honda max accel in car interface (#21585)
* hard set in car interface, not related to planning

* move to values
2021-07-14 11:06:29 -07:00
HaraldSchafer
a42d8f3a14 less accel (#21565)
* less accel

* new refs

* Update longitudinal_planner.py

* update refs
2021-07-12 18:30:56 -07:00
Adeeb Shihadeh
6d9dc9945a Honda: keep braking after PCM disables cruise (#21510)
* Honda: keep braking after PCM disables cruise

* update refs
2021-07-11 19:31:09 -07:00
Adeeb Shihadeh
cb7e96f99d rename enableCruise -> pcmCruise (#21546) 2021-07-10 13:56:11 -07:00
HaraldSchafer
be5ddd25cd Refactor long (#21433)
* refactor

* needs casting

* tests pass

* fix that test

* refactor in controls

* lets not go crazy

* change of names

* use constants

* better naming

* renamed

* soft constraints

* compile slack variables

* rm git conflict

* add slack variables

* unused

* new edition

* fcw

* fix tests

* dividing causes problems

* was way too slow

* take a step back

* byeeee

* for another time

* bad idxs

* little more cpu for cruise mpc

* update refs

* these limits seem fine

* rename

* test model timings fails sometimes

* add default

* save some cpu

* Revert "little more cpu for cruise mpc"

This reverts commit f0a8163ec90e8dc1eabb3c4a4268ad330d23374d.

* Revert "test model timings fails sometimes"

This reverts commit d259d845710ed2cbeb28b383e2600476527d4838.

* update refs

* less cpu

* Revert "Revert "test model timings fails sometimes""

This reverts commit e0263050d9929bfc7ee70c9788234541a4a8461c.

* Revert "less cpu"

This reverts commit 679007472bc2013e7fafb7b17de7a43d6f82359a.

* cleanup

* not too much until we clean up mpc

* more cost on jerk

* change ref

* add todo

* new ref

* indentation
2021-07-07 19:42:26 -07:00
Adeeb Shihadeh
c72d163e14 deprecate CP.enableCamera (#21509)
* deprecate CP.enableCamera

* more removal

* one more

* update refs
2021-07-07 14:59:18 -07:00
Willem Melching
a8fac002ae Honda Bosch longitudinal prerequisites (#21217)
* untested changes

* set compute_gb

* community feature for good measure

* add code for rolling backwards

* init needs CarParams

* stay in elm mode until carParams is written

* fix tester present bus number

* fix can errors

* fix enableCruise flag

* print when radar disable is done

* move retry logic to controlsd

* move lookup table into carcontroller params

* cleanup brake error values

* make init return

* that should be 1

* floats

* back to no failure handling

* try simplify knockout

* bump panda

* Move flags to panda

* add warnings

* Revert "try simplify knockout"

This reverts commit 4f496245791ea6bd041d4412b96035c6b434b91c.

* add note about LoC.long_control_state

* update ref
2021-06-22 16:28:11 +02:00
Greg Hogan
8071111f59 default carParams.stoppingControl to True (#21248)
* hyundai has full brake control

* set default stoppingControl to True

* update ref

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2021-06-15 14:00:57 +02:00
Adeeb Shihadeh
af8d417627 Fix Honda Accord transmission type detection (#21247) 2021-06-12 20:52:50 -07:00
ShaneSmiskol
e9e197eb3c Merge Accord trims (#21105)
* Merge unique Accord 1.5 fw versions

* remove all instances of ACCORD_15

* bump opendbc and update dbcs

* Switch between gearbox messages by detecting presence of gearbox msg

* both accord (2t) and accord hybrid use the same gearbox, 1.5t is the outlier

* default to GEARBOX

* add old name to migration

* bump opendbc

* update refs

* change msg name, bump cereal

* Update selfdrive/test/test_routes.py

* update ref

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Willem Melching <willem.melching@gmail.com>
2021-06-03 13:35:23 -07:00
Adeeb Shihadeh
a69e1715d4 Honda: cleanup enable logic (#20749) 2021-06-03 01:49:33 -07:00
ShaneSmiskol
551091bcfa Deprecate brakeLights field (#20954)
* remove all references to CS.brakeLights

* unused red

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-05-18 17:48:02 -07:00
Willem Melching
245312370f Cleanup HONDA_BOSCH alternate brake signal (#20901)
* Cleanup HONDA_BOSCH alternate brake signal

* always set self.brake_switch

* define in one place

* also defined here

* nesting

* remove CRV Hybrid

* rename brake_switch_ts

* add note about panda safety
2021-05-18 14:13:22 +02:00
Willem Melching
4215f63769 CRV Hybrid doesn't use alternate brake signal (#20945) 2021-05-18 12:16:08 +02:00
Adeeb Shihadeh
6c7ed8f2e4 enforce message checks in can parser (#20742)
* enforce message checks in can parser

* nissan

* vw

* hkg

* subaru

* toyota

* honda bosch

* gm

* honda nidec

* bump opendbc

* not all tss2 have bsm

* toyota fixes

* honda fixes

* vw fix

* fix subaru

* fix long tests

* update refs

* crv bsm
2021-04-25 12:52:16 -07:00
Adeeb Shihadeh
312b681a46 cereal cleanup part 2 (#20092)
* car stuff

* thermal

* Revert "car stuff"

This reverts commit 77fd1c65ebd01abfa8493ae12c9e6b14f7ada976.

* panda state

* camera stuff

* start deg

* most is building

* builds

* planner + controls run

* fix up paramsd

* cleanup

* process replay passes

* fix webcam build

* camerad

* no more frame

* thermald

* ui

* paramsd

* camera replay

* fix long tests

* fix camerad tests

* maxSteeringAngle

* bump cereal

* more frame

* cereal master
2021-02-16 21:39:32 -08:00
Samuel Coles
4c2efb4e7e Honda Fit Tune (#20094)
This commit lowers the kp and ki values for lateral tuning. This fixes the wheel shake, greatly increases straight line performance, and produces more human like driving on long curves.
2021-02-16 16:15:44 -08:00
Chris McCammon
012fa35096 Honda Odyssey tune (#20058) 2021-02-10 16:35:18 -08:00
Adeeb Shihadeh
000bd226aa Cereal cleanup (#20003)
* start cleanup

* fan speed

* cleanup dm

* fix cereal

* hwType -> pandaType

* update refs

* update refs

* bump cereal

* freeSpacePercent

* cereal master
2021-02-03 19:57:30 -08:00
Igor
093456cc40 Parametrize MIN_CAN_SPEED in car interfaces (#2684)
* Parametrize MIN_CAN_SPEED in car interfaces

* fixed instance in planner.py

* fix typo

* var name change

* changed var name to minSpeedCan for consistency with other uses of CAN in the capnproto files

* added default value to get_std_params, removed unneeded instances from car interface files

* Revert PEP8 autoformat corrections

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2020-12-04 11:09:34 +01:00
Ted Slesinski
36391bf12f Reduce Kp/Ki by 30% to eliminate steer oscillation (#1985) 2020-11-16 15:25:43 -08:00