Commit Graph

45 Commits

Author SHA1 Message Date
Shane Smiskol
f678ff0f22 car docs: sort parts by shown name (#28293)
* sort by shown name

* fix
2023-05-26 00:19:46 -07:00
Maxime Desroches
3785e161f0 car docs: allow auto_resume override (#28264)
* specify auto_resume

* format

* car compat

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-05-23 01:40:23 -07:00
Shane Smiskol
eee8a7a4b4 car docs: fix diff bot (#28266)
* test bot

* fix docs bot

* revert

* use dataclass

* sad this doesn't work
2023-05-23 00:36:42 -07:00
Maxime Desroches
9f5f8b603c car docs: list all needed hardware (#28212)
* generic car parts

* better carparts

* add part type

* more tests

* multiple enums

* unit tests

* just check isinstance

* better name

* remove _connector suffix

* remove those hyundai lines

* remove default arg

* Revert "remove default arg"

This reverts commit 139650a3b6b94358c3b9b12bb5fbe0a326d7abad.

* cleaner code structure

* use fingerprint

* review

* abstrac data class + common

* no more dataclass

* conflict

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-05-22 10:17:33 -07:00
Maxime Desroches
70677fe5fc add harness kit content to the doc (#28139)
* add harness kit content to the doc

* parts as enum

* nissan

* merge column

* rename column

* scaling

* scaling again

* 500px

* align text

* more px

* add style

* more width

* more

* more

* smaller text

* make all text smaller

* prev width

* default list

* remove hidden a ref

* try to remove again

* revert

* replace harness with harness_kit

* try fix

* cleaner

* center everything

* make pylint happy

* allow more than 1 of each parts

* use copy module

* review

* testing spacing

* revert

* bigger text

* formating

* split harness col lines

* remove print

* resolve

* rename to view

* keep formating in template

* simplify

* add unit test

* more generic way

* better

* harness connector only

* comment

* review

* put back harness parts

* missing dash

* too much space

* don't reload when clicking

* shorter comment

* only last line

* generate

---------

Co-authored-by: Cameron Clough <cameronjclough@gmail.com>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-05-15 15:33:54 -07:00
Adeeb Shihadeh
088cbfc9d5 car docs: add field for min compatibility requirements (#27805) 2023-04-04 17:47:49 -07:00
Adeeb Shihadeh
d064a32b00 docs: add experimental mode to compatibility description (#26954)
* docs: add experimental mode to compatibility description

* lower case
2023-01-14 16:28:17 -08:00
Shane Smiskol
6527f2c825 Car docs: link to car harness on shop (#26957)
* harness links

* test

* fix for no years cars

* match order of docs
2023-01-13 17:52:24 -08:00
Shane Smiskol
de6f9010fa Car docs: show video link (#26907)
* add videos to gh docs

* fix

* add icon

* fix

* try this

* white inner triangle

* width

* try height

* use video_icon in template

* clean up

* rename

* smaller
2023-01-11 23:30:11 -08:00
Shane Smiskol
5661738372 Car docs: move shop footnotes into openpilot (#26715)
move shop footnotes into openpilot
2022-12-06 15:00:11 -08:00
Shane Smiskol
1367f84425 Car docs: add a make-specific init function (#26565)
* add a hook function for makes to implement custom docs logic

* don't need this

* use the pre-defined list for honda's harnesses

* one line 😎

* Update selfdrive/car/docs_definitions.py

* i didn't know you didn't need a pass!

* don't change docs order
2022-11-21 18:01:08 -08:00
Adeeb Shihadeh
548888d634 docs: update Toyota DSU footnote (#26568) 2022-11-21 15:59:42 -08:00
Shane Smiskol
3e69973819 car docs: auto-generate footnote for DSU cars (#26321)
* note for dsu cars

* don't hardcode dsu footnote (1/2)

* test

* revert the experimental long toggle

* another day:(

* DSU doesn't have to be toyota specific, it's a generic carParam!

* this is safe, just make sure it's unknown

* these cars do not have OP long for some reason

* UNSUPPORTED_DSU_CAR

* forgot this

* fix autoResume

* fix autoResume 2
2022-11-03 01:00:33 -07:00
Shane Smiskol
735af656a0 car docs: docs-only footnote flag (#26335)
docs-only footnotes
2022-11-02 18:56:26 -07:00
Shane Smiskol
b76829c725 docs: expose available openpilot longitudinal control (#26312)
* openpilot -> openpilot available

* note for dsu cars

* common footnotes

* Revert "note for dsu cars" - another PR

This reverts commit 7f18742fdaaf5f86a1f1caa041b8b027d4b767cf.

* space

* better?

* Update selfdrive/car/docs_definitions.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* typo

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2022-11-01 15:55:21 -07:00
Adeeb Shihadeh
655a64b603 single longitudinal toggle for e2e and disable radar (#25688)
* single longitudinal toggle for e2e and disable radar

* write disable radar param

* rename

* better param name

* clean that up

* update refs

* update translations

* not live for experimental

* write it out

* vanish
2022-09-07 17:12:49 -07:00
Shane Smiskol
452d5e42ec Car docs: add auto-resume column (#25572)
* Move auto resume in sng to car interface

* Update docs

* shorter name, star

* order

* resumes?

* add hidden detail sentence

* good to know this works, but revert

* VW auto resume

* bump cereal to master

* Update ref_commit

* match cereal

* try this

* ?

?

* like this
2022-08-30 17:54:40 -07:00
Shane Smiskol
ed8d676870 Car docs diff bot: remove tier (#25611)
* fix car docs diff bot

* rm line
2022-08-30 11:23:42 -07:00
Shane Smiskol
747bcb013d Car docs: show more information about cars (#25415)
* back to actual information

* remove some star code

* round speeds

* Try out showing lateral acceleration

* remove that

* Fix speed units

* Add harness and try rounding to nearest half before scapping it

fix

^2

^2

* Add back steering torque star

* Fix static analysis

* auto-generate header

* fix static analysis. set to Harness.none by default

* rm
2022-08-18 15:12:18 -07:00
Adeeb Shihadeh
7087a154f5 Ford: add Q3 and Q4 harnesses (#25474) 2022-08-17 20:29:56 -07:00
Shane Smiskol
574021a0ac Car docs: test for missing harnesses (#25444)
* All cars must have a harness

* except body

* skip test

* Q for IoniQ
2022-08-15 21:44:15 -07:00
Jason Shuler
4ffe9e68db GM: Bolt EUV 2022-23 port (#24875)
* Switch to ECMPRDNL2 for GM gear

* Removing manumatic gear #

* values.py almost complete

* Silverado and Bolt EUV val and CP

* GM controller updated

* Cam hrns supp done (in theory)

* cleanup for new cars

* Remove extra constant

* WS, etc cleanup

* removing the unused

* Fix kpBP typo

* Updated docs

* Skip's PIF tune

* Dropped LKA CAN error patch

* Add silverado sigmoid ff

* CAN Err & LKA latch patch

* Remove EPS fault fix (another PR)

* Remove Silverado (another PR)

* clean up some common params

* Remove Escalade FP

Remove Escalade FP

* comment

* Premier is just a trim

Premier is just a trim

Premier is just a trim

* no footnote: new Bolt is like most other cars, older GM were outliers not at the camera

* clean up

clean up

* bump panda

* bump panda

* bump panda

* bump panda

* bump panda

* remove comments

* try spamming buttons on bus 2

* bump panda

* bumping opendbc w btn rc

* not needed for this port

This reverts commit 6af1f0ba799e075f877d7acc8ca0f117d97da361.

* add button safety

* Send next rc when spamming btns

* forward other signals in message

* missing DriveModeButton

* fill cruiseState.speed

* see if resume works without counter

* try the whole message

* send immediately and at 10Hz

* no resume, back to just button signal

* even holding random buttons it cancels

* Use torque controller with base tune

* stock long GM don't auto-resume yet

* Testing GM zero min steer speed

* Revert latcontrol

* revert opendbc

* latActive is basically lkas_enabled

* Update Bolt torque params

* comment

* clean up

* Add to releases

* Add test route

* Don't specify segment

* bump panda

* bump panda

* no harness for Bolt just yet

* Apply suggestions from code review

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* We support all and 2023

* move safetyParam up to first cam check

* Bump panda and update docs

* Update RELEASES.md

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

Co-authored-by: Shane Smiskol <shane@smiskol.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2022-08-12 16:10:34 -07:00
Adeeb Shihadeh
96e8d5c9fe Subaru: new harness is on the shop (#25406)
* Subaru: new harness is on the shop

* subaru a
2022-08-11 17:23:51 -07:00
Shane Smiskol
e05cfd2100 Ram 1500: add harness (#25376)
Add Ram harness!
2022-08-05 16:29:59 -07:00
Shane Smiskol
35338196ac CarInfo: detail sentence exception for Toyota stock longitudinal (#25331)
* Exception for 2022 RAV4

* Exception for all stock long Toyota

Exception for all stock long Toyota

* fix exception

fix

fix

fix
2022-08-01 17:44:22 -07:00
Shane Smiskol
c8a90ef586 Prepare for new supported vehicles webpage (#25021)
* add well maintained footnote

* stash

* some updates for the website

* one extensible sort function, pass sort function into template, continue to use "openpilot ACC"

* use items

same

* return a final dict

* Fix descriptions

* Required

* Add detail sentence

* Make string packages into namedtuple

* add temp year parsing

* revert this

* one unified class like harness

* fix static analysis

* Fix body

Fix body

* Make specifics strong

* remove years

* Make Camry footnote more clear

* Revert this too

* Add notCar text, fix steer speed > enable speed (remove comma, no speed mention)

* fix missing years

* group_by_make

* Use full package text

* Only use full package text

* Check car name if notCar, fix imports

* add_years no longer needed, remove 'with Stop and Go'

* fix that

fix that

fix that

* Exception for Nissan and Subaru

* Adjust DSU footnote text

* Fix speed overrides in sentence, CR-V package imp

* init() was being called multiple times, only need to run once to set row
2022-08-01 13:26:24 -07:00
Cameron Clough
fd5819e9ec Fix for multiple footnotes in car docs (#25256)
* Fix for multiple footnotes in car docs

* Split footnotes with comma

* oops

* one link tag

* fix empty footnotes

* sort footnotes

* Fix footnotes on website

* Revert "Fix footnotes on website"

This reverts commit 187686b0d7b591cf81a8d59ea6d45f7ba94b5fae.

* fix sorting if > 9

* try both

* it pushes star a bit too much and float: center doesn't work

* try on gh

try on gh

* doesn't look too good

* revert

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2022-07-23 00:00:17 -07:00
Adeeb Shihadeh
289239710d better star descriptions (#25236)
* better star descriptions

* most
2022-07-21 11:02:59 -07:00
Shane Smiskol
b30871daad CarInfo: parse out model years (#25208)
* add function

* split model and years

* typing and clean uop

* one function to split into make, model, years

* add test for bad years

* simpler re

* don't match only numbers

* clean up

* we can just use name

* clean up
2022-07-18 22:34:50 -07:00
Adeeb Shihadeh
500d16622c simplify compatibility docs (#25190)
* simplify tiers

* little more

* cleanup

* fix test
2022-07-18 17:53:00 -07:00
Shane Smiskol
e11bb76a64 car docs: remove steering torque hard-coding (#25019)
remove good torque hardcoding
2022-07-01 19:11:28 -07:00
Shane Smiskol
abcc7338d4 Car Port: 2022 Honda Civic (#24535)
* master 2022 Civic

* bump panda

* bump

* bump cereal

* fix

* needed

* try for now

* maybe

* revert for now

* move to Cam parser

* fix

* move to cam

* need AEB_STATUS too

* bump for debug prints

* bump opendbc and add cruise_params

* bump opendbc and update cruise_params

* bump

* test route

* update ref

* Revert "update ref"

This reverts commit 28345dab63d1919865ccb510265222a4cd4252f4.

* cleanup

* just to test

* bump

* revert

* need to send val 12 too?

* change bus

* not needed

* update bus

* syntax

* move this to other bus too

* Revert "move this to other bus too"

This reverts commit 770bf4745ee244c8426ac108f44b67777198d0a7.

* test new lane line signal

* needed too

* maybe need both?

* Test new LKAS hud message

* bump

* missing comma

* missing

* maybe

* add frame and idx

* add in hud_lanes

* switch this too

* bump panda

* add this

* I guess need this too

* to match

* also

* wasnt correct

* bump opendbc

* bump panda

* move to cam parser

* missing

* add here too

* bump

* remove from cam parser

* bump

* back to cam parser

* its 5hz

* bump for new checksum function

* bump for correct frequency

* update frame and idx

* bump

* bump and update

* send set me bit

* bump

* pass these values through

* silly atom

* ret

* fix this

* use copy instead

* add these too

* to check keyerror

* switch

* bump submodules

* send too

* proper

* Replace HUD with BOH

* add dashed lanes

* small fix

* clean up

* not needed anymore

* remove and change

* this too

* dont always set

* remove additional LKAS message

* bump

* add

* to test

* add frame

* bump

* rebase

* remove default values

* rename

* clean up some carstate logic

* regenerate docs

* spacing

* simplify more logic

* bump opendbc

* bump opendbc

* only if radarless

* panda at least builds now

* add comment

* bump

* fixes

* bump opendbc

* bump opendbc

fix for new DBC

* bump opendbc

* bump opendbc

* carstate: fix bus, parser signals

* Set safety param

* pt bus is 0, not 1

* Fix SCM_BUTTONS and bump panda and opendbc

* fixes for ACC_CONTROL

* bump opendbc

* bump opendbc

* convert from MPH on HONDA_BOSCH_RADARLESS

move is_metric

* make sure we don't disable if radarless

* don't show incorrect harness on website

don't show incorrect harness on website

* bump panda

* remove/update comments

* bump panda

* Fix harnesses

* one line check

* bump opendbc

* remove this

* Some carstate cleanup

We removed STANDSTILL->WHEELS_MOVING

we don't use CRUISE_PARAMS

add back

add back

* more cleanup

* update docs

* marketing says it has TJA and ACC with low speed follow

* send buttons on bus 0

bump panda

* comment

* camera needs to see buttons on bus 2

comment

* bump panda

* add to releases

* remove comments

* comment

* we don't use stock hud yet

Co-authored-by: vanillagorillaa <ntmccoy@yahoo.com>
Co-authored-by: vanillagorillaa <31773928+vanillagorillaa@users.noreply.github.com>
Co-authored-by: kevinharbin <76784413+kevinharbin@users.noreply.github.com>
2022-06-19 00:06:23 -07:00
Shane Smiskol
208d4a4fc7 Add Hyundai P harness (#24872)
* Update docs_definitions.py

* Update values.py
2022-06-17 13:39:15 -07:00
Shane Smiskol
88a100435f compatibility docs: auto-generate star descriptions (#24809)
* Auto-generate star descriptions

* Need this for the website

* And this

* required changes to make the website generation work

* better names

* Revert "better names"

This reverts commit be7dbbb5d846d7d55a1ad69533945e6a6c8a0b7c.

* simpler
2022-06-10 22:52:34 -07:00
HaraldSchafer
3066ad81a8 Car interface: set max lateral torque from table (#24789)
* json

* better naem

* Read from table

* formatting and default to nan

* Generate docs

* Read from table

* this should be the same

* Prius v is full

* test we always set the tunes correctly

add to release files

* Set for all cars

Set for all cars

* Revert tuning changes

Revert tuning changes

* remove that

* fixes

* update ref commit for new maxLateralAccels

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2022-06-10 17:57:23 -07:00
Shane Smiskol
1b402687e4 docs: adjust steering torque thresholds (#24798)
* Prius has good steering control now

* 1.5 is the threshold for good torque

* get back down there, hondas

* half stars for 1.0-1.5

* show number of cars

* try bigger

* emphasize tiers

balanced

* Add half star

* Update ref_commit
2022-06-09 18:51:34 -07:00
Shane Smiskol
bdc05fd13c Honda: rename Bosch harness to Bosch A 2022-06-07 17:18:03 -07:00
Shane Smiskol
c6bc03311c Car documentation: set steering torque star using car interface (#24709)
* Set good torque using torque controller tuning

* should be equal to

* save lateral accel to car params

* use maxLateralAccel

* always

* same convention

* nan will always evaluate to false

* The great good torque purge

* adjust default friction

* Add data for more cars

* adjust name

* Welcome back, guys. Only adjust good torque if maxLatAccel is set

* Update refs (1.7 is 1.7000001...)
2022-06-03 17:41:20 -07:00
Shane Smiskol
433fcc0c71 CarInfo: Add harness information (#24085)
* Add harness information

* test harness enum

* add harness info for tucson

* update Tucson harness

* get rid of development

* make global enum

* fix

* add harness info

* add harness info to CARS.md (since we need multiple lines per HKG platform)

* revert this

* Actively Maintained means something! (aka, to bronze with select VW)

* fix caravelle

* add harness tooltip on maintained column

fix

* lol tubaru

* always assume harness

* update honda harnesses

* add Ioniq hybrid 2017-19 harness, todo: not sure

* unused import

* hmm, did they really switch to the C for 1 year??

* add comment

* add comments

* adding tooltips should be fine

* fix santa fe harness

* welcome back, vw

* no need for two harness strings

* seems fine

* fix 19-20 Niro EV harness

* these were taking from old database, so assume correct

* could be d

* pass all car info into template

* no more tool tips

* these use j533 harnesses

* accidentally got removed in merge

* also merge issue

* don't need these

* make harness non-optional
2022-05-11 18:02:21 -07:00
Shane Smiskol
dabcfd266e car info: function that sorts all car info into tiers (#24498)
* base function that returns all car info sorted by make model

* don't need to pass it in quite yet
2022-05-11 15:59:08 -07:00
Shane Smiskol
f3bcbb1b50 car docs test: check car name (#24193) 2022-04-12 12:45:31 -07:00
Adeeb Shihadeh
e40c36f22b better support non-car robots (#24106)
* better support non-car robots

* bump cereal

* update refs
2022-04-01 20:03:20 -07:00
Igor Biletskyy
031f79ba88 car port: comma body (#24019)
* body FPv2

* ..

* ..

* ..

* Temp, REVERT!

* more cleanup

* typo

* ..

* del eyes

* should work?

* fix

* new dbc

* ..

* fixes

* static analysis

* cln balancing code

* no test route

* excluded_interfaces

* THE DOCS!

* comments on steer/speed mixin

* switch to bus 0

* less UDS

* FAKE bus 0 vin and fingerprint

* FAKE locationd

* Keep steady and remove handcoded offset

* Improve startup sequence, get closer to stock openpilot

* Forgot to define angle

* lowercase

* revert that

* little cleanup

* change safety model

* update refs

* body is gold

* handle no llk

* oops

* litte more

Co-authored-by: Comma Device <device@comma.ai>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2022-03-31 17:16:15 -07:00
Shane Smiskol
85d8997a8a docs: support for automatically generating website vehicles page (#24020)
* add vehicles.vue template

* add original vue file

* stash

* stash

* clean up a bit

* add template for now

* implement footnotes and tier copy

* no more generator

* convert to 2 spaces

* should work, now onto vue

* does GH handle this html well?

* fix

* auto-generate descriptions and make tiers' maps non-str

* remove old files

* move template specific variable into templates, should be a bit simpler

* js template is simplier too now

js template is simplier too now

js template is simplier too now

* add video links from the nice car_info

* make rows attributes

* clean up

* fix

* remove template

* experiment with video links in GH

add image

how does this look?

fix

* Revert "experiment with video links in GH"

This reverts commit 8375e717b563f7b4ecf009ffae00174de1a0b8e9.

* sort tier_car_info in place

* unused Tuple

* no type check

* fix script
2022-03-23 13:42:53 -07:00
Shane Smiskol
31a6b141d6 Docs: auto-generate supported cars documentation (#23762)
* make CAR class enum, and values.py formatting

* Revert "make CAR class enum, and values.py formatting"

This reverts commit 04d9817e9d5d6ab5c027754018fc445f2cd3067a.

* stash

* add supported packages and model years

* don't change model years in fps

* move Lexus to info dict and make int enum

* remove sometimes wrong model years from name string

* use enum names

* convert Honda's values

* nice names

* use name

* GM

* Mazda, Ford

* Hyundai: WIP

* finish Hyundai

* fix

* Nissan

* Subaru

* Tesla

* formatting is for another PR

* Chrysler: todo: unify the Pacificas?

* do volkswagen

* this isn't a zoo

* skip enums for now

* Update selfdrive/car/volkswagen/values.py

Co-authored-by: Jason Young <46612682+jyoung8607@users.noreply.github.com>

* set All

* temp cars

* auto-generate CARS.md

* update type hinting

* add generated file

* add longitudinal star to cars that support disabling radar

* add TODO

* add notes

* add min_steer_speed exception for hatchback

* add minimum steering speeds

* Add exceptions and run generator

* Missing Telluride

* fix Prius v

* missing Prius Prime

generate

* start to convert years to strings

* Fixup Hyundai

* convert year sets to strings

* handle this

* missing S3

* Fix and add all missing cars (verified with script

* Supported Package fixes

* add get_tiered_cars

* Check radarOffCan for removing most Honda from op long

* Update for Avalon stop and go update on master

* Fix missing car params

* add my temporary script i'm using to verify new generated DBC

add my temporary script i'm using to verify new generated DBC

* generate with jinja template

* add header and footer

* clean up

* rename

rename

* add exceptions. jinja is nice, but why are its loop indexes starting at 1?

* add list of known car videos

* See how these look

* Add nice table formatting for column description

Add nice table formatting for column description

* generate

* consisten br tag

* small clean up

* temp

* Move car videos into CarInfo

* add new copy and rename to footnotes

* Revert "temp"

This reverts commit 93c3fce1d3ab406f80cbfb9c00c2237d109c7846.

clean up

* generate

* replace with svg

* simplify a bit

* add footnotes to CarInfo

* move some variables to docs.py

* Add video link for Acadia

* Make Footnote an enum so we don't use random ints

* static analysis fixes

* move to CARS.md

* fix last missing footnote

* add to release files

* rm test file

* use svg

generate

* fix sorting

* not needed

* not sure how this got here

* remove Sedan/Couple and add Diesel footnote

* finish todos

* move make specific footnotes to selfdrive/car/*/values.py

rename

* change to zeros

* align bottom to center

* Apply some suggestions

* Update selfdrive/car/mock/values.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update copy

* Try headers + bullet points

* somehow better

somehow better

* finish updating copy

* move template and add links to sups

* stars shouldn't be clickable

that didn't work

try this

try this

this is better

* add type hints to CarInfo

add more type hinting

* optional needs a type and any covers all (?)

* move good steering torque to */values.py

* dataclasses are much nicer than attr

* use tuple

* Update docs/cars.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* suggestions

* suggestions

* suggestions

remove

* clean up a bit

* add more type hints

* center stars and remove hardcoding from template

* update copy

* Add test

* Fix types

Fix types

* add supported cars documentation test

* clean up

* replace with docs_definitions

* Add back Footnote enums

* Ah so these are like fstrings!

* Update selfdrive/car/CARS_template.md

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update selfdrive/car/docs.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update year from master merge

* Fix longitudinal star from merge

* sort properly stars by Column enum

* clean up

* HKG: Sorry guys

* Prius V gets FSR star, like others

* Update selfdrive/car/docs.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* update comment

* No Prius docs change for now

Co-authored-by: Jason Young <46612682+jyoung8607@users.noreply.github.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2022-03-16 21:27:05 -07:00