Commit Graph

96 Commits

Author SHA1 Message Date
Adeeb Shihadeh
86f4d86cd7 make calibrationInvalid a permanent alert 2020-09-04 13:20:48 -07:00
ZwX1616
9731e7a0d7 not show soft recover alerts 2020-08-27 17:59:26 -07:00
Chris
1b52930a52 Kilometers per hour now displayed as km/h (#2032)
Fixes #2031

Signed-off-by: Christopher Rabotin <christopher.rabotin@gmail.com>
2020-08-17 11:16:52 +02:00
Adeeb Shihadeh
cb5a2996e7 NEOS background updater (#1892) 2020-08-12 11:39:21 -07:00
Adeeb Shihadeh
8e63f06540 Alert when updated consistently fails (#2013)
* alert when update fails more than 10 times

* bring over offroad alert refactor from other branch

* and we have tests

* use it in snapshot

* bump apk

* don't show exceptions on release branches

* only write when changed

* why does delete use so much cpu

* clean that up

* little more
2020-08-11 16:23:57 -07:00
Adeeb Shihadeh
ee99b59bad fix missing negative limit in pid controller (#2001) 2020-08-08 11:49:13 -07:00
HaraldSchafer
490ee52687 add fall filter and less FP on posenet (#1971)
* add fall filter and less FP on posenet

* add alert

* list

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2020-08-03 15:51:56 -07:00
HaraldSchafer
8e2d344135 Misc locationd improvements (#1714)
* I like this more

* rewind less

* bump rednose

* falling off windshield detectopr

* adjust thresholds

* this is a soft disable now

* move that

* process replay fixes

* update refs

Co-authored-by: Comma Device <device@comma.ai>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2020-07-30 15:33:22 -07:00
Shane Smiskol
ebadb39e42 Fix hard deceleration after user accelerates above set cruise speed (#1880)
* Fix hard deceleration after user accelerates above set cruise speed

* 2nd required change
2020-07-20 17:04:05 +02:00
Adeeb Shihadeh
5db81f60ca Fix most remaining LGTM alerts (#1893)
* fixups from LGTM

* short globals

* fix spinner and textwindow

* total ordering

* no spinner/text window when import from manager

* not android
2020-07-19 16:12:22 -07:00
Adeeb Shihadeh
03e824a4b5 Alert when modeld is lagging by more than a frame (#1823)
* alert when modeld is lagging by more than 1 frame

* log frameAge in modelData

* set posenet valid

* compute frame_age once
2020-07-09 17:02:21 -07:00
Greg Hogan
c458f5a5d3 k-line 5 init fault type (#1821)
* k-line 5 baud fault type

* update name

* bump cereal

* fix name

* add missing event
2020-07-06 09:33:16 -07:00
Adeeb Shihadeh
64aeb80dcc fix blindspot detection 2020-06-30 13:44:56 -07:00
robbederks
df86c476c7 Dos (#1795) 2020-06-29 12:47:48 +02:00
Adeeb Shihadeh
ce80684f7e Add alert while in preEnabled state (#1791) 2020-06-28 20:29:42 -07:00
Willem Melching
5e254da8b3 fix wrong car mode alert 2020-06-24 18:20:30 -07:00
Adeeb Shihadeh
c4a3d7afb0 Block lane change start on blindspot detection (#1712)
* use BSM to block lane change start

* remove duplicate entry

* add approaching
2020-06-24 17:31:09 -07:00
ZwX1616
3aa99a01d7 recover EON/C2 AF (#1665) 2020-06-23 14:33:32 -07:00
Adeeb Shihadeh
51b7dc0e38 fix engage/disengage sounds 2020-06-23 10:50:24 -07:00
Adeeb Shihadeh
cab96374c5 more generic alert text for wrongCarMode 2020-06-19 20:36:10 -07:00
Adeeb Shihadeh
ccf6b80c7e Cleanup startup event handling (#1748)
* cleanup startup event

* always show permanent

* lowest

* update refs
2020-06-19 16:16:48 -07:00
Adeeb Shihadeh
fd8514eee3 hwType is in health 2020-06-18 15:37:21 -07:00
Adeeb Shihadeh
e892d6a9d9 if sky visible 2020-06-18 14:40:57 -07:00
Adeeb Shihadeh
b3101998ed update no GPS alert for comma two users 2020-06-18 13:01:28 -07:00
Adeeb Shihadeh
6c156d7f45 NEOS update required alert (#1722)
* NEOS update required

* permanent alert

* bump cereal
2020-06-16 12:21:41 -07:00
Adeeb Shihadeh
25688f36cc Block entry on non-adaptive cruise mode (#1708)
* block entry on non-adaptive cruise mode

* user disable

* toyota
2020-06-15 18:11:50 -07:00
Adeeb Shihadeh
9e34ed4e8c bump cereal 2020-06-15 16:01:35 -07:00
Adeeb Shihadeh
92c29c4269 bump cereal 2020-06-12 20:38:45 -07:00
Willem Melching
684f7b2cc0 no gps warning after 5 minutes (#1692) 2020-06-12 16:03:35 -07:00
Adeeb
0bbe870b5f Delay alert creation for some events (#1689)
* add creation delay parameter to alerts

* 1s delay for sensorsInvalid and canError

* bump cereal

* update refs
2020-06-12 15:32:50 -07:00
Adeeb
d4858e5ff5 Move driver monitoring out of controls (#1642)
* move dmonitoring out of controls

* run monitoring unit tests in CI
2020-06-09 13:25:15 -07:00
Willem Melching
15dc6044d4 Remove slow down for turns (#1647)
* Remove slow down for turns

* update ref
2020-06-05 16:01:53 -07:00
Jafar Al-Gharaibeh
73db079199 Fix rounding of minSteerSpeed in events (#1620)
I thought I was missing a rounding in Mazda code, but it turned
out to be a missing rounding after the recent event refactoring

Python3 interpreter:
>>> print(" %d  %d" % (1.6,1.4))
 1  1
>>> print(" %d  %d" % (round(1.6),round(1.4)))
 2  1
>>> print(" %d  %d" % (int(round(1.6)),round(1.4)))
 2  1
>>> print(" %d  %d" % (int(round(1.6)),int(round(1.4))))
 2  1

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
2020-06-03 14:01:32 -07:00
Willem Melching
2400417084 vehicle model types (#1631) 2020-06-03 13:47:47 -07:00
Willem Melching
0f20ac728f Bounds checks on liveParameters for testing on desk 2020-06-03 11:31:12 -07:00
Adeeb
165bcf1f31 Fix speed too low (#1627)
* fix speed too low

* bump ref

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2020-06-02 17:31:59 -07:00
Willem Melching
843a64c72f Make pylint more strict (#1626)
* make pylint more strict

* cleanup in progress

* done cleaning up

* no opendbc
2020-06-02 16:29:32 -07:00
Willem Melching
205cb04ee9 speedTooHigh should not be an immediate disable 2020-06-01 15:53:41 -07:00
Willem Melching
fab8425f2f Make driverview not pin two cores at 100% 2020-06-01 13:58:54 -07:00
Adeeb Shihadeh
6466ec982a enable flake8 E502: backslash is redundant between brackets 2020-05-31 17:41:18 -07:00
Adeeb Shihadeh
27754a277c enable E261 in flake8: two spaces before inline comment 2020-05-31 14:07:29 -07:00
Adeeb Shihadeh
efd5dffb1e enable flake8 E231: missing whitespace after comma 2020-05-31 12:49:11 -07:00
Adeeb
6051061ff8 Flake8 E22X (#1607)
* e221

* e225

* bump opendbc
2020-05-31 00:48:47 -07:00
Adeeb
d9bf9f0a40 Enable more flake8 checks (#1602)
* enable some more flake8 checks

* some more quick ones

* bump opendbc

* e401

* e711 e712

* e115 e116

* e222

* e301

* remove that

* e129

* e701 e702

* e125 e131

* e227

* e306

* e262

* W503

* e713

* e704

* e731

* bump opendbc

* fix some e722
2020-05-30 20:14:58 -07:00
Adeeb Shihadeh
916448af25 break canError into two separate events 2020-05-29 12:00:41 -07:00
Adeeb Shihadeh
7961d5ffd7 Fix below steer speed alert text not updating 2020-05-28 20:39:13 -07:00
HaraldSchafer
67017d69fe Minor fixes (#1571)
* was 5 seconds not .2!

* threshold for moving car highers, this can give FPw
2020-05-27 14:35:01 -07:00
Willem Melching
50f3f1d335 -Werror (#1567)
* werror

* -Wno-inconsistent-missing-override

* Silence ffmpeg deprecation warnings

* add some more pragmas to ignore warnings

Co-authored-by: Comma Device <device@comma.ai>
2020-05-26 13:27:01 -07:00
Willem Melching
fcf879d783 Add permanent CAN error alert (#1549)
* Add permanent CAN error alert

* canValid needs some time to initialize

* update ref
2020-05-21 16:08:05 -07:00
Willem Melching
e6f24f2390 Revert "Add permanent CAN error alert"
This reverts commit 0abf99dbe0.
2020-05-21 15:30:16 -07:00