Commit Graph

799 Commits

Author SHA1 Message Date
Adeeb Shihadeh
49498aa7b5 controlsd: no cruise speed while main off (#24052)
* controlsd: no cruise speed while main off

* probably more accurate

* update refs
2022-03-27 18:06:28 -07:00
HaraldSchafer
adf34c3414 CarParams: remove max steer (#24044)
* Remove max steer

* Update ref
2022-03-25 17:33:11 -07:00
Adeeb Shihadeh
8af20af66d pylint: enforce indentation (W0311) (#24039)
* pylint: enforce indentation (W0311)

* few more
2022-03-24 23:23:29 -07:00
Adeeb Shihadeh
ea74a90ca0 test onroad: CPU usage test improvements (#24035)
* test onroad: CPU usage test improvements

* remove those
2022-03-24 19:52:46 -07:00
Shane Smiskol
c88ced1f10 Honda Nidec: don't actuate while longitudinal is inactive (#24028)
* don't command any pcm_speed when long is not active

* update refs
2022-03-23 18:30:05 -07:00
HaraldSchafer
4a8fffd0f4 Apply EU guideline lateral limits (#23974)
* Apply EU limits

* Lower bound v_ego

* Add curvature limit comment

* Remove comment

* Update ref
2022-03-22 19:46:04 -07:00
Adeeb Shihadeh
b9c48f12ad update references to CARS.md and routes.py (#23993) 2022-03-18 13:30:06 -07:00
HaraldSchafer
dcece099ff Add angular rates carcontroller packet (#23980)
* Controlsd: give carcontroller angular rates

* Update cereal

* Needs to be list

* Update refs
2022-03-16 21:12:11 -07:00
Shane Smiskol
5fe00fb773 Move gas/brake pedal event logic to controlsd (#23850)
* move some state machine logic to controlsd

move some state machine logic to controlsd

* same order

same order

* move unsafeMode up

* disable at standstill

* save last CS

save last CS

* do we need to copy at all?

* don't copy

* rename

* Update selfdrive/controls/controlsd.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Revert "Update selfdrive/controls/controlsd.py"

This reverts commit 10bb51a0f0ee0d8e2a27c746a0638280a5eaea8a.

* Update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2022-03-15 20:51:07 -07:00
ZwX1616
de4031c98e DM: more precision running on DSP + e2e outputs (#23900)
* update cereal

* run but not use

* log distraction type

* regression scaling

* clean up naming

* add calib buf

* add to header

* fake model

* no calib model

* adjust threshs

* 018a305f

* fix bn

* tweak1

* tweak2

* 0ff2/666

* tweak3

* t4

* t5

* fix out of bound

* skip when replaying old segments

* update ref

* fix onnxmodel

* get calib

* update model replay refs

* up ref
2022-03-15 19:02:21 -07:00
Vivek Aithal
dfc1292614 locationd: Commissue fix (#23951)
* check allAliveAndValid only at filter init

* revert cereal and bugfix test

* rename filterValid to filterInitialized

* bump cereal

* correct err

* update refs
2022-03-15 14:40:29 -07:00
Adeeb Shihadeh
8718a59330 cleanup selfdrive/test (#23967)
* move test routes and test_models

* move fingerprints

* little more

* remove that
2022-03-14 15:46:16 -07:00
Gijs Koning
57b6fdc17a Rename RGB vision streams to match YUV streams (#23961)
* Renaming VISION_STREAM_RGB_.. to match yuv names like VISION_STREAM_ROAD
VISION_STREAM_RGB_BACK -> VISION_STREAM_RGB_ROAD
VISION_STREAM_RGB_FRONT -> VISION_STREAM_RGB_DRIVER

* little more

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2022-03-14 14:03:54 -07:00
Adeeb Shihadeh
f1aab78d08 longitudinal MPC: add MAX_T in T_IDXS_LST (#23960)
* longitudinal MPC: add MAX_T in T_IDXS_LST

* update refs

Co-authored-by: KexianShen <shenkexian@gmail.com>
2022-03-13 21:45:23 -07:00
Shane Smiskol
629399a449 carControl: add long and lat active fields (#23859)
* proof of concept

* actuators packet describes which actuators are active

* bump cereal

* fixes

* not needed for this PR

* Do Toyota

* add back controlsState.active

* bump cereal

* rest of cars

* in actuators

* add active back

* which

* use controlsState.active for now

* will make an issue

* Update selfdrive/controls/controlsd.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* move local lat_active checks into CC.latActive

* remove redundant checks

* move comment

move comment

* fix joystick mode

* get enabled from carcontrol

* do standstill check in controlsd

* make sure we consider the gas press case for GM

* use CC.actuators

* fix

* capitalization

* Bump cereal

Bump cereal

* make intermediate actuators

* similar convention to before

* clean that up

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2022-03-13 20:58:44 -07:00
Adeeb Shihadeh
41d8395729 jenkins: don't rely on SSH params (#23924)
* jenkins: don't rely on SSH param

* better ssh enabling

* fix path

* fix that
2022-03-07 15:57:18 -08:00
Willem Melching
492398826f modeld: sync based on frame timestamp (#23901)
* sync based on frame ts

* log extra frame id

* ints only

* update ref

* no rounding errors
2022-03-07 10:46:15 +01:00
Shane Smiskol
274885fc4d controlsd: fix vCruise jumping on pcmCruise cars (#23388)
* clean up v_cruise_kph

fix

fix

* Revert "clean up v_cruise_kph"

This reverts commit 211b5c3dbe073414ef5c39b19d6d2c6e8de2cf0b.

* always update vCruise and don't init if pcmCruise

* revert change

* update refs
2022-03-03 05:23:14 -08:00
Jonathan Frey
ab371f888a Longitudinal MPC set qp tolerance to 1e-3 (#23899)
* initialize solverExecutionTime longitudinal_planner

* test_onroad: improve timing evaluation

* longitudinal MPC: set qp_tol to 1e-3

* update ref

Co-authored-by: Harald Schafer <harald.the.engineer@gmail.com>
2022-03-02 21:38:40 -08:00
Jonathan Frey
1801baba68 remove trivial terminal constraint and associated CasADi generated functions (#23898)
* remove trivial terminal constraint and associated CasADi generated functions

* Update refs

Co-authored-by: Harald Schafer <harald.the.engineer@gmail.com>
2022-03-02 20:53:21 -08:00
George Hotz
8d6f49aecf model: mse err from 0.02-> 0.000056 (#23891)
* mse err from 0.028070712 -> 5.8073703e-05

* build with weights fixup

* need thneed lib also

* don't break for binaries

* static analysis says i need init

* check the bias

* load_dlc_weights

* nicer scons

* tested scons

* fix static

* pylint issue

* new ref

* a few more asserts

Co-authored-by: Harald Schafer <harald.the.engineer@gmail.com>
2022-03-02 20:52:17 -08:00
Vivek Aithal
7e6903b58f locationd, paramsd: Check conditions before updating kalman filters (#23789)
* update filters only when all messages are alivbe and valid

* update message valid and fix unit test

* update refs

* move check outside loop

* modify fake message fn in test

* deprecate inputsOK and resolve PR comments

* avoid double looped list comprehension

* follow import conventions

* modify paramsd valid to only be invalid in case of commIssue

* update refs
2022-03-02 01:01:29 -08:00
Shane Smiskol
8eab496ce3 Update Santa Fe 2019 route (#23888)
* new santa fe route, mid-drive to parking lot

* bump
2022-03-01 13:47:53 -08:00
Jonathan Frey
d09dffb7cd Cython acados and minor (#23835)
* acados_ocp_solver_pyx.pyx: implement get_stats for timings and ints

* long_mpc: use acados timers

* acados_ocp_solver_pyx.pyx: fix dynamics_get

* acados_ocp_solver_pyx.pyx: get statistics

* use acados_ocp_solver_pyx.pyx from commaai/cython2 branch

* acados_ocp_solver_pyx.pyx: implement store_iterate

* acados_ocp_solver_pyx.pyx: implement get_residuals

* acados_ocp_solver_pyx.pyx: fix set() for empty fields

* acados_ocp_solver_pyx.pyx: load_iterate

* cython acados: add print_statistics

* test_following_distance: fix typo

* test_longitudinal: unique names for test maneuvers

* longitudinal MPC: comments for evaluation

* longitudinal MPC: add comments to eval acados residuals

* long_mpc: use qp_solver_cond_N = 1

* long MPC: comments, simplify set_cur_state

* update acados version in build script

* longitudinal mpc: weigh a_change in 1 place only

* update ref

* Update ref

Co-authored-by: Harald Schafer <harald.the.engineer@gmail.com>
2022-02-25 14:16:44 -08:00
Adeeb Shihadeh
04b2545ec0 Subaru: remove Impreza CAN fingerprints (#23841)
* Subaru: remove Impreza CAN fingerprints

* fix process replay

* update refs
2022-02-23 15:44:17 -08:00
Adeeb Shihadeh
c483a9724d Honda: revert to button enable on Nidec (#23828)
* Honda: revert to button enable on Nidec

* fix test

* bump panda
2022-02-22 22:36:21 -08:00
Adeeb Shihadeh
c98d9791f0 adjust comma two model timing thresholds after bigmodel 2022-02-22 13:16:23 -08:00
HaraldSchafer
48154703a7 Fix tici bigmodel (#23817)
* Fix bigmodel on tici: cam intrinsics arent static

* Give TICI route own name for import

* Make function useable in offline test

* typo

* change tici ecam focal to trained focal

* No shadow variable

* Fixed ref

* Force update this time

* Update model replay ref commit
2022-02-21 19:57:04 -08:00
Willem Melching
ccdf069c8c onroad_test: increase camerad cpu usage after debayer changes 2022-02-21 16:18:01 +01:00
Willem Melching
428d412c1f longitudinal planner: disable change cost when stopped. not engaged or gas pressed (#23639)
* disable change cost completely on standstill and gas press

* cleanup

* set accel to zero

* clean up logic around standstill

* update ref
2022-02-21 16:14:41 +01:00
Adeeb Shihadeh
12cd852fc0 paramsd cpu usage has been increasing 2022-02-19 17:10:29 -08:00
Willem Melching
85efde269d bigmodel (#23684)
* Added wide cam vipc client and bigmodel transform logic

* Added wide_frame to ModelState, should still work normally

* Refactored image input into addImage method, should still work normally

* Updated thneed/compile.cc

* Bigmodel, untested: 44f83118-b375-4d4c-ae12-2017124f0cf4/200

* Have to initialize extra buffer in SNPEModel

* Default paramater value in the wrong place I think

* Move USE_EXTRA to SConscript

* New model: 6c34d59a-acc3-4877-84bd-904c10745ba6/250

* move use extra check to runtime, not on C2

* this is always true

* more C2 checks

* log if frames are out of sync

* more logging on no frame

* store in pointer

* print sof

* add sync logic

* log based on sof difference as well

* keep both models

* less assumptions

* define above thneed

* typo

* simplify

* no need for second client is main is already wide

* more comments update

* no optional reference

* more logging to debug lags

* add to release files

* both defines

* New model: 6831a77f-2574-4bfb-8077-79b0972a2771/950

* Path offset no longer relevant

* Remove duplicate execute

* Moved bigmodel back to big_supercombo.dlc

* add wide vipc stream

* Tici must be tici

* Needs state too

* add wide cam support to model replay

* handle syncing better

* ugh, c2

* print that

* handle ecam lag

* skip first one

* so close

* update refs

Co-authored-by: mitchellgoffpc <mitchellgoffpc@gmail.com>
Co-authored-by: Harald Schafer <harald.the.engineer@gmail.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Comma Device <device@comma.ai>
2022-02-19 16:06:31 -08:00
Shane Smiskol
2c7845fce0 Longitudinal control: interpolate longitudinal plan (#23787)
* interpolate longitudinal actuator delay

rename

* formatting

* interpolate v_target most importantly!

* fix interpolation and rename

* nicer setup

* left in from testing

* update refs
2022-02-18 00:45:00 -08:00
Willem Melching
14260c01c6 process replay: fix branch name alert (#23783)
* env is modified after start

* update ref
2022-02-17 16:47:42 +01:00
Adeeb Shihadeh
f59adbeaaa keep the new alert consistent for process replay 2022-02-16 23:47:02 -08:00
Adeeb Shihadeh
ff965c772b add branch name to startup master alert (#23782)
* add branch name to startup master alert

* still orange

* update refs
2022-02-16 20:27:07 -08:00
ClockeNessMnstr
9535dc606d Longitudinal: add Kf to carParams (#23752)
* sane_kf

* long_kf + cereal

* update ref

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2022-02-16 15:38:22 +01:00
George Hotz
90beaebefb add thneed optimizer (#23772)
* add thneed optimizer

* local work group opt

* kernels and final mods

* release files

* build system touchups

* fix kernel path, rand inputs for self test

* broken since extra is gone

* update model replay ref

Co-authored-by: Comma Device <device@comma.ai>
2022-02-15 15:32:00 -08:00
Vivek Aithal
3e915cf628 controlsd: Fix Toyota steer angle sensor race condition (#23747)
* fix steer angle race condition

* update ref

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2022-02-11 13:54:17 +01:00
Shane Smiskol
209bfe536b Honda: fix brake pressed signal (#23683)
* or brake_switch

* remove car exceptions

* Revert "remove car exceptions"

This reverts commit cad6a552aa4a17c69616014d3e9333d30c1fadd3.

* does have ts noise, use updated

* bump panda for tests

* bump

* messsssy draft

* clean up

* clean up

* bump

* CS: process all messages at once, like we do during real openpilot usage

* handle multiple messages updated in one cycle

* bump

* bump

* use less confusing, but equivalent cp.vl

* Update selfdrive/test/test_models.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* no msg

* bump opendbc

* Update selfdrive/car/honda/carstate.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* same test logic

* add brake_switch_prev to class

* need to set previous brake switch when not lagging (most of the time)

* need to compare

* only update previous if updated this cycle

rm

* need to maintain previous active state

* move brake_switch

* bump opendbc

* bump

* bump

* bump

* bump

* bump

* bump

* bump opendbc

* rename

* oops

* bump opendbc

* bump

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2022-02-10 13:04:37 -08:00
Vivek Aithal
8a2cbfe00b paramsd: fix VehicleModelInvalid errors (#23726)
* bound steerratio, stiffness std

* remove start steer_ratio limits after looking at data

* reduce sf obs noise

* update refs

* update refs

* add comment explaining change
2022-02-09 17:37:28 -08:00
Willem Melching
8effa2d878 hide localizerMalfunction alert (#23730)
* hide localizerMalfunction alert

* update ref
2022-02-08 22:22:03 -08:00
Adeeb Shihadeh
4c766934be reduce shutdownd CPU usage (#23723)
* reduce shutdownd CPU usage

* sync

Co-authored-by: Comma Device <device@comma.ai>
2022-02-07 18:50:54 -08:00
Adeeb Shihadeh
48e97b7872 small test_models.py speedup 2022-02-07 16:10:20 -08:00
Jafar Al-Gharaibeh
341f5a4ae0 Mazda CX-5 2022 Car port (#23704)
* Mazda CX5 2022 FW

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* CX-5 2022: No lockout and steer down to zero

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* CX-5 2022: No dashcam!

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* CX-5 2022: add to supported cars

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Mazda: stick with 800 max torque for now

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Update docs/CARS.md

* Apply suggestions from code review

* Mazda: set car models where needed

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Mazda: set minSteerSpeed per car

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* unused

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* cleanup

* Update selfdrive/car/mazda/interface.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2022-02-04 23:34:37 -08:00
Adeeb Shihadeh
af33998335 update refs 2022-01-30 20:46:40 -08:00
Adeeb Shihadeh
602f92fc0e controlsd: only add startup event until initialized (#23671)
* controlsd: only add startup event until initialized

* update refs

* update again
2022-01-30 20:38:05 -08:00
Adeeb Shihadeh
c8429f913e test car models improvements (#23668)
* run on all routes

* min segment length

* invalid

* revert that
2022-01-30 11:17:51 -08:00
Adeeb Shihadeh
d2735d73fc test car models: fix all panda safety mismatches (#23616)
* remove tolerance

* fix nissan mismatches

* warm up

* remove additional bosch check

* another honda exception

* little more

* Update selfdrive/test/test_models.py
2022-01-29 22:14:27 -08:00
Adeeb Shihadeh
5219554b85 Honda: fix controls mismatch for stock PCM configs (#23662)
* Honda: fix controls mismatch for stock PCM configs

* ready to remove

* bump panda
2022-01-29 17:01:26 -08:00