Commit Graph

69 Commits

Author SHA1 Message Date
Willem Melching
bd06434243 pre-commit pylint (#1580)
* "The commit-hook project sounds interesting though. I would definitely merge something that runs flake8 and pylint on the modified files!"
-  pd0wm, https://github.com/commaai/openpilot/pull/1575#issuecomment-634974344

* add pylint to pre-commit and make everything pass

* Remove uncommented stuff

Co-authored-by: J <user@4800.lan>
2020-05-27 20:00:14 -07:00
HaraldSchafer
67017d69fe Minor fixes (#1571)
* was 5 seconds not .2!

* threshold for moving car highers, this can give FPw
2020-05-27 14:35:01 -07:00
Adeeb Shihadeh
2ecc7d9f6f Fix blank mdMonoTime and controlsStateMonoTime in radard 2020-05-26 17:53:55 -07:00
Willem Melching
50f3f1d335 -Werror (#1567)
* werror

* -Wno-inconsistent-missing-override

* Silence ffmpeg deprecation warnings

* add some more pragmas to ignore warnings

Co-authored-by: Comma Device <device@comma.ai>
2020-05-26 13:27:01 -07:00
Willem Melching
fcf879d783 Add permanent CAN error alert (#1549)
* Add permanent CAN error alert

* canValid needs some time to initialize

* update ref
2020-05-21 16:08:05 -07:00
Willem Melching
e6f24f2390 Revert "Add permanent CAN error alert"
This reverts commit 0abf99dbe0.
2020-05-21 15:30:16 -07:00
Willem Melching
0abf99dbe0 Add permanent CAN error alert 2020-05-21 14:53:40 -07:00
Willem Melching
41da10ff38 Sounds available isdir -> isfile 2020-05-21 14:46:18 -07:00
Willem Melching
517826c1e1 Add percent sign to calibration screen 2020-05-21 14:43:07 -07:00
Adeeb Shihadeh
260e6aff53 fix possible FileNotFoundError 2020-05-21 09:59:39 -07:00
Willem Melching
9f0eac9089 Fix #1545, sensor alert on startup 2020-05-20 11:25:55 -07:00
Willem Melching
d099e09fb7 Handle posenet and sensor alerts in locationd (#1541)
* handle posenet and senor alerts in locationd

* defaults now set in capnp file

* Cleanup c++ version of params learner

* update ref commit
2020-05-19 16:45:20 -07:00
eFini
e14dfa3bec use buttonEvent.type instead of string (#1533) 2020-05-18 10:15:30 -07:00
Andre Volmensky
135385c5fb Bugfix: Reset saturated_count if angle no longer saturated (#1522) 2020-05-16 01:14:10 -07:00
Willem Melching
c18891b936 Alert callback functions were returning tuples 2020-05-15 18:29:22 -07:00
Willem Melching
c85b174584 White panda is deprecated (#1516)
* Start white panda deprecation

* Unify alert text

* Add noentry

* Change to no longer supported

* panda is lowercase

* Capitalize

* rerun ci
2020-05-15 13:00:00 -07:00
Willem Melching
631d0d94d3 Fix two event names 2020-05-15 12:24:12 -07:00
Adeeb
d976233f69 Alerts + Events refactor (#1466) 2020-05-14 15:21:21 -07:00
Willem Melching
ef33007813 Clip v_cruise to V_CRUISE_MAX 2020-05-13 18:05:24 -07:00
Willem Melching
e7ec02e201 speed too high louder alert 2020-05-13 18:02:09 -07:00
Willem Melching
516fa29738 Fix controlsd typo in refactor 2020-05-12 18:58:18 -07:00
Adeeb
08832ff29d Controlsd refactor (#1487)
* it's a class

* more refactor

* remove that

* car interface should create that

* that too

* not a dict

* don't create permanent events every iteration

* break up long lines

* fix honda

* small optimization

* less long lines

* dict is faster

* latcontrol less args

* longcontrol less args

* update profiling script

* few optimizations

* create events together

* clean up

* more clean up

* remove comment

* clean up

* simplify state transition

* more clean up

* update comments
2020-05-12 15:06:48 -07:00
Adeeb Shihadeh
10ae22a192 delete unused lines 2020-05-10 11:25:42 -07:00
Adeeb Shihadeh
48dec51f0e fix circular import reported by LGTM 2020-05-09 16:47:36 -07:00
HaraldSchafer
65fcc7c45f Better poly (#1437)
- better polyfitting
- no mpc cost change during lane change
- model trained with better ll gt, sim noise and guaranteed memories
2020-05-08 17:14:43 -07:00
Willem Melching
70ae01e3cd remove yet another reverse geocoder 2020-04-24 14:07:36 -07:00
Willem Melching
267ee4d73b no more geofence 2020-04-24 14:06:17 -07:00
Willem Melching
42f741d6ff No more line following robots 2020-04-24 14:05:19 -07:00
ZwX1616
922055f464 orange distracted alert is now continuous (#1412) 2020-04-23 14:15:05 -07:00
George Hotz
58e71de9fb add safety note 2020-04-20 13:56:02 -07:00
HaraldSchafer
d39595cf10 Faster lane change (#1381)
* final B2 for 0.75

* more aggression in lane changes
2020-04-16 18:13:37 -07:00
Willem Melching
2b2751c6bd Show relay malfunction alert (#1373)
* show relay malfunction alert

* Remove empty line

* Also immediate disengage

* Forgot noEntry

* Fix name
2020-04-16 11:38:31 -07:00
ZwX1616
133b1a20b4 RHD support for driver monitoring (#1299) 2020-04-15 16:48:44 -07:00
Willem Melching
7643b0a511 Force decel on soft disable (#1334) 2020-04-08 14:59:17 -07:00
Adeeb
0f6c22ce8b Unit test for alert width (#1307)
* unit test for alert width

* fix scale

* comment

* fix offending alert text

* rename

* update process replay refs

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2020-04-07 21:37:17 -07:00
Andre Volmensky
522dc29b53 Add angle based steer saturation timer (#1311)
* Add angle based steer saturation timeout

* Fixed saturated check
2020-04-05 10:59:54 -07:00
eFini
106be23c4e use put_nonblocking when possible (#1288)
* use put_nonblocking when possible

* revert uneeded changes
2020-03-31 12:09:38 -07:00
Willem Melching
3cb1568a54 High speed alert (#1295)
* add speed to high alerts

* Add permanent alert

* Two lines

* No permanent alerts

* Less bad alert

* Typo
2020-03-30 18:41:56 -07:00
BRose98
daba092038 Removed self-assignments (#1283)
* Removed self-assignments

* pulled master version of changed cubmodules

* Corrected the submodules

Co-authored-by: BRose98 <b.roseboom@students.uu.nl>
2020-03-29 12:31:27 -07:00
Willem Melching
1df6b67511 Nissan leaf (#1275)
* split out leaf and xtrail

* Add brake pedal

* This should work

* Fix test car models + bump panda

* Combined cruise enabled detection in single message

* Proper frequency checks

* Add doors

* Blinkers and doors

* Seatbelt

* Gear

* Add cancel message

* Unify steering pressed

* Remove angle limit

* Add steer saturation alert for angle based control

* Add set speed

* Change wheel speed factor

* Fix offset in set speed

* Timeout on engage for steer saturated

* Put counter back

* try cancel using seatbelt

* Try different cancel message

* Rename cancel signal

* Add LKAS alert

* Add missing fingerprint values

* Update test car models

* Add some comments
2020-03-27 21:44:59 -07:00
Harald Schafer
6766776e73 reformat for sim 2020-03-27 17:02:40 -07:00
ZwX1616
a95e61edf4 add webcam to cameras (#1201) 2020-03-26 19:19:47 -07:00
Harald Schafer
34f2c0da75 longitudinal e2e mpc 2020-03-26 17:43:11 -07:00
HaraldSchafer
5f8e3b4d93 New lane planner (#1276)
* better lane planner

* works well on test

* needs speed now

* update ref
2020-03-25 16:57:58 -07:00
Willem Melching
d08b56317f Go to dashcam mode if locked out, fixes #1109 2020-03-18 11:38:00 -07:00
HaraldSchafer
af5f99d7cf fade ll out and in (#1246)
* fade ll out and in

* bug fixes

* pretty important fixes

* safer in case model misses desire input

* Safer float compares

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2020-03-16 16:19:01 -07:00
Shane Smiskol
6ff881f789 initialize all messages in 1 line (#1206) 2020-03-05 17:32:52 -08:00
HaraldSchafer
63d3bb517f Pulse desire (#1172)
* initial

* compilation fixes

* add desire

* pulse desire

* 0d5728f6-a918-40a6-bce3-a9d0f1238180/20

* cleaner

* inject model

* inject model

* test runs

* ah already done I see

* remove useless

* update

* updates, doesnt work

* fix generating new references

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2020-03-04 18:51:45 -08:00
Adeeb
e8cb6ea06a Abstract common events + event cleanup (#1129)
* too many if

* unused

* whitespace

* key

* sefldrive/car/*

* no more gctx

* lower

* start abstracting common events

* all cars

* start small

* all cars

* reverse gear

* wrongCarMode

* wrongGear

* espDisabled

* steerUnvailable

* make linter happy

* c isn't used

* fix esp_disabled in VW

* update ref

* more red

* more cleanup

* fix subaru

* update ref
2020-02-20 16:22:25 -08:00
Andrew Valish
45718d9294 Add LaneChangeEnabled param and settings toggle (#1093)
* add LaneChangeEnabled param and settings toggle

* Read lane change toggle in pathplanner.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2020-02-14 15:24:59 -08:00