Commit Graph

7421 Commits

Author SHA1 Message Date
cowanhmoore
afaa2b917c HRV fix gas pedal signal (#1582)
Seperate CAR.HRV from CAR.FIT
HRV used GAS_PEDAL, not GAS_PEDAL_2 for FIT
2020-06-01 15:26:47 -07:00
Willem Melching
fa7d8f6e1b remove unused line in nissan carstate 2020-06-01 14:39:06 -07:00
Andre Volmensky
843b2940c5 Nissan mph bit (#1609)
* Added MPH bit for Rogue/XTrail

* Init seatbeltUnlatched as True
2020-06-01 14:38:20 -07:00
Dean Lee
c9dbaf821c Template version of read_param (#1593) 2020-06-01 14:30:53 -07:00
Willem Melching
d00cdf1e0c longitudinal test should broadcast liveLocationKalman 2020-06-01 14:24:48 -07:00
Dean Lee
cdb48cc180 dmonitoring : use memory cache to avoid malloc/free on every frame (#1599)
* use memory cache

* use template function to return buffer

* inline function

* const size_t

* use std::vector instead of kj::array
2020-06-01 14:00:43 -07:00
Willem Melching
fab8425f2f Make driverview not pin two cores at 100% 2020-06-01 13:58:54 -07:00
Willem Melching
a108e7f211 paramsd output at 20 Hz instead of 100 Hz 2020-06-01 13:47:17 -07:00
Willem Melching
f575a9ec12 Fix low speed engage on stop and go Hondas (#1613)
* fix low speed engage on stop and go Hondas

* update ref commit
2020-06-01 10:14:11 -07:00
Jafar Al-Gharaibeh
41fbce5906 Mazda: Slower rate for ACC cancel msg to avoid cruise disable (#1615)
* Slower rate for ACC cancel msg to avoid cruise disable

 Sending ACC cancel message at 10hz may end up disabling
main cruise state. That is because stoc ACC use the same
signal for both functions. If cruise is already enabled
the signal canceles it, otherwise cruise is disabled.
10hz seems to be still fast in some cases not allowing
the state to sync up between OP and the Stock state.
5hz avoids that issue. Also, the resume message was also
updated to 5hz as that seems to work better as well.

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Round up 27.96 to 28mph

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
2020-06-01 02:04:47 -07:00
Adeeb Shihadeh
6466ec982a enable flake8 E502: backslash is redundant between brackets 2020-05-31 17:41:18 -07:00
Adeeb Shihadeh
ebed2d1dcc enable flake8 E251: unexpected spaces around keyword / parameter equals 2020-05-31 17:34:47 -07:00
Adeeb Shihadeh
f3dcf861c7 enable flake8 E303: too many blank lines 2020-05-31 17:21:11 -07:00
Adeeb Shihadeh
27754a277c enable E261 in flake8: two spaces before inline comment 2020-05-31 14:07:29 -07:00
Willem Melching
02c130731c Add alternate Accord tuning 2020-05-31 13:37:55 -07:00
Willem Melching
a0adc44821 Enable new params learner for improved vehicle model estimation 2020-05-31 13:36:27 -07:00
Willem Melching
106cddb49a White panda no longer supported 2020-05-31 13:33:56 -07:00
Willem Melching
ea74edf71b Bump version to 0.8.0 2020-05-31 13:31:44 -07:00
Adeeb Shihadeh
efd5dffb1e enable flake8 E231: missing whitespace after comma 2020-05-31 12:49:11 -07:00
Adeeb
6051061ff8 Flake8 E22X (#1607)
* e221

* e225

* bump opendbc
2020-05-31 00:48:47 -07:00
Andre Volmensky
9fc826cb5c Added Rogue 2019/Leaf 2019 fingerprints (#1605)
* Added Rogue 2019/Leaf 2019 fingerprints

* Added Rogue as new car. Updated readme

* Added route to test_car_models.py. Fixed if statements to check against rogue/x-trail

* Fixed paste error

* Merged Leaf fingerprints

* Assume Rogue is MPH until we work out the mph/kph bit
2020-05-30 20:25:32 -07:00
Adeeb
d9bf9f0a40 Enable more flake8 checks (#1602)
* enable some more flake8 checks

* some more quick ones

* bump opendbc

* e401

* e711 e712

* e115 e116

* e222

* e301

* remove that

* e129

* e701 e702

* e125 e131

* e227

* e306

* e262

* W503

* e713

* e704

* e731

* bump opendbc

* fix some e722
2020-05-30 20:14:58 -07:00
Willem Melching
4fcf47812b add some sanity checks on returned params 2020-05-30 17:15:41 -07:00
Willem Melching
b5a2cec913 Improved tune for VW Golf Mk7. #1603
commit 012049274fd5573bdc5d2d0f198817646dfd5a1b
Author: Willem Melching <willem.melching@gmail.com>
Date:   Sat May 30 10:40:49 2020 -0700

    update ref

commit d50cc2d81fd73dcfccfe1a8e2726879941ec5327
Author: Jason Young <jyoung8607@gmail.com>
Date:   Sat May 30 10:32:25 2020 -0400

    Discard no-longer-used import

commit c092e6f5092535a3b4bb5cabb6f5ecf83ef754c7
Author: Jason Young <jyoung8607@gmail.com>
Date:   Sat May 30 10:21:57 2020 -0400

    Improved tune from community
2020-05-30 17:04:38 -07:00
Adeeb Shihadeh
18afb979fe remove file that shouldn't have been committed 2020-05-30 14:40:00 -07:00
Willem Melching
d920290544 add RAV4H_TSS2 EPS firmware version 2020-05-30 13:38:42 -07:00
Willem Melching
4cec8bcc30 Fix indentation in board.cc 2020-05-30 10:31:40 -07:00
Kishan Karunaratne
9256530a1d [GM] Show FCW from OP on dashboard UI / LED (#1596) 2020-05-30 10:17:04 -07:00
Dean Lee
af36aa28ab driving.cc: Pass ModelDataRaw by reference (#1600)
* pass ModelDataRaw by reference

* pass NVGpaint by refer
2020-05-30 10:08:44 -07:00
Erich Moraga
94b2d4d522 CAR.SIENNA Engine, ESP, and DSU f/w was missing (#1597)
DongleID 307249a92f279059... verified working via TeamViewer, as FPv2 switched to `fingerprintsource = fw`
2020-05-30 10:07:23 -07:00
Yahya Lmallas
3ddbb7fe5b Call to gmtime is potentially dangerous (#1598)
* Call to gmtime is potentially dangerous

* Revert "Call to gmtime is potentially dangerous"

This reverts commit cc531e4e1969f7a615230d8462f0be3258ba3378.

* Call to gmtime is potentially dangerous

* oops

* not a pointer

* Little identation fix
2020-05-30 10:06:29 -07:00
martinl
7b54dad0b8 Add Subaru blindspot monitoring signals (#1374)
* Add blindspot signals to carstate

* Change blindspot signals to boolean
2020-05-29 23:32:51 -07:00
VirtuallyChris
3d7cd9ec78 Add Camry Hybrid 2018 Engine FW 2020-05-29 17:26:05 -07:00
Adeeb Shihadeh
2d898bc0ed update refs 2020-05-29 12:41:20 -07:00
Adeeb Shihadeh
916448af25 break canError into two separate events 2020-05-29 12:00:41 -07:00
Jafar Al-Gharaibeh
34b9b5e849 Bounty: Mazda (#988)
* Mazda Port

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Update checksum to account for steer angle signal used in some cars

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Add test drive/segment ID to pass CI tests

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Process gear and brake signals, add new fingerprints

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Refactor some car interface code

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Drop redundant call, use Ecu, move warning to carstate, fix cruise speed

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Drop unused variables, cleanup handsoff tracking

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Update to steerError and steeringRate

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Refactor parse gear, update lkas signals from the new dbc

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Better tracking of engage and warning events

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* remove commented lines, update speed_kph to match panda

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Steer Error

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Set lkas enable speed to 52 kph

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Drop block signal use, fix LGTM alerts

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* When gas is pressed OP will disengage, sync local state with it

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Use car's speed signal instead of wheel speed

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Tidy up disengage events

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Rebase/Refactor with upstream

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Sync stock ACC state with OP

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* mazda dbc file renamed

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Improve acc stock and go by removing the 3 seconds limit

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Dashcam

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* PR Feedback

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Send ACC cancel only if we are sure cruise is enabled

Otherwise we run the risk of disabling main cruise

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* updated route

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* no process replay for now

* add to release files

* Revert "updated route"

This reverts commit 233db4f1bc2d8eefaa86488be4f6f88360d20793.

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2020-05-28 22:15:19 -07:00
Adeeb Shihadeh
7961d5ffd7 Fix below steer speed alert text not updating 2020-05-28 20:39:13 -07:00
Willem Melching
ba2ac1207a Running pre-commit in CI (#1590)
* Running pre-commit in CI

* fix dockerfile syntax

* dont run on submodule repo folders

* Fix some import errors in ci

* more stuff

* That should be the last one
2020-05-28 15:40:48 -07:00
Dean Lee
108a13ead8 UI: better read_model (#1586)
* update model struct inplace

* refer params

* pass path by refer
2020-05-28 15:10:49 -07:00
Willem Melching
3d08dcc3b2 Run mypy commit hook (#1591)
* run mypy commit hook

* fix mypy errors
2020-05-28 15:05:04 -07:00
Willem Melching
bee15f8abe make pre-commit pass without xx present 2020-05-28 13:20:28 -07:00
Willem Melching
44851ae934 bump opendbc 2020-05-28 11:53:17 -07:00
Erich Moraga
2bcab668d4 Added CAR.COROLLA_TSS2 EPS f/w x018965B12520 (#1587)
As seen in Discord, for DongleID/route 35794509ea3b423e|2020-05-28--14-51-06 (Euro Toyota Corolla Hatchback Hybrid)...
https://discord.com/channels/469524606043160576/524327905937850394/715579226186579985
2020-05-28 09:07:07 -07:00
Willem Melching
29aaa44740 flake8 in pre-commit(#1583) 2020-05-27 20:33:05 -07:00
Willem Melching
bd06434243 pre-commit pylint (#1580)
* "The commit-hook project sounds interesting though. I would definitely merge something that runs flake8 and pylint on the modified files!"
-  pd0wm, https://github.com/commaai/openpilot/pull/1575#issuecomment-634974344

* add pylint to pre-commit and make everything pass

* Remove uncommented stuff

Co-authored-by: J <user@4800.lan>
2020-05-27 20:00:14 -07:00
Harald Schafer
5a841c2856 Revert "better values"
This reverts commit 109ba298b1.
2020-05-27 17:11:27 -07:00
Willem Melching
8ea8f405db add gpsOK flag to liveLocationKalman 2020-05-27 15:14:13 -07:00
HaraldSchafer
67017d69fe Minor fixes (#1571)
* was 5 seconds not .2!

* threshold for moving car highers, this can give FPw
2020-05-27 14:35:01 -07:00
Harald Schafer
109ba298b1 better values 2020-05-27 12:16:05 -07:00
HaraldSchafer
7c8d6cbdef pure init (#1569) 2020-05-26 20:49:14 -07:00