Commit Graph

118 Commits

Author SHA1 Message Date
Pavel Galashin
9992f852b2 Mazda: fingerprint 2023 Mazda CX-5 Carbon Edition (#29092)
fingerprint 2023 Mazda CX-5 Carbon Edition
2023-07-31 19:51:44 -07:00
b801r
4b0cdf71f6 Fingerprint - 2020 Mazda CX-9 (#28805)
139b81648a954ae7|2023-07-04--13-46-16

VIN: JM3TCBDY7L0412945

Co-authored-by: Cameron Clough <cameronjclough@gmail.com>
2023-07-10 11:07:56 +01:00
weapons
eeccb09504 Mazda CX-5 2022 fingerprint (#28803)
Update values.py

Updated Mazda CX-5 2022 fingerprint for my vehicle (2023 Mazda CX-5 UAE).
2023-07-07 02:10:24 -07:00
Shane Smiskol
d59172bc19 Mazda: query and log FW on bus 0 (#28569)
* mazda: query FW on bus 0

* update refs
2023-06-29 00:14:09 -07:00
Maxime Desroches
e85acfa365 car: use default_factory for mutable fields in dataclasses (#28669)
* call me

* copy
2023-06-27 16:48:43 -07:00
Jafar Al-Gharaibeh
354b5be9c3 Mazda: Fix BSM detection with blinkers (#27919)
* Mazda: Fix BSM detection

Submitted-by: Samuel <samuel95_54@hotmail.com>
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* bump opendbc

* use new signals

---------

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-06-15 20:50:21 -07:00
Shane Smiskol
024abe6455 car docs: document parts of parts (#28292)
* more stuff

* even more

* all parts func

* start to use it

* include self in parts

* use car_parts_new

* not used

* more usages

* remove get_parts

* remove more commented stuff

* remove iter

* clean up some more stuff

* more

more

* ford

* optional

optional

* nissan

* use new classes

* fix tests

* fix

* order

* no more required

* connector

* CARS.md

---------

Co-authored-by: Maxime Desroches <desroches.maxime@gmail.com>
2023-05-31 21:30:50 -07:00
Shane Smiskol
2e4e41a7d3 Mazda: set default steering control values (#28342)
don't crash when porting new car
2023-05-30 15:40:54 -07:00
Maxime Desroches
9f5f8b603c car docs: list all needed hardware (#28212)
* generic car parts

* better carparts

* add part type

* more tests

* multiple enums

* unit tests

* just check isinstance

* better name

* remove _connector suffix

* remove those hyundai lines

* remove default arg

* Revert "remove default arg"

This reverts commit 139650a3b6b94358c3b9b12bb5fbe0a326d7abad.

* cleaner code structure

* use fingerprint

* review

* abstrac data class + common

* no more dataclass

* conflict

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-05-22 10:17:33 -07:00
Shane Smiskol
37eb9f900c Mazda: explicitly copy signals to forward (#28244)
mazda
2023-05-20 18:25:19 -07:00
Maxime Desroches
70677fe5fc add harness kit content to the doc (#28139)
* add harness kit content to the doc

* parts as enum

* nissan

* merge column

* rename column

* scaling

* scaling again

* 500px

* align text

* more px

* add style

* more width

* more

* more

* smaller text

* make all text smaller

* prev width

* default list

* remove hidden a ref

* try to remove again

* revert

* replace harness with harness_kit

* try fix

* cleaner

* center everything

* make pylint happy

* allow more than 1 of each parts

* use copy module

* review

* testing spacing

* revert

* bigger text

* formating

* split harness col lines

* remove print

* resolve

* rename to view

* keep formating in template

* simplify

* add unit test

* more generic way

* better

* harness connector only

* comment

* review

* put back harness parts

* missing dash

* too much space

* don't reload when clicking

* shorter comment

* only last line

* generate

---------

Co-authored-by: Cameron Clough <cameronjclough@gmail.com>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-05-15 15:33:54 -07:00
Shane Smiskol
5aebdb0ad0 Car docs: pass docs flag to car interfaces (#27311)
* docs

* docs

* docs

* docs

* use docs in gm
2023-04-18 12:22:22 -07:00
Jafar Al-Gharaibeh
97aeb83f95 Mazda: CX-9 2022, Mazda6 2018 FW (#27918)
* Mazda: CX-9 2022 FW

dongle-id: 7200177292912f30

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Add mazda 6 2018 FW FP

dongle id: 0383a108994bd18b

---------

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
Co-authored-by: Samuel <samuel95_54@hotmail.com>
2023-04-17 23:11:38 -07:00
Saber422
18f49b4541 MAZDA: add missing 2018 Mazda6 wagon FW (#27863)
route name:79e2c7ffb9ae445d|2023-04-10--21-58-55--0
2023-04-10 19:10:36 -07:00
Shane Smiskol
581fd62d26 steer limits: rename common dist to meas function (#27453)
* rename function

* make a wrapper function (ford uses dynamic up/down limits

* make two functions consistent

* make torque function convert to int
2023-02-26 17:32:52 -08:00
Shane Smiskol
8f5057ff2d GM: enforce steering command message timing (#27250)
* draft

* bump opendbc

* still draft

* that's not right

* superset of the changes, 33hz

* cleanup

* this should work

* remove line

* pass it in again

* actually no need to check updated now

* now_nanos

* consistent name

* fix replay

* one line isn't that bad

switch

switch

* fix CarController tests

* Update ref_commit
2023-02-09 15:37:39 -08:00
Adeeb Shihadeh
6fa9b555a4 rename carState.radarOffCan to radarUnavailable (#27187)
* rename carState.radarOffCan to radarUnavailable

* bump cereal
2023-02-02 11:38:09 -08:00
Shane Smiskol
aab33b1c5f Lateral jerk unit test (#25759)
* stash

* more test

* less test

* clean test

* no angle

* add tolerance

* fix gm

fix gm

* test both

* lower some rates on hkg

* stash

* simpler

* bump panda

* Revert "bump panda"

This reverts commit f2137c221145cca723fe6ee3378ba947b7061965.

* only torque

* make kona pass

* duplicate __init__

* move

* half clean up

* half clean up

* more clean up

* more clean up

* fix static analysis

* calculate over 0.5 seconds

* limit to max steer

* type annotation

* calc once
2022-12-15 21:52:07 -08:00
Shane Smiskol
f36a3664b0 CarController: log steer sent to the car (#26743)
* log value sent to the car

* rename

* bump

* Update ref_commit
2022-12-10 02:03:40 -08:00
alancyau
9c62513ffa Mazda: Add 2023 CX9 fw (#26704)
* Mazda: Add 2023 CX9 fw

DongleID: 629c4aced073d15a
Discord User: bsk#7841

* Attempt to steer below 28mph for CX9

* undo comment

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2022-12-07 16:50:14 -08:00
alancyau
47977b2c0e Mazda: Add support for 2023 CX9 in CARS.md (#26717)
* Mazda: Add support for 2023 CX9

See https://github.com/commaai/openpilot/pull/26704 for the 2023 CX9 firmware.

* update values

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2022-12-06 16:37:18 -08:00
Shane Smiskol
860f441e2f Car interface: set common params after port (#26613)
* remove pylint exception, _get_params takes no defaults

* clean up

* mock uses it too

* unused

* unused

* fix that

* bump

* Update selfdrive/car/interfaces.py
2022-11-29 11:49:13 -08:00
Jafar Al-Gharaibeh
1be4150089 Mazda: Add CX-5 2023 to supported cars (#26182)
* Mazda: Add CX-5 2023 to supported cars

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* add missing cam fw

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2022-10-25 15:32:49 -07:00
Jafar Al-Gharaibeh
63035e535b Mazda: add missing CX5 2021 FW (#25477)
dongle-id: 82c6d952da5e2122

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
2022-10-20 19:50:42 -07:00
Shane Smiskol
5356216e92 remove unused compute_gb (#25808) 2022-09-15 20:45:01 -07:00
Shane Smiskol
0ef6bb48df FPv2: move car-specific configuration into interfaces (#25711)
* Add VMCU address for EV6

* Rename vmcu

* add to tests

add to tests

* rename to more generic name

* more explicit

* remove print

* Like this much better, removes subtle fingerprinting problems

* clean up

* add test and clean up

* remove hyundai stuffs

* global

* Fpv2Config class

* fix missing fw versions from import order

* unused

* revert for now

* test for fpv2 configs with subtests

* subtests don't work that way

* do toyota as an example

* revert

revert

* do chrysler

* do rest

* stash

* much smaller of a diff than the alternative

* remove unused test

* fix tests

* remove brand from Request

* Make StandardQueries class

* add missing_ecus

clean up

* rename file

* unused

* test implemented

* add comment and rename

add comment and rename

add comment and rename

* should be impossible now

* this is a fixme

* rename to fw_query

* rename this too

* and this

* move vin queries to class

* order

* can use p16!

* formatting

* whoops, this wasn't gated on not len(found_versions)

* make this clear

* Standardize manufacturer software version query
2022-09-09 16:24:29 -07:00
Adeeb Shihadeh
655a64b603 single longitudinal toggle for e2e and disable radar (#25688)
* single longitudinal toggle for e2e and disable radar

* write disable radar param

* rename

* better param name

* clean that up

* update refs

* update translations

* not live for experimental

* write it out

* vanish
2022-09-07 17:12:49 -07:00
Cameron Clough
e9c87daef6 rename esp ECU to abs (#25640)
* rename esp ecu to abs

* bump cereal
2022-09-07 14:25:57 -07:00
Shane Smiskol
a0af3a998d Car docs: add more videos (#25494)
* Add Civic video

* add mazda cx-9 2022 video link
2022-08-19 13:34:23 -07:00
kravatch
3bb1315136 Mazda: add missing CX5 FW versions (#25423)
2022 cx5 signature
2022-08-12 22:31:57 -07:00
Adeeb Shihadeh
347455325e Mazda: use torque controller (#25265)
* Mazda: use torque controller

* update refs

* update refs
2022-07-25 15:16:38 -07:00
Adeeb Shihadeh
d462a08056 remove CS.steeringRateLimited (#25251)
* remove CS.steeringRateLimited

* bump cereal

* update refs
2022-07-24 14:56:55 -07:00
Jafar Al-Gharaibeh
75473daf31 Mazda: update supported models info (#25230)
* Mazda: update supported models info

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* correct format

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2022-07-21 10:20:58 -07:00
Jafar Al-Gharaibeh
a7b778c324 Mazda: Support CX-9 2022 (#25147)
* Mazda: Support CX-9 2022

dongle-id: 8c6e0e30decb68f7

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* update years

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2022-07-13 00:31:52 -07:00
Jafar Al-Gharaibeh
0eab1ed817 Mazda: CX-5 22 FW FP (#24778)
Mazda CX-5 2022 FW FP

dongle-id: 661621a8442f0688

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
2022-07-12 19:38:18 -07:00
Shane Smiskol
fd2de54172 Stock longitudinal: spam resume button when lead starts moving (#24873)
* always log leads, we hide them in ui

* only spam resume when future is > vEgoStarting

* do rest but vw

* vw

* remove comments

* rename to resume

* maintain original button msg rate

* mazda: ensure no resume if cancelling

* same for non-HDA2

* Always run planner if not opLong

* try 0.2

* 0.1 should be pretty safe

* add test for resuming

* fix test

* stricter test, speeds[-1] is 0.14 when starting here

* no walrus

* fixup mazda cc

* remove extra import
2022-07-07 00:24:03 -07:00
Shane Smiskol
e11bb76a64 car docs: remove steering torque hard-coding (#25019)
remove good torque hardcoding
2022-07-01 19:11:28 -07:00
Yu Yamaguchi
b51a90b5a8 Mazda: add missing FW version for CX-5 2022 (#24925) 2022-06-30 23:35:37 -07:00
Shane Smiskol
d2c2154a32 Clean up CarControllers (#25008)
* do VW

* Do the rest

* unused

* ford cc formatting

* final clean ups

* also just return update output
2022-06-30 17:23:12 -07:00
Shane Smiskol
bd782c982f Mazda: log standstill bit (#24923)
* set standstill bit for mazda

* use bit in carcontroller

* Revert "use bit in carcontroller"

This reverts commit f38210a191bcd6e34ff81626e857f778207a55e7.
2022-06-20 23:23:14 -07:00
Shane Smiskol
5aaf5be54c Mazda: fix resume spam at standstill (#24876)
* Fix Mazda resume spam at standstill

* one line

* Revert "one line"

This reverts commit 30c6504ed36adb92991acd6ebf42ffd6fe6c3b8c.
2022-06-16 01:47:29 -07:00
HaraldSchafer
9283040d84 Rocket league model (#24869)
* dd9a502d-c8e2-4831-b365-804b0ae0739d/600 80041070-d276-4fed-bdb9-0075e5442908/420

* no elementwise op

* 9dabf0fe-2e60-44bf-8d3a-d20a74aca072/600 ae746590-0bb5-4a16-80db-15f02d314f03/300 c4663a12-b499-4c9b-90dd-b169e3948cb1/60

* explicit slice

* some copies are useful

* 1456d261-d232-4654-8885-4d9fde883894/440 c06eba55-1931-4e00-9d63-acad00161be0/700 af2eb6ba-1935-4318-aaf8-868db81a4932/425

* 154f663e-d3e9-4020-ad49-0e640588ebbe/399 badb5e69-504f-4544-a99e-ba75ed204b74/800 08330327-7663-4874-af7a-dcbd2c994ba7/800

* set steer rate cost to 1.0

* smaller temporal size

* Update model reg

* update model ref again

* This did upload somehow

* Update steer rate cost

Co-authored-by: Yassine Yousfi <yyousfi1@binghamton.edu>
2022-06-15 15:29:42 -07:00
Shane Smiskol
433fcc0c71 CarInfo: Add harness information (#24085)
* Add harness information

* test harness enum

* add harness info for tucson

* update Tucson harness

* get rid of development

* make global enum

* fix

* add harness info

* add harness info to CARS.md (since we need multiple lines per HKG platform)

* revert this

* Actively Maintained means something! (aka, to bronze with select VW)

* fix caravelle

* add harness tooltip on maintained column

fix

* lol tubaru

* always assume harness

* update honda harnesses

* add Ioniq hybrid 2017-19 harness, todo: not sure

* unused import

* hmm, did they really switch to the C for 1 year??

* add comment

* add comments

* adding tooltips should be fine

* fix santa fe harness

* welcome back, vw

* no need for two harness strings

* seems fine

* fix 19-20 Niro EV harness

* these were taking from old database, so assume correct

* could be d

* pass all car info into template

* no more tool tips

* these use j533 harnesses

* accidentally got removed in merge

* also merge issue

* don't need these

* make harness non-optional
2022-05-11 18:02:21 -07:00
Shane Smiskol
ac1566b4c4 cars: move common car info to subclass (#24481)
* clean up values a bit and make HondaCarInfo for package

* also move min_steer_speed which had 12 occurrences

* odyssey has ALC down to 0

* do Nissan, Mazda, and Chrysler
2022-05-09 18:50:10 -07:00
Adeeb Shihadeh
49c2164814 add alert for CAN bus timeout (#24162)
* add alert for CAN bus timeout

* add alert

* set in interface

* cleanup

* cleanup

* add event

* fix mock

* bump

* bump opendbc

* update refs

* return reader
2022-04-12 22:58:34 -07:00
Shane Smiskol
20085620db Mazda: no steer unavailable alert for cars with full range steering (#23998)
* allow steer if minSteerSpeed is <= 0

* need to understand lkas_blocked, can we just use that?

need to understand lkas_blocked, can we just use that?

* Revert "need to understand lkas_blocked, can we just use that?"

This reverts commit 8793fb562d6ba41ce4fd8c8e8a974d639e98f79b.

* better

* fix

* little more clear

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2022-03-20 16:41:18 -07:00
Adeeb Shihadeh
2219cb4478 cars: cleanup CS usage (#23957) 2022-03-18 15:39:22 -07:00
Shane Smiskol
628eecff06 CARS.md tweaks (#23983)
* CARS.md fixups

* wrong one

* sort footnotes

* Mazda CX-9 has good torque

* Try this

* generate

* yup, os uses native filesystem order
2022-03-17 16:11:03 -07:00
Shane Smiskol
31a6b141d6 Docs: auto-generate supported cars documentation (#23762)
* make CAR class enum, and values.py formatting

* Revert "make CAR class enum, and values.py formatting"

This reverts commit 04d9817e9d5d6ab5c027754018fc445f2cd3067a.

* stash

* add supported packages and model years

* don't change model years in fps

* move Lexus to info dict and make int enum

* remove sometimes wrong model years from name string

* use enum names

* convert Honda's values

* nice names

* use name

* GM

* Mazda, Ford

* Hyundai: WIP

* finish Hyundai

* fix

* Nissan

* Subaru

* Tesla

* formatting is for another PR

* Chrysler: todo: unify the Pacificas?

* do volkswagen

* this isn't a zoo

* skip enums for now

* Update selfdrive/car/volkswagen/values.py

Co-authored-by: Jason Young <46612682+jyoung8607@users.noreply.github.com>

* set All

* temp cars

* auto-generate CARS.md

* update type hinting

* add generated file

* add longitudinal star to cars that support disabling radar

* add TODO

* add notes

* add min_steer_speed exception for hatchback

* add minimum steering speeds

* Add exceptions and run generator

* Missing Telluride

* fix Prius v

* missing Prius Prime

generate

* start to convert years to strings

* Fixup Hyundai

* convert year sets to strings

* handle this

* missing S3

* Fix and add all missing cars (verified with script

* Supported Package fixes

* add get_tiered_cars

* Check radarOffCan for removing most Honda from op long

* Update for Avalon stop and go update on master

* Fix missing car params

* add my temporary script i'm using to verify new generated DBC

add my temporary script i'm using to verify new generated DBC

* generate with jinja template

* add header and footer

* clean up

* rename

rename

* add exceptions. jinja is nice, but why are its loop indexes starting at 1?

* add list of known car videos

* See how these look

* Add nice table formatting for column description

Add nice table formatting for column description

* generate

* consisten br tag

* small clean up

* temp

* Move car videos into CarInfo

* add new copy and rename to footnotes

* Revert "temp"

This reverts commit 93c3fce1d3ab406f80cbfb9c00c2237d109c7846.

clean up

* generate

* replace with svg

* simplify a bit

* add footnotes to CarInfo

* move some variables to docs.py

* Add video link for Acadia

* Make Footnote an enum so we don't use random ints

* static analysis fixes

* move to CARS.md

* fix last missing footnote

* add to release files

* rm test file

* use svg

generate

* fix sorting

* not needed

* not sure how this got here

* remove Sedan/Couple and add Diesel footnote

* finish todos

* move make specific footnotes to selfdrive/car/*/values.py

rename

* change to zeros

* align bottom to center

* Apply some suggestions

* Update selfdrive/car/mock/values.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update copy

* Try headers + bullet points

* somehow better

somehow better

* finish updating copy

* move template and add links to sups

* stars shouldn't be clickable

that didn't work

try this

try this

this is better

* add type hints to CarInfo

add more type hinting

* optional needs a type and any covers all (?)

* move good steering torque to */values.py

* dataclasses are much nicer than attr

* use tuple

* Update docs/cars.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* suggestions

* suggestions

* suggestions

remove

* clean up a bit

* add more type hints

* center stars and remove hardcoding from template

* update copy

* Add test

* Fix types

Fix types

* add supported cars documentation test

* clean up

* replace with docs_definitions

* Add back Footnote enums

* Ah so these are like fstrings!

* Update selfdrive/car/CARS_template.md

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update selfdrive/car/docs.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update year from master merge

* Fix longitudinal star from merge

* sort properly stars by Column enum

* clean up

* HKG: Sorry guys

* Prius V gets FSR star, like others

* Update selfdrive/car/docs.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* update comment

* No Prius docs change for now

Co-authored-by: Jason Young <46612682+jyoung8607@users.noreply.github.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2022-03-16 21:27:05 -07:00
Adeeb Shihadeh
bae78dd46b don't read params in car interfaces (#23978) 2022-03-16 15:17:47 -07:00