Commit Graph

62 Commits

Author SHA1 Message Date
royjr
e377305ea8 Honda Civic 2022: match stock Auto Idle Stop behavior (#27722)
* honda_idlestop_timer

* whoops

* simplify

* just use stopping counter and move bosch radarless specific logic into the function

* it's actually 4 seconds

* Update selfdrive/car/honda/hondacan.py

* check equal to 0

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-03-29 19:04:33 -07:00
royjr
1853d6f40e Honda Bosch Radarless: experimental longitudinal support (#25364)
* civic22_long

* Stock requests -4

* add standstill bit

* bump

* fix standstill

* bump

* bump

* bump panda

* Update hondacan.py

* bump panda

* add docs

* bump panda

* bump panda

* fix control_on value

* set control_off

* fix cars.md

* Update panda

* Update opendbc

* Update panda

* Update panda

* allow more braking

* Revert "allow more braking"

This reverts commit ecd2493a436a095b621d815e8b0c7591fa6b93a9.

* Update panda

* fix speed mismatch

* Revert "fix speed mismatch"

This reverts commit ca795dc5bd9d6e841225e1ac1ff93a1f78618513.

* Update panda

* fix speed mismatch and standstill

* delay stopped message to match stock behavior

* green cruise only when enabled

* Update panda

* Revert "green cruise only when enabled"

This reverts commit d21aa5b541a42fa6d1c87e3b065f720af28ff38b.

* lesser nester

* simplify

* simplify control_on

* simplify common signals

* simplify CONTROL_ON

* lessest nester

* hide speed on gas_override to match stock behavior

* tiny simplification, lesser nester

* flip common acc control values around

* move magic number to global variable

* Revert "move magic number to global variable"

This reverts commit 160be0e0872dc08a8786d97fc2125b2eb131362d.

* remove stopped logic

* remove unused variable

* looks ok

* looks better

* simplify override

* clarify CONTROL_OFF signal comment

* civic22_long_bettercontroloff

shorten delay

init

selfless

whoops

move to carcontroller

selfmore

lower time, currently take 5s to kick in

just right

deline

* Rename CONTROL_OFF -> IDLESTOP_ALLOW

This tells the car its ready to turn off the engine, which does so when the car is standstill.

* Update panda

* Update opendbc

* Update panda

* fix docs

* Update panda

* Update panda

* Update opendbc

* Update panda

* Update panda

* Update panda

* Update panda

* bump panda

* idlestop in another PR

* radarless doesn't need tester present

* simplify that

* helper

* one line is fine

* test bump

* bumpback

* disallow

* reduce diff

---------

Co-authored-by: sshane <shane@smiskol.com>
2023-03-28 01:53:48 -07:00
Shane Smiskol
8f5057ff2d GM: enforce steering command message timing (#27250)
* draft

* bump opendbc

* still draft

* that's not right

* superset of the changes, 33hz

* cleanup

* this should work

* remove line

* pass it in again

* actually no need to check updated now

* now_nanos

* consistent name

* fix replay

* one line isn't that bad

switch

switch

* fix CarController tests

* Update ref_commit
2023-02-09 15:37:39 -08:00
Shane Smiskol
f36a3664b0 CarController: log steer sent to the car (#26743)
* log value sent to the car

* rename

* bump

* Update ref_commit
2022-12-10 02:03:40 -08:00
Shane Smiskol
997b2e11ae Honda Nidec: put max PCM gas into CarControllerParams (#26645)
* limit gas

* bump panda

* not sure why it was represented like this
2022-11-30 20:36:19 -08:00
Harald Schäfer
fbf3ef0895 More Honda rate limit (#26509)
* More Honda rate limit

* Update ref_commit
2022-11-15 14:21:00 -08:00
Harald Schäfer
e58f6fbc11 Rate limit honda steer (#26500)
* Rate limit honda steer

* Update ref_commit
2022-11-15 00:46:47 -08:00
royjr
d740940347 Honda Civic 2022: forward fault bit from camera (#25280)
civic22_brakesystemlight

Rename and add comment

Try using camera's LKAS_PROBLEM value
2022-08-09 12:57:03 -07:00
Adeeb Shihadeh
0ca62bf7df let can packer handle counter (#25240)
* let can packer handle counter

* diff is expected

* update refs

* clean that up

* bump opendbc

* fix sim
2022-07-21 20:54:53 -07:00
Shane Smiskol
fd2de54172 Stock longitudinal: spam resume button when lead starts moving (#24873)
* always log leads, we hide them in ui

* only spam resume when future is > vEgoStarting

* do rest but vw

* vw

* remove comments

* rename to resume

* maintain original button msg rate

* mazda: ensure no resume if cancelling

* same for non-HDA2

* Always run planner if not opLong

* try 0.2

* 0.1 should be pretty safe

* add test for resuming

* fix test

* stricter test, speeds[-1] is 0.14 when starting here

* no walrus

* fixup mazda cc

* remove extra import
2022-07-07 00:24:03 -07:00
Shane Smiskol
f79b068a71 Honda Civic 2022: remove LKAS fault reinitialization (#24979)
* no lkas problem

* remove frame
2022-06-29 20:31:22 -07:00
Shane Smiskol
abcc7338d4 Car Port: 2022 Honda Civic (#24535)
* master 2022 Civic

* bump panda

* bump

* bump cereal

* fix

* needed

* try for now

* maybe

* revert for now

* move to Cam parser

* fix

* move to cam

* need AEB_STATUS too

* bump for debug prints

* bump opendbc and add cruise_params

* bump opendbc and update cruise_params

* bump

* test route

* update ref

* Revert "update ref"

This reverts commit 28345dab63d1919865ccb510265222a4cd4252f4.

* cleanup

* just to test

* bump

* revert

* need to send val 12 too?

* change bus

* not needed

* update bus

* syntax

* move this to other bus too

* Revert "move this to other bus too"

This reverts commit 770bf4745ee244c8426ac108f44b67777198d0a7.

* test new lane line signal

* needed too

* maybe need both?

* Test new LKAS hud message

* bump

* missing comma

* missing

* maybe

* add frame and idx

* add in hud_lanes

* switch this too

* bump panda

* add this

* I guess need this too

* to match

* also

* wasnt correct

* bump opendbc

* bump panda

* move to cam parser

* missing

* add here too

* bump

* remove from cam parser

* bump

* back to cam parser

* its 5hz

* bump for new checksum function

* bump for correct frequency

* update frame and idx

* bump

* bump and update

* send set me bit

* bump

* pass these values through

* silly atom

* ret

* fix this

* use copy instead

* add these too

* to check keyerror

* switch

* bump submodules

* send too

* proper

* Replace HUD with BOH

* add dashed lanes

* small fix

* clean up

* not needed anymore

* remove and change

* this too

* dont always set

* remove additional LKAS message

* bump

* add

* to test

* add frame

* bump

* rebase

* remove default values

* rename

* clean up some carstate logic

* regenerate docs

* spacing

* simplify more logic

* bump opendbc

* bump opendbc

* only if radarless

* panda at least builds now

* add comment

* bump

* fixes

* bump opendbc

* bump opendbc

fix for new DBC

* bump opendbc

* bump opendbc

* carstate: fix bus, parser signals

* Set safety param

* pt bus is 0, not 1

* Fix SCM_BUTTONS and bump panda and opendbc

* fixes for ACC_CONTROL

* bump opendbc

* bump opendbc

* convert from MPH on HONDA_BOSCH_RADARLESS

move is_metric

* make sure we don't disable if radarless

* don't show incorrect harness on website

don't show incorrect harness on website

* bump panda

* remove/update comments

* bump panda

* Fix harnesses

* one line check

* bump opendbc

* remove this

* Some carstate cleanup

We removed STANDSTILL->WHEELS_MOVING

we don't use CRUISE_PARAMS

add back

add back

* more cleanup

* update docs

* marketing says it has TJA and ACC with low speed follow

* send buttons on bus 0

bump panda

* comment

* camera needs to see buttons on bus 2

comment

* bump panda

* add to releases

* remove comments

* comment

* we don't use stock hud yet

Co-authored-by: vanillagorillaa <ntmccoy@yahoo.com>
Co-authored-by: vanillagorillaa <31773928+vanillagorillaa@users.noreply.github.com>
Co-authored-by: kevinharbin <76784413+kevinharbin@users.noreply.github.com>
2022-06-19 00:06:23 -07:00
Shane Smiskol
e375087720 Honda carcontroller and signal cleanup (#24806)
* common signals

* move stopping

* space

* clean up

* bump opendbc
2022-06-11 00:14:58 -07:00
Cameron Clough
779bfbc63e honda bosch: typo affecting longitudinal limits clip (#24603)
* fix typo?

* another typo

* Revert "another typo"

This reverts commit 45cd9bf2e89d2e0af727b502e5a7881eb52c23ee.
2022-05-23 13:13:26 +02:00
grekiki
17e33978cd Mypy fixes for --check-untyped-defs (#24372)
more type fixes
2022-05-12 14:08:11 +02:00
Shane Smiskol
c88ced1f10 Honda Nidec: don't actuate while longitudinal is inactive (#24028)
* don't command any pcm_speed when long is not active

* update refs
2022-03-23 18:30:05 -07:00
Shane Smiskol
70286766da Honda: clean up CarInterface.apply and CarController (#23876)
* clean up honda/carcontroller

* indentation

* fixes

* clean up apply function

clean up apply function
2022-03-18 19:10:59 -07:00
Adeeb Shihadeh
2219cb4478 cars: cleanup CS usage (#23957) 2022-03-18 15:39:22 -07:00
Shane Smiskol
629399a449 carControl: add long and lat active fields (#23859)
* proof of concept

* actuators packet describes which actuators are active

* bump cereal

* fixes

* not needed for this PR

* Do Toyota

* add back controlsState.active

* bump cereal

* rest of cars

* in actuators

* add active back

* which

* use controlsState.active for now

* will make an issue

* Update selfdrive/controls/controlsd.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* move local lat_active checks into CC.latActive

* remove redundant checks

* move comment

move comment

* fix joystick mode

* get enabled from carcontrol

* do standstill check in controlsd

* make sure we consider the gas press case for GM

* use CC.actuators

* fix

* capitalization

* Bump cereal

Bump cereal

* make intermediate actuators

* similar convention to before

* clean that up

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2022-03-13 20:58:44 -07:00
Adeeb Shihadeh
6ff643c478 Honda: remove redundant steer fault check (#23920) 2022-03-07 10:37:23 -08:00
Adeeb Shihadeh
8eb6a6a535 Honda: no actuation while in pre-enabled state (#23657)
* Honda: no actuation in pre-enabled state

* Honda: no actuation while in pre-enabled state
2022-01-28 15:28:17 -08:00
Dean Lee
a653461dec check in tuple instead of list (#23477)
* check in tuple instead of list

* Update selfdrive/car/toyota/carcontroller.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>

* Update selfdrive/car/mazda/interface.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2022-01-10 16:36:51 +01:00
Shane Smiskol
cf9792dc53 Longcontrol: remove starting state (#23328)
* remove starting state

* new ref

* ready for merge

* try this

* cereal now on master

Co-authored-by: Harald Schafer <harald.the.engineer@gmail.com>
2022-01-04 15:40:39 -08:00
Willem Melching
4f1eb4278a Log actuators after applying rate limits in CarController (#23230)
* return actuators from carcontroller

* log it

* pass to latcontrol

* chrysler

* gm

* honda

* more brands

* rest of the brands

* gm cleanup

* hyundai cleanup

* update ref

* rename field

* fix subaru

* add types

* more subaru fixes #23240

* consistent whitespace

* bump cereal
2021-12-16 13:08:20 +01:00
Adeeb Shihadeh
0283942a95 Honda: use new Bosch LKAS_HUD messages (#23000)
* Honda: use new Bosch LKAS_HUD messages

* enum value

* better name

* flip that
2021-12-05 13:51:33 -08:00
Adeeb Shihadeh
b07ddad6ed comma pedal: rename create_gas_command -> create_gas_interceptor_command 2021-11-20 20:13:58 -08:00
Adeeb Shihadeh
70c1f19304 pedal: only send command while actuators active (#22942) 2021-11-16 22:38:23 -08:00
Harald Schafer
0e4058d0ec remove unused line in honda carcontroller 2021-10-07 11:18:55 -07:00
HaraldSchafer
e5da7cc04b no throttle when not enabled (#22474) 2021-10-07 11:15:08 -07:00
Willem Melching
6c29a4c7fb Honda Bosch longitudinal tuning (#22407)
* revert changes to standstill logic

* start with mostly open loop

* Revert "revert changes to standstill logic"

This reverts commit d737d858e7708aedaf09cfc068b85398161e9bbe.

* proper clipping

* less lag

* less gas command

* start gas from -0.2

* controls should take care of that

* use CarControllerParams

* switch to braking sooner

* Revert "switch to braking sooner"

This reverts commit cf11dae334ccb369f625d4b13b7cd4176156a446.

* 2.5x more P

* use active

* engage on rising edge

* Revert "engage on rising edge"

This reverts commit c972956cb460eedaff3d0169a40673a6ea933385.

* update ref
2021-10-07 16:37:02 +02:00
Adeeb Shihadeh
4c0b82308d honda nidec: fix no acceleration with pedal (#22368) 2021-09-28 16:31:12 -07:00
Adeeb Shihadeh
3b8fa4b7fd controls: only send cruise cancel while cruise is enabled (#22359)
* controls: only send cruise cancel while cruise is enabled

* cleanup

* might actually do something

* update refs

* update refs again

* update refs
2021-09-28 12:30:50 -07:00
HaraldSchafer
4e939a9648 NIDEC pedal, good gas/brake transition (#22314)
* need gas to combat windbrake

* coasting deadzone

* no pcm gas and no pedal when braking
2021-09-24 11:24:49 -07:00
HaraldSchafer
74b6c87254 cleanup old nidec accel override logic (#22181)
* cleanup old nidec accel override logic

* add ref without deprecated fields

* no more override
2021-09-10 10:34:18 -07:00
HaraldSchafer
449a28b9aa Speed only ACC control for NIDEC Odyssey (#22156)
* speed only nidec control

* mergeable
2021-09-06 21:11:26 -07:00
Willem Melching
21ae64868e put LongControlState in CarControl.Actuators (#22154) 2021-09-06 18:45:59 -07:00
Harald Schafer
054c912b9a need to add gas here 2021-09-03 14:01:24 -07:00
HaraldSchafer
ebf2a2279d Prevent PID windup on Honda NIDEC (#22112)
* add higher set speed

* freeze when close to cruise

* dont bias this

* higher set speed

* start high

* 2mph might be needed

* better condition

* limit accel windup like this

* wrong name
2021-09-02 14:16:44 -07:00
HaraldSchafer
c93f3b10f7 no more old nidec (#22104) 2021-09-02 12:05:03 -07:00
HaraldSchafer
68066168be Treat ILX braking like other Nidec hondas (#22078) 2021-08-30 13:47:13 -07:00
HaraldSchafer
1ac89f14aa Change car controller interface from gas/brake to acceleration (#21911)
* retune civic

* seems smooth

* back to normal

* new ref

* fix conflict

* runs

* rm

* accel scale is 4

* toyota should be good

* more cleanup

* fixup

* better naming

* update ref

* deprecated

* sending brake when not enable causes a fault

* rm gas and brake

* unused

* update ref

* acura logic is no more

* wrong before

* revert tuning cleanup

* adress comments

* update ref

* already on master

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2021-08-30 09:32:52 -07:00
Adeeb Shihadeh
9e03aa0b92 Honda cleanup (#22008)
* cleanup magic numbers

* long tuning

* indentation

* remove noqa

* little more
2021-08-22 00:27:48 -07:00
HaraldSchafer
e364ca2896 honda nidec safe windbrake interp (#21972) 2021-08-19 19:59:29 +02:00
HaraldSchafer
1c6c56a9df Remove acura (#21946)
* treat acura like nidec

* treat acura like nidec
2021-08-17 11:44:22 -07:00
HaraldSchafer
da73249fc2 Retune nidec long (#21941)
* retune civic

* add a deadzone

* large diffs may not be ok

* typo

* seems smooth

* improve pedal

* back to normal

* new ref

* new ref
2021-08-16 17:06:19 -07:00
Harald Schafer
cae0819e8b whitespace 2021-08-11 21:11:44 -07:00
HaraldSchafer
a8f3e2b3c2 Change long control honda pilot, ridgeline, honda fit, civic, ilx (#21886)
* not used

* just use gas

* allow gas

* try 0

* typo

* set to default

* set default

* makes more sense

* downtune and cleanup

* max accel always

* that is needed to smooth gas to brake

* try downtuning low speed

* try from default

* nidec is not bosch

* air resistance exists

* more smoothing

* wind brake sooner

* Civic experiments2 (#21862)

* control on throttle

* throttle modifier

* get acura in line

* try set speed control again (#21870)

* new acura function

* put back

* put back

* make linter happy

* define wind_brake once

* Civic experiments (#21908)

* remove civic

* start from scratch

* data drivenm

* the data does not lie

* data collection

* data driven

* limit

* final candidate

* fix windbrake

* Civic experiments (#21910)

* remove civic

* start from scratch

* data drivenm

* the data does not lie

* data collection

* data driven

* limit

* final candidate

* fix windbrake

* add acura control

* more cleanup

* cleanup

* update ref

* clip

* seems to fault

* always continuous

* new ref
2021-08-11 18:32:37 -07:00
arfy slowy
d74def61f8 fix: spelling typos (#21861)
* fix: typo spelling grammar

* revert

* Update selfdrive/locationd/calibrationd.py

* more revert

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2021-08-05 12:05:49 -07:00
Adeeb Shihadeh
cb7e96f99d rename enableCruise -> pcmCruise (#21546) 2021-07-10 13:56:11 -07:00
Willem Melching
a8fac002ae Honda Bosch longitudinal prerequisites (#21217)
* untested changes

* set compute_gb

* community feature for good measure

* add code for rolling backwards

* init needs CarParams

* stay in elm mode until carParams is written

* fix tester present bus number

* fix can errors

* fix enableCruise flag

* print when radar disable is done

* move retry logic to controlsd

* move lookup table into carcontroller params

* cleanup brake error values

* make init return

* that should be 1

* floats

* back to no failure handling

* try simplify knockout

* bump panda

* Move flags to panda

* add warnings

* Revert "try simplify knockout"

This reverts commit 4f496245791ea6bd041d4412b96035c6b434b91c.

* add note about LoC.long_control_state

* update ref
2021-06-22 16:28:11 +02:00