run pre-commit in release CI (#25158)

* run pre-commit in release

* add pylintrc and init files

* build first

* add mypy ini

* limit amount of debug scripts shipped in release

* add python version?

* add more missing __init__.py

* excluded rednose for cppcheck

* remove files before dirty check

.github/workflows/selfdrive_tests.yaml

@@ -58,6 +58,9 @@ jobs:
       run: |
         TARGET_DIR=$STRIPPED_DIR release/build_devel.sh
         cp Dockerfile.openpilot_base $STRIPPED_DIR
+        cp .pre-commit-config.yaml $STRIPPED_DIR
+        cp .pylintrc $STRIPPED_DIR
+        cp mypy.ini $STRIPPED_DIR
     - name: Build Docker image
       run: |
           eval "$BUILD"
@@ -66,6 +69,10 @@ jobs:
       run: |
           cd $STRIPPED_DIR
           ${{ env.RUN }} "CI=1 python selfdrive/manager/build.py && \
+                          pre-commit run --all && \
+                          rm .pre-commit-config.yaml && \
+                          rm .pylintrc && \
+                          rm mypy.ini && \
                           release/check-dirty.sh && \
                           python -m unittest discover selfdrive/car"
 

.pre-commit-config.yaml

@@ -54,7 +54,7 @@ repos:
         entry: cppcheck
         language: system
         types: [c++]
-        exclude: '^(third_party/)|(pyextra/)|(cereal/)|(opendbc/)|(panda/)|(tools/)|(selfdrive/modeld/thneed/debug/)|(selfdrive/modeld/test/)|(selfdrive/camerad/test/)/|(installer/)'
+        exclude: '^(third_party/)|(pyextra/)|(cereal/)|(rednose/)|(rednose_repo/)|(opendbc/)|(panda/)|(tools/)|(selfdrive/modeld/thneed/debug/)|(selfdrive/modeld/test/)|(selfdrive/camerad/test/)/|(installer/)'
         args:
         - --error-exitcode=1
         - --language=c++

release/files_common

@@ -57,6 +57,7 @@ common/api/__init__.py
 
 release/*
 
+tools/__init__.py
 tools/lib/*
 tools/joystick/*
 tools/replay/*.cc
@@ -128,7 +129,15 @@ system/clocksd/.gitignore
 system/clocksd/SConscript
 system/clocksd/clocksd.cc
 
-selfdrive/debug/*.py
+selfdrive/debug/can_printer.py
+selfdrive/debug/check_freq.py
+selfdrive/debug/dump.py
+selfdrive/debug/filter_log_message.py
+selfdrive/debug/get_fingerprint.py
+selfdrive/debug/uiview.py
+
+selfdrive/debug/hyundai_enable_radar_points.py
+selfdrive/debug/vw_mqb_config.py
 
 common/SConscript
 common/version.h
@@ -187,6 +196,9 @@ selfdrive/controls/lib/lateral_mpc_lib/*
 selfdrive/controls/lib/longitudinal_mpc_lib/*
 
 selfdrive/hardware
+
+system/__init__.py
+
 system/hardware/__init__.py
 system/hardware/base.h
 system/hardware/base.py
@@ -220,6 +232,7 @@ selfdrive/locationd/laikad_helpers.py
 selfdrive/locationd/locationd.h
 selfdrive/locationd/locationd.cc
 selfdrive/locationd/paramsd.py
+selfdrive/locationd/models/__init__.py
 selfdrive/locationd/models/.gitignore
 selfdrive/locationd/models/car_kf.py
 selfdrive/locationd/models/gnss_kf.py
@@ -330,6 +343,7 @@ selfdrive/manager/process.py
 selfdrive/manager/test/__init__.py
 selfdrive/manager/test/test_manager.py
 
+selfdrive/modeld/__init__.py
 selfdrive/modeld/SConscript
 selfdrive/modeld/modeld.cc
 selfdrive/modeld/dmonitoringmodeld.cc