Commit Graph

320 Commits

Author SHA1 Message Date
Justin Newberry
42ad28875a Tools: a basic auto fingerprinting tool (#30117)
* v1 auto fingerprint tool

* executable

* static analysis

* move to selfdrive/debug

* from any directory

* fix static analysis
old-commit-hash: 05f7c96327a93312379b0ec10880297addfbc073
2023-09-30 20:50:29 -07:00
Jiyong Youn
eb986384c8 HKG: Enable radar tracks for 2021 K5 Hybrid (#30113)
old-commit-hash: 2fee341a90faa652a82d82c3b3b35313d7684db3
2023-09-30 15:19:12 -07:00
Mike McKay
586f6acdac Update vw_mqb_config.py (#30101)
Added a message to tell the user to kill the comma process when running the script.
old-commit-hash: a5f2fd5b1a44ce4e18f5ae8a0271eeb47fb52fae
2023-09-29 11:00:44 -07:00
Adeeb Shihadeh
1b236c3b86 remove old profiling tool
old-commit-hash: 7ac659ade4dc756b56200496439d03dbc5c8e30a
2023-09-25 20:20:24 -07:00
royjr
34aafb5b1c debug: update alerts (#30023)
* remove vehicleModelInvalid

* add locationdTemporaryError

* add paramsdTemporaryError
old-commit-hash: f7f8b769efd0e7d144f6b19903a5a2a9d86c3772
2023-09-23 08:31:20 -07:00
Shane Smiskol
13381ed446 services: capitalize constant service list (#30005)
* rename

* bump

* Apply suggestions from code review
old-commit-hash: 7f073483bb2586053d6c5508ef3f420947941d90
2023-09-21 18:25:15 -07:00
Justin Newberry
c4f322ce2d Linter: remove pylint (#29611)
remove pylint
old-commit-hash: 1ee6ed4b16e2ade0dd887c0687243aee769043e5
2023-08-24 16:30:54 -07:00
Adeeb Shihadeh
16ec56398c add openpilot prefix to imports (#29498)
* add openpilot prefix to imports

* more

* more

* fix docs

* fix linter

* bump submodules

* fix patched tests

* update dynamic imports

* debug

* Revert "debug"

This reverts commit db5e13b9911cc74438bee123bc3430da6c31b24b.

* fix pm test
old-commit-hash: a9626f95b69af19306143fc4def02fb5769405d2
2023-08-20 20:49:55 -07:00
Adeeb Shihadeh
51634f52dc replace custom clock helpers with time module (#29499)
* replace custom clock stuff wtih time module

* fix double

* fix release

* bump cereal

* update type

* fix one more
old-commit-hash: d61f86d3398900ef01423d24cfdf897392a8efbb
2023-08-20 18:50:58 -07:00
Shane Smiskol
7e716dbc87 CANParser: perf benchmark on route script (#29324)
* timing test

* test

* fix

* print

* loop

* clean up

* wider range

* Update selfdrive/car/tests/test_models.py

* Apply suggestions from code review

* run many times

* Update selfdrive/car/tests/test_models.py

* run for many its

* run with unittest and print as list

* Update .github/workflows/selfdrive_tests.yaml

* Update .github/workflows/selfdrive_tests.yaml

* total time is super inconsistent (body)

* Update selfdrive/car/tests/test_models.py

* clean up

* clean up

* clean up

* this works!

* draft

* test suite not as modular

* try something like this

* can do kb, but not too representative

* clean up

* remove kb? it depends on signals

* clean up

* more clean up

* rename

* just measure all CANParsers

* can do all this manually

* but this is way simpler

* comment

* fix mypy

* this is correct too

* 3 seconds instead of 1.5
old-commit-hash: e2910d0720f0b65496234382847da1ab0d086e4d
2023-08-15 20:06:15 -07:00
Justin Newberry
f33b4de80b Ruff: b905 (strict zip) (#29336)
* added mutable default args

* most of the Bs

* add comment about lrucache

* b905
old-commit-hash: e4ead4f1830618f5f61978491930cb0b8d36ab26
2023-08-11 16:13:51 -07:00
Justin Newberry
d487c0501f Ruff: enable most of bugbear (#29320)
* added mutable default args

* most of the Bs

* add comment about lrucache
old-commit-hash: 62c1e6592439119f360dd64b854e7047f35222ba
2023-08-11 15:33:49 -07:00
Shane Smiskol
dd2d4decda test_car_model: remove duplicate argument (#29309)
* only need to pass test_route

* unused
old-commit-hash: 6106876da7604b28681a82be2c5e21c6d7e9a63a
2023-08-09 20:36:49 -07:00
Justin Newberry
3ee0786de3 CI: Pylint to ruff (#29294)
* pylint to riff

* pylint to riff

* pylint to riff

* revert more

* undo exclude removal

* exclude tinygrad

* set line length

* pylint exclusions to ruff

* same excludes as old linter

* fix tools QA

* remove unrequired check

* revert linting third_party

* ignore e402
old-commit-hash: 7fdd9fc37c1c5febf1cd3dc86441ebf0dec7f370
2023-08-09 13:26:54 -07:00
Justin Newberry
7b677910df Linter: Fix >160 line length test (#29287)
* test

* fix line length

* fix line length

* fix file size

* revert poetry

* cleanup for PR
old-commit-hash: cf64b27168614f851087adab2d7f766425922f64
2023-08-08 17:13:35 -07:00
Justin Newberry
ff96892511 Revert "CI: pylint to ruff (#29276)" (#29284)
This reverts commit ffad7279cbad3c4f2ea786287b4624d3a3aa18d7.
old-commit-hash: a91764954b0c9bfe5ccfc8e64321af6bb6c56536
2023-08-08 14:24:04 -07:00
Shane Smiskol
3278d3f557 test fw query: fix migration import (#29283)
huh this was just broken
old-commit-hash: b34341e7e5736d1e67dfb20c8edd9a07d269e2a1
2023-08-08 13:48:11 -07:00
Justin Newberry
99006365a3 CI: pylint to ruff (#29276)
* pylint to riff

* pylint to riff

* pylint to riff

* revert more

* undo exclude removal

* exclude tinygrad
old-commit-hash: cb31a53d8a93cf6cb1f8bd2fff1431716b3a47e4
2023-08-08 13:41:30 -07:00
Adeeb Shihadeh
c1b146cfe9 remove old debug scripts
old-commit-hash: 3da28d4df25a6fb4be92ab45ebafe3289996b0b2
2023-08-06 21:54:08 -07:00
Adeeb Shihadeh
b0c3778aae agnos 8 (#28843)
* agnos 8

* update to python 3.11.4 (#27452)

* rebase

* optional

* lower cython

* TEMP don't pull cl to use python3.11

* Revert "lower cython"

This reverts commit c5132f8a2727c212bdfc01e77aa53e50a17ead9d.

* fix cython

* remove tensorrt

* carla + opencv

* macos

* update timm and smp

* pynvc

* https

* downgrade numpy

* pin scipy

---------

Co-authored-by: Maxime Desroches <desroches.maxime@gmail.com>
Co-authored-by: Yassine <yassine.y10@gmail.com>

* revert that

* fix linter

---------

Co-authored-by: Maxime Desroches <desroches.maxime@gmail.com>
Co-authored-by: Yassine <yassine.y10@gmail.com>
old-commit-hash: 1945c356c2c127cfe1f2d1930e33f2f3af7a1eb4
2023-07-20 21:56:57 -07:00
Adeeb Shihadeh
33e6aad83b Revert "Update pycapnp and Cython (#29021)"
This reverts commit 9f80430d3958cbcf4fb9b67a428f45fd034c5649.

old-commit-hash: 9c307f2550ccade43409c9a5835203fdc355f26c
2023-07-18 18:47:35 -07:00
Maxime Desroches
6ba97408e9 Update pycapnp and Cython (#29021)
* cython + pycapnp

* from_bytes with context

* poetry lock

* limit numpy

* force build

* Revert "force build"

This reverts commit 8c7cb00421da9d0f1b7da2c94f75e9c43733f840.

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 76ef1b9b9f725834256d7b3429e2805739ccbed5
2023-07-18 16:40:36 -07:00
Larry Walters
3ceb097818 Hyundai: enable radar tracks for 2019 Santa Fe (#28623)
Hyundai: Adding second radar FW version for 2019 Santa Fe
old-commit-hash: d8aab568c6f7221525d793d45259ecff2895f30a
2023-06-21 16:40:39 -07:00
Kacper Rączy
2edd65ad4e process_replay: helpers (#28367)
* process_replay helper

* Refactor

* refactor check_enabled uses

* fix __init__

* noqa in __init__ imports

* Move compare_logs outside of process_replay

* Move save_logs to tools.lib.helpers

* Remove save_log from compare_logs

* fix lint issues
old-commit-hash: 64377a88f94527f56ba8e9cd7c01c97100681455
2023-06-06 10:31:13 -07:00
Adeeb Shihadeh
5258610d88 show ign off time in count events debug script
old-commit-hash: 43b0e51906f0054fe4ba0dddf27ce90df443d8bd
2023-05-28 11:59:01 -07:00
Adeeb Shihadeh
0a94d175b0 count_events.py: show alerts
old-commit-hash: ec53fad3c4f9bac5605e635a653d842402ccbf5d
2023-05-14 11:24:48 -07:00
Jason Young
71b94b8d91 VW MQB: Config tool update for new EPS (#28056)
old-commit-hash: a3070d0e356d3b7894d7b7690f693d988aa3130a
2023-04-27 18:40:36 -07:00
Shane Smiskol
85c7764c45 FW versions: import common variable (#27905)
* just import from fw_versions

* fix

* more fix
old-commit-hash: 1520716d429a7d4278c97d4689a6f77eae71bd40
2023-04-14 01:42:37 -07:00
Shane Smiskol
5200751eae test_car_model: allow route or segment name (#27866)
* allow route or segment name

* fix

* fixes

* fixes
old-commit-hash: 50d382884da193b7a0cd5fbc1ea6e42cca6b04a1
2023-04-10 18:56:49 -07:00
Adeeb Shihadeh
3d9dfbf2bd tizi: affine IRQ by action instead of number (#27811)
* tizi: affine IRQ by action instead of number

* do camera irqs

* debug script

---------

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 038d34aa7f25bff127d1265f6b1446cf40fe414b
2023-04-05 16:35:27 -07:00
Jason Wen
d492198bff Hyundai: add Sonata FW version to enable radar tracks (#27463)
old-commit-hash: f9c112e9b87530c463e2b10cac7bf7440d7c32d9
2023-03-20 13:31:50 -07:00
Robbe Derks
4f560215ba Improve OX frame timing jitter (#27582)
* frame timing script

* enable vsync output and improve fsin tracking

* increase measurement time

* fix python linting

---------

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: d26d8b3ba9787dc02b9c116d7e750a3b36dd0846
2023-03-16 10:59:27 +01:00
Shane Smiskol
241cc7b622 test_fw_query_on_routes.py: don't print FW for logging
old-commit-hash: 7f10c736ab0e1f027738b5f64ca75308435a3ade
2023-03-01 15:57:11 -08:00
Shane Smiskol
ab91420b6a CAN fingerprint script improvements (#27355)
* match online logic

* 0 and 2 are different buses. on gm, same address has different lengths

* match fingerprint_from_route
old-commit-hash: 48b059d3670e8082eae785c850508f88b1181188
2023-02-15 15:59:23 -08:00
Jason Wen
6b3d88dc9c Hyundai: Enable radar tracks for Santa Fe 2019 (#27175)
old-commit-hash: b740bdc99c213a73628081b9f07b559420072d99
2023-02-01 13:01:26 -08:00
Shane Smiskol
5bb9a667b8 Fix fuzz_fw_fingerprint.py script
old-commit-hash: 7090a8841935d3a1c67fd915e4898a9880c237b5
2023-01-24 00:04:56 -08:00
Jason Young
fd29973e28 VW MQB: Add diagnostic firewall note to config tool (#26975)
old-commit-hash: f6dc12a735b4856d2ac6225ec9a2f2aa36d2c2de
2023-01-15 13:13:50 -08:00
Shane Smiskol
d56edcf5f3 Fix car docs diff bot (#26955)
fix
old-commit-hash: 406d12b7c17ff0d3d4fb713a90b178978c36d042
2023-01-13 17:20:45 -08:00
Shane Smiskol
0ceb423ccc Car interface: require fingerprint and FW versions to get params (#26932)
* require fingerprint and FW versions

* add get_non_essential_params()

* comment

* all required

* classmethod, need to allow subclasses to override _get_params

* fix that

* fix

* fix

* wrong fix 🤦
old-commit-hash: b00bc4f57e2c9a3acb9e3b10528b7e30cbde43f1
2023-01-12 12:25:24 -08:00
Adeeb Shihadeh
b67646e1ab Revert "Car interface: require fingerprint and FW versions to get params (#26766)"
This reverts commit ff80ac0f7525916211da2cd0fce2c9c5f35ef89d.

old-commit-hash: f14deae475f32af5b04fc2ef3744a77445ad8177
2023-01-12 11:28:04 -08:00
Shane Smiskol
28ceb52c33 Car interface: require fingerprint and FW versions to get params (#26766)
* require fingerprint and FW versions

* add get_non_essential_params()

* comment

* all required

* classmethod, need to allow subclasses to override _get_params

* fix that

* fix
old-commit-hash: b68dabb689104ef0819a6c881b800076deb866f6
2023-01-11 23:44:50 -08:00
Adeeb Shihadeh
7c96e7876a cleanup panda types everywhere (#26574)
* cleanup panda types everywhere

* one more
old-commit-hash: 65fa87a96965000986e76604ac868891e35a86bc
2022-11-21 23:43:24 -08:00
Adeeb Shihadeh
b63326c89a Hyundai: common CAN-FD brake pressed signal (#26170)
* Hyundai: common CAN-FD brake pressed signal

* new name

* bump panda

* bump opendbc to master

* bump opendbc

* bump panda

* bump panda

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: c35e2b8e305b2648ce392ffdefd5d90b39ce353e
2022-10-20 19:55:04 -07:00
Adeeb Shihadeh
60cb813af5 ui: publish draw times + add test (#26119)
* ui: publish draw times + add test

* add some checks

* adjust

* fix linter

* update max

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 15b8c7d1dc3a75d78c0bbaa4f6b866374f6e8672
2022-10-17 17:14:38 -07:00
Jason Young
5812735bbe VW MNB: Add EPS config script support (#26007)
old-commit-hash: 46e741c7cc652a9b1b266c0881ef6f9c30f5a226
2022-10-07 12:50:35 -07:00
Kurt Nistelberger
fb06d2769f Sensor events splitup (#25714)
* PoC of reading sensors via interrupts instead of polling

* add Gyro and draft for magn

* add more functionality to gpio.cc

* change LSM gyro to interrupt

* resolve rebase conflict

* update BMX accel interrupt impl

* add interrupt collector thread to fetch in parallel

* change get_event interface to return true on successful read

* update BMX gyro interrupt impl

* update gpio.h/.cc according to comments

* address comments, rename Edgetype enum

* Edgetype to EdgeType

* update sensor interrupt interface

* add error handling, and read fd on trigger

* avoid sending empty messages

* fix build

* use gpiochip

* less diff

* gpiochip on both edges, but skip falling edge if rising edge is detected

* init last_ts with 0

* update sensord testcases

* update sensord testsweet

* test for pipeline

* readd with_process

* add null check

* move tests update to seperate PR

* sensord: improve test coverage (#25683)

* update sensord-interrupt testsweet

* address review comments

* inc stddev threshold

* fix format string

* add version 0 check again

* relax strictness after c3 with bmx tests

* relax strictness after tests

Co-authored-by: Kurt Nistelberger <kurt.nistelberger@gmail.com>

* address PR comments

* fix typo

* remove 4ms limit, and skip first 0.5sec of data

* revert disable_interuppt change to destructor

* fix and remove timing skip

* make gpiochip generic

* sensord port

* change from sensorEvents to separated events

* fix gyro usage

* add splitted sensor tests

* modify debug script sensor_data_to_hist.py

* refactor get_event interface to remove sensorEvent message type

* update locationd to non sensorEvent usage

* tmp commit

* fix replay

* fix accelerometer type

* fix sensor to hist debug script

* update sensord tests to split events

* remove rebase artifacts

* port test_sensord.py

* small clean up

* change cereal to sensorEvents-splitup branch

* upate sensorEvents in regen

* fix route generation for splitted sensor events

* regen cleanUp from sensorEvents change

* .

* remove light and temp from locationd

* add generic init delay per sensor

* .

* update routes

* move bmx gyro/accel to its own channel

* adopt sensor tests to bmx channel

* remove rebase artifacts

* fix sensord test

* handle bmx not present

* add bmx sockets to regen

* .

* .

* code cleanUp

* .

* address PR comments

* address PR comments

* address PR comments

* lsm clean up

* readd sensorEvents

* rever regen.py

* .

* update replay refs

* move channels

* fix artifact

* bump cereal

* update refs

* fix timing issue

Co-authored-by: Bruce Wayne <batman@workstation-eu-intern2.eu.local>
Co-authored-by: gast04 <kurt.nistelberger@gmail.com>
Co-authored-by: Willem Melching <willem.melching@gmail.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 29d3ed2ce63a65f793dc0ecb553180a0d0fba03e
2022-09-29 14:31:54 -07:00
Cameron Clough
23a4e66b17 configure mypy outside of pre-commit environment (#25892)
* add mypy config matching precommit

* use local mypy, add files to config

* excludes too

* fix config

* pylint is sad now... did it get updated?

* fix typing hints

* ignore

* this should be a regexp

* mypy doesn't like Deque despite inheriting MutableSequence

* more excludes

* Revert "pylint is sad now... did it get updated?"

This reverts commit 250c632f18ecb3d33ffb931e15425f9314a0964b.
old-commit-hash: 4e310b807fb1ccdde4b2078468fab46e5324dfa2
2022-09-27 20:43:05 -07:00
Willem Melching
7451db46cf sensord: use interrupts to improve LSM6DS3 timing accuracy (#24525)
* change LSM6DS3TR(-c) gyroscope  and accelerometer to interrupt

* add pthread for linking

* add interrupt collector thread to fetch in parallel to non interrupt based sensors

* change get_event interface to return true on successful read

* fetch sensor interrupts via gpiochip

* avoid sending empty messages (interrupt only, non interupt magn can leave a gap in the orphan block)

* add verifier script to sensor interrupts (sensor_data_to_hist.py)

* add/update sensord testsweet (test_sensord.py)

* add poll timed out check

* unexport interrupt gpio pins

* gpiochip on both edges, but skip falling edge if rising edge is detected, this is handled in the sensor as the status flag is checked if new data is availble

* add test to sensord to verify 100Hz interrupt frequency

* add sensor shutdown/low power mode functionality on sensord exit

* relax test, will be readded in the splitup PR

Co-authored-by: Kurt Nistelberger <kurt.nistelberger@gmail.com>
old-commit-hash: 84a3c355e5fdb7bb2f50847f925e894eecfa8918
2022-09-12 22:29:31 -07:00
calledit
88d173a925 VW MQB: Added support for APA racks to EPS configuration tool (#25556)
* Added support for APA racks

APA steering racks use a different bit to represent whether the ECU should enable steering assist.
This change supports those APA steering racks.

* Static analysis fix

* Static analysis fix2

* Code cleanup

* Update selfdrive/debug/vw_mqb_config.py

* Apply suggestions from code review

Co-authored-by: Jason Young <46612682+jyoung8607@users.noreply.github.com>

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Jason Young <46612682+jyoung8607@users.noreply.github.com>
old-commit-hash: fc3bdef89143721172230bcf413a08a0091bca32
2022-09-09 11:20:59 -07:00
Adeeb Shihadeh
e4f9781c17 single longitudinal toggle for e2e and disable radar (#25688)
* single longitudinal toggle for e2e and disable radar

* write disable radar param

* rename

* better param name

* clean that up

* update refs

* update translations

* not live for experimental

* write it out

* vanish
old-commit-hash: 655a64b60318ce44ef0271e03de16e8b135b5268
2022-09-07 17:12:49 -07:00