Commit Graph

104 Commits

Author SHA1 Message Date
grekiki
7cd23af9b1 Mypy fixes for --check-untyped-defs (#24372)
more type fixes
old-commit-hash: 17e33978cdd9322918e9d5d388f7fa47aa30e9b7
2022-05-12 14:08:11 +02:00
Gijs Koning
d0fc9afa48 Simulator: Fix CI and set low_quality default (#24354)
* Change low_quality argument and fix closing carla bridge

* Some fixes

* Change carla process in test

* Change fov to 120, higher doesn't look good

* Update readme and remove redundant test

* update

* Add folder description
old-commit-hash: ee433dfa57a60364423a222a7f18dc137b77f532
2022-04-29 07:15:05 -07:00
Gijs Koning
0112f4212f Simulator: Fix keyboard input (#24320)
* Fix keyboard input for simulator

* add unblock_stdout() to test

* Revert import change
old-commit-hash: 01968ca61ba32174f86f826c5b4166890034691c
2022-04-25 07:26:30 -07:00
Gijs Koning
4ed3a158af Simulator Tests (#24274)
* squash #24009

* Fix from other pr
Add low-quality arg

* Update tools/sim/test/test_carla_integration.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Updates for comments. Not finished yet

* commit

* fix arguments

* Final changes for comments

* Final fixes

* increase carla client timeout to 10

* make test executable

* actually wait for controlsd to send messages

* Error proof test. Starting up carla at each test and closing down using docker (tried many things).

* commit test carla

* Removed some time.sleeps
Add some more retries for bridge.

* Stop while loop on shutdown

* Increase teardown waiting time

Co-authored-by: Willem Melching <willem.melching@gmail.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 9be23cbdb9cbb6ee4cfc2e6332a81fd82f18c91e
2022-04-22 18:00:49 +02:00
grekiki
cc943ac9a5 mypy: enable --warn-unreachable (#24282)
* Optional solves mypy assuming None is always None

* oops

* spaces

* Update registration.py

* fix local error

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: b8b15d5cf1d2507c89bbe0e3b1de1ff043d9078e
2022-04-21 18:27:45 +02:00
Gijs Koning
8ddeb3f531 Add wide camera to Carla (#23989)
* Add c3 camera flag to bridge.py

* Set c3_cameras to default

* add runtime error message

* Remove c2 arg

* Update to 163 fov to not see through car

* update comment

* Update tools/sim/bridge.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>

* Revert camera.py changes

* Remove focal_length

* cleanup

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 13254cef2f56e960093ae05471f4c1c0281d7e34
2022-04-20 08:06:56 -07:00
Gijs Koning
7b4b8d3f58 Carla pip dependency and fix for git init (#24258)
* Add carla pip dependency for dev

* Revert other packages in pipfile

* Remove redundant carla install in docker

* Fix CI
Remove broken openpilot_build

* New run command
old-commit-hash: e95a250bcad5f07b7092ba6faf989352d933f678
2022-04-20 05:23:27 -07:00
Adeeb Shihadeh
69bfa59a81 sim: write params to enable in Dockerfile (#24113)
old-commit-hash: d1c3b7a20d0bd62dfb2a4c16d54b9e83b131055b
2022-04-04 09:05:20 -07:00
Adeeb Shihadeh
0c9aa1570b sim: add ignition toggling (#24043)
old-commit-hash: bb36a1c8b2136ef556613abddaca308a05d54295
2022-03-25 14:17:45 -07:00
Jack Huang
d44266bed4 CARLA: fix setting camera EOF (#24034)
* Fix Openpilot in Carla isn't accelerating

The scalars of the timestamp are different in real-world and simulation,
which will cause an infinite loop in selfdrive/modeld/modeld.cc.

* Set eof based on the frame ID

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* remove global

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: db93275d870990979acda75d8c8f9d1d502aabfa
2022-03-25 13:45:08 -07:00
Adeeb Shihadeh
bd71c594a2 pylint: enforce indentation (W0311) (#24039)
* pylint: enforce indentation (W0311)

* few more
old-commit-hash: 8af20af66ddaa6bc06d7f72f9134aa9afeed3ed8
2022-03-24 23:23:29 -07:00
Gijs Koning
772cbb7753 Update carla script to easier install docker and nvidia-docker (#23986)
* Easier docker and nvidia-docker install in carla script

* Small cleanup

* cleanuo

* cleanup

* More comments

* Remove adding usergroup step
old-commit-hash: 3d8537ab23197a383fd1dd7082329ddee1acfdb7
2022-03-18 14:07:39 -07:00
Gijs Koning
cedd8abc05 Rename RGB vision streams to match YUV streams (#23961)
* Renaming VISION_STREAM_RGB_.. to match yuv names like VISION_STREAM_ROAD
VISION_STREAM_RGB_BACK -> VISION_STREAM_RGB_ROAD
VISION_STREAM_RGB_FRONT -> VISION_STREAM_RGB_DRIVER

* little more

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 57b6fdc17a1f84ec922647c044da5df3cafc0ddc
2022-03-14 14:03:54 -07:00
Adeeb Shihadeh
05ba2a5866 sim: fix bridge after default values removed from CANParser
old-commit-hash: 36a3ec04bec98f6b61ada90cdda692dc6fdc0416
2022-01-29 18:22:14 -08:00
Adeeb Shihadeh
1ea1b9072a smaller docker image (#23469)
* save 2gb

* not used

* more cleanup

* little more

* wget too big

* follow

* needed for sim
old-commit-hash: fa3055f280ca56ce4563108a85e6ca6e121310c5
2022-01-10 11:43:18 -08:00
Ewout ter Hoeven
f206ebd054 Pyupgrade 3.6: Update syntax with Python 3.6+ features (#23305)
Updated Python code with Python 3.6+ features:
- utf-8 encoding is now the default (PEP 3120)
- Replace list comprehensions by Generator Expressions (PEP 289)
- Replace yield loop by yield from (PEP 380)
- Remove the (object) subclass when defining a class
- Replace the IOError alias by OSError (PEP 3151)
- Define sets with curly braces {} instead of set()
- Remove "r" parameter from open function, which is default

Co-Authored-By: Adeeb Shihadeh <8762862+adeebshihadeh@users.noreply.github.com>
Co-Authored-By: GregorKikelj <96022003+GregorKikelj@users.noreply.github.com>

Co-authored-by: Adeeb Shihadeh <8762862+adeebshihadeh@users.noreply.github.com>
Co-authored-by: GregorKikelj <96022003+GregorKikelj@users.noreply.github.com>
old-commit-hash: 332f568a8241fba9459cb70c76840b9670e6993a
2021-12-24 11:18:39 -08:00
Ewout ter Hoeven
a962365292 Convert format strings strings to f-strings (#23241)
* Convert all text strings to f-strings

Reformats all the text from the old "%-formatted" and .format(...) format to the newer f-string format, as defined in PEP 498. This requires Python 3.6+.

Flynt 0.69 was used to reformat the strings. 120 f-strings were created in 51 files.

F-strings are in general more readable, concise and performant. See also: https://www.python.org/dev/peps/pep-0498/#rationale

* revert pyextra changes

* revert ublox.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 55390d273f36f49da3896e687ac5530f40c1d150
2021-12-16 14:58:17 +01:00
Dean Lee
9b0fcaeb84 rename yuv streams (#23071)
* rename yuv streams

* bump cereal

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 348d2d2b0d169b0d181a51eb0e23b1f9b8fc6793
2021-11-29 18:14:59 -08:00
Willem Melching
70e2e78f52 sim: improve carla performance (#23046)
old-commit-hash: a4ca8e4835949f5f8a5d6123142f9ffcb7e36245
2021-11-28 11:32:37 +01:00
Adeeb Shihadeh
94d30c6c5f camerad: remove camera frame stream (#23045)
* camerad: remove camera frame stream

* fix release files
old-commit-hash: 8160cf3c1b2726709db58219c33d1616b4a8acb5
2021-11-27 21:58:21 -08:00
jimw
cf29eacca4 CARLA: send YUV and RGB over visionipc from bridge.py (#23012)
* CARLA: send YUV and RGB over visionipc

* CARLA: send YUV and RGB over visionipc-fix pipfile

* CARLA: send YUV and RGB over visionipc-Camerad class

* relock pipfile

* small bridge cleanup

* use tici camera resolution

* update vof

* HUD_SETTING has no counter

* no loggerd

Co-authored-by: jwolffe <wolffja@gmail.com>
Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: a58d272ae4afa11624220b9392295ad6659db1df
2021-11-26 16:58:25 +01:00
Adeeb Shihadeh
17b51d3fd8 sim: fix CAN error and block loggerd
old-commit-hash: 45ced84acf9d0c8fcb5d37a9be82f81b5ff59479
2021-11-13 12:21:24 -08:00
Adeeb Shihadeh
fc4b12c05c sim: set fingerprint with environment variable (#22679)
old-commit-hash: e556d3d3d3bf6a0cdc588abbae57b256aace0351
2021-10-24 21:59:50 -07:00
jimw
aaae6ac738 sim: send peripheralState message (#22541)
* controlsd: ignore peripheralState for Simulation

* controlsd: use fake peripheralState for Simulation

* controlsd: use fake peripheralState for Simulation

* controlsd: use fake peripheralState for Simulation

* Apply suggestions from code review

* sim: send peripheralState message

* sim: send peripheralState message

* sim: send peripheralState message

* sim: send peripheralState message

Co-authored-by: wolffja <wolffja@ubuntu20.04LTS>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 26c5e7b826cc04e301e3c8c50884582f05e27ceb
2021-10-13 17:16:56 -07:00
xia0long
42b4521f7b sim: update CARLA to 0.9.12 (#22497)
* bump carla

* update dockerfile

* no need

* specify version

* some fixups

* fix start_carla

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: a3c26a912a9d26233d040bd71fe5324cd25142fd
2021-10-10 15:54:47 -07:00
Adeeb Shihadeh
3ed45d74dd improve sim readme
old-commit-hash: 04271fef55d1ecf7d4a41c90a6e3331d7c5db294
2021-10-10 15:50:30 -07:00
Robbe Derks
58c99158a1 Make pandaState and safetyMode a list (#22454)
* wip: move to pandaStates

* bump cereal

* wip: SafetyMode struct

* move to safetyMode

* fix typo

* this can be None

* fix potential empty pandaStates list

* fix thermald

* fix controlsd

* rename safetyModes to safetyConfigs

* update process_replay

* fix test_models

* bump cereal
old-commit-hash: 91987f38d425e2a5dc61d09571933cffb9536113
2021-10-08 17:54:34 +02:00
Adeeb Shihadeh
782d7023d2 phonelibs -> third_party (#22477)
* git mv to third_party

* find and replace

* fix release tests

* update pre-commit

* update tici bins

* update eon bins

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 5b641379ae04d3408093381629b9d60dee81da27
2021-10-07 16:32:44 -07:00
Adeeb Shihadeh
b3fdccfab3 sim: build openpilot with frame stream camera
old-commit-hash: 59c47f0334524fc63b35b1fe067a70d47e1fe3de
2021-10-07 11:31:49 -07:00
Piotrek Rybiec
415de2224c sim: fix race condition in tmux script (#22365)
* carla simulator tmux script enhancement

* real name

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 8412f607b7145a64a0a78a585f27912557d10ee9
2021-09-28 14:07:41 -07:00
Alfonso Hernandez
0f3b5ba1dd Fix throttle scaling in simulator to match gas 1.0 to NIDEC_ACCEL_MAX in Honda CarControllerParams (#22310)
old-commit-hash: 703d0cb832fb04119d88cb796ff6845eae0557d4
2021-09-22 09:38:38 -07:00
HaraldSchafer
c422cce205 Port lateral planning to ACADOS (#22080)
* lateral acados

* looks good!

* add another solve, needed for init somehow

* use copy

* init correctly

* cleanup sconstruct

* Update files_common

* update cpu usage

* reset when invalid

* fix cpu usage

* cost_set doesnt leak

* new ref

* non leaky reset

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 7081ab4fb7473a5be424db4b63e6bdaacf62157f
2021-09-13 19:06:54 -07:00
HaraldSchafer
a73a820338 Change car controller interface from gas/brake to acceleration (#21911)
* retune civic

* seems smooth

* back to normal

* new ref

* fix conflict

* runs

* rm

* accel scale is 4

* toyota should be good

* more cleanup

* fixup

* better naming

* update ref

* deprecated

* sending brake when not enable causes a fault

* rm gas and brake

* unused

* update ref

* acura logic is no more

* wrong before

* revert tuning cleanup

* adress comments

* update ref

* already on master

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 1ac89f14aa7c45c56049e8dbb0d6c5bb83a0fc6b
2021-08-30 09:32:52 -07:00
HaraldSchafer
7e87930a20 Refactor lateral lag compensation (#21334)
* add T_IDXS

* refactor

* fix test

* unused

* typo

* needs casting

* Update selfdrive/controls/lib/drive_helpers.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* deprecate field

* regen all

* new segs

* add todo

* split back

* clean

* bad names

* do in controls

* add arg

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 6838e1c82c5abb9f347228006219d96744b3fbb5
2021-06-30 14:19:39 -07:00
orphen
b433129fd6 fix: sim: gracefully shutdown the bridge (#21413)
old-commit-hash: 325cabd4da786dae7f74558d2f41aaf1d471abaf
2021-06-29 13:45:34 -07:00
HaraldSchafer
34ca4a1a29 Simplify longitudinal tests (#21337)
* first pass

* passes!

* little more cleanup

* little more

* fix sim

* remove more plot stuff

* fix crash check

* fcw

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 234971203bbad057d85a61267e6ac7f2432394d6
2021-06-24 21:03:18 -07:00
Alfonso Hernandez
4f3ad7284c Simulator: Complete GPS message from Carala State Values (#21357)
old-commit-hash: 22b632f4078a979d34b833a4a265ac79014465c3
2021-06-21 13:52:46 +02:00
siggie0815
35f0bcb35a CARLA: save calibration params as capnp (#21144)
old-commit-hash: c798c5f027f8bb3fa507c980550addae18e648a8
2021-06-04 16:05:05 -07:00
Josh Smith
2cae3a3799 Add type hints, small cleanups (#21080)
* improve tools.lib.kbhit and tools.sim.lib.keyboard_ctrl

* unpack more efficiently

* minor improvements

* agnos.py match spec better

* manual_ctrl test missing queue arg

* fix incorrect type annotation

* queues are generic

* varname reuse resulting in incorrect type inference

* bytes().hex() rather than bytes.hex(bytes())

* a bit of type hinting stuff
old-commit-hash: 77321dbac4ebfedf9cb5e9085e16055346299749
2021-06-03 12:21:04 +02:00
Cameron Reikes
5d11f5adc5 sim: get GPS data from CARLA (#20717)
* Send simulated carla GPS to OP

* Use ublox enum from cereal

* Add more fields to carla gnss packet

* use math.degrees

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: fc4f27d20a9a3fdb0f91a8149e9b53a5c6e31828
2021-05-18 19:52:09 -07:00
Cameron Reikes
78ae1be356 Set standstill bit in sim (#20921)
old-commit-hash: 12ce8222529985948fb4bc985e0c2e545eb21ad6
2021-05-15 21:09:17 -07:00
siggie0815
c3a6cc6aa0 sim: mount working dir to the same dir in the container (#20908)
old-commit-hash: 4b7ea0a0329ebae3a56965270eac6dedd6a0e1d1
2021-05-14 20:00:13 -07:00
ChoMinSung
7aed8355db start_openpilot_docker.sh: pass in /dev/input for joystick support (#20563)
old-commit-hash: 780654cb3b3d9bce4ff4f4cfeb727d58cc427c91
2021-04-06 09:55:18 +02:00
Willem Melching
d0cd4d6de9 sim/build_container.sh: fix container name
old-commit-hash: c56396800351d09303cfa0b34442962fb7830faf
2021-03-23 13:20:59 +01:00
ChoMinSung
a5727d14cb start_openpilot_docker.sh: fix docker container name (#20444)
old-commit-hash: 34342b21a9b8524f21a9f8e23d0bd1f5364132cb
2021-03-23 13:20:11 +01:00
iejMac
8aa491994f update simulator README
old-commit-hash: 1830a87d9a39dee0f92dc5d2922513ab3d6e6d61
2021-03-17 00:42:32 -07:00
iejMac
10844d3b57 mount openpilot in simulator docker image (#20379)
* mount parameter

* works

* fixes
old-commit-hash: dc1506e3821fc372c267279e879b807757a2a28b
2021-03-16 22:23:38 -07:00
wolterhv
dfb437648e Specify comma containers come from ghcr.io in docker pull commands. (#20342)
old-commit-hash: 5463469f71e7861ccfbbd4d09b8e4ae56b8d3e45
2021-03-14 12:59:05 -07:00
iejMac
9f86db04ea Minimize sim docker image size (#20324)
old-commit-hash: 1e5b04ba2fd4642de2730041355714de6f497ed5
2021-03-11 19:04:29 -08:00
iejMac
7780426434 improving tools readme (#20305)
* rough draft

* plotjuggler and carla description

* testing someting

* this is cool

* very short replay and debug desc

* small change

* small change 2

* better word

* low quality mode

* better word

* fixes

* changes

* minor fixes

* ubuntu_setup fix + README changes

* Update tools/README.md

* Update README.md

* Update README.md

* Update README.md

* changes

* Update tools/sim/README.md

* final changes

* final change

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: c4031750f366905371565e3f9c80033534040647
2021-03-11 15:28:37 -08:00