From 422885dce67732ccc847baef2917e81a0e01f2bd Mon Sep 17 00:00:00 2001 From: David <49467229+TheSecurityDev@users.noreply.github.com> Date: Mon, 16 Feb 2026 11:55:46 -0600 Subject: [PATCH] ui replay: cleanup and fix workflow todos (#37230) * fix: update pull request trigger and clean up workflow paths * fix other event names --- .github/workflows/ui_preview.yaml | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ui_preview.yaml b/.github/workflows/ui_preview.yaml index 3663257da..72ced4985 100644 --- a/.github/workflows/ui_preview.yaml +++ b/.github/workflows/ui_preview.yaml @@ -3,15 +3,14 @@ on: push: branches: - master - pull_request: # TODO: change back to pull_request_target before merging + pull_request_target: types: [assigned, opened, synchronize, reopened, edited] branches: - 'master' - paths: # TODO: remove workflow path before merging + paths: - 'selfdrive/assets/**' - 'selfdrive/ui/**' - 'system/ui/**' - - '.github/workflows/ui_preview.yaml' workflow_dispatch: env: @@ -101,7 +100,7 @@ jobs: uses: AnimMouse/setup-ffmpeg@ae28d57dabbb148eff63170b6bf7f2b60062cbae - name: Finding diffs - if: github.event_name == 'pull_request' + if: github.event_name == 'pull_request_target' id: find_diff run: | export PYTHONPATH=${{ github.workspace }} @@ -139,7 +138,7 @@ jobs: } >> "$GITHUB_OUTPUT" - name: Saving proposed ui - if: github.event_name == 'pull_request' + if: github.event_name == 'pull_request_target' working-directory: ${{ github.workspace }}/master_mici run: | git config user.name "GitHub Actions Bot" @@ -164,7 +163,7 @@ jobs: git push origin ${{ env.REPORT_FILES_BRANCH_NAME }} - name: Comment on PR - if: github.event_name == 'pull_request' + if: github.event_name == 'pull_request_target' uses: thollander/actions-comment-pull-request@v2 with: message: |