Commit Graph

108 Commits

Author SHA1 Message Date
Dean Lee 0984736972 cpplint: add filter `build/include_subdir` (#29585)
old-commit-hash: 21da5a216f
2023-08-24 15:42:17 +01:00
Dean Lee 5f4b422305 cpplint: add filter `whitespace/semicolon` (#29568)
old-commit-hash: f203648de0
2023-08-23 15:00:30 -07:00
Dean Lee 97e9d55588 cpplint: `build/include_what_you_use` (#29556)
* include_what_you_use

* remove comments

* include <memory>

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 2d99521e75
2023-08-23 13:25:17 -07:00
Dean Lee 004a097c95 cpplint: add `readability/braces` filter (#29554)
old-commit-hash: 363740a497
2023-08-23 10:13:46 -07:00
Adeeb Shihadeh 701cd6f6fe add cpplint (#26855)
* setup cpplint

* only start that

* check line length

* check these

* rm exceptions
old-commit-hash: 952d720b6e
2023-08-22 13:55:23 -07:00
Adeeb Shihadeh 16ec56398c add openpilot prefix to imports (#29498)
* add openpilot prefix to imports

* more

* more

* fix docs

* fix linter

* bump submodules

* fix patched tests

* update dynamic imports

* debug

* Revert "debug"

This reverts commit db5e13b9911cc74438bee123bc3430da6c31b24b.

* fix pm test
old-commit-hash: a9626f95b6
2023-08-20 20:49:55 -07:00
Justin Newberry d487c0501f Ruff: enable most of bugbear (#29320)
* added mutable default args

* most of the Bs

* add comment about lrucache
old-commit-hash: 62c1e65924
2023-08-11 15:33:49 -07:00
Adeeb Shihadeh b7f6b6dc95 pytest unit test running (#29261)
* setup config

* collect passes

* pytest system/ works
old-commit-hash: 670fa9af5f
2023-08-10 08:23:19 -07:00
Adeeb Shihadeh 8e2a03b46d rm some old tests
old-commit-hash: 44c76257a1
2023-08-09 22:31:47 -07:00
Dean Lee f39cb90a09 camerad: auto free the buffer when it goes out of scope (#28807)
old-commit-hash: 8076107b4f
2023-08-08 13:26:04 -07:00
Mitchell Goff 49b07db500 Added python VisionBuf class (#29075)
* Added python VisionBuf class

* fixed property names

* Bump cereal
old-commit-hash: f0ae0c34cd
2023-07-25 01:08:39 -07:00
Dean Lee 05b2a0b884 common/swaglog: remove trailing semicolon from macros (#29042)
old-commit-hash: 269ceca27a
2023-07-19 19:46:42 -07:00
Dean Lee 9be7d252b8 camerad: remove unused frame_length from `struct FrameMetadata` (#28693)
* remove unused frame_length

* bump cereal

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 9784f61f23
2023-06-25 12:51:10 -07:00
Mitchell Goff 31834eac4c Remove get_model_yuv_transform function (#28568)
* remove yuv_transform from update_calibration

* Remove get_model_yuv_transform entirely
old-commit-hash: ae5bfcf248
2023-06-21 20:02:44 -07:00
ZwX1616 a18a41659d camerad: write static AE settings only once (#28134)
* this is free

* illusion of choice
old-commit-hash: 78ba67e211
2023-05-08 18:43:54 -07:00
ZwX1616 2a5ca702e7 OX03C10: improve tone mapping (#27754)
Co-authored-by: Comma Dev1ce & Y. Yousfi <device@comma.ai>
old-commit-hash: 4b1f77d54a
2023-04-05 19:46:04 -07:00
ZwX1616 897271fc32 camerad: reduce daytime HDR blur (#27644)
* 60hz

* be dynamic

* cast

---------

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 25a7f87b42
2023-03-22 13:44:29 -07:00
Dean Lee cf52038858 camerad: remove deprecated focus parameters from FrameMetadata (#27638)
old-commit-hash: a86730a2c6
2023-03-21 16:55:06 -07:00
Robbe Derks 4f560215ba Improve OX frame timing jitter (#27582)
* frame timing script

* enable vsync output and improve fsin tracking

* increase measurement time

* fix python linting

---------

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: d26d8b3ba9
2023-03-16 10:59:27 +01:00
ZwX1616 6b64d20006 ci: intra-camera timing check (#27069)
* test frame time

* 1 is still much tighter than 5
old-commit-hash: e2e780e7c6
2023-01-24 16:34:41 -08:00
Adeeb Shihadeh 16dabbd686 fix typo AR0321 -> AR0231 (#26993)
old-commit-hash: ef42652368
2023-01-17 19:52:06 -08:00
ZwX1616 93679d10fc camerad: reduce ox LFM noise (#26949)
* wip

* make separate score func

* n4ot g

* clean up

* remove

* simplify

* b2b

* more than 0

* this is fine

* led

* balance costs

* clean up

* no if tici

* box view

* new baselines

* Revert "new baselines"

This reverts commit f7a5d059eda70fa4d49e3024923da30e8821f42b.

* Revert "box view"

This reverts commit a57924be36e7d6abc2585aca9575c74cd583ef86.

* maximize dcg

Co-authored-by: Comma Dev1ce <device@comma.ai>
old-commit-hash: bc8e2032f7
2023-01-17 14:16:28 -08:00
ZwX1616 0dc7085d41 camerad: rework ox exposure score (#26948)
* wip

* make separate score func

* n4ot g

* clean up

* remove

* simplify

* b2b

* balance costs

* clean up

* no if tici

* box view

* new baselines

* Revert "new baselines"

This reverts commit f7a5d059eda70fa4d49e3024923da30e8821f42b.

* Revert "box view"

This reverts commit a57924be36e7d6abc2585aca9575c74cd583ef86.

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 028527423c
2023-01-13 21:32:15 -08:00
Adeeb Shihadeh b3e47c691b move all third party stuff into third_party/ (#26853)
* mv fastcluster

* move msm_kgsl.h

* camerad include

* update path

* mv pyextra

* fix tici build

* add acados_template to release build

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: cd8e03d53e
2022-12-31 21:00:50 -08:00
ZwX1616 2bbf68c63b camerad: lower cost for OX high gain idxs (#26775)
old-commit-hash: e6e33531ca
2022-12-12 16:35:25 -08:00
ZwX1616 8a32eec398 camerad: minor ae improvement to OX (#26566)
old-commit-hash: 2153bfe27a
2022-11-23 13:08:04 -08:00
ZwX1616 0ec1b66315 camerad: fix OX flicker (#26439)
old-commit-hash: 5eaf525c18
2022-11-09 21:49:24 -08:00
Kurt Nistelberger 2d2e3a8d48 CI: camera box update (#26414)
* check if all frames are laggy

* apply tolerance

Co-authored-by: Kurt Nistelberger <kurt.nistelberger@gmail.com>
old-commit-hash: 4ec1c7e614
2022-11-08 13:51:16 -08:00
ZwX1616 d8a3d93a9d CI: set OX frame sync tolerance (#26347)
* ox tolerate

* int

* update comments
old-commit-hash: aab4b79416
2022-11-03 14:27:45 -07:00
ZwX1616 dec5a0f014 camerad: fix OX not having vignetting comp (#26329)
old-commit-hash: fdd125853f
2022-11-02 14:42:29 -07:00
Rohit Bernard bf27021719 sim: Converting RGB frames to NV12 format in OpenCL (#26169)
* convert carla rgb frames to nv12

* code cleanup

* move kernel

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 9377448888
2022-10-29 13:20:37 -07:00
Adeeb Shihadeh 52529fb8f6 fix autobrightness for OX03C10 (#25915)
* fix autobrightness for OX03C10

* fix scaling

* use cur ev

* oops

* bump cereal
old-commit-hash: 2384a9ee67
2022-09-28 15:45:15 -07:00
Adeeb Shihadeh f50800b768 camerad: improved frame sync and skip tests (#25904)
* camerad: cleanup frame sync and skip tests

* fix linter

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 1c6dc12a04
2022-09-27 21:32:21 -07:00
ZwX1616 0bc78ce16b camerad: recalibrate ox colors for HDR (#25874)
re
old-commit-hash: 4ed0abd197
2022-09-22 12:52:48 -07:00
ZwX1616 129a49aeef camerad: fix OX page faults (#25853)
old-commit-hash: bae94a0070
2022-09-20 16:00:56 -07:00
Dean Lee 761cb60c54 camerad: fix class/struct forward declaration mistake (#25842)
old-commit-hash: 8870b439dd
2022-09-19 13:24:20 -07:00
Dean Lee f7b83d6f02 camerad: make sure cl_context is valid for lifetime of camerad (#25735)
old-commit-hash: 8ae3199578
2022-09-16 21:10:26 -07:00
Dean Lee b546a476cc camerad: cleanup CameraBuf::acquire (#25737)
* cleanup

* add that back

* less indent

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 78fd303d50
2022-09-16 20:50:10 -07:00
Dean Lee d482e04b01 camerad: remove function camera_autoexposure (#25733)
old-commit-hash: 5bb230cde4
2022-09-16 20:18:54 -07:00
Dean Lee e1c1a8fc2a CameraBuf: remove unused member 'camera_state' (#25736)
old-commit-hash: 25ce997f37
2022-09-16 20:11:46 -07:00
Dean Lee 0ce385a486 camera_qcom2: remove unneeded static keywords (#25780)
old-commit-hash: 467c4f7fb3
2022-09-16 20:10:08 -07:00
ZwX1616 7cd138328e better OX03C10 settings (#25796)
* ev has different scales

* fix initial gradient

* fix highlight weirdness

* try smooth set of gains

* delay

* add gain idx

* oops

* set different min dc

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: c7a0f23b45
2022-09-15 15:06:43 -07:00
Adeeb Shihadeh 565511431d camerad: log image sensor in camera states (#25786)
* camerad: log image sensor in camera states

* for all cams

* bump cereal

* revert that

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 7352e6d940
2022-09-14 15:40:29 -07:00
Dean Lee fad0bdf23c camerad: build camerad on PC (#25726)
* compile camerad on PC

* scons cleanup

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 29f9c536b4
2022-09-11 13:56:38 -07:00
Dean Lee 158f9f0cde camera_qcom2: move util functions to separate files (#25720)
old-commit-hash: 1c8aa88161
2022-09-10 14:22:43 -07:00
George Hotz 71f609f2cc port OX03C10 (#25161)
* start porting OS04C10

* something

* is the pll why this doesn't work

* understand plls, still doesn't work

* work

* weee something

* working?

* timing

* encoderd works with less cameras

* 1928

* flip image

* color balance

* adjust black level

* extra height maybe

* cleanups

* clean up sensor i2c

* sensors

* approx 20fps

* remove mirror

* 50ms, no fsin yet

* remove imx390 support

* some attempt at AE

* linearize the response

* OX changes (#25697)

* organize

* wb

* best effort but probably messed up by artifacts

* multicam sync

Co-authored-by: Comma Device <device@comma.ai>

* clean up

* more

* fix multiexposure

* start porting OS04C10

* something

* is the pll why this doesn't work

* understand plls, still doesn't work

* work

* weee something

* working?

* timing

* encoderd works with less cameras

* 1928

* flip image

* color balance

* adjust black level

* extra height maybe

* cleanups

* clean up sensor i2c

* sensors

* approx 20fps

* remove mirror

* 50ms, no fsin yet

* remove imx390 support

* some attempt at AE

* linearize the response

* OX changes (#25697)

* organize

* wb

* best effort but probably messed up by artifacts

* multicam sync

Co-authored-by: Comma Device <device@comma.ai>

* clean up

* more

* fix multiexposure

* unbroken AE

* oops

* sort of good AE

* both should work 1

* open then init

* fix debayer

* rename

* fix test build

Co-authored-by: Comma Device <device@comma.ai>
Co-authored-by: ZwX1616 <zwx1616@gmail.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: aea1a0d5e6
2022-09-09 22:38:00 -07:00
Robbe Derks ab7ff545c5 camerad: read param to see if we want manual gain (#25642)
* also read params to determine if we want manual gains

* check for larger than 0

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: 7ecc0409bd
2022-09-01 22:18:44 -07:00
ZwX1616 cf84a3ba30 camerad: optional exposure params overrides (#25616)
* add params override

* speedup

* put in param list

* clean up names

Co-authored-by: Comma Device <device@comma.ai>
old-commit-hash: e9258cccbe
2022-08-31 16:40:25 -07:00
Adeeb Shihadeh 35ff65121e pre-commit: add codespell (#25571)
old-commit-hash: 6590fb2b93
2022-08-30 11:20:55 -07:00
Adeeb Shihadeh d9c279aea9 params: make python and c++ API match (#25573)
* params: make python and c++ API match

* few more
old-commit-hash: 90a4565eb2
2022-08-26 20:46:19 -07:00
Adeeb Shihadeh e3f291fe45 webcam isn't a special build anymore
old-commit-hash: c626198575
2022-08-26 20:44:29 -07:00
Adeeb Shihadeh 0448644af4 only build camera test on pc
old-commit-hash: 6bbea8080e
2022-08-25 19:59:22 -07:00
Dean Lee a9f4294d99 CameraBuf: remove unused cur_rgb_buf (#25544)
rm cur_rgb_buf
old-commit-hash: 405e6c046d
2022-08-24 11:03:12 -07:00
Willem Melching 4d924f1b39 camerad: cleanup unused RGB code (#25172)
* camerad: cleanup unused RGB code

* hdr is unused

* more cleanup

* remove envs

* remove from sconsfile

* fix docs
old-commit-hash: f38204ad26
2022-07-14 19:21:40 +02:00
Dean Lee db39cae8f6 camerad: reduce cpu usage (#24993)
wait for 50ms
old-commit-hash: d13137a83f
2022-06-30 11:29:25 +02:00
Dean Lee be6634b037 Camerad: small cleanup (#24992)
* remove CameraExpInfo

* remove release callback
old-commit-hash: e20d2cfa9b
2022-06-30 11:05:49 +02:00
Maxime Desroches 53dd6afc96 snapshot: fix rgb overflow (#24963)
clamp rgb
old-commit-hash: 240c44e50c
2022-06-27 15:36:27 +02:00
Adeeb Shihadeh d9d83b0225 Move camerad to system/ (#24836)
* mv camerad

* add hardware symlink

* fix unit tests
old-commit-hash: 6123ab3d1c
2022-06-19 14:43:49 -07:00