Removed build strict test and enabled -Werror flag

.circleci/config.yml

@@ -40,19 +40,6 @@ jobs:
           path: /tmp/misra/misra_safety_output.txt
 
 
-  strict-compiler:
-    machine:
-      docker_layer_caching: true
-    steps:
-      - checkout
-      - run:
-          name: Build image
-          command: "docker build -t panda_strict_compiler -f tests/build_strict/Dockerfile ."
-      - run:
-          name: Build Panda with strict compiler rules
-          command: |
-            docker run panda_strict_compiler /bin/bash -c "cd /panda/tests/build_strict; ./test_build_strict.sh"
-
   build:
     machine:
       docker_layer_caching: true
@@ -105,6 +92,5 @@ workflows:
     jobs:
       - safety
       - misra-c2012
-      - strict-compiler
       - build
       - safety_replay

board/Makefile

@@ -1,5 +1,5 @@
 PROJ_NAME = panda
-CFLAGS = -g -Wall
+CFLAGS = -g -Wall -Wextra -Wstrict-prototypes -Werror
 
 CFLAGS += -mlittle-endian -mthumb -mcpu=cortex-m4
 CFLAGS += -mhard-float -DSTM32F4 -DSTM32F413xx -mfpu=fpv4-sp-d16 -fsingle-precision-constant

board/Makefile.strict

@@ -1,8 +0,0 @@
-PROJ_NAME = panda
-CFLAGS = -g -Wall -Wextra -Wstrict-prototypes
-
-CFLAGS += -mlittle-endian -mthumb -mcpu=cortex-m4
-CFLAGS += -mhard-float -DSTM32F4 -DSTM32F413xx -mfpu=fpv4-sp-d16 -fsingle-precision-constant
-STARTUP_FILE = startup_stm32f413xx
-
-include build.mk

tests/build_strict/Dockerfile

@@ -1,9 +0,0 @@
-FROM ubuntu:16.04
-
-RUN apt-get update && apt-get install -y gcc-arm-none-eabi libnewlib-arm-none-eabi python python-pip gcc g++
-
-RUN pip install pycrypto==2.6.1
-
-COPY . /panda
-
-WORKDIR /panda

tests/build_strict/test_build_strict.sh

@@ -1,15 +0,0 @@
-#!/bin/bash -e
-
-cd ../../board/
-
-make -f Makefile.strict clean
-make -f Makefile.strict bin 2> compiler_output.txt
-
-
-if [[ -s "compiler_output.txt" ]]
-then
-  echo "Found alerts from the compiler:"
-  cat compiler_output.txt
-  exit 1
-fi
-