I thought I was missing a rounding in Mazda code, but it turned
out to be a missing rounding after the recent event refactoring
Python3 interpreter:
>>> print(" %d %d" % (1.6,1.4))
1 1
>>> print(" %d %d" % (round(1.6),round(1.4)))
2 1
>>> print(" %d %d" % (int(round(1.6)),round(1.4)))
2 1
>>> print(" %d %d" % (int(round(1.6)),int(round(1.4))))
2 1
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Slower rate for ACC cancel msg to avoid cruise disable
Sending ACC cancel message at 10hz may end up disabling
main cruise state. That is because stoc ACC use the same
signal for both functions. If cruise is already enabled
the signal canceles it, otherwise cruise is disabled.
10hz seems to be still fast in some cases not allowing
the state to sync up between OP and the Stock state.
5hz avoids that issue. Also, the resume message was also
updated to 5hz as that seems to work better as well.
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Round up 27.96 to 28mph
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Added Rogue 2019/Leaf 2019 fingerprints
* Added Rogue as new car. Updated readme
* Added route to test_car_models.py. Fixed if statements to check against rogue/x-trail
* Fixed paste error
* Merged Leaf fingerprints
* Assume Rogue is MPH until we work out the mph/kph bit
commit 012049274fd5573bdc5d2d0f198817646dfd5a1b
Author: Willem Melching <willem.melching@gmail.com>
Date: Sat May 30 10:40:49 2020 -0700
update ref
commit d50cc2d81fd73dcfccfe1a8e2726879941ec5327
Author: Jason Young <jyoung8607@gmail.com>
Date: Sat May 30 10:32:25 2020 -0400
Discard no-longer-used import
commit c092e6f5092535a3b4bb5cabb6f5ecf83ef754c7
Author: Jason Young <jyoung8607@gmail.com>
Date: Sat May 30 10:21:57 2020 -0400
Improved tune from community
* Call to gmtime is potentially dangerous
* Revert "Call to gmtime is potentially dangerous"
This reverts commit cc531e4e1969f7a615230d8462f0be3258ba3378.
* Call to gmtime is potentially dangerous
* oops
* not a pointer
* Little identation fix
* Mazda Port
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Update checksum to account for steer angle signal used in some cars
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Add test drive/segment ID to pass CI tests
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Process gear and brake signals, add new fingerprints
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Refactor some car interface code
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Drop redundant call, use Ecu, move warning to carstate, fix cruise speed
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Drop unused variables, cleanup handsoff tracking
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Update to steerError and steeringRate
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Refactor parse gear, update lkas signals from the new dbc
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Better tracking of engage and warning events
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* remove commented lines, update speed_kph to match panda
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Steer Error
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Set lkas enable speed to 52 kph
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Drop block signal use, fix LGTM alerts
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* When gas is pressed OP will disengage, sync local state with it
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Use car's speed signal instead of wheel speed
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Tidy up disengage events
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Rebase/Refactor with upstream
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Sync stock ACC state with OP
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* mazda dbc file renamed
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Improve acc stock and go by removing the 3 seconds limit
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Dashcam
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* PR Feedback
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* Send ACC cancel only if we are sure cruise is enabled
Otherwise we run the risk of disabling main cruise
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* updated route
Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
* no process replay for now
* add to release files
* Revert "updated route"
This reverts commit 233db4f1bc2d8eefaa86488be4f6f88360d20793.
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
* Running pre-commit in CI
* fix dockerfile syntax
* dont run on submodule repo folders
* Fix some import errors in ci
* more stuff
* That should be the last one
* "The commit-hook project sounds interesting though. I would definitely merge something that runs flake8 and pylint on the modified files!"
- pd0wm, https://github.com/commaai/openpilot/pull/1575#issuecomment-634974344
* add pylint to pre-commit and make everything pass
* Remove uncommented stuff
Co-authored-by: J <user@4800.lan>
* remove the clCreateProgramWithSource interceptor
* that's old code, thneed is better
* label them thneed_, we shouldn't need to touch CL for anything not SNPE related
* add PubMaster & SubMaster
remove 'delete msg'
remove headers
* use constructor to initial all submster
* modify drain sockets
* fix typo in ssconscript.remove lines
no checkValid in loggerd
last modify
handle_message:event->&event
fix type
remove heads
event to auto
* new interface
* api changed
* Revert "use constructor to initial all submster"
This reverts commit 73be7ea46250a325ce41d3a0445e34395a2ae692.
* change to new api
* revert loggerd
* dd
* use new PubSub api
* update to new interface
don't modify loggerd
reset panda
reset opendbc
remove empty lines
* switch to new pubMaster
* update to the new inteface
change
remove error code
. to ->
merge paramsd.cc
update panda
fix typo
simplify
fix typo
* Fix build
* always conflate
Co-authored-by: deanlee <deanlee3@gmail.com>
* test test
* yo dawg
* yo dawg 2
* yo dawg 3
* calib in ui
* no pitch and yaw
* no more drive rating
* stricter
* param is no longer a vp
* less wall of test
* less is more
* better language
* cleaner
* add sonata interface
update values.py
update values.py
* change sonata_1 to sonata_2019
* add sonata 2019 and forte 2019 to README
prettier fucked me up pretty hard at first
sdfsd
* update README.md
* mock test
* hyundai fw query
* Change query
* this works
* That is not engine
* hyundai fw query
* Change query
* this works
* That is not engine
* Skip FW query in test_car_models
* Those routes don't fingerprint properly after speedup
* only send toyota queries to subaddresses
Co-authored-by: openpilot laptop <laptop@comma.ai>
* bigmodel
* more debug print
* debugging bigmodel
* remove the tanh, debugging
* print images/buffers
* disassemble the command queues
* decompiler
* dump the shaders
* full disasm
* support patching kernel and fixing convolution_horizontal_reduced_reads_1x1
* microbenchmark
* 42 GFLOPS, 1 GB/s
* gemm benchmark
* 75 GFLOPS vs 42 GFLOPS
* 115 GFLOPS
* oops, never mind
* gemm image is slow
* this is pretty hopeless
* gemm image gets 62 GFLOPS
* this is addictive and still a waste of time
* cleanup cleanup
* that hook was dumb
* tabbing
* more tabbing
Co-authored-by: Comma Device <device@comma.ai>
* way cleaner take 2
* cleanup
* be more relaxed
* just let it be
* don't drive backwards or upside down
* do this more
* vNED sometyimes invalid
* use reasonble stds
* stability in nonlinear zone
* previous metrics were without publishing
* thneed runs the model
* thneed is doing the hooking
* set kernel args
* thneeding the bufferS
* print the images well
* thneeds with better buffers
* includes
* disasm adreno
* parse packets
* disasm works
* disasm better
* more thneeding
* much thneeding
* much more thneeding
* thneed works i think
* thneed is patient
* thneed works
* 7.7%
* gpuobj sync
* yay, it mallocs now
* cleaning it up, Thneed
* sync objs and set power
* thneed needs inputs and outputs
* thneed in modeld
* special modeld runs
* can't thneed the DSP
* test is weird
* thneed modeld uses 6.4% CPU
* add thneed to release
* move to debug
* delete some junk from the pr
* always track the timestamp
* timestamp hacks in thneed
* create a new command queue
* fix timestamp
* pretty much back to what we had, you can't use SNPE with thneed
* improve thneed test
* disable save log
Co-authored-by: Comma Device <device@comma.ai>
* add rednose
* update rednose
* This compiles
* Add rednose to release
* cleanup
* Extract generated dir as argument
* Add constants.py to release
* Add rednose to dockerfile
* Fix that
Previous commit moved G80 from G90 grouping to Hyundai Genesis grouping.
Bug found as minSteerSpeed is 0 for G80 but 60 for Hyundai Genesis.
Taking @pd0wm recommendation and ungrouping G80 to its own.
* it's a class
* more refactor
* remove that
* car interface should create that
* that too
* not a dict
* don't create permanent events every iteration
* break up long lines
* fix honda
* small optimization
* less long lines
* dict is faster
* latcontrol less args
* longcontrol less args
* update profiling script
* few optimizations
* create events together
* clean up
* more clean up
* remove comment
* clean up
* simplify state transition
* more clean up
* update comments
* Shebang Fix
Per George's "I'd merge a PR replacing the 4 python3.7 with python3" on Discord. George updated Python to 3.8.2 for webcam tools, which broke manager from launching. Instead of chasing the exact version, it seems more reasonable to fall back to 3.
* More Python3.7's
* convert c-capnp to c++
change paramater type
* remove c-capnp header from commonmodel.c
* unsigned short -> uint16_t
* MSM_CAMERA_I2C_ADDR_TYPE_MAX->4
* ui:move c-capnp to c++
* move Subsockets into vector
* rename reader to msg
include cereal/gen/cpp/log.capnp
* fix some errors
restore some changes
restore previous
* cleanup codes
cleanup codes
* remove unused variable alert_size
* handle capnproto's enum in a robust way
add break to default
* switch -> std:map
* use static std::map instead of switch
do cleanup
* fix wrong variable name
* use FlatArrayMessageReader instead of custom MessageReader
remove messagehelp.h
Revert "use FlatArrayMessageReader instead of custom MessageReader"
This reverts commit 57d8b6b1e2b4bad908246f35eb068535b1627167.
use FlatArrayMessageReader instead of custom MessageReader
add header file
remove capnp_c lib,add kj lib
include serialize.h
fix
remove duplicate includes
* lgtm in readme, and mac nui fixes
* call super inits in radars
* unused imports, dup lines
* more radars, more unused imports
* pass CP into RadarInterfaceBase
* more fixups
* unused imports
* delete unused lines
* ugh, new unused import
Co-authored-by: George Hotz <geohot@gmail.com>
* Update Elantra Values one last time
I got the params learner values from EON. These are the values it settled on after driving over a week.
* Include Stiffness Params Value.
* Update interface.py
George Hotz
Jafar Al-Gharaibeh
Willem Melching
Adeeb
cowanhmoore
Andre Volmensky
Dean Lee
Adeeb Shihadeh
Kishan Karunaratne
Erich Moraga
Yahya Lmallas
martinl
VirtuallyChris
Harald Schafer
Thaixican
Tunder (Chris in RL)
George Hotz
Alice Knag
openpilot laptop
TK211X
Hylke Jellema
eFini
Comma Device
Chris Souers
Paweł Goliński
Bruce Wayne
Jason Young
xps-genesis
robbederks
William
Patrick Violette
ZwX1616
Adeeb
Shane Smiskol