commaai
/
panda
mirror of https://github.com/commaai/panda.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
2,726 Commits 55 Branches 0 Tags 42 MiB
Commit Graph

84 Commits

Author SHA1 Message Date
Shane Smiskol daa739efb7
missed a busTime (#1990) 
* whoops

* addr dat src
 2024-07-31 14:30:53 -07:00
Shane Smiskol edcd0fe4d4
IsoTpMessage: extend timeout on first frame response (#1933) 
* extend on first frame too

* debug/checks

* fix able to go from single to first to single etc forever

* more clean up

* more clean up

* comments!
 2024-04-17 23:23:50 -07:00
Cameron Clough 0c7d5f11d7
use pyupgrade to update syntax (#1889) 2024-02-24 13:56:28 -08:00
Justin Newberry 104d708547
Precommit: ensure executable bit is set (#1650) 
* precommit ensure executable

* fix the violations

* the correct shebang
 2023-09-05 15:32:44 -07:00
Shane Smiskol 1e41659aab
Revert "iso-tp: more checks (#1487)" (#1616) 
* Revert "iso-tp: return if updated (#1610)"

This reverts commit 0eb04fae67.

* Revert "iso-tp: more sanity checks (#1487)"

This reverts commit 01db9e4a83.
 2023-08-28 23:08:41 -07:00
Shane Smiskol 0eb04fae67
iso-tp: return if updated (#1610) 
return if updated

reverts some of https://github.com/commaai/panda/pull/1314
 2023-08-26 06:45:46 -07:00
Shane Smiskol 01db9e4a83
iso-tp: more sanity checks (#1487) 
* assert rx not done for single frame to be valid

* not sure if this is correct yet

* return if updated

reverts some of https://github.com/commaai/panda/pull/1314

* Revert "return if updated"

This reverts commit ba4c4f194a.
 2023-08-26 06:35:34 -07:00
Shane Smiskol 05e0f4a944
IsoTpMessage: fix length mask for single frames (#1523) 
* Update uds.py

* this was completely broken

* wait nevermind
 2023-07-18 12:05:14 -07:00
Adeeb Shihadeh 5285eec35a
pre-commit: autoupdate hooks (#1347) 
* Update pre-commit hook versions

* fix that

---------

Co-authored-by: adeebshihadeh <adeebshihadeh@users.noreply.github.com>
 2023-07-01 18:03:53 -07:00
Adeeb Shihadeh 21843092ff
bump to python 3.11.4 (#1481) 
* bump to python 3.11.4

* Update .pre-commit-config.yaml

* lint

* import

* no | yet

* rm ignores

* Update tests/libpanda/libpanda_py.py

---------

Co-authored-by: Maxime Desroches <desroches.maxime@gmail.com>
 2023-07-01 17:43:34 -07:00
Shane Smiskol 7af22677f7
CanClient: check invalid sub-addresses (#1483) 
* check/catch invalid sub-addresses

* clean up

* break to next addr on first receipt of bad subaddr
 2023-06-23 16:33:12 -07:00
Shane Smiskol bcd8c57a70
uds: fix TypeError for invalid subfunctions (#1474) 
fix TypeError
 2023-06-20 23:17:57 -07:00
Shane Smiskol 675b1e847f
iso-tp: revert CAN frame length check (#1411) 
revert
 2023-05-12 22:14:23 -07:00
Shane Smiskol 8efbcf041c
IsoTpMessage: return if consecutive frame last received (#1314) 
* what about

* actually this is what we want

* more explicit about this condition

* frame type

* add enum

* use in func
 2023-03-31 20:11:53 -07:00
Shane Smiskol a12c0a7956
IsoTpMessage: don't skip a byte when sending consecutive frames to subaddress (#1320) 
handle
 2023-03-31 19:44:46 -07:00
Shane Smiskol 189f0436ba
IsoTpMessage: check CAN frame length (#1315) 
* Revert "Revert "IsoTpMessage: check CAN frame length (#1312)""

This reverts commit 09fee3e7ea.

* need to pad for the check to work

* pass rx_offset up from can client

* detect from internal can_client and just use it for the checks

* move

* revert this for another PR

* fix
 2023-03-31 19:22:16 -07:00
Shane Smiskol c92f8ecfde
IsoTpMessage: fix rx_len sanity checks (#1319) 
fix a bug
 2023-03-31 19:17:16 -07:00
Shane Smiskol 02eb84936b
UdsClient: support sub addresses (#1317) 
* UdsClient: support sub addresses

* Update python/uds.py

* Update python/uds.py
 2023-03-31 13:59:02 -07:00
Shane Smiskol 09fee3e7ea Revert "IsoTpMessage: check CAN frame length (#1312)" 
This reverts commit 9349337ebb.
 2023-03-31 12:11:13 -07:00
Shane Smiskol 7933635b54
IsoTpMessage: rx_len sanity checks (#1311) 
* add some more sanity checks for _isotp_rx_next

* another PR

* Update python/uds.py

* cannot be bigger than 0xfff
 2023-03-30 23:23:42 -07:00
Shane Smiskol 23563cec7c
IsoTpMessage: check not reserved frame (#1313) 
* add some more sanity checks for _isotp_rx_next

* another PR

* rever

* can remove return

* add back the space here tho :(

* raise
 2023-03-30 22:35:02 -07:00
Shane Smiskol 9349337ebb
IsoTpMessage: check CAN frame length (#1312) 
* add some more sanity checks for _isotp_rx_next

* another PR

* revert
 2023-03-30 22:14:35 -07:00
Shane Smiskol 3334dc21f5
IsoTpMessage: parameterize separation time (#1088) 
* parameterize separation time

* take in seconds and convert

* fix

* define once
 2022-10-05 16:35:28 -07:00
Shane Smiskol cffc41e878 Specify IsoTpMessage keywords 2022-10-05 16:22:53 -07:00
Shane Smiskol 7d196264a4
IsoTpMessage: param for single frame flow control (#1079) 
* iso-tp: request a single frame at a time

* behind param

* this might be more clear

* like this better

* fit the theme

* revert this change
 2022-10-05 16:12:24 -07:00
Shane Smiskol 1910db8d4c
IsoTpMessage.send: setup_only argument (#1081) 
* some fixes

* some fixes

* revert to tx not done

* this should work

* correct debug prints

* not true

* revert this

* setup_only
 2022-09-30 14:29:41 -07:00
Shane Smiskol 51f023bc66
IsoTpMessage: return if message updated (#1078) 
* extend timeout for each message/frame (not multi-frame full response)

* linter
 2022-09-27 18:08:09 -07:00
Shane Smiskol 11ea112258
IsoTpMessage: add separation time to flow control msg (#1074) 
* one frame at a time, 20 ms delay

* send one at a time

* update separation time to 10ms

* comment
 2022-09-19 20:47:12 -07:00
Greg Hogan ab693a22d5 UDS DTC number and status helpers 2022-04-04 17:55:11 -07:00
Greg Hogan 288cbf65d1
uds: update security access and i/o control services (#738) 2021-10-10 00:45:59 -07:00
Greg Hogan 2570770f7b
UDS: add response pending timeout (#723) 
* Extend ISO-TP subsequent frame timeout, add response pending timeout and extra debug info

* Change response_pending to local variable, move response_pending_timeout to UdsClient, update ISO-TP debug output

* Set UDS request pending timeout to 6 seconds (ISO 14229-2:2013 section 7.2 recommended value + 1 second latency)

* manage response pending in single location

* more generous response pending timeout

* add tx timeout

* fix lint error

* fix rx addr for 29 bit addrs

* fix linting issue

Co-authored-by: Martin Lillepuu <martin@mlp.ee>
 2021-09-23 18:21:21 -07:00
Willem Melching a65c45d5e7 uds.py: fix typo in response description 2021-04-17 22:11:30 +02:00
Jason Young 3bb0408ee6
Add support for variable UDS RX offsets (#631) 2021-03-07 20:33:55 -08:00
Adeeb Shihadeh 6848c7576b use same flake8 config as openpilot 2020-06-03 16:22:30 -07:00
Willem Melching e0a706e4f0
Stricter pylint (#550) 
* stricter pylint

* Add as argument
 2020-06-02 16:27:07 -07:00
Adeeb d7f7b14118
Enable almost all Flake8 checks (#548) 
* fix W391

* E262

* E703

* W293

* some E

* E231

* some more E

* E225

* more E

* E252

* no tabs

* more tabs

* E701

* uds.py

* almost all of them

* only e265 left

* not sure why this is triggering on commented out code

* ignore esptool
 2020-06-01 01:49:26 -07:00
Adeeb Shihadeh f70ef291f9 whitespace fix 2020-05-31 17:49:37 -07:00
Adeeb Shihadeh 9102c16118 two spaces before inline comment 2020-05-31 14:07:01 -07:00
Willem Melching b8267341a1
Add pre commit checks + CI (#545) 
* Add pre commit checks

* untested but should work

* fix typo in dockerfile

* add sqlite

* add pylintrc to ignore usb1 members

* Typo in stage name

* Move to requirements
 2020-05-29 11:52:03 -07:00
Willem Melching a618e64d1a fix typing errors 2020-05-28 14:06:13 -07:00
Willem Melching 5307bf7277 Fix multi message iso tp requests 2020-05-18 19:48:47 -07:00
Greg Hogan 73a60d5c9c uds: clear rx buffer on drain 2020-02-05 23:34:00 -08:00
Greg Hogan 3b20804b6f uds: rx message buffering 2020-02-05 23:25:34 -08:00
Willem Melching ded4b3f743 UDS: handle remote addressing 2019-12-16 15:54:30 -08:00
Greg Hogan 02d579a537 functional addr handling 2019-11-17 09:30:06 -08:00
Greg Hogan 8138fc14c8 uds: handle function addrs and fw version query example 2019-11-16 18:54:28 -08:00
Greg Hogan b9b79e8b77 uds zero second timeout 2019-11-15 13:52:25 -08:00
Greg Hogan f239b996db single addr was better 2019-11-14 13:34:25 -08:00
Greg Hogan b3e1a133ae uds: better debug prints 2019-11-12 22:22:49 -08:00
Greg Hogan 68c39fb3e2 uds: no need for threads if you always drain rx 2019-11-12 18:52:41 -08:00