Commit Graph

2764 Commits

Author SHA1 Message Date
Adeeb Shihadeh 9270848da8
merge misra and cppcheck runs (#1790) 2024-01-09 20:04:44 -08:00
Jason Young 2a0536c631
VW MQB: Safety update for EA timeout fix (#955) 2024-01-09 19:20:46 -08:00
John Belmonte f886918c87
README typo (#1788) 2024-01-08 13:53:57 -08:00
Adeeb Shihadeh d0184f7266
pre-commit: autoupdate hooks (#1784)
Update pre-commit hook versions

Co-authored-by: adeebshihadeh <adeebshihadeh@users.noreply.github.com>
2024-01-04 15:17:24 -08:00
Justin Newberry 20722a5946
Subaru: cruise_rpm and cruise_throttle are 13 bits (#1786)
* fix cruise throttle

* and es_status

* bump opendbc
2023-12-29 19:25:02 -05:00
Eric Brown 0bcaa73d2a
Sort output of can_bit_transition script numerically (#1785) 2023-12-29 11:32:37 -08:00
Hoang Bui 114b85a649
CI: Translate abspath to relpath for build. (#1783)
relpath sconscript
2023-12-22 10:16:09 -08:00
Adeeb Shihadeh 85b4232b35
pre-commit: autoupdate hooks (#1782)
Update pre-commit hook versions

Co-authored-by: adeebshihadeh <adeebshihadeh@users.noreply.github.com>
2023-12-21 21:46:42 -08:00
Shane Smiskol 6e645d2d33
safety: fully reset dynamic rx check fields (#1767)
* stash

* clean up

* clean up

* more clean up

* just status

* status

* does nothing

* not here
2023-12-15 21:59:19 -08:00
Shane Smiskol 3f6f82616b
Honda: reset prev brake switch (#1781)
we should be resetting this!
2023-12-15 21:40:19 -08:00
Justin Newberry 7e2b312fa8
helpers: get last vehicle speed (#1777)
get last speed
2023-12-15 14:37:28 -08:00
Shane Smiskol 5b41a63ae5
Ford: check predicted gas (#1776)
* check pred value

* test
2023-12-15 00:01:17 -08:00
Shane Smiskol bb75afc84e
safety: add safety param for gas interceptor (#1735)
* some refactoring still needing to be done here

* 50hz

* set rx checks

* tx msgs

* test

* fix

* forgot to check this since it's static now

* enable_gas_interceptor

* more

* remove int funcs since are common

* generic!

* not generic

* need to set counter now

* set_enable_gas_interceptor not needed

* already reset in safety init

* fix test

* remove gas_interceptor_detected (partly)

* oof need for hjonda too

* edit structs

* more honda (still broken)

* fix typo

* shift these down

* can also make this extensible

* stash

* defining classes is much simpler, maybe in future we will have some sort of wrapper after some more thought

* remove create_interceptor_test now

* add lta interceptor

* clean up print

* clean up

* once

* type hint

* rm

* no interceptor with stock long + good test

* add interceptor counter to honda

* need alt interceptor + set rx checks for honda

* we were never testing button enable with nidec + interceptor!

honda almost all passing

* these fixes make sense

* clean up

* better

* clean up test cov

* clean up

* not needed

* fix tx msgs

* clean up

* cppcheck

* fix

* unnecessary
2023-12-14 15:22:17 -08:00
Shane Smiskol 30647d6604
safety tests: set gas interceptor counter (#1775)
* safety: check interceptor msg counter (#1738)

* toyota: check interceptor counter

* add counters and check rx

* honda: check counter

* clean up

* revert

* typing
2023-12-13 19:32:16 -08:00
Shane Smiskol e51411344b safety tests: clean up gas interceptor detected 2023-12-12 22:58:09 -08:00
Shane Smiskol 294992ac2c
safety tests: rename gas interceptor test (#1774)
* more appropriate name for gas interceptor

* safety
2023-12-12 22:15:36 -08:00
Louie Lu a88fe8c883
examples: Make can_bit_transition.py support can_logger.py (#1198)
* Add Time field to can_logger.py

* Update can_bit_transition to support can_logger format

* Fix csv opening

Using `rb` to open csv file will throw the exception:

  _csv.Error: iterator should return strings,
              not bytes (the file should be opened in text mode)

Fix it with `r` and `newline=''`
2023-12-10 11:25:25 -08:00
Adeeb Shihadeh 3e63e66256 rm .dockerignore 2023-12-10 11:17:19 -08:00
Adeeb Shihadeh d5983833d2
Docs update (#1769)
* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md
2023-12-10 11:14:53 -08:00
Jason Wen a6b76dfda0
Hyundai CAN-FD Longitudinal: enable for ICE camera-SCC cars (non-HDA2) (#1671)
* allow ice camera scc longitudinal

* Merge commaai#30021

* test

* clean up

* clean up 2

* some test work

* re-use existing test for radar-scc for now

* clean up

* clean up

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-12-09 17:37:28 -08:00
Shane Smiskol ff49666893
Hyundai CAN FD: radar-SCC longitudinal test (#1771)
* this rightly fails

* now safety
2023-12-09 16:55:46 -08:00
Adeeb Shihadeh d066ae70cd
ensure MISRA coverage table is always up to date (#1772)
* ensure MISRA coverage table is always up to date

* update comment
2023-12-09 15:48:33 -08:00
Adeeb Shihadeh 1e1aa42921 move this to commaai/neo 2023-12-09 14:54:16 -08:00
Adeeb Shihadeh 12d326c110
parallelize misra mutation tests (#1768)
* parallelize misra mutation tests

* timeouts
2023-12-09 14:32:40 -08:00
Shane Smiskol a5753a2077 safety helpers: hide debug print for now 2023-12-09 02:28:10 -08:00
Shane Smiskol cf108cd4cc
safety: full coverage (#1750)
* stash

* if x > xy.x[0], then subsequent x < xy.x[i+1] enforces it is monotonic, or uses last y

* rm

* test safety tick

* coverage: include safety.h

* car-only test

* MAX

* op

* add safety_config_valid
2023-12-09 02:27:29 -08:00
Adeeb Shihadeh fbef31126f
remove misra-c2012-21.1 suppression (#1765) 2023-12-09 01:31:52 -08:00
Adeeb Shihadeh 6e96d2e57a
misra test cleanup (#1764)
* misra test cleanup

* fix pedal

* cleanup

* debug

* fix

* undo debug

* add CAN3
2023-12-09 01:28:50 -08:00
Adeeb Shihadeh 7340ece196
misra mutation test (#1763)
* misra mutation test

* a few cases

* revert that

* fixups

* test that

* build fw
2023-12-08 23:20:42 -08:00
Shane Smiskol 80782bcbe4
Toyota: LTA steering control safety (#1189)
* simple lta safety

* fix compilation error

* allow current angle when disabled

* toyota angle rate limits

* use GET_BIT

* update limits, temp fix blocked msgs (not critical safety)

* try these limits

* debug

* add setme check, double rate limit for half rate

* update safety limits to openpilot (2 bp)

* had duplicate checks here

* rm line

* better comment

* silly bug

* draft

* Revert "draft"

This reverts commit 756ef70135.

* toyota: add safety for tester present

* block ACC_HUD

* check stock ECU

* add test

* and now pass test

* safety replay: support toyota lta

* remove radar stuff

* max torque safety

max torque safety

* driver torque

* one line

* match openpilot limits

* rename to max_angle and check quality flag

* measure current angle

* clean up

* oh we can combine

* no driver torque limiting for now

* todo: decide the tolerance if any

* add max angle and prepare for to enable inactive safety

* enable inactive safety

* fix replay when inactive

fix replay when inactive

* fix qf check

* ohh this was a bug

* measure vehicle speed

* because safety is in m/s

* rm MeasurementSafetyTest

* stash very draft changes

* fix

* uncomment

* clean up

* rm

* already added

* clean up

* temp fix

* test angle measurements

* add constant

* ltl cleanup

* include this test in test_angle_measurements

* better

* order makes more sense

* fix

* clean up ford cmts

* move to base

* todo

* misra

* already do this below

* angle tests: take in max angle as argument

useful for safety modes that are limited (ford/toyota)

* fix ramp test: round measurement since toyota's scale isn't round

* clean that up

* no subtest

* back

* is tested now!

* flat is more clear

* add check for mismatching bits

* LTA is fully tested now

* clean up

* test_angle_cmd_when_enabled

* whops

* flip

* fix broken test

* need this if we type angle meas func

* should set prev torque

* no subtest

* remove default valid qf

spce

* one line

* cmt

* fixes

* vehicle speed macro

* vehicle speed macro v2

* Update board/safety_declarations.h

* easier to follow

* one line

* rightttt

* rename to toyota_lka_rx_checks, not default
2023-12-08 15:00:23 -08:00
Shane Smiskol f741a90de8
safety: macro to update vehicle speed (#1762)
vehicle speed update macro
2023-12-06 18:05:07 -08:00
Shane Smiskol 845658e169
Toyota LTA: set torque measurement (#1761)
* catch

* fix ramp test: round measurement since toyota's scale isn't round

* reorder

* can be in main PR
2023-12-06 17:46:48 -08:00
Adeeb Shihadeh fa2b8c0e47
pre-commit: autoupdate hooks (#1759)
Update pre-commit hook versions

Co-authored-by: adeebshihadeh <adeebshihadeh@users.noreply.github.com>
2023-12-05 11:04:47 -08:00
Shane Smiskol ea78657bef
Toyota: rename LTA torque wind down signal (#1757)
* rename setme_x64

* bump opendbc ref
2023-12-04 21:05:02 -08:00
Adeeb Shihadeh a9af9cbd74
run safety tests in parallel (#1756)
* run safety tests in parallel

* fix

* fix path
2023-12-04 20:50:43 -08:00
Adeeb Shihadeh 892ca5a0f1 this is a better name 2023-11-30 19:20:08 -08:00
Adeeb Shihadeh b50455cc76
safety: specify RX message frequency in Hz (#1754)
* safety: specify RX message frequency in Hz

* these are redundant now

* update that

* cleanup
2023-11-30 14:55:15 -08:00
Shane Smiskol c57a3c2d15
safety replay: support Nissan (#1753)
* nissan safety replay

* hex
2023-11-29 23:07:25 -08:00
Shane Smiskol 2ee6e36e99
safety replay: set angle measurement (#1752)
set angle meas in safety replay
2023-11-29 23:04:14 -08:00
Shane Smiskol d070f6e7c9
Toyota tests: rx speed messages in correct scale (#1751)
because it's kph, safety works in m/s
2023-11-29 20:49:50 -08:00
Adeeb Shihadeh 09465a753c
pre-commit: autoupdate hooks (#1748)
Update pre-commit hook versions

Co-authored-by: adeebshihadeh <adeebshihadeh@users.noreply.github.com>
2023-11-28 14:22:03 -08:00
Adeeb Shihadeh e6fadef4dd one more int -> bool 2023-11-27 16:29:07 -08:00
Shane Smiskol 5884962372
Honda: fix alt brake address check race condition (#1746)
* common honda addr checks

* oohhhh

* rename RxCheck from merge

* more rename

* checked data and found 0x1A6 does not exist on any Bosch, so combining with 0x296 is safe

* formatting

* need this since refactor

* clean up

* fixup

* misra

* coverage caught another bug!

* another duplicate addr from multi tests

* proper base class

* formatting

* misra

* flat

* Revert "flat"

This reverts commit d5ea2adf26.

* forgot to specify bus (fuzzy test caught it, but whitelisting rx addrs
would so much quicker)
2023-11-27 00:18:24 -06:00
Shane Smiskol beffd7bcbf
Nissan: check bus for brake pressed msg (#1740)
* never checked bus!

* easy fix
2023-11-26 21:07:20 -06:00
Adeeb Shihadeh 6eb89cefdf
board: remove set_phone_power (#1747) 2023-11-25 13:17:08 -08:00
Adeeb Shihadeh c67c973b99 Revert "Honda: fix alt brake address check race condition (#1723)"
This reverts commit 42a62936fb.
2023-11-24 16:49:55 -08:00
Adeeb Shihadeh aa6ea0772b Revert "safety: check interceptor msg counter (#1738)"
This reverts commit 83acc65743.
2023-11-24 16:49:26 -08:00
Adeeb Shihadeh dc1fd96118
Revert "H7: fix GMLAN bitbang timer (#1542)" (#1745)
This reverts commit 5778c0ae5d.
2023-11-24 16:00:18 -08:00
Adeeb Shihadeh 574d2db10d remove more kline usage 2023-11-23 17:29:53 -08:00
Adeeb Shihadeh 666a462450
remove low level LIN support (#1744) 2023-11-23 17:18:25 -08:00