Commit Graph

404 Commits

Author SHA1 Message Date
Tici f7089b71b9 relay test 2020-08-17 10:15:17 +00:00
Adeeb Shihadeh ecef0a19d0 add dos to safety tests 2020-08-12 13:32:33 -07:00
Andre Volmensky 3a8430b9d5
Updating X-Trail/Rogue gas_pressed threshold (#585) 2020-08-08 11:10:32 -07:00
martinl 32199b2e49
Replace pycrypto with pycryptodome (#581)
* replace pycrypto with pycryptodome

* replace all instances with pycryptodome
2020-08-05 12:58:43 -07:00
Adeeb Shihadeh b88f96e72a fix linter 2020-07-30 14:36:39 -07:00
Robbe 8bdacca123 Make the gmlan test a little easier to use 2020-07-29 13:10:53 -07:00
martinl c55e84bf56
Change Subaru safety test to use generated dbc (#575)
* Change Subaru test to use generated dbc

* update openpilot pinned commit
2020-07-23 13:06:11 -07:00
Adeeb Shihadeh 0d97b6d4eb
Safety Test: ensure TX msgs for other cars are blocked (#521) 2020-06-21 23:25:54 -07:00
Adeeb Shihadeh 5b14945140
Abstract RX checks for gas, brakes, and relay malfunction (#556)
* abstract gas, brake, and relay RX checks

* toyota

* mazda

* vw and subaru

* gm, honda, nissan

* chrysler

* rename

* revert that
2020-06-16 02:01:00 -07:00
Adeeb Shihadeh 086be906d7
Add test routes for Hyundai legacy and Subaru legacy safety modes (#558)
* add subaru legacy route to safety replay

* hyundai legacy routet push
2020-06-15 18:15:49 -07:00
Adeeb d0442fd1e4
add hyundai legacy safety mode (#554) 2020-06-12 18:03:31 -07:00
Adeeb Shihadeh abeafb6256 fix linter 2020-06-11 17:06:53 -07:00
Robbe 5d6fcbb422 gmlan harness test 2020-06-11 16:44:37 -07:00
martinl b2c86eb66b
Subaru safety refactoring (#532)
* Update subaru safety tx messages

* Add Subaru preglobal driver torque limits

* fix preglobal desired_torque

* fix subaru preglobal torque rate limit and tx messages

* readability update for desired_torque

* fix preglobal tests

* Subaru safety refactoring, added missing legacy checks and updated test

* Remove subaru_global check from tests

* Reorder legacy constants, remove subaru_init

* Update Subaru legacy safety and tests to match dbc scaling factors

* remove scaling factor from torque_driver

* Change preglobal driver torque scaling factor

* Change driver torque factor to 10

* Fix preglobal dbc name

* Fix Subaru legacy safety test

* update openpilot commit

* init valid with one line
2020-06-11 15:51:05 -07:00
Adeeb Shihadeh 9eee6ca556 update safety tests after DBC changes 2020-06-09 16:51:08 -07:00
Adeeb 35bff5db51
Speed up misra test in CI (#552) 2020-06-07 21:42:23 -07:00
Adeeb Shihadeh 6848c7576b use same flake8 config as openpilot 2020-06-03 16:22:30 -07:00
Willem Melching e0a706e4f0
Stricter pylint (#550)
* stricter pylint

* Add as argument
2020-06-02 16:27:07 -07:00
Adeeb d7f7b14118
Enable almost all Flake8 checks (#548)
* fix W391

* E262

* E703

* W293

* some E

* E231

* some more E

* E225

* more E

* E252

* no tabs

* more tabs

* E701

* uds.py

* almost all of them

* only e265 left

* not sure why this is triggering on commented out code

* ignore esptool
2020-06-01 01:49:26 -07:00
Adeeb Shihadeh eba113cb67 backslash is redundant between brackets 2020-05-31 17:39:42 -07:00
Adeeb Shihadeh 275e76c2b2 fix linter complaint about too many blank lines 2020-05-31 17:20:47 -07:00
Adeeb Shihadeh 9102c16118 two spaces before inline comment 2020-05-31 14:07:01 -07:00
Adeeb Shihadeh 3a85f4c25c use whole route when running safety replay from CLI 2020-05-30 21:31:18 -07:00
Willem Melching b8267341a1
Add pre commit checks + CI (#545)
* Add pre commit checks

* untested but should work

* fix typo in dockerfile

* add sqlite

* add pylintrc to ignore usb1 members

* Typo in stage name

* Move to requirements
2020-05-29 11:52:03 -07:00
Jafar Al-Gharaibeh 89658d0bde
Mazda: safety tests add missing safety checks (#525)
* Mazda: add safety test

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Update mazda safety to capture more events

    * gas press
    * brake press
    * speed - lkas on/off

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Customize safety tests

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Add RX checks

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Format

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Set lkas enable speed at 52 kph

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Test case when speed<enable_lkas_speed

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Be consistent with names in other places

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Add test case for lkas on when speed dips below lkas enable speed

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Make sure lkas disabled

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Use car's speed signal instead of wheel speed

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Allow acc cancel msg

  When gas is pressed OP disenages stock cruise doesn't get disengaged.
panda needs to know when OP engages again. OP re-enageges on cruise button
presses. This commit uses the same re-enage logic in panda.

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* rebase

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* allow acc_cancel in safety tests

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* rename variable, fix comment

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
2020-05-28 13:09:54 -07:00
robbederks b48c74c2e9
Adding UNO to automated tests (#538)
* Added UNO to automated tests

* Longer wait for uno while resetting?

* Increased wrong timeout

* this fixes it locally
2020-05-26 15:35:51 -07:00
Adeeb 9ebde2535c
Reset state on safety mode init (#542)
* reset state on safety mode init

* more global state

* reset message seen too

* misra
2020-05-26 14:23:39 -07:00
Adeeb Shihadeh 5210e51b82 remove unused files 2020-05-24 12:11:24 -07:00
Adeeb 0657064594
Hyundai checksum (#540)
* 3/5 hyundai checksums done

* cleanup

* these 3 should be universal across all hkg

* fix tests

* fix misra
2020-05-22 14:40:51 -07:00
Adeeb Shihadeh 0610ed1e25 Hyundai wheel speed counter is actually 4 bits spread over two signals 2020-05-17 22:40:51 -07:00
Adeeb 55b79b4721
GitHub Actions (#535) 2020-05-17 19:53:23 -07:00
Greg Hogan 01bf740240 remove 0x1BE checksum test 2020-05-14 15:44:38 -07:00
Greg Hogan c31b899a58 honda bosch longitudinal safety 2020-05-14 15:44:38 -07:00
Adeeb e4558c0737
Safety: message length check on RX and TX (#529) 2020-05-11 12:58:33 -07:00
Adeeb 869f123218
Hyundai: counter check (#530)
* hyundai counter check

* fix misra

* add counter to tests
2020-05-09 00:52:57 -07:00
Adeeb Shihadeh a4390713e6 gitignore for route logs 2020-05-09 00:50:34 -07:00
Adeeb Shihadeh 0a123b1815 that too 2020-04-30 14:54:40 -07:00
Adeeb Shihadeh ba6355d4c0 unused lines 2020-04-30 14:53:43 -07:00
Adeeb c9102c00ee
Chrysler: use can packer in safety tests (#522)
* Chrysler: use can packer in safety tests

* bump opendbc
2020-04-30 14:26:28 -07:00
Adeeb 9874e73350
Abstract steering safety tests for Toyota and Chrysler (#520)
* start abstracting torque steering tests

* remove duplicate

* chrysler

* remove that

* revert that for now

* fix toyota

* unused
2020-04-29 20:37:12 -07:00
Chris Souers 2299ecffc4
Block 0xe5 (Honda Bosch) at the panda/uno. Only allow static values. (#515)
* Safety for static 0xe5

Passes Misra test

* Add e5 to test.

* Readd
2020-04-28 14:13:00 -07:00
Adeeb 3517306113
Subaru: fix steer torque scaling (#501)
* Subaru: fix steer torque scaling

* fix legacy test
2020-04-28 10:47:26 -07:00
Adeeb 0bc864b3d5
Make torque-based steering state global (#518)
* use generic steering state vars for toyota

* chrysler

* gm

* comment

* more unnecessary lines

* hyundai

* subaru

* vw

* fix mazda
2020-04-28 10:33:20 -07:00
Adeeb d9355c4148
Make cruise_engaged_prev a global + test case for it (#519)
* make cruise_engaged_prev a global

* test for cruise_engaged_prev
2020-04-27 22:13:30 -07:00
Adeeb 2115376412
Abstract sample speed test (#516)
* all cars move

* honda

* update comments

* vw
2020-04-27 21:36:56 -07:00
Adeeb Shihadeh 11dc9054f9 remove unused function 2020-04-27 20:38:27 -07:00
Adeeb e5a586eea9
Abstract gas interceptor tests (#517)
* abstract interceptor tests

* honda
2020-04-27 20:35:36 -07:00
Adeeb 1dbed65e38
Safety Test Refactor: Honda (#495)
* nidec

* bosch

* button

* more common

* packer

* more packer

* readability

* tx too

* don't need that

* delete StdTest

* don't need to duplicate this

* only nidec has interceptor
2020-04-27 19:40:15 -07:00
Adeeb Shihadeh 0632710acd base class for different panda safety tests 2020-04-27 15:39:08 -07:00
Adeeb Shihadeh bd98fe6031 safety tests: use shorter function name 2020-04-27 15:27:28 -07:00