Commit Graph

1507 Commits

Author SHA1 Message Date
Adeeb Shihadeh 3d5a7179b0 fix whitespace after opening bracket 2020-05-31 21:36:34 -07:00
Adeeb Shihadeh f70ef291f9 whitespace fix 2020-05-31 17:49:37 -07:00
Adeeb Shihadeh eba113cb67 backslash is redundant between brackets 2020-05-31 17:39:42 -07:00
Adeeb Shihadeh 8039638482 fix linter complaint about unexpected spaces around keyword / parameter equals 2020-05-31 17:34:34 -07:00
Adeeb Shihadeh 275e76c2b2 fix linter complaint about too many blank lines 2020-05-31 17:20:47 -07:00
Adeeb Shihadeh 9102c16118 two spaces before inline comment 2020-05-31 14:07:01 -07:00
Adeeb Shihadeh 49ffbe99f6 disable non-universal checks in hyundai safety 2020-05-31 12:08:02 -07:00
Adeeb Shihadeh 3a85f4c25c use whole route when running safety replay from CLI 2020-05-30 21:31:18 -07:00
Andre Volmensky 098f47a5b4
Fix leaf brake rx check (#547) 2020-05-30 16:43:53 -07:00
Willem Melching b8267341a1
Add pre commit checks + CI (#545)
* Add pre commit checks

* untested but should work

* fix typo in dockerfile

* add sqlite

* add pylintrc to ignore usb1 members

* Typo in stage name

* Move to requirements
2020-05-29 11:52:03 -07:00
Alice Knag 339976c3ca
document tx message addresses better (#543)
* document tx message addresses better

* comment out scc messages for now
2020-05-28 19:59:14 -07:00
Willem Melching a618e64d1a fix typing errors 2020-05-28 14:06:13 -07:00
Adeeb Shihadeh 9bece64e8f use mazda init 2020-05-28 13:20:46 -07:00
Adeeb Shihadeh 08db086d58 mazda cleanup 2020-05-28 13:15:04 -07:00
Jafar Al-Gharaibeh 89658d0bde
Mazda: safety tests add missing safety checks (#525)
* Mazda: add safety test

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Update mazda safety to capture more events

    * gas press
    * brake press
    * speed - lkas on/off

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Customize safety tests

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Add RX checks

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Format

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Set lkas enable speed at 52 kph

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Test case when speed<enable_lkas_speed

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Be consistent with names in other places

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Add test case for lkas on when speed dips below lkas enable speed

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Make sure lkas disabled

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Use car's speed signal instead of wheel speed

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Allow acc cancel msg

  When gas is pressed OP disenages stock cruise doesn't get disengaged.
panda needs to know when OP engages again. OP re-enageges on cruise button
presses. This commit uses the same re-enage logic in panda.

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* rebase

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* allow acc_cancel in safety tests

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* rename variable, fix comment

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
2020-05-28 13:09:54 -07:00
Andre Volmensky bdec1398e5
Fix length of 0x20b in NISSAN_TX_MSGS, wasn't cancelling ACC (#544) 2020-05-27 12:41:19 -07:00
robbederks b48c74c2e9
Adding UNO to automated tests (#538)
* Added UNO to automated tests

* Longer wait for uno while resetting?

* Increased wrong timeout

* this fixes it locally
2020-05-26 15:35:51 -07:00
Adeeb Shihadeh a5802cdd15 Hyundai: remove unused message from RX checks 2020-05-26 14:36:44 -07:00
Adeeb 9ebde2535c
Reset state on safety mode init (#542)
* reset state on safety mode init

* more global state

* reset message seen too

* misra
2020-05-26 14:23:39 -07:00
Adeeb d4f3f15c33
Refactor addr check (#541)
* refactor addr checks

* re-enable that

* Willem comment
2020-05-26 11:24:33 -07:00
Adeeb Shihadeh 5210e51b82 remove unused files 2020-05-24 12:11:24 -07:00
Adeeb 0657064594
Hyundai checksum (#540)
* 3/5 hyundai checksums done

* cleanup

* these 3 should be universal across all hkg

* fix tests

* fix misra
2020-05-22 14:40:51 -07:00
Adeeb 07e668eca4
Fast CI (#539) 2020-05-19 12:50:32 -07:00
Willem Melching 5307bf7277 Fix multi message iso tp requests 2020-05-18 19:48:47 -07:00
Adeeb Shihadeh 0610ed1e25 Hyundai wheel speed counter is actually 4 bits spread over two signals 2020-05-17 22:40:51 -07:00
Adeeb Shihadeh 0d581aa5f2 dockerfile optimization 2020-05-17 21:50:11 -07:00
Adeeb Shihadeh eaefa2f6c7 fix docker file path 2020-05-17 20:45:59 -07:00
Adeeb Shihadeh 243a65f30c pull base image 2020-05-17 20:44:10 -07:00
Adeeb Shihadeh 0dd9470af5 only push to dockerhub from master 2020-05-17 19:56:11 -07:00
Adeeb 55b79b4721
GitHub Actions (#535) 2020-05-17 19:53:23 -07:00
robbederks b2c720bf40
Dos (#533) 2020-05-14 21:05:42 -07:00
Greg Hogan 01bf740240 remove 0x1BE checksum test 2020-05-14 15:44:38 -07:00
Greg Hogan 0bd06c9e0b remove 0x1BE check (breaks some vehicles) 2020-05-14 15:44:38 -07:00
Greg Hogan c31b899a58 honda bosch longitudinal safety 2020-05-14 15:44:38 -07:00
Adeeb 66250c41d3
Disable docker layer caching (#534) 2020-05-12 23:29:35 -07:00
Adeeb Shihadeh 6b19fa4961 include nissan safety in release build 2020-05-11 23:41:43 -07:00
Adeeb Shihadeh db31886ad6 gate mazda safety behind debug flag 2020-05-11 13:15:26 -07:00
Adeeb e4558c0737
Safety: message length check on RX and TX (#529) 2020-05-11 12:58:33 -07:00
Adeeb 869f123218
Hyundai: counter check (#530)
* hyundai counter check

* fix misra

* add counter to tests
2020-05-09 00:52:57 -07:00
Adeeb Shihadeh a4390713e6 gitignore for route logs 2020-05-09 00:50:34 -07:00
andrewcopenpilot ac1b64e628
Fix CAN Ignition for Black Panda and Uno (#526) 2020-05-07 19:29:10 -07:00
robbederks 273e3882fd
When initializing all the CAN busses, make sure the are also cleared (#527)
Thanks to 4vanetten <4vanetten@gmail.com>
2020-05-06 11:39:44 -07:00
bkralik c2bea78f6d
Fix python library on Windows (#523)
On Windows, setAutoDetachKernelDriver is not supported (http://libusb.sourceforge.net/api-1.0/group__libusb__dev.html#ga5e0cc1d666097e915748593effdc634a) and causes libusb to get stuck (simple try-catch is not working). This prevents any issues when running both at native windows python and cygwined python...
2020-05-02 12:18:26 -07:00
Adeeb Shihadeh 0a123b1815 that too 2020-04-30 14:54:40 -07:00
Adeeb Shihadeh ba6355d4c0 unused lines 2020-04-30 14:53:43 -07:00
Adeeb c9102c00ee
Chrysler: use can packer in safety tests (#522)
* Chrysler: use can packer in safety tests

* bump opendbc
2020-04-30 14:26:28 -07:00
Adeeb 9874e73350
Abstract steering safety tests for Toyota and Chrysler (#520)
* start abstracting torque steering tests

* remove duplicate

* chrysler

* remove that

* revert that for now

* fix toyota

* unused
2020-04-29 20:37:12 -07:00
Chris Souers 2299ecffc4
Block 0xe5 (Honda Bosch) at the panda/uno. Only allow static values. (#515)
* Safety for static 0xe5

Passes Misra test

* Add e5 to test.

* Readd
2020-04-28 14:13:00 -07:00
Adeeb 3517306113
Subaru: fix steer torque scaling (#501)
* Subaru: fix steer torque scaling

* fix legacy test
2020-04-28 10:47:26 -07:00
Adeeb 0bc864b3d5
Make torque-based steering state global (#518)
* use generic steering state vars for toyota

* chrysler

* gm

* comment

* more unnecessary lines

* hyundai

* subaru

* vw

* fix mazda
2020-04-28 10:33:20 -07:00