* how does this/did that pass?!
* fix misra
* add comment
* we could do this
* or could do what eps torque does
* another pr
* not unused
* need this for special gm
* support testing integer torque
cmt
* there we go
* stash again
* Revert "stash again"
This reverts commit 4ecf6cc91c.
* this works!
* clean up
* cmt
* ugh this test was broken
* add some comments for this behemoth, and switch to rxing real msgs
* for now, no measurement test since we don't have any info about driver torque on can. for ex:
max value, factor on CAN, etc.
clean up
* more clean up
* just use it everywhere
* better cmt
* cmt
* this was failing for the wrong reason
* stash
* Revert "stash"
This reverts commit b29e09ca85.
* call it driver torque
* Revert "call it driver torque"
This reverts commit 1ed5ce5ebe.
* hmm this works
* hyundai fix in another pr
* support testing integer torque
cmt
* there we go
* Revert "there we go"
This reverts commit 6c5a19aad8.
* Revert "support testing integer torque"
This reverts commit 2c381077d5.
* clean up
* Update tests/safety/common.py
* found another bug!
* update test
* why does toyota add 1 but not chrysler?!
* test/fix others
* clean up
* more
* global
* clean up
* one function to reset AND update
* without abs and only negative values: this is not caught (since negative error < 1)
* ugly draft
* clean up, tests work
* now only should use this function
* better cmt
* better loc
* constant in python too!
* actually duplicate comment
* Update common.py
* without abs and only negative values: this is not caught (since negative error < 1)
* ugly draft
* this catches it
* draft
* draft
* draft
* works now!
* no blurry tests
* ugh subaru is like this too
* okay some can scaling makes it slightly off (wheel speeds)
* uncommont
* clean up
* test the steering request bit
* not in the angle yet
* not angle yet
* fixes
* draft
* can do this
* adapting the 3 steer req mismatch tests might be too intricate
Revert "can do this"
This reverts commit 775abf877b.
* don't change safety and test the actual behavior
* add comment
* rm
* revert
* For example, now this caught
* "fix"
* Update tests/safety/common.py
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com>
* draft
* now clean up old comments
* no more special broken ice addr checks
* revert
* fix
* add test for ICE HDA1
* Revert "add test for ICE HDA1"
This reverts commit 76d2b0f066.
* can be separate
* macro for addr check struct
* add checks for alt buttons (fixes race condition)
* add macro for array len
* add comment
* misra
* comments to help separate
* can't put parenthesis around array item
* review suggestions
* no intermediary macros for making the structs (remove misra violation)
* Update board/safety/safety_hyundai_canfd.h
* single lines
* can avoid double checking hda2 since we have addr checks for it now
* wip
* steer bit
* add tolerance
* increase a bit more
* test too
* Had that backwards
* Here too
* review suggestions
* minimal diff
* minimal diff
* add type hints
* spacing
Co-authored-by: Shane Smiskol <shane@smiskol.com>
* update test name
* add tolerance comment
Co-authored-by: Shane Smiskol <shane@smiskol.com>
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com>
* common test for that
* canfd too
* we set this everywhere
* never none
* subclass
* Update tests/safety/common.py
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com>
* Nissan Altima: Specify panda flag for alt bus safety config
* test this safety mode
* test this safety mode
* rm
* nl
---------
Co-authored-by: Shane Smiskol <shane@smiskol.com>
Shane Smiskol
Adeeb Shihadeh
shameer99
Greg Hogan
Igor Biletskyy
Jason Wen
Justin Newberry