Commit Graph

2465 Commits

Author SHA1 Message Date
Adeeb Shihadeh 124a83c0bf disable forest while it's rebuilt 2023-08-30 11:18:40 -07:00
Adeeb Shihadeh a4fa40a713
python: show lib and fw versions in error (#1622)
* python: show lib and fw versions in error

* fix

* cleanup
2023-08-30 10:56:30 -07:00
Adeeb Shihadeh bc2f10da57 Revert "pre-commit: autoupdate hooks (#1618)"
This reverts commit 526588b3e9.
2023-08-30 10:38:12 -07:00
Justin Newberry e30ba9547c
Subaru: add steer req bit test (#1613)
add active bit test
2023-08-30 01:29:27 -07:00
Adeeb Shihadeh 526588b3e9
pre-commit: autoupdate hooks (#1618)
* Update pre-commit hook versions

* fix ranges

---------

Co-authored-by: adeebshihadeh <adeebshihadeh@users.noreply.github.com>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-08-30 01:27:07 -07:00
Jason Wen e6c1648835
Hyundai CAN-FD: Alternate `LKAS` steering message (#1504)
* new steering message!

* fix

* check tx

* fix var

* allow all tx to test LFA suppression

* Attempt to block laneline information to suppress LFA

* Try 0x364

* Block all bus 2/6 messages

* Final test to block LFA

* Fix tx

* in another PR

* cleanup

* lint

* Add new tx to unit test

* linter

* Apply suggestions

* Revert to this

* Unnecessary

* clean up

* rename to hda2

* prototype

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-08-29 23:40:14 -07:00
Jason Wen 48632d9e0b
Hyundai CAN FD: fix boolean types in fwd hook (#1620)
* Safety: Utilize boolean values for message block checks in forward hooks

* Revert "Safety: Utilize boolean values for message block checks in forward hooks"

This reverts commit ee9809dbd3.

* others

* Revert "others"

This reverts commit f64cc1c76a.

* just do hyundai

* function to get steering address

* unclear if this is cleaner

Revert "function to get steering address"

This reverts commit 2a2b972a20.

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-08-29 20:23:41 -07:00
Igor Biletksyy d41a0abef6 H7: comments for RAM organization reasoning 2023-08-29 16:10:50 -07:00
Igor Biletskyy 91d457cbb1
H7: reorganize RAM (#1619)
init
2023-08-29 13:04:27 -07:00
Igor Biletskyy 687e9feeb1
H7: decrease FDCAN TX FIFOs to 1 (#1614)
init
2023-08-29 13:04:20 -07:00
Igor Biletskyy 267dd04537
Update README.md
change Mac OS gcc version
2023-08-29 12:34:44 -07:00
Shane Smiskol ca9d8675b9
Revert "Toyota: ACC message relay check (#1612)" (#1617)
This reverts commit 5a9d8cfaaf.
2023-08-28 23:18:42 -07:00
Shane Smiskol 1e41659aab
Revert "iso-tp: more checks (#1487)" (#1616)
* Revert "iso-tp: return if updated (#1610)"

This reverts commit 0eb04fae67.

* Revert "iso-tp: more sanity checks (#1487)"

This reverts commit 01db9e4a83.
2023-08-28 23:08:41 -07:00
Shane Smiskol 5a9d8cfaaf
Toyota: ACC message relay check (#1612)
* toyota: add safety for tester present

* block ACC_HUD

* check stock ECU

* clean up

* not this

* test new addr

* comment

* rm

* cmt
2023-08-27 15:43:59 -07:00
Shane Smiskol 0eb04fae67
iso-tp: return if updated (#1610)
return if updated

reverts some of https://github.com/commaai/panda/pull/1314
2023-08-26 06:45:46 -07:00
Shane Smiskol 01db9e4a83
iso-tp: more sanity checks (#1487)
* assert rx not done for single frame to be valid

* not sure if this is correct yet

* return if updated

reverts some of https://github.com/commaai/panda/pull/1314

* Revert "return if updated"

This reverts commit ba4c4f194a.
2023-08-26 06:35:34 -07:00
briskspirit f7a1daab74 jungle: force CAN core reset on bus off detection 2023-08-25 17:58:10 -07:00
Shane Smiskol cca252c8d4
Honda: match openpilot button enable check (#1607)
* NONE -> not BUTTON

* update test and fix safety

* cleaner
2023-08-25 16:11:08 -07:00
Igor Biletksyy 8ed82d3899 jungle: fix can_health update on request 2023-08-25 15:42:39 -07:00
Adeeb Shihadeh 09cd81752d
python lib: close USB context properly (#1606)
* python lib: close USB context properly

* fix jungle

* rm that

---------

Co-authored-by: Comma Device <device@comma.ai>
2023-08-24 19:15:37 -07:00
Igor Biletskyy 0a32b17513
H7: few more Kb of RAM found (#1605)
* init

* remove discard
2023-08-24 16:56:31 -07:00
Adeeb Shihadeh 0587f22bf3
add --minimal build flag (#1604) 2023-08-24 14:01:27 -07:00
Willem Melching a48678f625
MacOS: Homebrew GCC is now version 13 (#1603) 2023-08-24 13:52:59 -07:00
Igor Biletskyy 737030a8a5
F4: fix UART clocks (#1588)
init
2023-08-23 15:38:59 -07:00
Igor Biletskyy c3c8d8f5de
peripherals.h clean and duplicates removal (#1599)
* init

* ULPI disable

* not related to clocks
2023-08-23 15:17:06 -07:00
Justin Newberry 04df95db1c
Subaru: add new angle LKAS message definitions (#1602)
* just add the lkas message to start

* added to tests too

* default parameter
2023-08-23 13:17:36 -07:00
Igor Biletskyy ee2f9dfd9c
H7: clean up peripherals.h (#1597)
init
2023-08-23 10:22:38 -07:00
Justin Newberry 3d91d78018
Revert "Subaru: infrastructure to support the new angle based control… (#1601)
Revert "Subaru: infrastructure to support the new angle based controllers (#1590)"

This reverts commit ea16a54166.
2023-08-22 17:30:11 -07:00
Adeeb Shihadeh 83423e2071
pre-commit: autoupdate hooks (#1600)
Update pre-commit hook versions

Co-authored-by: adeebshihadeh <adeebshihadeh@users.noreply.github.com>
2023-08-22 10:40:02 -07:00
Justin Newberry ea16a54166
Subaru: infrastructure to support the new angle based controllers (#1590) 2023-08-22 00:21:19 -07:00
Igor Biletskyy b47b8259ef
unify CAN/FDCAN odjects naming (#1596)
* init

* happy MISRA
2023-08-21 16:09:31 -07:00
Adeeb Shihadeh 57ec466a91
prefix openpilot imports (#1593) 2023-08-20 17:50:31 -07:00
Jason Wen 1d874be2b7
Safety: unify `controls_allowed` with boolean (#1589) 2023-08-18 13:22:04 -07:00
Adeeb Shihadeh aed103d537 Revert "Subaru: gen2 long safety (#1587)"
This reverts commit 2ae2567d8d.
2023-08-17 15:58:45 -07:00
Shane Smiskol d916357a3c
body: set vehicle_moving (#1591)
* add vehicle_moving

* Update board/safety/safety_body.h
2023-08-17 15:51:42 -07:00
Justin Newberry 95c89b8045
GM: switch to common gas/brake test (#1578)
* gm switch to common gas/brake test

* fix typo

* add comment about regen
2023-08-17 01:55:11 -07:00
Justin Newberry 2ae2567d8d
Subaru: gen2 long safety (#1587)
* setup proper safety for gen2 long

* whitespace

* misra

* alt bus

* high beam assist

* better names

* whitespace

* whitespace

* whitespace
2023-08-17 01:32:34 -07:00
Shane Smiskol 1f475a8aff
Hyundai: match openpilot standstill check (#1586)
* checks that we can replicate in openpilot

* clean up

* fix test

* can simplify this

* can also simplify this
2023-08-16 23:51:07 -07:00
Igor Biletksyy cfff3386c5 fix linter 2023-08-16 16:14:21 -07:00
Igor Biletksyy 16b3ec4ca3 add FW size checker script 2023-08-16 15:49:08 -07:00
Justin Newberry 02bcd14376
Subaru: cleanup to prepare for angle controller (#1585)
cleanup prepare for angle
2023-08-16 12:40:29 -07:00
Shane Smiskol b25810670e
Hyundai CAN FD: fix PCM cruise check (#1584)
* add pcm

* fix

* NA

* explicitly check cruise status

* comment and misra
2023-08-16 00:08:07 -07:00
Justin Newberry 8bd3e93813
Subaru: Global gen1 longitudinal safety (#1500)
* Add subaru long TX and RX messages

* misra c2012 fix

* fix tests

* Reorder signals

* increase max steering torque

* merge fix

* merge fix, remove cnt from test

* Move subaru logitudinal behind flag, add safety test

* update subaru_longitudinal checks

* cleanup

* Add subaru longitudinal checks

* misra fix

* Add subaru rpm and throttle rate limit checks

* temporary disable cruise throttle and cruise rpm checks

* update subaru long test

* update longitudinal safety and add tests

* fix tests

* fix misra

* subaru long signals limits checks

* Add controls_allowed to long tests

* remove unused variables

* Add AEB passthru and tests

* Add bus

* Update AEB logic

* Add GEN2 AEB support

* syntax fix

* Update AEB tests

* Add comment for subaru_aeb

* Do not check cruise_throttle and cruise_rpm limits when gas pressed

* use long limits struct

* Subaru: longitudinal checks only when controls_allowed, use ES_LKAS_State LKAS_Alert for AEB

* fix misra, set controls_allowed for es_brake test

* fix misra

* Fix es_brake violation check

* Add 0x323 to longitudinal test

* Remove stock fcw from aeb signals

* Use GET_BYTES

* Revert "export FW_PATH"

This reverts commit 2a5058d858.

* Revert "cleanup fw filename conventions (#1434)"

This reverts commit 4dd2735e38.

* Revert "Revert "export FW_PATH""

This reverts commit 86e8d321d0.

* Revert "Revert "cleanup fw filename conventions (#1434)""

This reverts commit 5aae6716fa.

* cleaned up safety

* cleanup subaru long safety

* subaru_aeb -> stock_aeb for other platforms

* fix unittests

* pretty

* need to upload this route

* remove AEB stuff for now

* remove unrequired rpm checks

* add comment

* added comment about acceleration and use throttle limit for rpm too

* inactive_throttle_fix

* Update board/safety/safety_subaru.h

Co-authored-by: Shane Smiskol <shane@smiskol.com>

* added comments about long limits

* increase max brake

* revert that

* cleanup

* rename throttle to gas

* add safety replay

* remove todo

* rename throttle to gas

* move subaru stuff out of common test

* PR cleanup

* added min gas

* reduce initial complexity by not intercepting cruisecontrol or brake_status

* create common gas brake safety test

* remove unrelated subaru reference

* also test below min_value

* fix fwd hook test

* better name and hardcoded

* use same as acceleration limits

* revert gm

* remove callable

* also limit rpm

* remove safety replay for now

* revert unrelated changes

* pr cleanup

* remove unused gasbrake safety test

* fix ruff linter

* PR cleanup

* pr cleanup?

* added common brake test and moved generic test to base safety class

* remove duplicate test

* wip

* wip

* rename longitudinalaccelsafety

* revert limits correct test

* fix controls allowed test

* move gm over to long gas brake test

* assert that limits are reasonable

* fix typing

* fix linter again

* fix linter again

* fix linter again

* like to make it clear

* typo

* fix from merge

* clearer names

* dont need thesemore

* subaru: use common test

* fix merge issue

* inactive gas from long limits

* fix tests

* linter

* fix gen2

* fix linter

* also test torque when doing long control

* renamre transmision rpm

* consistent whitespace

* rename declarations too

* rename transmission rpm

* same line

* actually is transmission rpm

---------

Co-authored-by: Martin Lillepuu <martin@mlp.ee>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
2023-08-15 18:51:13 -07:00
Justin Newberry f4e63e7da5
Safety: Rename alt transmission rpm (#1583)
* renamre transmision rpm

* consistent whitespace

* rename declarations too
2023-08-15 17:25:44 -07:00
Adeeb Shihadeh ab6601a756
pre-commit: autoupdate hooks (#1582)
Update pre-commit hook versions

Co-authored-by: adeebshihadeh <adeebshihadeh@users.noreply.github.com>
2023-08-15 10:29:32 -07:00
Adeeb Shihadeh d7f75ca722
safety tests: test one of each MCU type 2023-08-14 21:08:46 -07:00
Igor Biletskyy ab70a3c867
jungle: add pin header control (#1581)
* init

* style

* clean + gpio output
2023-08-14 19:38:38 -07:00
Justin Newberry 10a2727882
Subaru: prepare tests for long and angle control (#1580)
* prepare tests for long and angle control

* fix names
2023-08-14 19:26:00 -07:00
Justin Newberry 4ea50fbb09
Ruff: propgate config from OP (#1579) 2023-08-14 12:52:02 -07:00
Justin Newberry 05295dc42a
Safety: alternate longitudinal limits (#1577)
alt limits
2023-08-12 19:34:53 -07:00