commaai
/
panda
mirror of https://github.com/commaai/panda.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix possible null ptr dereference (#670)

This commit is contained in:
Igor 2021-06-18 20:10:44 -07:00 committed by GitHub
parent eccafa3712
commit 4c57ebd928
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
board/drivers/usb.h
View File

@ -420,14 +420,12 @@ void USB_WritePacket(const void *src, uint16_t len, uint32_t ep) {
USBx_INEP(ep)->DIEPCTL |= (USB_OTG_DIEPCTL_CNAK | USB_OTG_DIEPCTL_EPENA);
// load the FIFO
const uint32_t *src_copy = (const uint32_t *)src;
for (uint32_t i = 0; i < count32b; i++) {
// FIXME:
// cppcheck-suppress nullPointer
USBx_DFIFO(ep) = *src_copy;
// FIXME:
// cppcheck-suppress nullPointerArithmetic
src_copy++;
if (src != NULL) {
const uint32_t *src_copy = (const uint32_t *)src;
for (uint32_t i = 0; i < count32b; i++) {
USBx_DFIFO(ep) = *src_copy;
src_copy++;
}
}
}