Commit Graph

1328 Commits

Author SHA1 Message Date
Shane Smiskol b556672f9c
Lexus ES TSS2: improve start from stop response time (#1301)
* permit braking

* consider pitch
2024-09-27 21:21:27 -07:00
Jason Wen 4e64728753
HKG: Add FW version and update model year for Genesis GV60 2022 (#1293)
* HKG: Add FW version and model year for Genesis GV60 2022

* Update opendbc/car/hyundai/values.py

Co-authored-by: Jason Young <46612682+jyoung8607@users.noreply.github.com>

---------

Co-authored-by: Jason Young <46612682+jyoung8607@users.noreply.github.com>
2024-09-27 16:56:29 -04:00
Jason Wen 3dcf350501
Hyundai: Refactor interface with int flags (#1294)
* LEGACY_SAFETY_MODE_CAR

* CAMERA_SCC_CAR and experimentalLongitudinalAvailable

* CANFD_CAR

* CAN_GEARS

* reorder

* merge CANFD_CAMERA_SCC into CAMERA_SCC

* RADAR_SCC -> CANFD_RADAR_SCC

* remove CANFD_CAMERA_SCC

* revert

* fix

* redo in another PR

* remove unused

* revert test for now

* rename in new PR
2024-09-27 16:21:56 -04:00
Jason Young aa20e8ad75
HKG: Refactor alternate lateral limits (#1300)
* HKG: Refactor alternate lateral limits

* add a test
2024-09-27 16:02:42 -04:00
Jason Wen d2ca1860d8
HKG: Car Port for Genesis G80 2024 (2.5T, HDA2) (#1132)
* HKG: Car Port for Genesis G80 2024 (2.5T, HDA2)

* Apply #1284

* Apply #1285

* add test route

* Update opendbc/car/hyundai/values.py

Co-authored-by: Jason Young <46612682+jyoung8607@users.noreply.github.com>

---------

Co-authored-by: Jason Young <46612682+jyoung8607@users.noreply.github.com>
2024-09-26 23:34:41 -04:00
Jason Wen d332152aa1
Hyundai CAN-FD: Add CAN fingerprint fallback checks for HDA2 detection (#1285)
* Hyundai CAN-FD: Add CAN fingerprint fallback checks for HDA2 detection

* fix test

* just 1 source

* update unit test

* comment

* simplify

* move hda2 to the end of arg so it's cleaner

* Update opendbc/car/hyundai/interface.py

Co-authored-by: Jason Young <46612682+jyoung8607@users.noreply.github.com>

---------

Co-authored-by: Jason Young <46612682+jyoung8607@users.noreply.github.com>
2024-09-26 23:09:46 -04:00
Shane Smiskol f4b30bcd07
Lexus ES TSS2: compensate for creeping force (#1271)
* compensate for creeping force

* better comp

* not needed yet
2024-09-26 19:47:05 -07:00
Jason Wen 97f519b47a
Hyundai CAN-FD: Universal gear checks (#1284) 2024-09-26 22:32:47 -04:00
Jason Young 9dc8b8edac
HKG: Interface refactor (#1292)
* refactor experimentalLongiudinalAvailable

* refactor enableBsm

* refactor Panda safety config

* section headers

* radarUnavailable to common long section

* dashcam cars to car specific section
2024-09-26 16:50:35 -04:00
Jason Young 851d16108d
HKG: Cleanup EV and HYBRID flag setting (#1290)
* HKG: Cleanup redundant code

* remove unused imports
2024-09-26 15:56:41 -04:00
Jason Wen b11c159d87
HKG: Car Port for Genesis GV70 Electrified 2023 (HDA2) (#1131)
* HKG: Car Port for Genesis GV70 Electrified 2023 (HDA2)

* add test routes

* remove

* Apply suggestions from code review

Co-authored-by: Jason Young <46612682+jyoung8607@users.noreply.github.com>

---------

Co-authored-by: Jason Young <46612682+jyoung8607@users.noreply.github.com>
2024-09-26 14:27:19 -04:00
Jason Wen 8a56957ec5
Hyundai CAN-FD: Use `ACCELERATOR` for EV gear shifter positions (#1280)
* Hyundai CAN-FD: Use `ACCELERATOR` for EV gear shifter positions

* revert

* duplicated message checks
2024-09-26 13:12:49 -04:00
Jason Wen 521d8ff7d6
Hyundai: DBC updates for FCEV support (#1281)
* Hyundai CAN: gear shifter and accelerator pedal signals for FCEV

* Different name
2024-09-24 23:09:42 -04:00
Shane Smiskol bda4ad475a
Toyota: prevent lagged gas after heavy braking (#1279)
fix
2024-09-24 19:27:40 -07:00
Jason Young 8c17e039be
VW MQB: Temporarily remove 2024 Volkswagen Jetta (#1272) 2024-09-24 13:41:39 -04:00
Shane Smiskol 0f8cea64fd
Revert "Lexus: prevent lagged gas after heavy braking" (#1270)
Revert "Lexus: prevent lagged gas after heavy braking (#1266)"

This reverts commit f2c4bb7365.
2024-09-23 21:10:29 -07:00
Shane Smiskol f2c4bb7365
Lexus: prevent lagged gas after heavy braking (#1266)
* fix slow gas after heavy braking

* only target this specific case

* better comment

* Update opendbc/car/toyota/carcontroller.py
2024-09-23 20:56:07 -07:00
Kacper Rączy 090f476688
body: remove orientation/angular velocity checks (#1267)
Do not check for llk
2024-09-23 20:34:58 -07:00
Shane Smiskol 0b7648ad2c
Toyota: don't apply PCM compensation in the stopping state (#1264)
check inside so we ramp down smoothly not cut out compensation
2024-09-20 20:46:59 -07:00
Shane Smiskol 4b7c90dada
Lexus ES TSS2: reduce braking overshoot (#1261)
* construct final CS.pcm_accel_net

* compensate both ways (simpler)

compensate both ways (simpler)

* comment

* cmt

* todo
2024-09-20 20:42:31 -07:00
Shane Smiskol 24e8e091e3
Toyota PCM compensation: don't compensate in standstill (#1262)
don't compensate if in standstill
2024-09-20 20:14:24 -07:00
Shane Smiskol 0771622149
Toyota: lower long integral for new tune (#1255)
* lower integral

* Update opendbc/car/toyota/interface.py
2024-09-20 15:40:04 -07:00
Shane Smiskol 71aa716366
Toyota: pitch compensate new long tune (#1260)
* compensate for pitch (shouldn't apply too much on downhills and too little on uphills now) with some tricks

* less defart

* , given
2024-09-19 22:30:23 -07:00
Jason Young 9b87d3db55
FCA Giorgio: Reserve safety ID (#1252) 2024-09-18 16:08:07 -04:00
Jason Young a894cc9e29
FCA Giorgio: CAN database (#1250)
* refactor from older PR, add test coverage

* PEP8, consistency

* clarifying comments

* more concise

* consistency
2024-09-18 12:48:17 -04:00
Jason Young 4bc60b18d2
test_checksums refactor (#1249)
* refactor for future test code sharing

* PEP8 function naming

* wrap a long line
2024-09-18 12:16:58 -04:00
Shane Smiskol b937eefca1
Lexus ES TSS2: improve start from stop for ICE variants (#1248)
* Improve start from stop for Lexus ES TSS2 ICE

* won't be perfect, but we don't pitch compensate for other cars yet

* rm

* ramp to 0 when negative

* add todo

* clean up

* ugh, it's a subtype mypy!!

* huh, most lexus don't have CLUTCH, will have to find those later

* bug fixes

* clean up
2024-09-17 17:50:49 -07:00
Shane Smiskol c8beb979ec
Toyota: add brake force signal for hybrids (#1247)
add brake force signal
2024-09-16 17:30:34 -07:00
Shane Smiskol de025aed51
Toyota: add drive force signal for hybrids (#1246)
* add new signal

* set minmax

* better comments

* clarify

* add FDRVREAL for hybrids

* forgot scaling factor
2024-09-16 17:05:56 -07:00
Shane Smiskol cb92fc81fe
Toyota: add another acceleration request signal (#1245)
* add new signal

* set minmax

* better comments

* clarify
2024-09-16 16:15:40 -07:00
Shane Smiskol 6f08c8ab3d
Toyota: add ENG2F41 (#1244)
add ENG2F41
2024-09-16 14:48:20 -07:00
Jakub Czekański 57ebdbfa05
VW MQB: Keep CAN IDs in order (#1243)
ACC_02 had address in decimal format and was out of order.
2024-09-15 11:17:09 -04:00
Jakub Czekański 811ed779ff
VW MQB: Add missing ESP_33 messages and tests (#1242)
Added new CRC without coverage - oversight from rebasing #1016
2024-09-13 18:04:34 -04:00
Jakub Czekański d55feec17a
VW MQB: Add CRC for Airbag_01, ESP_02, ESP10, ESP33, Licht_Anf_01 (#1016)
VW MQB: Add crc for Airbag_01, ESP_02, ESP_10, ESP_33 and Licht_Anf_01
2024-09-13 12:22:34 -04:00
Jakub Czekański 0994697391
VW MQB: Refactored CRC calculation (#1236)
* VW MQB: Refactor CRC constants

Big switch statement in volkswagen_mqb_checksum was refactored with map of arrays.
With this approach there's no need for specifying all 16 byte values if constant is the same for all of them.

* temporary, repeat packing step 1M times

* follow comma convention for include order

* comma indent convention, tighten message annotations

* whitespace

* cleanup

* more comma indent convention

* Revert "temporary, repeat packing step 1M times"

This reverts commit 06d8f46710.

* comment touch-up

* beautify spacing

* codespell says you're gonna have to Google it

* fully initialize all data ID arrays

* clarify array name as part of VW support

* fix comment typo

---------

Co-authored-by: Jason Young <jyoung8607@gmail.com>
2024-09-13 10:43:16 -04:00
Adeeb Shihadeh 2b85882c51
toyota doesn't have gas 2024-09-12 17:03:18 -07:00
Shane Smiskol 56c7afa5a3
rm longitudinal profiles (#1240)
rm
2024-09-12 16:55:06 -07:00
Shane Smiskol b43d3003c5
fix spacing for test_checksums (#1239) 2024-09-12 16:36:04 -07:00
Jakub Czekański 751404a8b5
VW MQB: Added unittests for CRC calculation (#1235)
* VW MQB: Added unittests for CRC calculation

Some of the messages are either missing fields that causes serialization to skip bits
or CRC/BZ fields aren't picked up by packers leading to invalid values.

* VW MQB: Add missing fields in Getriebe_11

Test case is reenabled and now passes

* EV_Gearshift -> Motor_EV_01, enable test

* skip Getribe_11 testing with a note about why

* reenable all others, except SWA_01

* turns out we can still test Getriebe_11

* New test data for SWA_01, re-enable test

* no longer a need for test skipping

* no longer a need for custom tests

* more concise

* prefix with VW for clarity

---------

Co-authored-by: Jason Young <jyoung8607@gmail.com>
2024-09-12 15:02:08 -04:00
Jason Young 4b31c18530
VW MQB: Various message and signal updates (#1238)
* VehicleSpeed -> ESP_08

* ESP_21 updates

* Motor_20 updates

* SWA_01 updates

* ESP_20 updates

* Getriebe_11 updates
2024-09-12 14:00:50 -04:00
Jason Young d8aba58b25
VW MQB: EV_Gearshift -> Motor_EV_01 (#1237)
* DBC updates

* update comment in CRC function

* updates to carstate and interface

* update shifter VAL lookup
2024-09-12 12:39:20 -04:00
Shane Smiskol c43cd3a24b Nidec: add longitudinal control comment
This name is confusion
2024-09-10 19:07:24 -07:00
Shane Smiskol 3ff90573c7
Test all torque cars' lateral limits (#1232)
* test more models!

* Impreza 2020: reach max in ~0.8s instead of ~0.6

* leave todo for gen2, not safety critical since jerk is under threshold (1000/40*2/100=0.5s)

* fix honda
2024-09-10 15:20:34 -07:00
Adeeb Shihadeh ef7102a8ae
Toyota: AEB actuation setup (#1227)
* try this

* cleanup

* lil more

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
2024-09-07 16:32:53 -07:00
Shane Smiskol c0a9ab5c39
Move radar delay to carParams (#1224)
move radar delay to CP
2024-09-05 15:45:42 -07:00
Shane Smiskol 3dde383593
Radar interface getter (#1220)
* ret it now

* don't forget

* better
2024-09-05 14:15:40 -07:00
Jason Young 86be858a37
Hongqi: Add DBC for Hongqi HS5 (#580) 2024-09-05 13:23:46 -04:00
dkiiv 199480095c
VW PQ: Volkswagen Jetta 6th Gen (#1208)
VW PQ: add fingerprint for new car model
2024-09-05 12:47:35 -04:00
Maxime Desroches 6619c18f1f
distutils comment (#1222)
comment
2024-09-04 14:48:02 -07:00
Maxime Desroches 1e6e045f64
add setuptools for python3.12 (#1221)
setuptools
2024-09-04 14:20:59 -07:00