Commit Graph

82 Commits

Author SHA1 Message Date
Tim Wilson
1d03fb59c8 Car port: CADILLAC ESCALADE ESV 2019 (#29913)
* add CADILLAC ESCALADE ESV PLATINUM 2019

* add test route

* Update selfdrive/car/gm/interface.py

* combine params

* that's just a trim

* wow, there's a huge torque offset (left is 1.2 m/s^2, right is 1.9 m/s^2 max lat accel)

* don't hard code

* Update selfdrive/car/torque_data/override.yaml

* consistent formatting

* add to releases

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: b95d69ae1b
2023-10-21 02:04:24 -07:00
Justin Newberry
58936aa0cb Use StrEnum for car classes (#30114)
* str enum

* import sort

* fix car helpers

* fix that

* fix static analysis
old-commit-hash: 6ae465e4af
2023-09-30 17:15:34 -07:00
Adeeb Shihadeh
16ec56398c add openpilot prefix to imports (#29498)
* add openpilot prefix to imports

* more

* more

* fix docs

* fix linter

* bump submodules

* fix patched tests

* update dynamic imports

* debug

* Revert "debug"

This reverts commit db5e13b9911cc74438bee123bc3430da6c31b24b.

* fix pm test
old-commit-hash: a9626f95b6
2023-08-20 20:49:55 -07:00
Shane Smiskol
c817cb942d CAN fingerprinting test (#29427)
* timing test

* test

* fix

* print

* loop

* clean up

* wider range

* Update selfdrive/car/tests/test_models.py

* Apply suggestions from code review

* run many times

* Update selfdrive/car/tests/test_models.py

* run for many its

* run with unittest and print as list

* Update .github/workflows/selfdrive_tests.yaml

* Update .github/workflows/selfdrive_tests.yaml

* total time is super inconsistent (body)

* Update selfdrive/car/tests/test_models.py

* clean up

* clean up

* clean up

* this works!

* draft

* test suite not as modular

* try something like this

* can do kb, but not too representative

* clean up

* remove kb? it depends on signals

* clean up

* more clean up

* rename

* just measure all CANParsers

* can do all this manually

* but this is way simpler

* comment

* stash

* draft

* draft

* remove old script

* clean up

* revert

* use it

* remove test

* opt

* no partial

* remove

* revert test_models

* test can fingerprinting

* so much simpler!

* fix dict resizing

* simplify

* need to do this

* fix

* move to new file

* rename

* comment

* ignore function-uses-loop-variable
old-commit-hash: fd8f8d8785
2023-08-17 00:57:12 -07:00
Justin Newberry
3ee0786de3 CI: Pylint to ruff (#29294)
* pylint to riff

* pylint to riff

* pylint to riff

* revert more

* undo exclude removal

* exclude tinygrad

* set line length

* pylint exclusions to ruff

* same excludes as old linter

* fix tools QA

* remove unrequired check

* revert linting third_party

* ignore e402
old-commit-hash: 7fdd9fc37c
2023-08-09 13:26:54 -07:00
Justin Newberry
7b677910df Linter: Fix >160 line length test (#29287)
* test

* fix line length

* fix line length

* fix file size

* revert poetry

* cleanup for PR
old-commit-hash: cf64b27168
2023-08-08 17:13:35 -07:00
morrislee
9bd006f551 GM camera ACC: add camera diagnostic address to fingerprints (#28331)
* add missing addresses FP for silverado

* add for all camera acc gm

* add test

* check both rx and tx

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 2914fa9d12
2023-06-25 20:13:55 -07:00
Shane Smiskol
31c1e66a01 car docs: document parts of parts (#28292)
* more stuff

* even more

* all parts func

* start to use it

* include self in parts

* use car_parts_new

* not used

* more usages

* remove get_parts

* remove more commented stuff

* remove iter

* clean up some more stuff

* more

more

* ford

* optional

optional

* nissan

* use new classes

* fix tests

* fix

* order

* no more required

* connector

* CARS.md

---------

Co-authored-by: Maxime Desroches <desroches.maxime@gmail.com>
old-commit-hash: 024abe6455
2023-05-31 21:30:50 -07:00
Maxime Desroches
734b6481b7 car docs: list all needed hardware (#28212)
* generic car parts

* better carparts

* add part type

* more tests

* multiple enums

* unit tests

* just check isinstance

* better name

* remove _connector suffix

* remove those hyundai lines

* remove default arg

* Revert "remove default arg"

This reverts commit 139650a3b6b94358c3b9b12bb5fbe0a326d7abad.

* cleaner code structure

* use fingerprint

* review

* abstrac data class + common

* no more dataclass

* conflict

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 9f5f8b603c
2023-05-22 10:17:33 -07:00
Maxime Desroches
4626add29c add harness kit content to the doc (#28139)
* add harness kit content to the doc

* parts as enum

* nissan

* merge column

* rename column

* scaling

* scaling again

* 500px

* align text

* more px

* add style

* more width

* more

* more

* smaller text

* make all text smaller

* prev width

* default list

* remove hidden a ref

* try to remove again

* revert

* replace harness with harness_kit

* try fix

* cleaner

* center everything

* make pylint happy

* allow more than 1 of each parts

* use copy module

* review

* testing spacing

* revert

* bigger text

* formating

* split harness col lines

* remove print

* resolve

* rename to view

* keep formating in template

* simplify

* add unit test

* more generic way

* better

* harness connector only

* comment

* review

* put back harness parts

* missing dash

* too much space

* don't reload when clicking

* shorter comment

* only last line

* generate

---------

Co-authored-by: Cameron Clough <cameronjclough@gmail.com>
Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 70677fe5fc
2023-05-15 15:33:54 -07:00
Yong-seok, Jang
f8453b27d5 GM: Trailblazer 2021-22 support (#27830)
* Add trailblazer support

* Update routes.py

* Update routes.py

* Update CARS.md

* Fix incorrect torque name

* Update values.py and CARS.md

* Change to update another route

* update docs

* only 2021 https://en.wikipedia.org/wiki/Chevrolet_Trailblazer_(crossover)

only 2021

* new FP with missing addrs

* Update selfdrive/car/gm/interface.py

* tune the torque params

* update docs

* remove as a new platform

* Revert "remove as a new platform"

This reverts commit c9c65f29dbb1e1a5926540bb75433928325d6c0e.

* add comment and comment out FP

* need it to be in all_known_cars to test_model

* add to releases

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: e1ad8df519
2023-04-12 23:32:03 -07:00
Adeeb Shihadeh
9410a4f513 car docs: add field for min compatibility requirements (#27805)
old-commit-hash: 088cbfc9d5
2023-04-04 17:47:49 -07:00
Vivek Aithal
b6909a65e7 Bolt EUV: Non-linear torque function (#27696)
* add erf based ff

* silly bug; diff of nonlinear != nonlinear of diff

* add sigmoid based ff, ensure slope at 0 > 1

* reduce steer down limit and increase driver allowance

* rebase panda

* atry without friction, and with tanh nonlinear

* finalize the nonlinear function

* do not disable friction compensation in the ff

* bump panda

* bump panda

* update refs

* update refs

* resolve comments

* Add type hints

---------

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 15b880c0ea
2023-03-29 15:10:39 -07:00
koch-cf
b39f632403 GM: Buick LaCrosse 2017-19 support (#27332)
* Added Buick LaCrosse 2017

* Added Buick LaCrosse as candidate

* Added Buick LaCrosse CAR_INFO and Fingerprint

* Added Buick LaCrosse to non_tested_cars

* Added Buick LaCrosse

* Updated number of supported cars to 237

* Added ACC and LKAS description to Buick LaCrosse

* Updated CAR_INFO for Buick LaCrosse

* Added the Escalade which was recently updated

* Update selfdrive/car/gm/values.py

Suggested fingerprint by @sshane

Co-authored-by: Shane Smiskol <shane@smiskol.com>

* Premium is a trim with ACC. Use package name instead

* lacrosse custom FF;
fit info:
describe(steer_offsets) = DescribeResult(nobs=1649402, minmax=(-0.7127894163131714, 5.3997602462768555), mean=3.3090523060153645, variance=0.3130325564084465, skewness=-1.5986155151533736, kurtosis=8.18810418298873)
Samples: 1357787
Regularizing...
Regularized samples: 1140
speed: DescribeResult(nobs=1140, minmax=(8.478170424241286, 35.837870224662446), mean=27.888804767013475, variance=34.16742353763829, skewness=-1.068587303119431, kurtosis=0.6193071765927134)
angle: DescribeResult(nobs=1140, minmax=(-21.057768565637094, 28.516874490999708), mean=-0.4328602593886506, variance=43.19046813273241, skewness=0.001966426701503317, kurtosis=0.20547357649038434)
steer: DescribeResult(nobs=1140, minmax=(-0.8432471203007578, 0.9634959333674695), mean=-0.021981142946747863, variance=0.20152217060233915, skewness=0.03202313890158864, kurtosis=-1.2318826088567174)
Performing fit...
Fit: [5.85397825e-01 3.27650818e-01 4.60531117e-03 1.32307599e+01
 1.37194709e-01 1.33099557e-01 6.14782304e-02]
ANGLE_COEF = 0.58539783
ANGLE_COEF2 = 0.32765082
ANGLE_OFFSET = 0.00460531
SPEED_OFFSET = 13.23075991
SIGMOID_COEF_RIGHT = 0.13719471
SIGMOID_COEF_LEFT = 0.13309956
SPEED_COEF = 0.06147823
MAE old 0.2098, new 0.0309
STD old 0.1021, new 0.0273
deg 00-03:457, deg 03-06:258, deg 06-09:218, deg 09-12:132, deg 12-15:62
deg 15-18:6, deg 18-21:4, deg 21-24:1, deg 24-27:0, deg 27-30:2
deg 30-33:0, deg 33-36:0, deg 36-39:0, deg 39-42:0, deg 42-45:0

mph 10-15:0, mph 15-20:1, mph 20-25:18, mph 25-30:12, mph 30-35:30
mph 35-40:26, mph 40-45:52, mph 45-50:54, mph 50-55:73, mph 55-60:86
mph 60-65:204, mph 65-70:228, mph 70-75:179, mph 75-80:176, mph 80-85:1
mph 85-90:0,

* Update routes.py

* remove from non tested routes

* use torque controller

* update docs

* update releases

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
Co-authored-by: Tim Wilson <twilsonco@gmail.com>
old-commit-hash: ae423a6868
2023-03-20 13:10:19 -07:00
Adeeb Shihadeh
5da2a5fa05 GM: revert steering limits update (#27413)
* Revert " GM: update steering limits (#27331)"

This reverts commit b8740c4d6c5bad5ac947d9eefeb38a5b47876ca3.

* update refs

* bump panda
old-commit-hash: 1504c10760
2023-02-21 15:48:10 -08:00
Eric Brown
b98587ae87 GM: detect unplugged or missing radar (#27245)
* Add flashed Volt fingerprint

* Add another fingerprint

* Detect radar header message

* dashcamOnly if ASCM vehicle with radar unavailable

May be able to change this in the future to OP long off with experimental long available

* no submodule update

* Revert minEnableSpeed

* combine into one fingerprint

* Don't use GM radar DBC

Co-authored-by: Shane Smiskol <shane@smiskol.com>

* unused

* add new FP

* update docs

* use_off_car_defaults

use_off_car_defaults

* update docs

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: c3ba2a025b
2023-02-20 15:28:32 -08:00
Ricky Gilleland
701bde9de3 GM: Escalade 2017 support (#27276)
* Initial 2017 Escalade values

* update docs/CARS.md

* revert back to v1 fingerprint & add test route

* revert bad merge

* update fingerprint

* update

* update

* Update selfdrive/car/gm/values.py

* Update selfdrive/car/gm/values.py

* no engine

* Try global tune

* pcm

* Driver Assist Package has ACC, and includes LKAS from previous package

* update docs

* add to releases

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: b76795d7f0
2023-02-15 17:07:24 -08:00
Vivek Aithal
474e072c02 GM: update steering limits (#27331)
* reduce steer down limit, driver allowance

* update refs

* update refs
old-commit-hash: 1cdf80003d
2023-02-14 13:22:49 -08:00
Shane Smiskol
503fea8e12 GM: reduce steering message rate (#27201)
* Lower active rate and raise limits to compensate

* bump panda

* bump panda

* Update ref_commit

* bump panda to master
old-commit-hash: 86d86fa9da
2023-02-07 23:38:05 -08:00
Shane Smiskol
cc44b893c4 docs: open footnotes in new tab
old-commit-hash: 47cca343ec
2023-01-12 15:07:14 -08:00
Shane Smiskol
e66e4d8af2 Lateral jerk unit test (#25759)
* stash

* more test

* less test

* clean test

* no angle

* add tolerance

* fix gm

fix gm

* test both

* lower some rates on hkg

* stash

* simpler

* bump panda

* Revert "bump panda"

This reverts commit f2137c221145cca723fe6ee3378ba947b7061965.

* only torque

* make kona pass

* duplicate __init__

* move

* half clean up

* half clean up

* more clean up

* more clean up

* fix static analysis

* calculate over 0.5 seconds

* limit to max steer

* type annotation

* calc once
old-commit-hash: aab33b1c5f
2022-12-15 21:52:07 -08:00
Shane Smiskol
203ade9602 GM: add Bolt EV test route (#26681)
* bolt ev!

* releases

* it's a trim
old-commit-hash: 3e2a49c6e5
2022-12-02 22:09:42 -08:00
Shane Smiskol
ee961b62f8 Car docs: add a make-specific init function (#26565)
* add a hook function for makes to implement custom docs logic

* don't need this

* use the pre-defined list for honda's harnesses

* one line 😎

* Update selfdrive/car/docs_definitions.py

* i didn't know you didn't need a pass!

* don't change docs order
old-commit-hash: 1367f84425
2022-11-21 18:01:08 -08:00
Tim Wilson
713ec37e49 Add video_link for GMC Sierra (#26506)
* Add video_link for GMS Sierra

* fix precommit

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 187f8c177a
2022-11-17 02:03:13 -08:00
Tim Wilson
d985096170 Add video link for Volt (#26504)
old-commit-hash: bdc432d218
2022-11-15 10:55:43 -08:00
Shane Smiskol
6a7ce3a4d6 GM camera ACC: vision-only ACC behind toggle (#25631)
* put gm camera voacc behind disable radar toggle

* bump panda

* bump panda

* bump panda

* experimental long

* fixes

* car control notes and fixes for Bolt EUV

* might enable stop and go

* consistent name

* min enable speed seems to be around 5 kph

* camera acc can engage under 5 kph if stopped

* comment

* comment

* remove this for now

* only real brake

* comments

* update max brake

* bump

* clean up/fix

* same if

* simplify

* fix

* old comment

* no brake_pressed

* temporary fault fix

* tune longitudinal

* update docs

* bump panda

* GM camera ACC cars have no regen in ACC

* cleaner

* cleaner

* fix

* set max gas

* fixes

* fix LKAS unavailable warning from camera

* only camera

* bump panda

* bump panda

* bump panda

* bump panda

* clean up gmcan

* clean up CC

* flip

* rm

* rm comment

* clean up

* custom starting/stopping probably not needed

* Update selfdrive/car/gm/carcontroller.py

* fix crash

* long tuning

* we need long control state to resume

* CAMERA_ACC_CAR not needed

* no interp on accel

* tuning

* formatting

* formatting

* formatting

* formatting

* formatting

* no need to init ccp

* makes more sense now
old-commit-hash: 2fb7b4ffad
2022-11-02 02:46:29 -07:00
Shane Smiskol
ed9c040be9 GM: reduce LKAS faults while inactive (#26196)
* send at 10hz when inactive

* try to make it fine to switch rates

* fix rate

* todododo

* fine if we skip, we usually send too early

* clean up

* this may be required, 50Hz is not really needed to sync/initialize

* preserves previous behavior (not sure if this makes sense)

* Revert "preserves previous behavior (not sure if this makes sense)"

This reverts commit 3b297bca72307b5cba09bec4e2cd8e0f2761af42.

* Revert "this may be required, 50Hz is not really needed to sync/initialize"

This reverts commit a6b4693814214d3f508db922f3b371c402a13995.

* rm com

* Update ref_commit

* gate behind GM Cam

* common logic

* bet

* update refs
old-commit-hash: 27e315e58f
2022-10-25 00:12:49 -07:00
Shane Smiskol
dcb882a690 GM: inactive gas/regen safety (#26184)
* Add INACTIVE_REGEN

* bump

* Update selfdrive/car/gm/carcontroller.py
old-commit-hash: 3a70253567
2022-10-21 01:14:15 -07:00
Shane Smiskol
8e1e6132c8 GM: raise max brake (#25810)
* -4 didn't make any sense?

* comments

* comments

* update to 400

* bump panda

* remove unused iso limit vars

* update comments

* bump panda

* Update selfdrive/car/gm/values.py

* Update ref_commit
old-commit-hash: 84adb8d925
2022-10-04 00:39:19 -07:00
Cameron Clough
529b861d4b docs: remove redundant keyword args (#25899)
remove unnecessary keyword args, unnecessary package
old-commit-hash: 89768376c0
2022-09-27 14:00:08 -07:00
Jason Shuler
929cf64bb5 GM: Chevy Bolt EV 2022-23 (#25430)
* Chevy Bolt EV w ACC Port

* dashcam

* The website allows you to select the package without ACC

* fix Bolt E(U)V centerToFront

* Update selfdrive/car/gm/values.py

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: cfaa1b7d3e
2022-09-15 20:11:53 -07:00
Jason Shuler
c1fa914af8 GM: Chevy Equinox 2019-22 (#25431)
* Chevy Equinox Port

* LKAS is not standard on 2019, but it's the same package as ACC. (LKAS standard 2020+)

* 2019 here too

* clean up

* add to untested

* not in docs

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 1aa8c0525e
2022-09-15 17:55:02 -07:00
Shane Smiskol
978c84e885 Car docs: more consistent package names (#25797)
* update docs

* Revert "update docs"

This reverts commit a5127198fe8e43ecadb0cbde432773f4da2e212a.

* spell it out

* update docs

* add (ACC) for consistency

* All VW
old-commit-hash: ce9c689bb4
2022-09-15 16:07:51 -07:00
Shane Smiskol
16b585f007 GM: add Silverado 2021 High Country FP (#25499)
* Add FP from 61c6258cac78af08

* add to dict
old-commit-hash: 0822f94bb4
2022-08-22 17:45:41 -07:00
Shane Smiskol
4f628954c7 GMC: Sierra 2020-21 support (#25523)
* Add Sierra

* actually this package works

* add to releases

* credit
old-commit-hash: 68ba8df693
2022-08-22 17:35:04 -07:00
Jason Shuler
a019d5ea40 GM: Chevy Silverado 2020-21 support (#25429)
* Silverado support

Co-authored-by: Jason Shuler <jshuler@gmail.com>

* Update docs

* Try 2 m/s/s

* Should be good torque values

* Add Silverado test route

* Add to releases

* Send counter

* can't send multiple or it faults

* Send at 33hz, no counter

* try 25hz, don't line up exactly with car's buttons

* never tried 10hz with same counter

* Update selfdrive/car/gm/gmcan.py

* Make same as pcmCruise branch

* update year and package (different packages needed per-trim)

* Update year in releases

* Revert to 21

* We can use this package name again

* wrong one!

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 1e9fdff642
2022-08-19 16:58:06 -07:00
Shane Smiskol
e1a61dec0c GM Bolt EUV: update supported packages (#25496)
* Update values.py

* Update selfdrive/car/gm/values.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* update docs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: fb19e24d60
2022-08-19 15:48:46 -07:00
MadBrad
74142e16b1 Car docs: add video link for 2022 Chevy Bolt EUV (#25443)
* Car docs: Add video link for 2022 Chevy Bolt EUV

* New video added
old-commit-hash: 07320fb8a8
2022-08-15 15:29:46 -07:00
Shane Smiskol
dc4270ceee Car docs: fix required package for Bolt EUV 2022-23 (#25421)
* Need Adaptive Cruise Control

* no 2LT in configurator

* or redline
old-commit-hash: c2162420d2
2022-08-12 20:56:26 -07:00
Jason Shuler
3072fb4aec GM: Bolt EUV 2022-23 port (#24875)
* Switch to ECMPRDNL2 for GM gear

* Removing manumatic gear #

* values.py almost complete

* Silverado and Bolt EUV val and CP

* GM controller updated

* Cam hrns supp done (in theory)

* cleanup for new cars

* Remove extra constant

* WS, etc cleanup

* removing the unused

* Fix kpBP typo

* Updated docs

* Skip's PIF tune

* Dropped LKA CAN error patch

* Add silverado sigmoid ff

* CAN Err & LKA latch patch

* Remove EPS fault fix (another PR)

* Remove Silverado (another PR)

* clean up some common params

* Remove Escalade FP

Remove Escalade FP

* comment

* Premier is just a trim

Premier is just a trim

Premier is just a trim

* no footnote: new Bolt is like most other cars, older GM were outliers not at the camera

* clean up

clean up

* bump panda

* bump panda

* bump panda

* bump panda

* bump panda

* remove comments

* try spamming buttons on bus 2

* bump panda

* bumping opendbc w btn rc

* not needed for this port

This reverts commit 6af1f0ba799e075f877d7acc8ca0f117d97da361.

* add button safety

* Send next rc when spamming btns

* forward other signals in message

* missing DriveModeButton

* fill cruiseState.speed

* see if resume works without counter

* try the whole message

* send immediately and at 10Hz

* no resume, back to just button signal

* even holding random buttons it cancels

* Use torque controller with base tune

* stock long GM don't auto-resume yet

* Testing GM zero min steer speed

* Revert latcontrol

* revert opendbc

* latActive is basically lkas_enabled

* Update Bolt torque params

* comment

* clean up

* Add to releases

* Add test route

* Don't specify segment

* bump panda

* bump panda

* no harness for Bolt just yet

* Apply suggestions from code review

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* We support all and 2023

* move safetyParam up to first cam check

* Bump panda and update docs

* Update RELEASES.md

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

Co-authored-by: Shane Smiskol <shane@smiskol.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 4ffe9e68db
2022-08-12 16:10:34 -07:00
Tim Wilson
5066d2c04c GM: separate EV/ICE gas/brake lookup tables (#25354)
* GM: separate EV/ICE gas/brake lookup tables

* removed blank line

* V are the same

* comment

better ordering

comment

comment

* Add some delay for the laggy brakes

Add some delay for the laggy brakes

* move actuator to only acadia

* start braking at 0 m/s/s

* Revert "start braking at 0 m/s/s"

This reverts commit 55c1dee733aab3dc037fb1705c9bd0ace55c849f.

* add delay for escalade

* revert EV changes

* Update selfdrive/car/gm/carcontroller.py

* comment

* only ACADIA

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 2a4020da60
2022-08-08 13:55:40 -07:00
Shane Smiskol
140c521982 GM: add OBD-II harness to all GMs (#25356)
* Update/cleanup CarInfo

* Update footnote

* this will be on the website

* update docs

Co-authored-by: Jason Shuler <jshuler@gmail.com>
old-commit-hash: e1d38be92f
2022-08-05 15:19:21 -07:00
Shane Smiskol
537d42c234 Prepare for new supported vehicles webpage (#25021)
* add well maintained footnote

* stash

* some updates for the website

* one extensible sort function, pass sort function into template, continue to use "openpilot ACC"

* use items

same

* return a final dict

* Fix descriptions

* Required

* Add detail sentence

* Make string packages into namedtuple

* add temp year parsing

* revert this

* one unified class like harness

* fix static analysis

* Fix body

Fix body

* Make specifics strong

* remove years

* Make Camry footnote more clear

* Revert this too

* Add notCar text, fix steer speed > enable speed (remove comma, no speed mention)

* fix missing years

* group_by_make

* Use full package text

* Only use full package text

* Check car name if notCar, fix imports

* add_years no longer needed, remove 'with Stop and Go'

* fix that

fix that

fix that

* Exception for Nissan and Subaru

* Adjust DSU footnote text

* Fix speed overrides in sentence, CR-V package imp

* init() was being called multiple times, only need to run once to set row
old-commit-hash: c8a90ef586
2022-08-01 13:26:24 -07:00
Jason Shuler
2f3e4b1b67 GM: values.py cleanup & minor updates (#24908)
* Comment update on static limits

* Astra FP cleanup

* DBC autogen & customizable

* Add new Escalade FP, disable bad

* Add DROPPED CanBus value

* Update/cleanup CarInfo

* DBC -> defaultdict

* Fix DBC typing issue

* Revert Escalade fix

* clean up

* comment spacing

* revert this for now

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: fcc5b3d70c
2022-07-01 13:45:32 -07:00
Shane Smiskol
7464b42368 CarInfo: Add harness information (#24085)
* Add harness information

* test harness enum

* add harness info for tucson

* update Tucson harness

* get rid of development

* make global enum

* fix

* add harness info

* add harness info to CARS.md (since we need multiple lines per HKG platform)

* revert this

* Actively Maintained means something! (aka, to bronze with select VW)

* fix caravelle

* add harness tooltip on maintained column

fix

* lol tubaru

* always assume harness

* update honda harnesses

* add Ioniq hybrid 2017-19 harness, todo: not sure

* unused import

* hmm, did they really switch to the C for 1 year??

* add comment

* add comments

* adding tooltips should be fine

* fix santa fe harness

* welcome back, vw

* no need for two harness strings

* seems fine

* fix 19-20 Niro EV harness

* these were taking from old database, so assume correct

* could be d

* pass all car info into template

* no more tool tips

* these use j533 harnesses

* accidentally got removed in merge

* also merge issue

* don't need these

* make harness non-optional
old-commit-hash: 433fcc0c71
2022-05-11 18:02:21 -07:00
Shane Smiskol
426a300c21 docs: support for automatically generating website vehicles page (#24020)
* add vehicles.vue template

* add original vue file

* stash

* stash

* clean up a bit

* add template for now

* implement footnotes and tier copy

* no more generator

* convert to 2 spaces

* should work, now onto vue

* does GH handle this html well?

* fix

* auto-generate descriptions and make tiers' maps non-str

* remove old files

* move template specific variable into templates, should be a bit simpler

* js template is simplier too now

js template is simplier too now

js template is simplier too now

* add video links from the nice car_info

* make rows attributes

* clean up

* fix

* remove template

* experiment with video links in GH

add image

how does this look?

fix

* Revert "experiment with video links in GH"

This reverts commit 8375e717b563f7b4ecf009ffae00174de1a0b8e9.

* sort tier_car_info in place

* unused Tuple

* no type check

* fix script
old-commit-hash: 85d8997a8a
2022-03-23 13:42:53 -07:00
Shane Smiskol
bf8262394f Docs: auto-generate supported cars documentation (#23762)
* make CAR class enum, and values.py formatting

* Revert "make CAR class enum, and values.py formatting"

This reverts commit 04d9817e9d5d6ab5c027754018fc445f2cd3067a.

* stash

* add supported packages and model years

* don't change model years in fps

* move Lexus to info dict and make int enum

* remove sometimes wrong model years from name string

* use enum names

* convert Honda's values

* nice names

* use name

* GM

* Mazda, Ford

* Hyundai: WIP

* finish Hyundai

* fix

* Nissan

* Subaru

* Tesla

* formatting is for another PR

* Chrysler: todo: unify the Pacificas?

* do volkswagen

* this isn't a zoo

* skip enums for now

* Update selfdrive/car/volkswagen/values.py

Co-authored-by: Jason Young <46612682+jyoung8607@users.noreply.github.com>

* set All

* temp cars

* auto-generate CARS.md

* update type hinting

* add generated file

* add longitudinal star to cars that support disabling radar

* add TODO

* add notes

* add min_steer_speed exception for hatchback

* add minimum steering speeds

* Add exceptions and run generator

* Missing Telluride

* fix Prius v

* missing Prius Prime

generate

* start to convert years to strings

* Fixup Hyundai

* convert year sets to strings

* handle this

* missing S3

* Fix and add all missing cars (verified with script

* Supported Package fixes

* add get_tiered_cars

* Check radarOffCan for removing most Honda from op long

* Update for Avalon stop and go update on master

* Fix missing car params

* add my temporary script i'm using to verify new generated DBC

add my temporary script i'm using to verify new generated DBC

* generate with jinja template

* add header and footer

* clean up

* rename

rename

* add exceptions. jinja is nice, but why are its loop indexes starting at 1?

* add list of known car videos

* See how these look

* Add nice table formatting for column description

Add nice table formatting for column description

* generate

* consisten br tag

* small clean up

* temp

* Move car videos into CarInfo

* add new copy and rename to footnotes

* Revert "temp"

This reverts commit 93c3fce1d3ab406f80cbfb9c00c2237d109c7846.

clean up

* generate

* replace with svg

* simplify a bit

* add footnotes to CarInfo

* move some variables to docs.py

* Add video link for Acadia

* Make Footnote an enum so we don't use random ints

* static analysis fixes

* move to CARS.md

* fix last missing footnote

* add to release files

* rm test file

* use svg

generate

* fix sorting

* not needed

* not sure how this got here

* remove Sedan/Couple and add Diesel footnote

* finish todos

* move make specific footnotes to selfdrive/car/*/values.py

rename

* change to zeros

* align bottom to center

* Apply some suggestions

* Update selfdrive/car/mock/values.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update copy

* Try headers + bullet points

* somehow better

somehow better

* finish updating copy

* move template and add links to sups

* stars shouldn't be clickable

that didn't work

try this

try this

this is better

* add type hints to CarInfo

add more type hinting

* optional needs a type and any covers all (?)

* move good steering torque to */values.py

* dataclasses are much nicer than attr

* use tuple

* Update docs/cars.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* suggestions

* suggestions

* suggestions

remove

* clean up a bit

* add more type hints

* center stars and remove hardcoding from template

* update copy

* Add test

* Fix types

Fix types

* add supported cars documentation test

* clean up

* replace with docs_definitions

* Add back Footnote enums

* Ah so these are like fstrings!

* Update selfdrive/car/CARS_template.md

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update selfdrive/car/docs.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* Update year from master merge

* Fix longitudinal star from merge

* sort properly stars by Column enum

* clean up

* HKG: Sorry guys

* Prius V gets FSR star, like others

* Update selfdrive/car/docs.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* update comment

* No Prius docs change for now

Co-authored-by: Jason Young <46612682+jyoung8607@users.noreply.github.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 31a6b141d6
2022-03-16 21:27:05 -07:00
Adeeb Shihadeh
f96d34902f GM: use generated DBC (#23615)
* Rename GM PT dbc to generated

* bump opendbc

Co-authored-by: Jason Shuler <jshuler@gmail.com>
old-commit-hash: cdd3598146
2022-01-24 20:51:57 -08:00
Adeeb Shihadeh
597535c014 linter: don't allow implicitly concatenated strings (#23513)
* linter: don't allow implicitly concatenated strings

* fix hyundai
old-commit-hash: 2c94f15584
2022-01-13 14:19:38 -08:00
Jason Young
a399abf438 GM: EPS fault workaround (#22404)
* seems legit

* panda -> loopback

* fix comment

* add some "why" comments for the next guy

* re-test with stock 50Hz rate

* ugly test

* Update selfdrive/car/gm/carstate.py

Co-authored-by: qadmus <42746943+qadmus@users.noreply.github.com>

* update refs

* Update selfdrive/car/gm/carstate.py

Co-authored-by: qadmus <42746943+qadmus@users.noreply.github.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: b49f518782
2021-10-28 16:54:12 -07:00