Commit Graph

150 Commits

Author SHA1 Message Date
Adeeb Shihadeh
224672705c Hyundai Ioniq EV LTD (#1694)
* add ioniq

* bump panda

* test route

* bump pnada
2020-06-15 11:45:37 -07:00
Adeeb
0bbe870b5f Delay alert creation for some events (#1689)
* add creation delay parameter to alerts

* 1s delay for sensorsInvalid and canError

* bump cereal

* update refs
2020-06-12 15:32:50 -07:00
Willem Melching
2a12c653d5 update process replay after sonata stiffness change 2020-06-12 13:20:54 -07:00
Adeeb Shihadeh
cf72a4eb34 don't clear scons cache in CI 2020-06-10 17:49:34 -07:00
Willem Melching
c18e7da3c2 Write orientation & transform in C++ (#1637)
* locationd at 20hz

* update ref

* bump cereal

* dont modify global state

* add scons files

* ecef2geodetic and geodetic2ecef

* Finish local coords class

* Add header file

* Add orientation.cc

* cleanup

* Add functions to header file

* Add cython wrapper

* y u no work?

* This passes the tests

* test rot2quat and quat2rot

* Teste euler2rot and rot2euler

* rot_matrix

* test ecef_euler_from_ned and ned_euler_from_ecef

* add benchmark

* Add test

* Consistent newlines

* no more radians supported in geodetic

* test localcoord single

* test localcoord single

* all tests pass

* Unused import

* Add alternate namings

* Add source for formulas

* no explicit tests needed

* remove benchmark

* Add release files

* Typo

* Remove print statement

* no access to raw transform matrix

* temporarily add tolerance

* handcode quat2euler

* update ref
2020-06-09 16:44:26 -07:00
Willem Melching
15dc6044d4 Remove slow down for turns (#1647)
* Remove slow down for turns

* update ref
2020-06-05 16:01:53 -07:00
Willem Melching
63c8e8439b Model + camerad test (#1622)
* kind of works

* move that

* hack to get camerad to reliably terminate

* not sure why SIGTERM wasn't working before

* compare bytes

* clean up some hacks

* gitignore

* fix that

* WIP

* no reboot

* comparison works

* pretty print

* fix build

* run in jenkins

* python path

* space

* raise timeout

* new eon

* skip the copy

* spinner

* spin less

* update model ref commit

* reenable that

* clean up

* fix jenkinsfile

* parallel

* wrap it in a stage

* fix linter

* better progress

* lower timeout

Co-authored-by: Comma Device <device@comma.ai>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2020-06-04 18:57:25 -07:00
Adeeb
367155168a Update Flake8 config (#1624)
* update flake8 checks

* add E502

* no whitespace warnings

* fix violations

* no W391

Co-authored-by: Jason Young <jason@comma.ai>
2020-06-03 16:13:34 -07:00
Willem Melching
66455b075d locationd profiling (#1625) 2020-06-02 17:32:55 -07:00
Adeeb
165bcf1f31 Fix speed too low (#1627)
* fix speed too low

* bump ref

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2020-06-02 17:31:59 -07:00
Willem Melching
843a64c72f Make pylint more strict (#1626)
* make pylint more strict

* cleanup in progress

* done cleaning up

* no opendbc
2020-06-02 16:29:32 -07:00
Willem Melching
d00cdf1e0c longitudinal test should broadcast liveLocationKalman 2020-06-01 14:24:48 -07:00
Willem Melching
f575a9ec12 Fix low speed engage on stop and go Hondas (#1613)
* fix low speed engage on stop and go Hondas

* update ref commit
2020-06-01 10:14:11 -07:00
Adeeb Shihadeh
ebed2d1dcc enable flake8 E251: unexpected spaces around keyword / parameter equals 2020-05-31 17:34:47 -07:00
Adeeb Shihadeh
f3dcf861c7 enable flake8 E303: too many blank lines 2020-05-31 17:21:11 -07:00
Adeeb Shihadeh
27754a277c enable E261 in flake8: two spaces before inline comment 2020-05-31 14:07:29 -07:00
Adeeb Shihadeh
efd5dffb1e enable flake8 E231: missing whitespace after comma 2020-05-31 12:49:11 -07:00
Adeeb
6051061ff8 Flake8 E22X (#1607)
* e221

* e225

* bump opendbc
2020-05-31 00:48:47 -07:00
Andre Volmensky
9fc826cb5c Added Rogue 2019/Leaf 2019 fingerprints (#1605)
* Added Rogue 2019/Leaf 2019 fingerprints

* Added Rogue as new car. Updated readme

* Added route to test_car_models.py. Fixed if statements to check against rogue/x-trail

* Fixed paste error

* Merged Leaf fingerprints

* Assume Rogue is MPH until we work out the mph/kph bit
2020-05-30 20:25:32 -07:00
Adeeb
d9bf9f0a40 Enable more flake8 checks (#1602)
* enable some more flake8 checks

* some more quick ones

* bump opendbc

* e401

* e711 e712

* e115 e116

* e222

* e301

* remove that

* e129

* e701 e702

* e125 e131

* e227

* e306

* e262

* W503

* e713

* e704

* e731

* bump opendbc

* fix some e722
2020-05-30 20:14:58 -07:00
Willem Melching
b5a2cec913 Improved tune for VW Golf Mk7. #1603
commit 012049274fd5573bdc5d2d0f198817646dfd5a1b
Author: Willem Melching <willem.melching@gmail.com>
Date:   Sat May 30 10:40:49 2020 -0700

    update ref

commit d50cc2d81fd73dcfccfe1a8e2726879941ec5327
Author: Jason Young <jyoung8607@gmail.com>
Date:   Sat May 30 10:32:25 2020 -0400

    Discard no-longer-used import

commit c092e6f5092535a3b4bb5cabb6f5ecf83ef754c7
Author: Jason Young <jyoung8607@gmail.com>
Date:   Sat May 30 10:21:57 2020 -0400

    Improved tune from community
2020-05-30 17:04:38 -07:00
Adeeb Shihadeh
18afb979fe remove file that shouldn't have been committed 2020-05-30 14:40:00 -07:00
Adeeb Shihadeh
2d898bc0ed update refs 2020-05-29 12:41:20 -07:00
Jafar Al-Gharaibeh
34b9b5e849 Bounty: Mazda (#988)
* Mazda Port

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Update checksum to account for steer angle signal used in some cars

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Add test drive/segment ID to pass CI tests

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Process gear and brake signals, add new fingerprints

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Refactor some car interface code

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Drop redundant call, use Ecu, move warning to carstate, fix cruise speed

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Drop unused variables, cleanup handsoff tracking

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Update to steerError and steeringRate

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Refactor parse gear, update lkas signals from the new dbc

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Better tracking of engage and warning events

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* remove commented lines, update speed_kph to match panda

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Steer Error

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Set lkas enable speed to 52 kph

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Drop block signal use, fix LGTM alerts

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* When gas is pressed OP will disengage, sync local state with it

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Use car's speed signal instead of wheel speed

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Tidy up disengage events

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Rebase/Refactor with upstream

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Sync stock ACC state with OP

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* mazda dbc file renamed

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Improve acc stock and go by removing the 3 seconds limit

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Dashcam

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* PR Feedback

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* Send ACC cancel only if we are sure cruise is enabled

Otherwise we run the risk of disabling main cruise

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* updated route

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>

* no process replay for now

* add to release files

* Revert "updated route"

This reverts commit 233db4f1bc2d8eefaa86488be4f6f88360d20793.

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
2020-05-28 22:15:19 -07:00
Willem Melching
ba2ac1207a Running pre-commit in CI (#1590)
* Running pre-commit in CI

* fix dockerfile syntax

* dont run on submodule repo folders

* Fix some import errors in ci

* more stuff

* That should be the last one
2020-05-28 15:40:48 -07:00
Willem Melching
3d08dcc3b2 Run mypy commit hook (#1591)
* run mypy commit hook

* fix mypy errors
2020-05-28 15:05:04 -07:00
Willem Melching
bee15f8abe make pre-commit pass without xx present 2020-05-28 13:20:28 -07:00
Willem Melching
29aaa44740 flake8 in pre-commit(#1583) 2020-05-27 20:33:05 -07:00
Willem Melching
bd06434243 pre-commit pylint (#1580)
* "The commit-hook project sounds interesting though. I would definitely merge something that runs flake8 and pylint on the modified files!"
-  pd0wm, https://github.com/commaai/openpilot/pull/1575#issuecomment-634974344

* add pylint to pre-commit and make everything pass

* Remove uncommented stuff

Co-authored-by: J <user@4800.lan>
2020-05-27 20:00:14 -07:00
Adeeb
c78602e8cc Remove incomplete Hyundai Ioniq port (#1570) 2020-05-26 20:48:41 -07:00
Adeeb Shihadeh
a1ffcdd253 update refs after radarState fields populated 2020-05-26 18:12:12 -07:00
Thaixican
dd16990952 Add 2020 Lexus RX Hybrid support (#1547)
* Add 2020 Lexus RX Hybrid support

* Add 2020 Lexus RX Hybrid to IGNORED_FINGERPRINTS and route to test_car_models per @pd0wm
2020-05-26 13:49:18 -07:00
Adeeb Shihadeh
b251eff764 remove that script 2020-05-22 14:50:08 -07:00
Adeeb Shihadeh
ea1b192565 bump panda after hyundai checksum 2020-05-22 14:42:22 -07:00
Willem Melching
fcf879d783 Add permanent CAN error alert (#1549)
* Add permanent CAN error alert

* canValid needs some time to initialize

* update ref
2020-05-21 16:08:05 -07:00
Willem Melching
ef2ea14ecc add sonata 2019 to test_car_modelsg 2020-05-20 17:20:17 -07:00
Alice Knag
fde1a5e9af add support for Sonata 2019 (#1538)
* add sonata interface

update values.py

update values.py

* change sonata_1 to sonata_2019

* add sonata 2019 and forte 2019 to README

prettier fucked me up pretty hard at first
sdfsd

* update README.md

* mock test
2020-05-20 17:12:00 -07:00
Willem Melching
d099e09fb7 Handle posenet and sensor alerts in locationd (#1541)
* handle posenet and senor alerts in locationd

* defaults now set in capnp file

* Cleanup c++ version of params learner

* update ref commit
2020-05-19 16:45:20 -07:00
Willem Melching
96605d0951 This one also needs to be fixed 2020-05-19 16:19:00 -07:00
Adeeb Shihadeh
8788ab36e4 remove those debug prints 2020-05-19 13:54:24 -07:00
Willem Melching
bb8bbdd9ee Hyundai fw query (#1540)
* hyundai fw query

* Change query

* this works

* That is not engine

* hyundai fw query

* Change query

* this works

* That is not engine

* Skip FW query in test_car_models

* Those routes don't fingerprint properly after speedup

* only send toyota queries to subaddresses

Co-authored-by: openpilot laptop <laptop@comma.ai>
2020-05-19 13:43:44 -07:00
Adeeb
d976233f69 Alerts + Events refactor (#1466) 2020-05-14 15:21:21 -07:00
Adeeb
08832ff29d Controlsd refactor (#1487)
* it's a class

* more refactor

* remove that

* car interface should create that

* that too

* not a dict

* don't create permanent events every iteration

* break up long lines

* fix honda

* small optimization

* less long lines

* dict is faster

* latcontrol less args

* longcontrol less args

* update profiling script

* few optimizations

* create events together

* clean up

* more clean up

* remove comment

* clean up

* simplify state transition

* more clean up

* update comments
2020-05-12 15:06:48 -07:00
Willem Melching
27ffa29f6c Fix counter in HKG clu11 message (#1484)
* fix counter in clu11 message

* update ref
2020-05-10 20:13:35 -07:00
Willem Melching
5182da3100 fix update ref script 2020-05-10 18:55:53 -07:00
Adeeb Shihadeh
ad2c54e991 fake less of PubMaster and SubMaster when profiling 2020-05-03 17:41:26 -07:00
Adeeb
337529d5cb Add steerWarning and steerError to carState (#1444)
* Add steerWarning and steerError to carState

* fix gm and hyundai

* update refs
2020-05-01 13:13:12 -07:00
Willem Melching
5d69e97281 Less hardcoded values in profiling script 2020-05-01 11:38:30 -07:00
Willem Melching
4301c5efb5 small cleanup of profiling script 2020-05-01 10:49:02 -07:00
Willem Melching
b3e7d94303 run both deterministic and statistical profiler 2020-04-30 17:39:37 -07:00