Commit Graph

93 Commits

Author SHA1 Message Date
Adeeb Shihadeh
9e34ed4e8c bump cereal 2020-06-15 16:01:35 -07:00
Adeeb Shihadeh
92c29c4269 bump cereal 2020-06-12 20:38:45 -07:00
Willem Melching
684f7b2cc0 no gps warning after 5 minutes (#1692) 2020-06-12 16:03:35 -07:00
Adeeb
0bbe870b5f Delay alert creation for some events (#1689)
* add creation delay parameter to alerts

* 1s delay for sensorsInvalid and canError

* bump cereal

* update refs
2020-06-12 15:32:50 -07:00
Adeeb
d4858e5ff5 Move driver monitoring out of controls (#1642)
* move dmonitoring out of controls

* run monitoring unit tests in CI
2020-06-09 13:25:15 -07:00
Willem Melching
15dc6044d4 Remove slow down for turns (#1647)
* Remove slow down for turns

* update ref
2020-06-05 16:01:53 -07:00
Jason Young
68531b071c Reduce scheduler latency for realtime processes (#1638)
* WIP: reduce boardd and other lags

* Copypasta fault

* Silence spurious startup warning

Co-authored-by: Comma Device <device@comma.ai>
2020-06-05 17:09:41 -04:00
Adeeb
367155168a Update Flake8 config (#1624)
* update flake8 checks

* add E502

* no whitespace warnings

* fix violations

* no W391

Co-authored-by: Jason Young <jason@comma.ai>
2020-06-03 16:13:34 -07:00
Jafar Al-Gharaibeh
73db079199 Fix rounding of minSteerSpeed in events (#1620)
I thought I was missing a rounding in Mazda code, but it turned
out to be a missing rounding after the recent event refactoring

Python3 interpreter:
>>> print(" %d  %d" % (1.6,1.4))
 1  1
>>> print(" %d  %d" % (round(1.6),round(1.4)))
 2  1
>>> print(" %d  %d" % (int(round(1.6)),round(1.4)))
 2  1
>>> print(" %d  %d" % (int(round(1.6)),int(round(1.4))))
 2  1

Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
2020-06-03 14:01:32 -07:00
Willem Melching
2400417084 vehicle model types (#1631) 2020-06-03 13:47:47 -07:00
Willem Melching
0f20ac728f Bounds checks on liveParameters for testing on desk 2020-06-03 11:31:12 -07:00
Adeeb
165bcf1f31 Fix speed too low (#1627)
* fix speed too low

* bump ref

Co-authored-by: Willem Melching <willem.melching@gmail.com>
2020-06-02 17:31:59 -07:00
Willem Melching
843a64c72f Make pylint more strict (#1626)
* make pylint more strict

* cleanup in progress

* done cleaning up

* no opendbc
2020-06-02 16:29:32 -07:00
Willem Melching
205cb04ee9 speedTooHigh should not be an immediate disable 2020-06-01 15:53:41 -07:00
Willem Melching
fab8425f2f Make driverview not pin two cores at 100% 2020-06-01 13:58:54 -07:00
Adeeb Shihadeh
6466ec982a enable flake8 E502: backslash is redundant between brackets 2020-05-31 17:41:18 -07:00
Adeeb Shihadeh
f3dcf861c7 enable flake8 E303: too many blank lines 2020-05-31 17:21:11 -07:00
Adeeb Shihadeh
27754a277c enable E261 in flake8: two spaces before inline comment 2020-05-31 14:07:29 -07:00
Willem Melching
106cddb49a White panda no longer supported 2020-05-31 13:33:56 -07:00
Adeeb Shihadeh
efd5dffb1e enable flake8 E231: missing whitespace after comma 2020-05-31 12:49:11 -07:00
Adeeb
6051061ff8 Flake8 E22X (#1607)
* e221

* e225

* bump opendbc
2020-05-31 00:48:47 -07:00
Adeeb
d9bf9f0a40 Enable more flake8 checks (#1602)
* enable some more flake8 checks

* some more quick ones

* bump opendbc

* e401

* e711 e712

* e115 e116

* e222

* e301

* remove that

* e129

* e701 e702

* e125 e131

* e227

* e306

* e262

* W503

* e713

* e704

* e731

* bump opendbc

* fix some e722
2020-05-30 20:14:58 -07:00
Adeeb Shihadeh
916448af25 break canError into two separate events 2020-05-29 12:00:41 -07:00
Adeeb Shihadeh
7961d5ffd7 Fix below steer speed alert text not updating 2020-05-28 20:39:13 -07:00
Willem Melching
bd06434243 pre-commit pylint (#1580)
* "The commit-hook project sounds interesting though. I would definitely merge something that runs flake8 and pylint on the modified files!"
-  pd0wm, https://github.com/commaai/openpilot/pull/1575#issuecomment-634974344

* add pylint to pre-commit and make everything pass

* Remove uncommented stuff

Co-authored-by: J <user@4800.lan>
2020-05-27 20:00:14 -07:00
HaraldSchafer
67017d69fe Minor fixes (#1571)
* was 5 seconds not .2!

* threshold for moving car highers, this can give FPw
2020-05-27 14:35:01 -07:00
Adeeb Shihadeh
2ecc7d9f6f Fix blank mdMonoTime and controlsStateMonoTime in radard 2020-05-26 17:53:55 -07:00
Willem Melching
50f3f1d335 -Werror (#1567)
* werror

* -Wno-inconsistent-missing-override

* Silence ffmpeg deprecation warnings

* add some more pragmas to ignore warnings

Co-authored-by: Comma Device <device@comma.ai>
2020-05-26 13:27:01 -07:00
Willem Melching
fcf879d783 Add permanent CAN error alert (#1549)
* Add permanent CAN error alert

* canValid needs some time to initialize

* update ref
2020-05-21 16:08:05 -07:00
Willem Melching
e6f24f2390 Revert "Add permanent CAN error alert"
This reverts commit 0abf99dbe0.
2020-05-21 15:30:16 -07:00
Willem Melching
0abf99dbe0 Add permanent CAN error alert 2020-05-21 14:53:40 -07:00
Willem Melching
41da10ff38 Sounds available isdir -> isfile 2020-05-21 14:46:18 -07:00
Willem Melching
517826c1e1 Add percent sign to calibration screen 2020-05-21 14:43:07 -07:00
Adeeb Shihadeh
260e6aff53 fix possible FileNotFoundError 2020-05-21 09:59:39 -07:00
Willem Melching
9f0eac9089 Fix #1545, sensor alert on startup 2020-05-20 11:25:55 -07:00
Willem Melching
d099e09fb7 Handle posenet and sensor alerts in locationd (#1541)
* handle posenet and senor alerts in locationd

* defaults now set in capnp file

* Cleanup c++ version of params learner

* update ref commit
2020-05-19 16:45:20 -07:00
eFini
e14dfa3bec use buttonEvent.type instead of string (#1533) 2020-05-18 10:15:30 -07:00
Andre Volmensky
135385c5fb Bugfix: Reset saturated_count if angle no longer saturated (#1522) 2020-05-16 01:14:10 -07:00
Willem Melching
c18891b936 Alert callback functions were returning tuples 2020-05-15 18:29:22 -07:00
Willem Melching
c85b174584 White panda is deprecated (#1516)
* Start white panda deprecation

* Unify alert text

* Add noentry

* Change to no longer supported

* panda is lowercase

* Capitalize

* rerun ci
2020-05-15 13:00:00 -07:00
Willem Melching
631d0d94d3 Fix two event names 2020-05-15 12:24:12 -07:00
Adeeb
d976233f69 Alerts + Events refactor (#1466) 2020-05-14 15:21:21 -07:00
Willem Melching
ef33007813 Clip v_cruise to V_CRUISE_MAX 2020-05-13 18:05:24 -07:00
Willem Melching
e7ec02e201 speed too high louder alert 2020-05-13 18:02:09 -07:00
Willem Melching
516fa29738 Fix controlsd typo in refactor 2020-05-12 18:58:18 -07:00
Adeeb
08832ff29d Controlsd refactor (#1487)
* it's a class

* more refactor

* remove that

* car interface should create that

* that too

* not a dict

* don't create permanent events every iteration

* break up long lines

* fix honda

* small optimization

* less long lines

* dict is faster

* latcontrol less args

* longcontrol less args

* update profiling script

* few optimizations

* create events together

* clean up

* more clean up

* remove comment

* clean up

* simplify state transition

* more clean up

* update comments
2020-05-12 15:06:48 -07:00
Adeeb Shihadeh
10ae22a192 delete unused lines 2020-05-10 11:25:42 -07:00
Adeeb Shihadeh
48dec51f0e fix circular import reported by LGTM 2020-05-09 16:47:36 -07:00
HaraldSchafer
65fcc7c45f Better poly (#1437)
- better polyfitting
- no mpc cost change during lane change
- model trained with better ll gt, sim noise and guaranteed memories
2020-05-08 17:14:43 -07:00
Willem Melching
70ae01e3cd remove yet another reverse geocoder 2020-04-24 14:07:36 -07:00