Commit Graph

89 Commits

Author SHA1 Message Date
HaraldSchafer
f7edd5f3d3 Car interface: set max lateral torque from table (#24789)
* json

* better naem

* Read from table

* formatting and default to nan

* Generate docs

* Read from table

* this should be the same

* Prius v is full

* test we always set the tunes correctly

add to release files

* Set for all cars

Set for all cars

* Revert tuning changes

Revert tuning changes

* remove that

* fixes

* update ref commit for new maxLateralAccels

Co-authored-by: Shane Smiskol <shane@smiskol.com>
old-commit-hash: 3066ad81a8
2022-06-10 17:57:23 -07:00
Jason Shuler
f392d45f41 GM: interface cleanup (#24774)
* Move all defaults above models

* Remove reduntant/defaults

* make minEnableSpeed common

* Update selfdrive/car/gm/interface.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

Co-authored-by: Shane Smiskol <shane@smiskol.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: b95c449847
2022-06-07 17:23:08 -07:00
Shane Smiskol
1a2bf8412c Car documentation: set steering torque star using car interface (#24709)
* Set good torque using torque controller tuning

* should be equal to

* save lateral accel to car params

* use maxLateralAccel

* always

* same convention

* nan will always evaluate to false

* The great good torque purge

* adjust default friction

* Add data for more cars

* adjust name

* Welcome back, guys. Only adjust good torque if maxLatAccel is set

* Update refs (1.7 is 1.7000001...)
old-commit-hash: c6bc03311c
2022-06-03 17:41:20 -07:00
Shane Smiskol
ddf2d5b63c Button-enable cars: common functions for button events (#24678)
* function for creating button events

* fix

* one line

* alphabetical

alphabetical

* only needed once

* common function for enable events

* add to list

* extend

* fixes

* add type hints

* flip around
old-commit-hash: eed6803ccc
2022-06-01 12:03:34 -07:00
Shane Smiskol
e63294da62 Add ACC faulted status to carState (#24399)
* add accFaulted bool to carState

* same for VW

* remove import

* bump

* move to common

* bump cereal to master
old-commit-hash: 5b105facae
2022-05-02 18:05:00 -07:00
Adeeb Shihadeh
3789587df1 add alert for CAN bus timeout (#24162)
* add alert for CAN bus timeout

* add alert

* set in interface

* cleanup

* cleanup

* add event

* fix mock

* bump

* bump opendbc

* update refs

* return reader
old-commit-hash: 49c2164814
2022-04-12 22:58:34 -07:00
Shane Smiskol
5a9c45b6e3 Clean up CarInterface.apply and CarControllers (#24060)
* do tesla

* parentheses

* Do Chrysler

* Make sure Hyundai long never actuates when long inactive

.

* clean up Hyundai

* more clear

* formatting

* Stock sets these to zero

* fix params

* move jerk logic into CC

clean up
old-commit-hash: c8f5b21744
2022-04-05 23:38:45 -07:00
Adeeb Shihadeh
3327348aeb don't read params in car interfaces (#23978)
old-commit-hash: bae78dd46b
2022-03-16 15:17:47 -07:00
Adeeb Shihadeh
94e02bcb3f add parkingBrake to carState (#23968)
* add parkingBrake to carState

* fix gm
old-commit-hash: ae19308e83
2022-03-14 16:32:20 -07:00
Adeeb Shihadeh
805a00b5f3 cleanup selfdrive/test (#23967)
* move test routes and test_models

* move fingerprints

* little more

* remove that
old-commit-hash: 8718a59330
2022-03-14 15:46:16 -07:00
Adeeb Shihadeh
ec47e0fef0 break up selfdrive.config (#23959)
* break up selfdrive.config

* add to release files

* fix import order
old-commit-hash: 5c3f3e44bc
2022-03-13 21:42:39 -07:00
Shane Smiskol
3e61c7e6ae carControl: add long and lat active fields (#23859)
* proof of concept

* actuators packet describes which actuators are active

* bump cereal

* fixes

* not needed for this PR

* Do Toyota

* add back controlsState.active

* bump cereal

* rest of cars

* in actuators

* add active back

* which

* use controlsState.active for now

* will make an issue

* Update selfdrive/controls/controlsd.py

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>

* move local lat_active checks into CC.latActive

* remove redundant checks

* move comment

move comment

* fix joystick mode

* get enabled from carcontrol

* do standstill check in controlsd

* make sure we consider the gas press case for GM

* use CC.actuators

* fix

* capitalization

* Bump cereal

Bump cereal

* make intermediate actuators

* similar convention to before

* clean that up

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 629399a449
2022-03-13 20:58:44 -07:00
Shane Smiskol
8ade6dd81a GM: remove noisy ignition signal (#23698)
* move BUICK_REGAL to dashcamOnly

* bump to master
old-commit-hash: fccb80e9a5
2022-02-03 12:32:33 -08:00
Adeeb Shihadeh
71da8d1250 No actuation while in pre-enabled state (#23658)
* No actuation while in pre-enabled state

* update refs
old-commit-hash: 72e00a0768
2022-01-28 16:03:44 -08:00
Dean Lee
98de810849 check in tuple instead of list (#23477)
* check in tuple instead of list

* Update selfdrive/car/toyota/carcontroller.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>

* Update selfdrive/car/mazda/interface.py

Co-authored-by: Willem Melching <willem.melching@gmail.com>

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: a653461dec
2022-01-10 16:36:51 +01:00
kevinharbin
4c6fcce21f selfdrive/car/gm/interface.py: fix typo in comment (#23429)
spelling
old-commit-hash: c7fb8f4e32
2022-01-06 15:53:48 +01:00
Adeeb Shihadeh
2e0de00728 GM: move abandoned cars into dashcam only (#23423)
old-commit-hash: 450656e2a7
2022-01-05 19:48:06 -08:00
Dean Lee
0a762c27ce interfaces/apply: follow capnp best practices (#23371)
old-commit-hash: 05b905d140
2022-01-04 11:34:49 +01:00
Willem Melching
7b3e330def Log actuators after applying rate limits in CarController (#23230)
* return actuators from carcontroller

* log it

* pass to latcontrol

* chrysler

* gm

* honda

* more brands

* rest of the brands

* gm cleanup

* hyundai cleanup

* update ref

* rename field

* fix subaru

* add types

* more subaru fixes #23240

* consistent whitespace

* bump cereal
old-commit-hash: 4f1eb4278a
2021-12-16 13:08:20 +01:00
Dave
1ed29c23cb GMC Acadia: Add lateral feedforward function (#22899)
* GM Acadia lateral tuning

* old tune was not returning to center, nor strong enough. Trying to make P and F equal.

* reduce integral, and eyeball actuator delay

* return PI to openpilot default

* remove default values from acadia

Co-authored-by: qadmus <42746943+qadmus@users.noreply.github.com>
old-commit-hash: 957864019a
2021-11-18 15:45:37 -08:00
Jason Young
a399abf438 GM: EPS fault workaround (#22404)
* seems legit

* panda -> loopback

* fix comment

* add some "why" comments for the next guy

* re-test with stock 50Hz rate

* ugly test

* Update selfdrive/car/gm/carstate.py

Co-authored-by: qadmus <42746943+qadmus@users.noreply.github.com>

* update refs

* Update selfdrive/car/gm/carstate.py

Co-authored-by: qadmus <42746943+qadmus@users.noreply.github.com>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: b49f518782
2021-10-28 16:54:12 -07:00
Gibby
ee70f39f1b GM: 2016 Escalade ESV (#22670)
* Added 2016 Escalade ESV fingerprint and data.

* Updated CARS.md for GM vehicles

* Uploaded Escalade fingerprint

* Removed part about auto high beams for GM. Seems to work for some.

* Revert other modifications in CARS.md

* Revert other modifications in CARS.md

* Added test route for Escalade

* Added tunning for Escalade to reduce jerky steering

* Apply suggestions from code review

* Update selfdrive/car/gm/interface.py

* cleanup test route

Co-authored-by: Gibby <git@twoitguys>
Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 46009fa6fd
2021-10-26 15:59:24 -07:00
qadmus
b88eea00b5 GM: improved Volt lateral tuning (#22621)
* GM Volt lateral tuning and feedforward function

* improve comments, lower P 5% to 0.17, which matches all my notes over time, 0.18 was a last test change.

* don't justify actuator delay for now

* update refs

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
old-commit-hash: 2e0bc9d365
2021-10-21 14:10:41 -07:00
Robbe Derks
58c99158a1 Make pandaState and safetyMode a list (#22454)
* wip: move to pandaStates

* bump cereal

* wip: SafetyMode struct

* move to safetyMode

* fix typo

* this can be None

* fix potential empty pandaStates list

* fix thermald

* fix controlsd

* rename safetyModes to safetyConfigs

* update process_replay

* fix test_models

* bump cereal
old-commit-hash: 91987f38d4
2021-10-08 17:54:34 +02:00
Adeeb Shihadeh
821f1f6cb6 remove community supported cars from community features (#22330)
* remove community supported cars from community features

* remove bosch and hkg long

* remove test case

* update refs
old-commit-hash: 649af76fd4
2021-09-23 17:34:52 -07:00
Willem Melching
b079219b93 Use CP.vEgoStopping and clean up CP.startAccel (#22199)
* use CP.vEgoStopping and clean up

* update ref
old-commit-hash: 1e62b09e5d
2021-09-11 17:13:30 -07:00
Willem Melching
6f5c9d5ad1 Clean up PID controller ACCEL_MIN/ACCEL_MAX (#22148)
* use ISO 15622:2018 limits in PID controller

* allow more for nidec

* limit PID inputs

* CP is not needed

* add GM

* not used

* update ref

* fix honda bosch
old-commit-hash: f941111dcd
2021-09-06 17:29:32 -07:00
HaraldSchafer
a73a820338 Change car controller interface from gas/brake to acceleration (#21911)
* retune civic

* seems smooth

* back to normal

* new ref

* fix conflict

* runs

* rm

* accel scale is 4

* toyota should be good

* more cleanup

* fixup

* better naming

* update ref

* deprecated

* sending brake when not enable causes a fault

* rm gas and brake

* unused

* update ref

* acura logic is no more

* wrong before

* revert tuning cleanup

* adress comments

* update ref

* already on master

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 1ac89f14aa
2021-08-30 09:32:52 -07:00
Adeeb Shihadeh
b7c1b9a6e8 rename enableCruise -> pcmCruise (#21546)
old-commit-hash: cb7e96f99d
2021-07-10 13:56:11 -07:00
Adeeb Shihadeh
691ea8553f deprecate CP.enableCamera (#21509)
* deprecate CP.enableCamera

* more removal

* one more

* update refs
old-commit-hash: c72d163e14
2021-07-07 14:59:18 -07:00
Greg Hogan
d0e5f3fb92 default carParams.stoppingControl to True (#21248)
* hyundai has full brake control

* set default stoppingControl to True

* update ref

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 8071111f59
2021-06-15 14:00:57 +02:00
Adeeb Shihadeh
99b2c0d024 Alerts update (#20567)
* steer temp unavailable should be a soft disable

* no mute

* these should be no entries

* sound

* better name

* deprecated

* make vehicleModelInvalid a soft disable

* update refs

* bump cereal

* bump cereal

* update refs
old-commit-hash: 2fa1b2572d
2021-04-07 12:18:58 -07:00
Adeeb Shihadeh
f25cec394e grey panda is unsupported (#2458)
old-commit-hash: 47c21f10f5
2020-11-03 19:56:25 -08:00
Adeeb Shihadeh
39d98d3d2d Car cleanup (#1924)
* cleanup car code

* more pruning

* little more

* less pylint disables

* radar stuff

* fix

* udpate refs

* fix honda bosch

* fix test
old-commit-hash: 892e1162c0
2020-07-25 15:07:27 -07:00
Adeeb Shihadeh
304d893af6 GM cleanup + ignition fix (#1729)
* small cleanup

* alertmanager handles that

* improve tuning

* below steer speed

* Revert "improve tuning"

This reverts commit 5d2de147d2c9979af09b7964ad59e4b95ddb2f2a.

* bump panda

* update refs

* bump panda
old-commit-hash: 472fe66962
2020-06-18 12:24:47 -07:00
Adeeb
8c0971086b Fix speed too low (#1627)
* fix speed too low

* bump ref

Co-authored-by: Willem Melching <willem.melching@gmail.com>
old-commit-hash: 165bcf1f31
2020-06-02 17:31:59 -07:00
Willem Melching
a56e2b01f8 Make pylint more strict (#1626)
* make pylint more strict

* cleanup in progress

* done cleaning up

* no opendbc
old-commit-hash: 843a64c72f
2020-06-02 16:29:32 -07:00
Adeeb Shihadeh
37a67a2a14 enable flake8 E502: backslash is redundant between brackets
old-commit-hash: 6466ec982a
2020-05-31 17:41:18 -07:00
Adeeb Shihadeh
68a3061c9d enable E261 in flake8: two spaces before inline comment
old-commit-hash: 27754a277c
2020-05-31 14:07:29 -07:00
Adeeb
5e857427ba Enable more flake8 checks (#1602)
* enable some more flake8 checks

* some more quick ones

* bump opendbc

* e401

* e711 e712

* e115 e116

* e222

* e301

* remove that

* e129

* e701 e702

* e125 e131

* e227

* e306

* e262

* W503

* e713

* e704

* e731

* bump opendbc

* fix some e722
old-commit-hash: d9bf9f0a40
2020-05-30 20:14:58 -07:00
Adeeb
48340cc8cb Alerts + Events refactor (#1466)
old-commit-hash: d976233f69
2020-05-14 15:21:21 -07:00
Willem Melching
8d4658790e Remove fake yaw rate from carstate (#1426)
* remove fake yaw rate from carstate

* update ref
old-commit-hash: f7f0a81d13
2020-04-27 14:10:07 -07:00
Adeeb
7f2008aa0b Remove Cadillac CT6 port (#1359)
* remove CT6 port

* dont need this route

* extra char

* fix carcontroller params
old-commit-hash: e22482eb31
2020-04-13 15:53:24 -07:00
Adeeb
15916d03f4 Abstract pcmEnable and pcmDisable events (#1350)
* don't need individual prev state vars since whole CS is copied

* don't need a whole function since toyota alerts were simplified

* better here

* abstract pcmEnable/pcmDisable events

* the flippening came to NEOS

* delete

* unused

* Revert "the flippening came to NEOS"

This reverts commit 91cfb73b2914f637863335f4e5f5952620b3e977.
old-commit-hash: 8d791d78dd
2020-04-10 16:12:58 -07:00
rbiasini
5849f719ef abstract pedalPressed event (#1218)
* abstract pedalPressed event

* Fix bug

* update refs
old-commit-hash: fe911bcca8
2020-03-08 23:35:00 -07:00
rbiasini
8fc38619c0 Abstract gasPressed for all cars (#1151)
* min_steer_speed alert (with adjusted hysteresis) for all cars, abstracted gas pre_enable event

* move lines a bit

* more GM cleanup

* typo

* move espDisabled to carState packet

* brought back min steer speed alert only in hyundai. It's a bit tricky and behavior should be changed

* ops, wrong change

* bug

* update cereal

* update ref
old-commit-hash: 9685a5a743
2020-02-21 18:24:37 -08:00
Adeeb
65a2c62114 Abstract common events + event cleanup (#1129)
* too many if

* unused

* whitespace

* key

* sefldrive/car/*

* no more gctx

* lower

* start abstracting common events

* all cars

* start small

* all cars

* reverse gear

* wrongCarMode

* wrongGear

* espDisabled

* steerUnvailable

* make linter happy

* c isn't used

* fix esp_disabled in VW

* update ref

* more red

* more cleanup

* fix subaru

* update ref

old-commit-hash: e8cb6ea06a
2020-02-20 16:22:25 -08:00
rbiasini
b495a36507 Abstract std params (#1138)
* get_can_parser and get_cam_can_parser are now standard static methods
old-commit-hash: af39d74a5b
2020-02-20 14:06:02 -08:00
rbiasini
5375a08920 get_can_parser and get_cam_can_parser are now standard static methods (#1136)
old-commit-hash: dc3ea9b08d
2020-02-20 13:08:43 -08:00
Adeeb
0468c42f22 Abstract CarInterface init (#1131)
* abstract CarInterface init

* unused

* subaru

* gm cleanup

* vw

* typo

* carcontroller

* more cleanup

* fix vw

old-commit-hash: 13f60eae91
2020-02-19 20:37:07 -08:00